linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] smack: fix magic value
@ 2013-07-10 11:51 Phil Carmody
  2013-07-21  1:41 ` Casey Schaufler
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Carmody @ 2013-07-10 11:51 UTC (permalink / raw)
  To: casey; +Cc: linux-security-module, linux-kernel, jarkko.sakkinen, Phil Carmody

5d is ']', 'M' is 4d.

Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com>
---
 include/uapi/linux/magic.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
index 2944278..5c1d878 100644
--- a/include/uapi/linux/magic.h
+++ b/include/uapi/linux/magic.h
@@ -11,7 +11,7 @@
 #define DEBUGFS_MAGIC          0x64626720
 #define SECURITYFS_MAGIC	0x73636673
 #define SELINUX_MAGIC		0xf97cff8c
-#define SMACK_MAGIC		0x43415d53	/* "SMAC" */
+#define SMACK_MAGIC		0x43414d53	/* "SMAC" */
 #define RAMFS_MAGIC		0x858458f6	/* some random number */
 #define TMPFS_MAGIC		0x01021994
 #define HUGETLBFS_MAGIC 	0x958458f6	/* some random number */
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] smack: fix magic value
  2013-07-10 11:51 [PATCH] smack: fix magic value Phil Carmody
@ 2013-07-21  1:41 ` Casey Schaufler
  0 siblings, 0 replies; 2+ messages in thread
From: Casey Schaufler @ 2013-07-21  1:41 UTC (permalink / raw)
  To: Phil Carmody
  Cc: linux-security-module, linux-kernel, jarkko.sakkinen, Casey Schaufler

On 7/10/2013 4:51 AM, Phil Carmody wrote:
> 5d is ']', 'M' is 4d.

And spelling was never my strong suit. I don't know of anyone
who depends on this value, but in case someone does the correct
fix is to change the comment, not the constant.

>
> Signed-off-by: Phil Carmody <phil.carmody@partner.samsung.com>
> ---
>  include/uapi/linux/magic.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
> index 2944278..5c1d878 100644
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -11,7 +11,7 @@
>  #define DEBUGFS_MAGIC          0x64626720
>  #define SECURITYFS_MAGIC	0x73636673
>  #define SELINUX_MAGIC		0xf97cff8c
> -#define SMACK_MAGIC		0x43415d53	/* "SMAC" */
> +#define SMACK_MAGIC		0x43414d53	/* "SMAC" */
>  #define RAMFS_MAGIC		0x858458f6	/* some random number */
>  #define TMPFS_MAGIC		0x01021994
>  #define HUGETLBFS_MAGIC 	0x958458f6	/* some random number */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-07-21  1:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-10 11:51 [PATCH] smack: fix magic value Phil Carmody
2013-07-21  1:41 ` Casey Schaufler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).