* [PATCH] extable: Skip sorting if the table is empty
@ 2013-07-17 7:55 Uwe Kleine-König
2013-08-08 8:51 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2013-07-17 7:55 UTC (permalink / raw)
To: Ingo Molnar, David Daney, H. Peter Anvin
Cc: Borislav Petkov, linux-kernel, kernel
At least on ARM no-MMU the extable is empty and so there is nothing to
sort. So add a check for the table to be empty which effectively only
changes that the misleading pr_notice is suppressed.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
I first tried to select BUILDTIME_EXTABLE_SORT for ARM no-MMU, too, but that
failed to build with
no __ex_table in file: vmlinux
. I didn't dig deeper for the reasons, but maybe this is worth fixing, too?
Best regards
Uwe
kernel/extable.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/extable.c b/kernel/extable.c
index 67460b9..832cb28 100644
--- a/kernel/extable.c
+++ b/kernel/extable.c
@@ -41,7 +41,7 @@ u32 __initdata main_extable_sort_needed = 1;
/* Sort the kernel's built-in exception table */
void __init sort_main_extable(void)
{
- if (main_extable_sort_needed) {
+ if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
pr_notice("Sorting __ex_table...\n");
sort_extable(__start___ex_table, __stop___ex_table);
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] extable: Skip sorting if the table is empty
2013-07-17 7:55 [PATCH] extable: Skip sorting if the table is empty Uwe Kleine-König
@ 2013-08-08 8:51 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2013-08-08 8:51 UTC (permalink / raw)
To: Ingo Molnar, David Daney, H. Peter Anvin
Cc: Borislav Petkov, linux-kernel, kernel, Andrew Morton
Hello,
[adding akpm to Cc:]
On Wed, Jul 17, 2013 at 09:55:11AM +0200, Uwe Kleine-König wrote:
> At least on ARM no-MMU the extable is empty and so there is nothing to
> sort. So add a check for the table to be empty which effectively only
> changes that the misleading pr_notice is suppressed.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I first tried to select BUILDTIME_EXTABLE_SORT for ARM no-MMU, too, but that
> failed to build with
>
> no __ex_table in file: vmlinux
>
> . I didn't dig deeper for the reasons, but maybe this is worth fixing, too?
this doesn't appear in current next and I didn't get any feed back yet.
What do you think?
Thanks
Uwe
> kernel/extable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/extable.c b/kernel/extable.c
> index 67460b9..832cb28 100644
> --- a/kernel/extable.c
> +++ b/kernel/extable.c
> @@ -41,7 +41,7 @@ u32 __initdata main_extable_sort_needed = 1;
> /* Sort the kernel's built-in exception table */
> void __init sort_main_extable(void)
> {
> - if (main_extable_sort_needed) {
> + if (main_extable_sort_needed && __stop___ex_table > __start___ex_table) {
> pr_notice("Sorting __ex_table...\n");
> sort_extable(__start___ex_table, __stop___ex_table);
> }
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-08 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 7:55 [PATCH] extable: Skip sorting if the table is empty Uwe Kleine-König
2013-08-08 8:51 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).