From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
Youquan Song <youquan.song@linux.intel.com>,
Yinghai Lu <yinghai@kernel.org>, Gleb Natapov <gleb@redhat.com>,
Youquan Song <youquan.song@intel.com>,
Sheng Yang <sheng@linux.intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native
Date: Sat, 17 Aug 2013 02:03:51 -0700 [thread overview]
Message-ID: <1376730231.1954.7.camel@joe-AO722> (raw)
In-Reply-To: <20130817082419.GA10005@pd.tnic>
On Sat, 2013-08-17 at 10:24 +0200, Borislav Petkov wrote:
> On Sat, Aug 17, 2013 at 09:42:56AM +0200, Ingo Molnar wrote:
> >
> > * Youquan Song <youquan.song@linux.intel.com> wrote:
[]
> > Firstly, please use the customary (multi-line) comment
> > style:
> >
> > /*
> > * Comment .....
> > * ...... goes here.
> > */
> >
> > specified in Documentation/CodingStyle.
>
> This keeps popping up. Maybe it should be in checkpatch, Joe?
> With the special handling of net/ and drivers/net/ of course.
I don't feel that's useful.
You're welcome to add it if you want to.
checkpatch tends to be used for firs patch submissions and
adding it would only encourage a new wave of trivial whitespace
patches.
I think there are already way, _way_ too many existing instances
of comments that are of the form
/* foo
* ...
to add that.
There are 10s of thousands outside of net/ and drivers/net/.
next prev parent reply other threads:[~2013-08-17 9:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 1:22 [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Youquan Song
2013-07-23 9:17 ` Ingo Molnar
2013-07-24 14:04 ` Youquan Song
2013-07-25 22:01 ` Ingo Molnar
2013-07-29 16:48 ` Youquan Song
2013-07-24 3:55 ` [tip:x86/apic] x86/apic: Enable x2APIC physical mode on native hardware too, when there are fewer than 256 CPUs tip-bot for Youquan Song
2013-07-24 4:24 ` [PATCH] x86, apic: Enable x2APIC physical when cpu < 256 native Yinghai Lu
2013-07-24 6:22 ` Gleb Natapov
2013-07-25 14:05 ` Yinghai Lu
2013-07-29 17:05 ` Youquan Song
2013-08-14 18:40 ` Youquan Song
2013-08-14 11:11 ` Ingo Molnar
2013-08-17 13:44 ` Youquan Song
2013-08-17 7:42 ` Ingo Molnar
2013-08-17 8:24 ` Borislav Petkov
2013-08-17 9:03 ` Joe Perches [this message]
2013-08-17 15:44 ` Borislav Petkov
2013-08-17 16:26 ` Joe Perches
2013-08-18 10:02 ` Borislav Petkov
2013-08-17 19:52 ` Youquan Song
2013-08-19 7:11 ` Ingo Molnar
2013-08-02 19:12 ` Konrad Rzeszutek Wilk
2013-07-24 14:45 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376730231.1954.7.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sheng@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).