* [PATCH] parisc: Export flush_cache_page() (needed by lustre)
@ 2013-09-05 9:33 Geert Uytterhoeven
2013-09-05 16:01 ` James Bottomley
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2013-09-05 9:33 UTC (permalink / raw)
To: James E.J. Bottomley, Helge Deller
Cc: linux-parisc, linux-kernel, Geert Uytterhoeven
ERROR: "flush_cache_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/parisc/kernel/cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
index c035673..b521c0a 100644
--- a/arch/parisc/kernel/cache.c
+++ b/arch/parisc/kernel/cache.c
@@ -602,6 +602,7 @@ flush_cache_page(struct vm_area_struct *vma, unsigned long vmaddr, unsigned long
__flush_cache_page(vma, vmaddr, PFN_PHYS(pfn));
}
}
+EXPORT_SYMBOL_GPL(flush_cache_page);
#ifdef CONFIG_PARISC_TMPALIAS
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre)
2013-09-05 9:33 [PATCH] parisc: Export flush_cache_page() (needed by lustre) Geert Uytterhoeven
@ 2013-09-05 16:01 ` James Bottomley
2013-09-05 17:13 ` Kyle McMartin
2013-09-05 18:25 ` John David Anglin
0 siblings, 2 replies; 5+ messages in thread
From: James Bottomley @ 2013-09-05 16:01 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: James E.J. Bottomley, Helge Deller, linux-parisc, linux-kernel
On Thu, 2013-09-05 at 11:33 +0200, Geert Uytterhoeven wrote:
> ERROR: "flush_cache_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/parisc/kernel/cache.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
> index c035673..b521c0a 100644
> --- a/arch/parisc/kernel/cache.c
> +++ b/arch/parisc/kernel/cache.c
> @@ -602,6 +602,7 @@ flush_cache_page(struct vm_area_struct *vma, unsigned long vmaddr, unsigned long
> __flush_cache_page(vma, vmaddr, PFN_PHYS(pfn));
> }
> }
> +EXPORT_SYMBOL_GPL(flush_cache_page);
This is an internal API: no architecture exports this. Whoever is
trying to use it needs to use the correct API, so this is the wrong
patch.
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre)
2013-09-05 16:01 ` James Bottomley
@ 2013-09-05 17:13 ` Kyle McMartin
2013-09-05 18:07 ` Geert Uytterhoeven
2013-09-05 18:25 ` John David Anglin
1 sibling, 1 reply; 5+ messages in thread
From: Kyle McMartin @ 2013-09-05 17:13 UTC (permalink / raw)
To: James Bottomley
Cc: Geert Uytterhoeven, James E.J. Bottomley, Helge Deller,
linux-parisc, linux-kernel
On Thu, Sep 05, 2013 at 09:01:59AM -0700, James Bottomley wrote:
> > +EXPORT_SYMBOL_GPL(flush_cache_page);
>
> This is an internal API: no architecture exports this. Whoever is
> trying to use it needs to use the correct API, so this is the wrong
> patch.
>
I suspect it's copy_{to,from}_user_page being called here:
drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c:
copy_to_user_page(vma, page, addr,
which we could probably take out of line.
--Kyle
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre)
2013-09-05 17:13 ` Kyle McMartin
@ 2013-09-05 18:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2013-09-05 18:07 UTC (permalink / raw)
To: Kyle McMartin
Cc: James Bottomley, James E.J. Bottomley, Helge Deller, Parisc List,
linux-kernel
On Thu, Sep 5, 2013 at 7:13 PM, Kyle McMartin <kyle@infradead.org> wrote:
> On Thu, Sep 05, 2013 at 09:01:59AM -0700, James Bottomley wrote:
>> > +EXPORT_SYMBOL_GPL(flush_cache_page);
>>
>> This is an internal API: no architecture exports this. Whoever is
>> trying to use it needs to use the correct API, so this is the wrong
>> patch.
>>
>
> I suspect it's copy_{to,from}_user_page being called here:
Indeed. Sorry, I should have mentioned that.
> drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c:
> copy_to_user_page(vma, page, addr,
>
> which we could probably take out of line.
If you want to hide flush_cache_page() for modules, yes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] parisc: Export flush_cache_page() (needed by lustre)
2013-09-05 16:01 ` James Bottomley
2013-09-05 17:13 ` Kyle McMartin
@ 2013-09-05 18:25 ` John David Anglin
1 sibling, 0 replies; 5+ messages in thread
From: John David Anglin @ 2013-09-05 18:25 UTC (permalink / raw)
To: James Bottomley
Cc: Geert Uytterhoeven, James E.J. Bottomley, Helge Deller,
linux-parisc, linux-kernel
On 9/5/2013 12:01 PM, James Bottomley wrote:
> On Thu, 2013-09-05 at 11:33 +0200, Geert Uytterhoeven wrote:
>> ERROR: "flush_cache_page" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> arch/parisc/kernel/cache.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c
>> index c035673..b521c0a 100644
>> --- a/arch/parisc/kernel/cache.c
>> +++ b/arch/parisc/kernel/cache.c
>> @@ -602,6 +602,7 @@ flush_cache_page(struct vm_area_struct *vma, unsigned long vmaddr, unsigned long
>> __flush_cache_page(vma, vmaddr, PFN_PHYS(pfn));
>> }
>> }
>> +EXPORT_SYMBOL_GPL(flush_cache_page);
> This is an internal API: no architecture exports this. Whoever is
> trying to use it needs to use the correct API, so this is the wrong
> patch.
>
There is a declaration for it in arch/parisc/include/asm/cacheflush.h.
There are a bunch
of callers in mm. The interface in documented in
Documentation/cachetlb.txt. We currently
use it in copy_to_user_page and copy_from_user_page.
Dave
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-05 18:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-05 9:33 [PATCH] parisc: Export flush_cache_page() (needed by lustre) Geert Uytterhoeven
2013-09-05 16:01 ` James Bottomley
2013-09-05 17:13 ` Kyle McMartin
2013-09-05 18:07 ` Geert Uytterhoeven
2013-09-05 18:25 ` John David Anglin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).