* [PATCH 1/2] UBI: Fix error path in scan_pool()
@ 2013-09-25 20:32 Richard Weinberger
2013-09-25 20:32 ` [PATCH 2/2] UBI: Call scan_all() with correct offset in error case Richard Weinberger
2013-09-26 7:20 ` [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Genoud
0 siblings, 2 replies; 10+ messages in thread
From: Richard Weinberger @ 2013-09-25 20:32 UTC (permalink / raw)
To: dedekind1
Cc: dwmw2, linux-mtd, linux-kernel, richard.genoud, Richard Weinberger
We have to set "ret", not "err" in case of an error.
Reported-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/fastmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index f5aa4b0..9b42add 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
ubi_err("bad image seq: 0x%x, expected: 0x%x",
be32_to_cpu(ech->image_seq), ubi->image_seq);
- err = UBI_BAD_FASTMAP;
+ ret = UBI_BAD_FASTMAP;
goto out;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] UBI: Call scan_all() with correct offset in error case
2013-09-25 20:32 [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Weinberger
@ 2013-09-25 20:32 ` Richard Weinberger
2013-09-26 7:22 ` Richard Genoud
2013-09-26 7:20 ` [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Genoud
1 sibling, 1 reply; 10+ messages in thread
From: Richard Weinberger @ 2013-09-25 20:32 UTC (permalink / raw)
To: dedekind1
Cc: dwmw2, linux-mtd, linux-kernel, richard.genoud, Richard Weinberger
If we find an invalid fastmap we have to scan from the very beginning.
Otherwise we leak the first 64 PEBs.
Reported-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/attach.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
index c071d41..03b32b0 100644
--- a/drivers/mtd/ubi/attach.c
+++ b/drivers/mtd/ubi/attach.c
@@ -1417,9 +1417,11 @@ int ubi_attach(struct ubi_device *ubi, int force_scan)
ai = alloc_ai("ubi_aeb_slab_cache2");
if (!ai)
return -ENOMEM;
- }
- err = scan_all(ubi, ai, UBI_FM_MAX_START);
+ err = scan_all(ubi, ai, 0);
+ } else {
+ err = scan_all(ubi, ai, UBI_FM_MAX_START);
+ }
}
}
#else
--
1.8.1.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-25 20:32 [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Weinberger
2013-09-25 20:32 ` [PATCH 2/2] UBI: Call scan_all() with correct offset in error case Richard Weinberger
@ 2013-09-26 7:20 ` Richard Genoud
2013-09-26 7:24 ` Richard Weinberger
1 sibling, 1 reply; 10+ messages in thread
From: Richard Genoud @ 2013-09-26 7:20 UTC (permalink / raw)
To: Richard Weinberger; +Cc: dedekind1, dwmw2, linux-mtd, linux-kernel
On 25/09/2013 22:32, Richard Weinberger wrote:
> We have to set "ret", not "err" in case of an error.
>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/mtd/ubi/fastmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index f5aa4b0..9b42add 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
> if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
> ubi_err("bad image seq: 0x%x, expected: 0x%x",
> be32_to_cpu(ech->image_seq), ubi->image_seq);
> - err = UBI_BAD_FASTMAP;
> + ret = UBI_BAD_FASTMAP;
> goto out;
> }
>
>
Tested-by: Richard Genoud <richard.genoud@gmail.com>
It reveals another bug though.
[ 0.812500] UBI: default fastmap pool size: 95
[ 0.820312] UBI: default fastmap WL pool size: 25
[ 0.820312] UBI: attaching mtd2 to ubi0
[ 0.914062] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
[ 0.921875] UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
[ 0.929687] kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
[ 0.937500] CPU: 0 PID: 1 Comm: swapper Not tainted 3.11.1 #15
[ 0.945312] [<c0012e20>] (unwind_backtrace+0x0/0xe0) from [<c0010bb8>] (show_stack+0x10/0x14)
[ 0.953125] [<c0010bb8>] (show_stack+0x10/0x14) from [<c01a15e4>] (destroy_ai+0x230/0x244)
[ 0.960937] [<c01a15e4>] (destroy_ai+0x230/0x244) from [<c01a2c5c>] (ubi_attach+0x1f8/0x34c)
[ 0.968750] [<c01a2c5c>] (ubi_attach+0x1f8/0x34c) from [<c0197678>] (ubi_attach_mtd_dev+0x2b8/0x86c)
[ 0.976562] [<c0197678>] (ubi_attach_mtd_dev+0x2b8/0x86c) from [<c0346630>] (ubi_init+0x1d8/0x29c)
[ 0.984375] [<c0346630>] (ubi_init+0x1d8/0x29c) from [<c0008810>] (do_one_initcall+0x94/0x144)
[ 0.992187] [<c0008810>] (do_one_initcall+0x94/0x144) from [<c0335a9c>] (kernel_init_freeable+0xe8/0x1ac)
[ 1.000000] [<c0335a9c>] (kernel_init_freeable+0xe8/0x1ac) from [<c0251500>] (kernel_init+0x8/0xe4)
[ 1.007812] [<c0251500>] (kernel_init+0x8/0xe4) from [<c000e590>] (ret_from_fork+0x14/0x24)
[ 1.742187] UBI: scanning is finished
Thanks !
Richard.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] UBI: Call scan_all() with correct offset in error case
2013-09-25 20:32 ` [PATCH 2/2] UBI: Call scan_all() with correct offset in error case Richard Weinberger
@ 2013-09-26 7:22 ` Richard Genoud
0 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2013-09-26 7:22 UTC (permalink / raw)
To: Richard Weinberger; +Cc: dedekind1, dwmw2, linux-mtd, linux-kernel
On 25/09/2013 22:32, Richard Weinberger wrote:
> If we find an invalid fastmap we have to scan from the very beginning.
> Otherwise we leak the first 64 PEBs.
>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/mtd/ubi/attach.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/ubi/attach.c b/drivers/mtd/ubi/attach.c
> index c071d41..03b32b0 100644
> --- a/drivers/mtd/ubi/attach.c
> +++ b/drivers/mtd/ubi/attach.c
> @@ -1417,9 +1417,11 @@ int ubi_attach(struct ubi_device *ubi, int force_scan)
> ai = alloc_ai("ubi_aeb_slab_cache2");
> if (!ai)
> return -ENOMEM;
> - }
>
> - err = scan_all(ubi, ai, UBI_FM_MAX_START);
> + err = scan_all(ubi, ai, 0);
> + } else {
> + err = scan_all(ubi, ai, UBI_FM_MAX_START);
> + }
> }
> }
> #else
>
Works great, the assert is not triggered anymore.
Tested-by: Richard Genoud <richard.genoud@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-26 7:20 ` [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Genoud
@ 2013-09-26 7:24 ` Richard Weinberger
2013-09-26 7:33 ` Richard Genoud
0 siblings, 1 reply; 10+ messages in thread
From: Richard Weinberger @ 2013-09-26 7:24 UTC (permalink / raw)
To: Richard Genoud; +Cc: dedekind1, dwmw2, linux-mtd, linux-kernel
Am 26.09.2013 09:20, schrieb Richard Genoud:
> On 25/09/2013 22:32, Richard Weinberger wrote:
>> We have to set "ret", not "err" in case of an error.
>>
>> Reported-by: Richard Genoud <richard.genoud@gmail.com>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/mtd/ubi/fastmap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>> index f5aa4b0..9b42add 100644
>> --- a/drivers/mtd/ubi/fastmap.c
>> +++ b/drivers/mtd/ubi/fastmap.c
>> @@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
>> if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
>> ubi_err("bad image seq: 0x%x, expected: 0x%x",
>> be32_to_cpu(ech->image_seq), ubi->image_seq);
>> - err = UBI_BAD_FASTMAP;
>> + ret = UBI_BAD_FASTMAP;
>> goto out;
>> }
>>
>>
>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
>
> It reveals another bug though.
>
> [ 0.812500] UBI: default fastmap pool size: 95
> [ 0.820312] UBI: default fastmap WL pool size: 25
> [ 0.820312] UBI: attaching mtd2 to ubi0
> [ 0.914062] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
This worries me more...
The fastmap is corrupted, now we have to find out why.
Broken driver? Powercut? IO errors?
> [ 0.921875] UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
> [ 0.929687] kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
I see.
Thanks,
//richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-26 7:24 ` Richard Weinberger
@ 2013-09-26 7:33 ` Richard Genoud
2013-09-26 9:25 ` Richard Genoud
0 siblings, 1 reply; 10+ messages in thread
From: Richard Genoud @ 2013-09-26 7:33 UTC (permalink / raw)
To: Richard Weinberger
Cc: Artem Bityutskiy, David Woodhouse, linux-mtd, linux-kernel
2013/9/26 Richard Weinberger <richard@nod.at>:
> Am 26.09.2013 09:20, schrieb Richard Genoud:
>> On 25/09/2013 22:32, Richard Weinberger wrote:
>>> We have to set "ret", not "err" in case of an error.
>>>
>>> Reported-by: Richard Genoud <richard.genoud@gmail.com>
>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>> ---
>>> drivers/mtd/ubi/fastmap.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>>> index f5aa4b0..9b42add 100644
>>> --- a/drivers/mtd/ubi/fastmap.c
>>> +++ b/drivers/mtd/ubi/fastmap.c
>>> @@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
>>> if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
>>> ubi_err("bad image seq: 0x%x, expected: 0x%x",
>>> be32_to_cpu(ech->image_seq), ubi->image_seq);
>>> - err = UBI_BAD_FASTMAP;
>>> + ret = UBI_BAD_FASTMAP;
>>> goto out;
>>> }
>>>
>>>
>>
>> Tested-by: Richard Genoud <richard.genoud@gmail.com>
>>
>> It reveals another bug though.
>>
>> [ 0.812500] UBI: default fastmap pool size: 95
>> [ 0.820312] UBI: default fastmap WL pool size: 25
>> [ 0.820312] UBI: attaching mtd2 to ubi0
>> [ 0.914062] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
>
> This worries me more...
> The fastmap is corrupted, now we have to find out why.
> Broken driver? Powercut? IO errors?
I guess this is caused by u-boot when it deletes the UBI fastmap
internal volume.
I'm replaying the whole scenario with debug to see when it happens.
>
>> [ 0.921875] UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
>> [ 0.929687] kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
>
> I see.
>
> Thanks,
> //richard
--
for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-26 7:33 ` Richard Genoud
@ 2013-09-26 9:25 ` Richard Genoud
2013-09-26 9:59 ` Richard Weinberger
2013-09-27 11:01 ` Richard Weinberger
0 siblings, 2 replies; 10+ messages in thread
From: Richard Genoud @ 2013-09-26 9:25 UTC (permalink / raw)
To: Richard Weinberger
Cc: Artem Bityutskiy, David Woodhouse, linux-mtd, linux-kernel
2013/9/26 Richard Genoud <richard.genoud@gmail.com>:
> 2013/9/26 Richard Weinberger <richard@nod.at>:
>> Am 26.09.2013 09:20, schrieb Richard Genoud:
>>> On 25/09/2013 22:32, Richard Weinberger wrote:
>>>> We have to set "ret", not "err" in case of an error.
>>>>
>>>> Reported-by: Richard Genoud <richard.genoud@gmail.com>
>>>> Signed-off-by: Richard Weinberger <richard@nod.at>
>>>> ---
>>>> drivers/mtd/ubi/fastmap.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
>>>> index f5aa4b0..9b42add 100644
>>>> --- a/drivers/mtd/ubi/fastmap.c
>>>> +++ b/drivers/mtd/ubi/fastmap.c
>>>> @@ -428,7 +428,7 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
>>>> if (be32_to_cpu(ech->image_seq) != ubi->image_seq) {
>>>> ubi_err("bad image seq: 0x%x, expected: 0x%x",
>>>> be32_to_cpu(ech->image_seq), ubi->image_seq);
>>>> - err = UBI_BAD_FASTMAP;
>>>> + ret = UBI_BAD_FASTMAP;
>>>> goto out;
>>>> }
>>>>
>>>>
>>>
>>> Tested-by: Richard Genoud <richard.genoud@gmail.com>
>>>
>>> It reveals another bug though.
>>>
>>> [ 0.812500] UBI: default fastmap pool size: 95
>>> [ 0.820312] UBI: default fastmap WL pool size: 25
>>> [ 0.820312] UBI: attaching mtd2 to ubi0
>>> [ 0.914062] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
>>
>> This worries me more...
>> The fastmap is corrupted, now we have to find out why.
>> Broken driver? Powercut? IO errors?
> I guess this is caused by u-boot when it deletes the UBI fastmap
> internal volume.
> I'm replaying the whole scenario with debug to see when it happens.
I added some traces and I found that : (dumping ec_header after
"ubi_io_read_ec_hdr(ubi, pnum, ech, 0); " in ubi_scan_fastmap())
[ 0.812500] UBI: default fastmap pool size: 95
[ 0.820312] UBI: default fastmap WL pool size: 25
[ 0.828125] UBI: attaching mtd2 to ubi0
[ 0.851562] ubi_scan_fastmap:
[ 0.859375] Erase counter header dump:
[ 0.859375] magic 0x55424923
[ 0.867187] version 1
[ 0.867187] ec 1
[ 0.867187] vid_hdr_offset 2048
[ 0.875000] data_offset 4096
[ 0.875000] image_seq 891983656 <- image seq is good.
[ 0.875000] hdr_crc 0x13cc9a78
[ 0.882812] erase counter header hexdump:
[ 0.882812] 00000000: 55 42 49 23 01 00 00 00 00 00 00 00 00 00 00
01 00 00 08 00 00 00 10 00 35 2a 97
28 00 00 00 00 UBI#....................5*.(....
[ 0.890625] 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00
00 13 cc 9a 78 ...............................x
[ 0.960937] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
[ 0.968750] UBI error: ubi_scan_fastmap: Attach by fastmap failed,
doing a full scan!
[ 0.976562] kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still
has objects
[ 0.976562] CPU: 0 PID: 1 Comm: swapper Not tainted 3.11.1 #20
[ 0.984375] [<c0012e20>] (unwind_backtrace+0x0/0xe0) from
[<c0010bb8>] (show_stack+0x10/0x14)
[ 0.992187] [<c0010bb8>] (show_stack+0x10/0x14) from [<c01a15e4>]
(destroy_ai+0x230/0x244)
[ 1.000000] [<c01a15e4>] (destroy_ai+0x230/0x244) from [<c01a2c4c>]
(ubi_attach+0x1e8/0x34c)
[ 1.007812] [<c01a2c4c>] (ubi_attach+0x1e8/0x34c) from [<c0197678>]
(ubi_attach_mtd_dev+0x2b8/0x86c)
[ 1.015625] [<c0197678>] (ubi_attach_mtd_dev+0x2b8/0x86c) from
[<c0346630>] (ubi_init+0x1d8/0x29c)
[ 1.023437] [<c0346630>] (ubi_init+0x1d8/0x29c) from [<c0008810>]
(do_one_initcall+0x94/0x144)
[ 1.031250] [<c0008810>] (do_one_initcall+0x94/0x144) from
[<c0335a9c>] (kernel_init_freeable+0xe8/0x1a
c)
[ 1.039062] [<c0335a9c>] (kernel_init_freeable+0xe8/0x1ac) from
[<c0251528>] (kernel_init+0x8/0xe4)
[ 1.046875] [<c0251528>] (kernel_init+0x8/0xe4) from [<c000e590>]
(ret_from_fork+0x14/0x24)
[ 1.804687] UBI: scanning is finished
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-26 9:25 ` Richard Genoud
@ 2013-09-26 9:59 ` Richard Weinberger
2013-09-27 11:01 ` Richard Weinberger
1 sibling, 0 replies; 10+ messages in thread
From: Richard Weinberger @ 2013-09-26 9:59 UTC (permalink / raw)
To: Richard Genoud; +Cc: Artem Bityutskiy, David Woodhouse, linux-mtd, linux-kernel
Am 26.09.2013 11:25, schrieb Richard Genoud:
> I added some traces and I found that : (dumping ec_header after
> "ubi_io_read_ec_hdr(ubi, pnum, ech, 0); " in ubi_scan_fastmap())
Please show me the diff to understand what exactly you did. :)
> [ 0.812500] UBI: default fastmap pool size: 95
> [ 0.820312] UBI: default fastmap WL pool size: 25
> [ 0.828125] UBI: attaching mtd2 to ubi0
> [ 0.851562] ubi_scan_fastmap:
> [ 0.859375] Erase counter header dump:
> [ 0.859375] magic 0x55424923
> [ 0.867187] version 1
> [ 0.867187] ec 1
> [ 0.867187] vid_hdr_offset 2048
> [ 0.875000] data_offset 4096
> [ 0.875000] image_seq 891983656 <- image seq is good.
> [ 0.875000] hdr_crc 0x13cc9a78
> [ 0.882812] erase counter header hexdump:
> [ 0.882812] 00000000: 55 42 49 23 01 00 00 00 00 00 00 00 00 00 00
> 01 00 00 08 00 00 00 10 00 35 2a 97
> 28 00 00 00 00 UBI#....................5*.(....
> [ 0.890625] 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00
> 00 13 cc 9a 78 ...............................x
Hmm, maybe a memory corruption. Strange.
Thanks,
//richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-26 9:25 ` Richard Genoud
2013-09-26 9:59 ` Richard Weinberger
@ 2013-09-27 11:01 ` Richard Weinberger
2013-09-27 11:12 ` Richard Genoud
1 sibling, 1 reply; 10+ messages in thread
From: Richard Weinberger @ 2013-09-27 11:01 UTC (permalink / raw)
To: Richard Genoud; +Cc: Artem Bityutskiy, David Woodhouse, linux-mtd, linux-kernel
Am 26.09.2013 11:25, schrieb Richard Genoud:
> I added some traces and I found that : (dumping ec_header after
> "ubi_io_read_ec_hdr(ubi, pnum, ech, 0); " in ubi_scan_fastmap())
> [ 0.812500] UBI: default fastmap pool size: 95
> [ 0.820312] UBI: default fastmap WL pool size: 25
> [ 0.828125] UBI: attaching mtd2 to ubi0
> [ 0.851562] ubi_scan_fastmap:
> [ 0.859375] Erase counter header dump:
> [ 0.859375] magic 0x55424923
> [ 0.867187] version 1
> [ 0.867187] ec 1
> [ 0.867187] vid_hdr_offset 2048
> [ 0.875000] data_offset 4096
> [ 0.875000] image_seq 891983656 <- image seq is good.
> [ 0.875000] hdr_crc 0x13cc9a78
> [ 0.882812] erase counter header hexdump:
> [ 0.882812] 00000000: 55 42 49 23 01 00 00 00 00 00 00 00 00 00 00
> 01 00 00 08 00 00 00 10 00 35 2a 97
> 28 00 00 00 00 UBI#....................5*.(....
> [ 0.890625] 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00
> 00 13 cc 9a 78 ...............................x
> [ 0.960937] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
BTW: Do you really print the same PEB as scan_pool() complains about?
Do you know how many PEBs for one fastmap are needed on your target?
Thanks,
//richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] UBI: Fix error path in scan_pool()
2013-09-27 11:01 ` Richard Weinberger
@ 2013-09-27 11:12 ` Richard Genoud
0 siblings, 0 replies; 10+ messages in thread
From: Richard Genoud @ 2013-09-27 11:12 UTC (permalink / raw)
To: Richard Weinberger
Cc: Artem Bityutskiy, David Woodhouse, linux-mtd, linux-kernel
2013/9/27 Richard Weinberger <richard@nod.at>:
> Am 26.09.2013 11:25, schrieb Richard Genoud:
>> I added some traces and I found that : (dumping ec_header after
>> "ubi_io_read_ec_hdr(ubi, pnum, ech, 0); " in ubi_scan_fastmap())
>> [ 0.812500] UBI: default fastmap pool size: 95
>> [ 0.820312] UBI: default fastmap WL pool size: 25
>> [ 0.828125] UBI: attaching mtd2 to ubi0
>> [ 0.851562] ubi_scan_fastmap:
>> [ 0.859375] Erase counter header dump:
>> [ 0.859375] magic 0x55424923
>> [ 0.867187] version 1
>> [ 0.867187] ec 1
>> [ 0.867187] vid_hdr_offset 2048
>> [ 0.875000] data_offset 4096
>> [ 0.875000] image_seq 891983656 <- image seq is good.
>> [ 0.875000] hdr_crc 0x13cc9a78
>> [ 0.882812] erase counter header hexdump:
>> [ 0.882812] 00000000: 55 42 49 23 01 00 00 00 00 00 00 00 00 00 00
>> 01 00 00 08 00 00 00 10 00 35 2a 97
>> 28 00 00 00 00 UBI#....................5*.(....
>> [ 0.890625] 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>> 00 00 00 00 00 00 00 00 00 00 00 00
>> 00 13 cc 9a 78 ...............................x
>> [ 0.960937] UBI error: scan_pool: bad image seq: 0x0, expected: 0x352a9728
>
> BTW: Do you really print the same PEB as scan_pool() complains about?
No, those debug traces were dumb, sorry...
I understand fastmap code better now :)
> Do you know how many PEBs for one fastmap are needed on your target?
Actually, I just found the problem.
U-boot has an old UBI implementation that was not aware of image_seq.
So when I write the ubifs volume, some PEB got erased by UBI(in uboot)
and written with a image_seq==0.
and fastmap doesn't pay attention to this use case.
I'll have to test a patch I made and I'll send it in a while.
Richard.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-09-27 11:13 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-25 20:32 [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Weinberger
2013-09-25 20:32 ` [PATCH 2/2] UBI: Call scan_all() with correct offset in error case Richard Weinberger
2013-09-26 7:22 ` Richard Genoud
2013-09-26 7:20 ` [PATCH 1/2] UBI: Fix error path in scan_pool() Richard Genoud
2013-09-26 7:24 ` Richard Weinberger
2013-09-26 7:33 ` Richard Genoud
2013-09-26 9:25 ` Richard Genoud
2013-09-26 9:59 ` Richard Weinberger
2013-09-27 11:01 ` Richard Weinberger
2013-09-27 11:12 ` Richard Genoud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).