* [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr
@ 2013-09-28 12:08 Sachin Kamat
2013-09-28 12:08 ` [PATCH 02/11] pinctrl: exynos5440: " Sachin Kamat
` (10 more replies)
0 siblings, 11 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-at91.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index f350fd2..2673ce3 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1671,7 +1671,7 @@ static struct platform_driver at91_gpio_driver = {
.driver = {
.name = "gpio-at91",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(at91_gpio_of_match),
+ .of_match_table = at91_gpio_of_match,
},
.probe = at91_gpio_probe,
};
@@ -1680,7 +1680,7 @@ static struct platform_driver at91_pinctrl_driver = {
.driver = {
.name = "pinctrl-at91",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(at91_pinctrl_of_match),
+ .of_match_table = at91_pinctrl_of_match,
},
.probe = at91_pinctrl_probe,
.remove = at91_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 02/11] pinctrl: exynos5440: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-10-08 7:55 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 03/11] pinctrl: imx35: " Sachin Kamat
` (9 subsequent siblings)
10 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-exynos5440.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-exynos5440.c b/drivers/pinctrl/pinctrl-exynos5440.c
index 544d469..8fe2ab0 100644
--- a/drivers/pinctrl/pinctrl-exynos5440.c
+++ b/drivers/pinctrl/pinctrl-exynos5440.c
@@ -1048,7 +1048,7 @@ static struct platform_driver exynos5440_pinctrl_driver = {
.driver = {
.name = "exynos5440-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(exynos5440_pinctrl_dt_match),
+ .of_match_table = exynos5440_pinctrl_dt_match,
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 03/11] pinctrl: imx35: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
2013-09-28 12:08 ` [PATCH 02/11] pinctrl: exynos5440: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-10-08 7:56 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 04/11] pinctrl: imx51: " Sachin Kamat
` (8 subsequent siblings)
10 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-imx35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx35.c b/drivers/pinctrl/pinctrl-imx35.c
index c454982..278a04a 100644
--- a/drivers/pinctrl/pinctrl-imx35.c
+++ b/drivers/pinctrl/pinctrl-imx35.c
@@ -1019,7 +1019,7 @@ static struct platform_driver imx35_pinctrl_driver = {
.driver = {
.name = "imx35-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(imx35_pinctrl_of_match),
+ .of_match_table = imx35_pinctrl_of_match,
},
.probe = imx35_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 04/11] pinctrl: imx51: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
2013-09-28 12:08 ` [PATCH 02/11] pinctrl: exynos5440: " Sachin Kamat
2013-09-28 12:08 ` [PATCH 03/11] pinctrl: imx35: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-10-08 7:56 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 05/11] pinctrl: imx53: " Sachin Kamat
` (7 subsequent siblings)
10 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-imx51.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx51.c b/drivers/pinctrl/pinctrl-imx51.c
index db268b9..19ab182 100644
--- a/drivers/pinctrl/pinctrl-imx51.c
+++ b/drivers/pinctrl/pinctrl-imx51.c
@@ -782,7 +782,7 @@ static struct platform_driver imx51_pinctrl_driver = {
.driver = {
.name = "imx51-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(imx51_pinctrl_of_match),
+ .of_match_table = imx51_pinctrl_of_match,
},
.probe = imx51_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 05/11] pinctrl: imx53: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (2 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 04/11] pinctrl: imx51: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-10-08 7:57 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 06/11] pinctrl: imx6dl: " Sachin Kamat
` (6 subsequent siblings)
10 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-imx53.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx53.c b/drivers/pinctrl/pinctrl-imx53.c
index 17562ae..f8d45c4 100644
--- a/drivers/pinctrl/pinctrl-imx53.c
+++ b/drivers/pinctrl/pinctrl-imx53.c
@@ -468,7 +468,7 @@ static struct platform_driver imx53_pinctrl_driver = {
.driver = {
.name = "imx53-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(imx53_pinctrl_of_match),
+ .of_match_table = imx53_pinctrl_of_match,
},
.probe = imx53_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 06/11] pinctrl: imx6dl: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (3 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 05/11] pinctrl: imx53: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-09-28 12:08 ` [PATCH 07/11] pinctrl: imx6q: " Sachin Kamat
` (5 subsequent siblings)
10 siblings, 0 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-imx6dl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx6dl.c b/drivers/pinctrl/pinctrl-imx6dl.c
index a76b724..db2a148 100644
--- a/drivers/pinctrl/pinctrl-imx6dl.c
+++ b/drivers/pinctrl/pinctrl-imx6dl.c
@@ -474,7 +474,7 @@ static struct platform_driver imx6dl_pinctrl_driver = {
.driver = {
.name = "imx6dl-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(imx6dl_pinctrl_of_match),
+ .of_match_table = imx6dl_pinctrl_of_match,
},
.probe = imx6dl_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 07/11] pinctrl: imx6q: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (4 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 06/11] pinctrl: imx6dl: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-10-08 7:59 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 08/11] pinctrl: samsung: " Sachin Kamat
` (4 subsequent siblings)
10 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-imx6q.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx6q.c b/drivers/pinctrl/pinctrl-imx6q.c
index 76dd9c4..8eb5ac1 100644
--- a/drivers/pinctrl/pinctrl-imx6q.c
+++ b/drivers/pinctrl/pinctrl-imx6q.c
@@ -480,7 +480,7 @@ static struct platform_driver imx6q_pinctrl_driver = {
.driver = {
.name = "imx6q-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(imx6q_pinctrl_of_match),
+ .of_match_table = imx6q_pinctrl_of_match,
},
.probe = imx6q_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 08/11] pinctrl: samsung: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (5 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 07/11] pinctrl: imx6q: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-09-28 12:08 ` [PATCH 09/11] pinctrl: vf610: " Sachin Kamat
` (3 subsequent siblings)
10 siblings, 0 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-samsung.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c
index 92a9d6c..47ec2e8 100644
--- a/drivers/pinctrl/pinctrl-samsung.c
+++ b/drivers/pinctrl/pinctrl-samsung.c
@@ -1148,7 +1148,7 @@ static struct platform_driver samsung_pinctrl_driver = {
.driver = {
.name = "samsung-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(samsung_pinctrl_dt_match),
+ .of_match_table = samsung_pinctrl_dt_match,
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 09/11] pinctrl: vf610: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (6 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 08/11] pinctrl: samsung: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-09-28 12:08 ` [PATCH 10/11] pinctrl: imx6sl: " Sachin Kamat
` (2 subsequent siblings)
10 siblings, 0 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-vf610.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-vf610.c b/drivers/pinctrl/pinctrl-vf610.c
index 68a970b..bddd913 100644
--- a/drivers/pinctrl/pinctrl-vf610.c
+++ b/drivers/pinctrl/pinctrl-vf610.c
@@ -316,7 +316,7 @@ static struct platform_driver vf610_pinctrl_driver = {
.driver = {
.name = "vf610-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(vf610_pinctrl_of_match),
+ .of_match_table = vf610_pinctrl_of_match,
},
.probe = vf610_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 10/11] pinctrl: imx6sl: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (7 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 09/11] pinctrl: vf610: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-09-28 12:08 ` [PATCH 11/11] pinctrl: plgpio: " Sachin Kamat
2013-10-08 7:54 ` [PATCH 01/11] pinctrl: at91: " Linus Walleij
10 siblings, 0 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/pinctrl/pinctrl-imx6sl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-imx6sl.c b/drivers/pinctrl/pinctrl-imx6sl.c
index 4eb7cca..f21b738 100644
--- a/drivers/pinctrl/pinctrl-imx6sl.c
+++ b/drivers/pinctrl/pinctrl-imx6sl.c
@@ -380,7 +380,7 @@ static struct platform_driver imx6sl_pinctrl_driver = {
.driver = {
.name = "imx6sl-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(imx6sl_pinctrl_of_match),
+ .of_match_table = imx6sl_pinctrl_of_match,
},
.probe = imx6sl_pinctrl_probe,
.remove = imx_pinctrl_remove,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (8 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 10/11] pinctrl: imx6sl: " Sachin Kamat
@ 2013-09-28 12:08 ` Sachin Kamat
2013-10-03 4:37 ` Viresh Kumar
` (2 more replies)
2013-10-08 7:54 ` [PATCH 01/11] pinctrl: at91: " Linus Walleij
10 siblings, 3 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-09-28 12:08 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, sachin.kamat, Viresh Kumar
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
index 0a7f0bdb..ff2940e 100644
--- a/drivers/pinctrl/spear/pinctrl-plgpio.c
+++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
@@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
.owner = THIS_MODULE,
.name = "spear-plgpio",
.pm = &plgpio_dev_pm_ops,
- .of_match_table = of_match_ptr(plgpio_of_match),
+ .of_match_table = plgpio_of_match,
},
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 11/11] pinctrl: plgpio: " Sachin Kamat
@ 2013-10-03 4:37 ` Viresh Kumar
2013-10-03 7:06 ` Sachin Kamat
2013-10-03 7:11 ` Viresh Kumar
2013-10-08 8:06 ` Linus Walleij
2 siblings, 1 reply; 26+ messages in thread
From: Viresh Kumar @ 2013-10-03 4:37 UTC (permalink / raw)
To: Sachin Kamat; +Cc: Linux Kernel Mailing List, Linus Walleij
On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
of_match_ptr() isn't a data structure.. And also what does "protects" mean here?
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
> index 0a7f0bdb..ff2940e 100644
> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
> .owner = THIS_MODULE,
> .name = "spear-plgpio",
> .pm = &plgpio_dev_pm_ops,
> - .of_match_table = of_match_ptr(plgpio_of_match),
> + .of_match_table = plgpio_of_match,
> },
> };
Patch is okay otherwise.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-10-03 4:37 ` Viresh Kumar
@ 2013-10-03 7:06 ` Sachin Kamat
2013-10-03 7:07 ` Viresh Kumar
0 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-10-03 7:06 UTC (permalink / raw)
To: Viresh Kumar; +Cc: Linux Kernel Mailing List, Linus Walleij
On 3 October 2013 10:07, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> The data structure of_match_ptr() protects is always compiled in.
>
> of_match_ptr() isn't a data structure..
Yes you are right. of_match_ptr() is a macro. The data structure here
refers to its argument and not of_match_ptr() itself.
>And also what does "protects" mean here?
It just means that of_match_ptr() avoids an undefined reference error
had CONFIG_OF been used around the data structures definition by
making the pointer NULL.
>
>> Hence of_match_ptr() is not needed.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
>> index 0a7f0bdb..ff2940e 100644
>> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
>> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
>> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
>> .owner = THIS_MODULE,
>> .name = "spear-plgpio",
>> .pm = &plgpio_dev_pm_ops,
>> - .of_match_table = of_match_ptr(plgpio_of_match),
>> + .of_match_table = plgpio_of_match,
>> },
>> };
>
> Patch is okay otherwise.
Hope to have your ack on this :)
Thanks for reviewing.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-10-03 7:06 ` Sachin Kamat
@ 2013-10-03 7:07 ` Viresh Kumar
2013-10-03 7:10 ` Sachin Kamat
0 siblings, 1 reply; 26+ messages in thread
From: Viresh Kumar @ 2013-10-03 7:07 UTC (permalink / raw)
To: Sachin Kamat; +Cc: Linux Kernel Mailing List, Linus Walleij
On 3 October 2013 12:36, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 3 October 2013 10:07, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>> The data structure of_match_ptr() protects is always compiled in.
>>
>> of_match_ptr() isn't a data structure..
>
> Yes you are right. of_match_ptr() is a macro. The data structure here
> refers to its argument and not of_match_ptr() itself.
>
>>And also what does "protects" mean here?
>
> It just means that of_match_ptr() avoids an undefined reference error
> had CONFIG_OF been used around the data structures definition by
> making the pointer NULL.
>
>>
>>> Hence of_match_ptr() is not needed.
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>>> ---
>>> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
>>> index 0a7f0bdb..ff2940e 100644
>>> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
>>> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
>>> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
>>> .owner = THIS_MODULE,
>>> .name = "spear-plgpio",
>>> .pm = &plgpio_dev_pm_ops,
>>> - .of_match_table = of_match_ptr(plgpio_of_match),
>>> + .of_match_table = plgpio_of_match,
>>> },
>>> };
>>
>> Patch is okay otherwise.
>
> Hope to have your ack on this :)
> Thanks for reviewing.
Yeah I will Ack this.. but was waiting for your next version with fixed log. :)
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-10-03 7:07 ` Viresh Kumar
@ 2013-10-03 7:10 ` Sachin Kamat
2013-10-03 7:12 ` Viresh Kumar
0 siblings, 1 reply; 26+ messages in thread
From: Sachin Kamat @ 2013-10-03 7:10 UTC (permalink / raw)
To: Viresh Kumar; +Cc: Linux Kernel Mailing List, Linus Walleij
On 3 October 2013 12:37, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 3 October 2013 12:36, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> On 3 October 2013 10:07, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>> On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Yeah I will Ack this.. but was waiting for your next version with fixed log. :)
Do you really want a new one. If so, please let me know how you would
like this to be re-worded. I have already used this for others and
thought it was clear enough :)
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 11/11] pinctrl: plgpio: " Sachin Kamat
2013-10-03 4:37 ` Viresh Kumar
@ 2013-10-03 7:11 ` Viresh Kumar
2013-10-08 8:06 ` Linus Walleij
2 siblings, 0 replies; 26+ messages in thread
From: Viresh Kumar @ 2013-10-03 7:11 UTC (permalink / raw)
To: Sachin Kamat; +Cc: Linux Kernel Mailing List, Linus Walleij
On 28 September 2013 17:38, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/pinctrl/spear/pinctrl-plgpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c
> index 0a7f0bdb..ff2940e 100644
> --- a/drivers/pinctrl/spear/pinctrl-plgpio.c
> +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c
> @@ -735,7 +735,7 @@ static struct platform_driver plgpio_driver = {
> .owner = THIS_MODULE,
> .name = "spear-plgpio",
> .pm = &plgpio_dev_pm_ops,
> - .of_match_table = of_match_ptr(plgpio_of_match),
> + .of_match_table = plgpio_of_match,
> },
> };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-10-03 7:10 ` Sachin Kamat
@ 2013-10-03 7:12 ` Viresh Kumar
2013-10-03 7:12 ` Sachin Kamat
0 siblings, 1 reply; 26+ messages in thread
From: Viresh Kumar @ 2013-10-03 7:12 UTC (permalink / raw)
To: Sachin Kamat; +Cc: Linux Kernel Mailing List, Linus Walleij
On 3 October 2013 12:40, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Do you really want a new one. If so, please let me know how you would
> like this to be re-worded. I have already used this for others and
> thought it was clear enough :)
Ahh.. misread your subject and then your reply :)..
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-10-03 7:12 ` Viresh Kumar
@ 2013-10-03 7:12 ` Sachin Kamat
0 siblings, 0 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-10-03 7:12 UTC (permalink / raw)
To: Viresh Kumar; +Cc: Linux Kernel Mailing List, Linus Walleij
On 3 October 2013 12:42, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 3 October 2013 12:40, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> Do you really want a new one. If so, please let me know how you would
>> like this to be re-worded. I have already used this for others and
>> thought it was clear enough :)
>
> Ahh.. misread your subject and then your reply :)..
No problem. Thanks anyway.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
` (9 preceding siblings ...)
2013-09-28 12:08 ` [PATCH 11/11] pinctrl: plgpio: " Sachin Kamat
@ 2013-10-08 7:54 ` Linus Walleij
10 siblings, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 7:54 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 02/11] pinctrl: exynos5440: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 02/11] pinctrl: exynos5440: " Sachin Kamat
@ 2013-10-08 7:55 ` Linus Walleij
0 siblings, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 7:55 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 03/11] pinctrl: imx35: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 03/11] pinctrl: imx35: " Sachin Kamat
@ 2013-10-08 7:56 ` Linus Walleij
0 siblings, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 7:56 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 04/11] pinctrl: imx51: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 04/11] pinctrl: imx51: " Sachin Kamat
@ 2013-10-08 7:56 ` Linus Walleij
0 siblings, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 7:56 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 05/11] pinctrl: imx53: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 05/11] pinctrl: imx53: " Sachin Kamat
@ 2013-10-08 7:57 ` Linus Walleij
0 siblings, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 7:57 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 07/11] pinctrl: imx6q: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 07/11] pinctrl: imx6q: " Sachin Kamat
@ 2013-10-08 7:59 ` Linus Walleij
0 siblings, 0 replies; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 7:59 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-09-28 12:08 ` [PATCH 11/11] pinctrl: plgpio: " Sachin Kamat
2013-10-03 4:37 ` Viresh Kumar
2013-10-03 7:11 ` Viresh Kumar
@ 2013-10-08 8:06 ` Linus Walleij
2013-10-08 8:10 ` Sachin Kamat
2 siblings, 1 reply; 26+ messages in thread
From: Linus Walleij @ 2013-10-08 8:06 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, Viresh Kumar
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
I have applied this as well, and after that I squashed all 11 commits into
one.
I think these 11 patches should have been one from the beginning
but it's quicker for me to simply squash them than to ask you to
resubmit a squashed patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr
2013-10-08 8:06 ` Linus Walleij
@ 2013-10-08 8:10 ` Sachin Kamat
0 siblings, 0 replies; 26+ messages in thread
From: Sachin Kamat @ 2013-10-08 8:10 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-kernel, Viresh Kumar
On 8 October 2013 13:36, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>
>> The data structure of_match_ptr() protects is always compiled in.
>> Hence of_match_ptr() is not needed.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Cc: Viresh Kumar <viresh.kumar@linaro.org>
>
> I have applied this as well, and after that I squashed all 11 commits into
> one.
>
> I think these 11 patches should have been one from the beginning
> but it's quicker for me to simply squash them than to ask you to
> resubmit a squashed patch.
Thanks for doing it. I wasn't sure if you preferred single one to
driver-wise split.
Squashing is simpler compared to splitting :)
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2013-10-08 8:10 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-28 12:08 [PATCH 01/11] pinctrl: at91: Remove redundant of_match_ptr Sachin Kamat
2013-09-28 12:08 ` [PATCH 02/11] pinctrl: exynos5440: " Sachin Kamat
2013-10-08 7:55 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 03/11] pinctrl: imx35: " Sachin Kamat
2013-10-08 7:56 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 04/11] pinctrl: imx51: " Sachin Kamat
2013-10-08 7:56 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 05/11] pinctrl: imx53: " Sachin Kamat
2013-10-08 7:57 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 06/11] pinctrl: imx6dl: " Sachin Kamat
2013-09-28 12:08 ` [PATCH 07/11] pinctrl: imx6q: " Sachin Kamat
2013-10-08 7:59 ` Linus Walleij
2013-09-28 12:08 ` [PATCH 08/11] pinctrl: samsung: " Sachin Kamat
2013-09-28 12:08 ` [PATCH 09/11] pinctrl: vf610: " Sachin Kamat
2013-09-28 12:08 ` [PATCH 10/11] pinctrl: imx6sl: " Sachin Kamat
2013-09-28 12:08 ` [PATCH 11/11] pinctrl: plgpio: " Sachin Kamat
2013-10-03 4:37 ` Viresh Kumar
2013-10-03 7:06 ` Sachin Kamat
2013-10-03 7:07 ` Viresh Kumar
2013-10-03 7:10 ` Sachin Kamat
2013-10-03 7:12 ` Viresh Kumar
2013-10-03 7:12 ` Sachin Kamat
2013-10-03 7:11 ` Viresh Kumar
2013-10-08 8:06 ` Linus Walleij
2013-10-08 8:10 ` Sachin Kamat
2013-10-08 7:54 ` [PATCH 01/11] pinctrl: at91: " Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).