From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch.pl: Check for the FSF mailing address
Date: Sun, 06 Oct 2013 14:48:47 -0700 [thread overview]
Message-ID: <1381096127.2081.166.camel@joe-AO722> (raw)
In-Reply-To: <20131006213309.GO19510@leaf>
On Sun, 2013-10-06 at 14:33 -0700, Josh Triplett wrote:
> On Sun, Oct 06, 2013 at 02:27:17PM -0700, Joe Perches wrote:
> > On Sun, 2013-10-06 at 14:18 -0700, Josh Triplett wrote:
> > > On Sat, Oct 05, 2013 at 11:27:39PM -0700, Greg Kroah-Hartman wrote:
> > > > On Sat, Oct 05, 2013 at 11:51:48AM -0700, Joe Perches wrote:
> > > > > On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> > > > > > Kernel maintainers reject new instances of the GPL boilerplate paragraph
> > > > > > directing people to write to the FSF for a copy of the GPL, since the
> > > > > > FSF has moved in the past and may do so again.
> > []
> > > any objections to merging the patch in its current form?
> >
> > Your own suggestion that this be applied only to
> > patches hasn't been implemented.
>
> Given Greg's comment that we want to eliminate the existing instances, I
> wanted to make sure implementing that change still makes sense.
>
> I can easily enough make checkpatch emit an ERROR for patches and a WARN
> or CHK for existing files, if that's the consensus.
Hi Josh
Most of the time, action is at least as useful as consensus.
If you do the runtime --file check, please use this form:
my $msg_type = \&WARN;
$msg_type = \&CHK if ($file);
&{$msg_type}("FSF_MESSAGE",
etc...)
(that form matches the trigraph test)
Use whatever ERROR/WARN/CHK you think appropriate.
next prev parent reply other threads:[~2013-10-06 21:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 18:43 [PATCH] checkpatch.pl: Check for the FSF mailing address Josh Triplett
2013-10-05 18:51 ` Joe Perches
2013-10-05 19:03 ` Josh Triplett
2013-10-06 6:27 ` Greg Kroah-Hartman
2013-10-06 7:01 ` Joe Perches
2013-10-06 7:05 ` Greg Kroah-Hartman
2013-10-06 8:10 ` Borislav Petkov
2013-10-06 13:44 ` Greg Kroah-Hartman
2013-10-06 13:55 ` Borislav Petkov
2013-10-06 19:18 ` Greg Kroah-Hartman
2013-10-06 20:07 ` Borislav Petkov
2013-10-06 19:19 ` Rob Landley
2013-10-06 21:16 ` Josh Triplett
2013-10-06 21:18 ` Josh Triplett
2013-10-06 21:27 ` Joe Perches
2013-10-06 21:33 ` Josh Triplett
2013-10-06 21:48 ` Joe Perches [this message]
2013-10-06 22:23 ` [PATCHv2] " Josh Triplett
2013-10-06 23:05 ` Greg Kroah-Hartman
2013-10-06 23:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381096127.2081.166.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).