[PATCH 0/1] Possibly fix USB OTG on GTA04 and N900

[PATCH 0/1] Possibly fix USB OTG on GTA04 and N900

[Roger Quadros]

Hi,

USB OTG on these boards might be broken on Greg's usb-next branch [1]
after the Generic PHY framework and associated patches were merged.

This is a probable fix but I'm not able to test these boards. Please
give it a try and your Ack if it works. Thanks.

[1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git

cheers,
-roger

Roger Quadros (1):
  ARM: dts: omap3:  Adapt USB OTG to generic PHY framework

 arch/arm/boot/dts/omap3-gta04.dts |    2 ++
 arch/arm/boot/dts/omap3-n900.dts  |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

-- 
1.7.4.1

[PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

[Roger Quadros]

The generic PHY framewrok expects different properties than the
old USB PHY framework. Supply those properties.

Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was
merged in greg/usb-next. [1]

[1] - https://lkml.org/lkml/2013/9/27/581

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/boot/dts/omap3-gta04.dts |    2 ++
 arch/arm/boot/dts/omap3-n900.dts  |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-gta04.dts b/arch/arm/boot/dts/omap3-gta04.dts
index a84684a..b9b55c9 100644
--- a/arch/arm/boot/dts/omap3-gta04.dts
+++ b/arch/arm/boot/dts/omap3-gta04.dts
@@ -131,6 +131,8 @@
 &usb_otg_hs {
 	interface-type = <0>;
 	usb-phy = <&usb2_phy>;
+	phys = <&usb2_phy>;
+	phy-names = "usb2-phy";
 	mode = <3>;
 	power = <50>;
 };
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index d64fa04..e13b697 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -87,6 +87,8 @@
 &usb_otg_hs {
 	interface-type = <0>;
 	usb-phy = <&usb2_phy>;
+	phys = <&usb2_phy>;
+	phy-names = "usb2-phy";
 	mode = <2>;
 	power = <50>;
 };
-- 
1.7.4.1

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

[Sebastian Andrzej Siewior]

On 10/07/2013 03:28 PM, Roger Quadros wrote:
> The generic PHY framewrok expects different properties than the
> old USB PHY framework. Supply those properties.
> 
> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was
> merged in greg/usb-next. [1]

Would it be much pain (and do we want this at all) to add a fallback
into the kernel or at least a printk pointing out to update the .dts
for two releases or so? So the user does not need to spent hours to
figure out why it suddenly stopped working.

Sebastian

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

[Roger Quadros]

On 10/07/2013 04:40 PM, Sebastian Andrzej Siewior wrote:
> On 10/07/2013 03:28 PM, Roger Quadros wrote:
>> The generic PHY framewrok expects different properties than the
>> old USB PHY framework. Supply those properties.
>>
>> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was
>> merged in greg/usb-next. [1]
> 
> Would it be much pain (and do we want this at all) to add a fallback
> into the kernel or at least a printk pointing out to update the .dts
> for two releases or so? So the user does not need to spent hours to
> figure out why it suddenly stopped working.
> 

I agree with you. 

Also, figuring out which kernel configs to enable for
USB OTG to work on OMAP is a pain in itself to the user.

cheers,
-roger

Re: [PATCH 0/1] Possibly fix USB OTG on GTA04 and N900

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Hi,

On Mon, Oct 07, 2013 at 04:28:12PM +0300, Roger Quadros wrote:
> USB OTG on these boards might be broken on Greg's usb-next branch [1]
> after the Generic PHY framework and associated patches were merged.
> 
> This is a probable fix but I'm not able to test these boards. Please
> give it a try and your Ack if it works. Thanks.
> 
> [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git

I have tested the Nokia N900 part of the patch. Without this patch
the USB port does not work:

[    1.015014] musb-omap2430 480ab000.usb_otg_hs: unable to find phy

With the patch everything seems to work.

Tested-by: Sebastian Reichel <sre@debian.org>

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote:
> The generic PHY framewrok expects different properties than the
> old USB PHY framework. Supply those properties.
> 
> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was
> merged in greg/usb-next. [1]
> 
> [1] - https://lkml.org/lkml/2013/9/27/581
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

[Roger Quadros]

Hi Benoit,

On 10/10/2013 06:34 PM, Felipe Balbi wrote:
> On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote:
>> The generic PHY framewrok expects different properties than the
>> old USB PHY framework. Supply those properties.
>>
>> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was
>> merged in greg/usb-next. [1]
>>
>> [1] - https://lkml.org/lkml/2013/9/27/581
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> Acked-by: Felipe Balbi <balbi@ti.com>
> 

Could you please pick this one for 3.13? Thanks.

I don't see it in your 3.13 take 2 pull request.

cheers,
-roger

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

[Benoit Cousson]

Hi Roger,

On 14/10/2013 11:20, Roger Quadros wrote:
> Hi Benoit,
>
> On 10/10/2013 06:34 PM, Felipe Balbi wrote:
>> On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote:
>>> The generic PHY framewrok expects different properties than the
>>> old USB PHY framework. Supply those properties.
>>>
>>> Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was
>>> merged in greg/usb-next. [1]
>>>
>>> [1] - https://lkml.org/lkml/2013/9/27/581
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>
>> Acked-by: Felipe Balbi <balbi@ti.com>
>>
>
> Could you please pick this one for 3.13? Thanks.
>
> I don't see it in your 3.13 take 2 pull request.

It was not in it. I've just applied it.

Thanks
Benoit

-- 
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com