linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cpqarray: remove deprecated IRQF_DISABLED
@ 2013-10-12  4:15 Michael Opdenacker
  2013-10-14 22:17 ` Miller, Mike (OS Dev)
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Opdenacker @ 2013-10-12  4:15 UTC (permalink / raw)
  To: chirag.kantharia; +Cc: iss_storagedev, linux-kernel, Michael Opdenacker

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 drivers/block/cpqarray.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 2b94403..370721e 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -406,7 +406,7 @@ static int cpqarray_register_ctlr(int i, struct pci_dev *pdev)
 	}
 	hba[i]->access.set_intr_mask(hba[i], 0);
 	if (request_irq(hba[i]->intr, do_ida_intr,
-		IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i]))
+		IRQF_SHARED, hba[i]->devname, hba[i]))
 	{
 		printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
 				hba[i]->intr, hba[i]->devname);
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
  2013-10-12  4:15 [PATCH] cpqarray: remove deprecated IRQF_DISABLED Michael Opdenacker
@ 2013-10-14 22:17 ` Miller, Mike (OS Dev)
  2014-03-04 21:23   ` Michael Opdenacker
  2014-10-01 10:09   ` Michael Opdenacker
  0 siblings, 2 replies; 4+ messages in thread
From: Miller, Mike (OS Dev) @ 2013-10-14 22:17 UTC (permalink / raw)
  To: Michael Opdenacker, chirag.kantharia; +Cc: ISS StorageDev, linux-kernel



> -----Original Message-----
> From: Michael Opdenacker [mailto:michael.opdenacker@free-
> electrons.com]
> Sent: Friday, October 11, 2013 11:15 PM
> To: chirag.kantharia@hp.com
> Cc: ISS StorageDev; linux-kernel@vger.kernel.org; Michael Opdenacker
> Subject: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
> 
> This patch proposes to remove the use of the IRQF_DISABLED flag
> 
> It's a NOOP since 2.6.35 and it will be removed one day.

I plan to send a patch soon to remove cpqarray completely.

-- mikem

> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-
> electrons.com>
> ---
>  drivers/block/cpqarray.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c index
> 2b94403..370721e 100644
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -406,7 +406,7 @@ static int cpqarray_register_ctlr(int i, struct pci_dev
> *pdev)
>  	}
>  	hba[i]->access.set_intr_mask(hba[i], 0);
>  	if (request_irq(hba[i]->intr, do_ida_intr,
> -		IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i]))
> +		IRQF_SHARED, hba[i]->devname, hba[i]))
>  	{
>  		printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",
>  				hba[i]->intr, hba[i]->devname);
> --
> 1.8.1.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
  2013-10-14 22:17 ` Miller, Mike (OS Dev)
@ 2014-03-04 21:23   ` Michael Opdenacker
  2014-10-01 10:09   ` Michael Opdenacker
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Opdenacker @ 2014-03-04 21:23 UTC (permalink / raw)
  To: Miller, Mike (OS Dev), chirag.kantharia; +Cc: ISS StorageDev, linux-kernel

Hello Mike,

On 10/15/2013 12:17 AM, Miller, Mike (OS Dev) wrote:
>
>> -----Original Message-----
>> From: Michael Opdenacker [mailto:michael.opdenacker@free-
>> electrons.com]
>> Sent: Friday, October 11, 2013 11:15 PM
>> To: chirag.kantharia@hp.com
>> Cc: ISS StorageDev; linux-kernel@vger.kernel.org; Michael Opdenacker
>> Subject: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
>>
>> This patch proposes to remove the use of the IRQF_DISABLED flag
>>
>> It's a NOOP since 2.6.35 and it will be removed one day.
> I plan to send a patch soon to remove cpqarray completely.
Any news from this removal? I would like to get rid of my patch for good...

Thank you in advance,

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
  2013-10-14 22:17 ` Miller, Mike (OS Dev)
  2014-03-04 21:23   ` Michael Opdenacker
@ 2014-10-01 10:09   ` Michael Opdenacker
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Opdenacker @ 2014-10-01 10:09 UTC (permalink / raw)
  To: Miller, Mike (OS Dev), chirag.kantharia; +Cc: ISS StorageDev, linux-kernel

Hi Mike,

On 10/15/2013 12:17 AM, Miller, Mike (OS Dev) wrote:
>
>> -----Original Message-----
>> From: Michael Opdenacker [mailto:michael.opdenacker@free-
>> electrons.com]
>> Sent: Friday, October 11, 2013 11:15 PM
>> To: chirag.kantharia@hp.com
>> Cc: ISS StorageDev; linux-kernel@vger.kernel.org; Michael Opdenacker
>> Subject: [PATCH] cpqarray: remove deprecated IRQF_DISABLED
>>
>> This patch proposes to remove the use of the IRQF_DISABLED flag
>>
>> It's a NOOP since 2.6.35 and it will be removed one day.
> I plan to send a patch soon to remove cpqarray completely.
>
> -- mikem

Any news? Would you like me to take care of this patch if you don't have
time? It would be with pleasure...

Michael.


-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-10-01 10:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-12  4:15 [PATCH] cpqarray: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-10-14 22:17 ` Miller, Mike (OS Dev)
2014-03-04 21:23   ` Michael Opdenacker
2014-10-01 10:09   ` Michael Opdenacker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).