* [PATCH] s390: Remove unused variable in copy_from_realmem()
@ 2013-10-15 6:50 Geert Uytterhoeven
2013-10-15 7:17 ` Martin Schwidefsky
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2013-10-15 6:50 UTC (permalink / raw)
To: Martin Schwidefsky, Michael Holzheu
Cc: linux-s390, linux-kernel, Geert Uytterhoeven
arch/s390/kernel/crash_dump.c: In function 'copy_from_realmem':
arch/s390/kernel/crash_dump.c:48:6: warning: unused variable 'rc' [-Wunused-variable]
Introduced by commit 4d3b0664a0d0c0dc7501cfbd067f74226aeca510 ("s390: Allow
vmalloc target buffers for copy_from_oldmem()").
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/s390/kernel/crash_dump.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c
index 7dd21720e5b0..3db6af0601a5 100644
--- a/arch/s390/kernel/crash_dump.c
+++ b/arch/s390/kernel/crash_dump.c
@@ -45,7 +45,6 @@ static inline void *load_real_addr(void *addr)
static int copy_from_realmem(void *dest, void *src, size_t count)
{
unsigned long size;
- int rc;
if (!count)
return 0;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390: Remove unused variable in copy_from_realmem()
2013-10-15 6:50 [PATCH] s390: Remove unused variable in copy_from_realmem() Geert Uytterhoeven
@ 2013-10-15 7:17 ` Martin Schwidefsky
0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2013-10-15 7:17 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Michael Holzheu, linux-s390, linux-kernel
On Tue, 15 Oct 2013 08:50:11 +0200
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> arch/s390/kernel/crash_dump.c: In function 'copy_from_realmem':
> arch/s390/kernel/crash_dump.c:48:6: warning: unused variable 'rc' [-Wunused-variable]
>
> Introduced by commit 4d3b0664a0d0c0dc7501cfbd067f74226aeca510 ("s390: Allow
> vmalloc target buffers for copy_from_oldmem()").
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/s390/kernel/crash_dump.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c
> index 7dd21720e5b0..3db6af0601a5 100644
> --- a/arch/s390/kernel/crash_dump.c
> +++ b/arch/s390/kernel/crash_dump.c
> @@ -45,7 +45,6 @@ static inline void *load_real_addr(void *addr)
> static int copy_from_realmem(void *dest, void *src, size_t count)
> {
> unsigned long size;
> - int rc;
>
> if (!count)
> return 0;
Thanks for the hint but there is already a equivalent patch from Heiko on the
features branch on git-s390. I plan to get it pulled in the merge window for
3.13 as I feel that the warning is not important enough to fix it now.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-15 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-15 6:50 [PATCH] s390: Remove unused variable in copy_from_realmem() Geert Uytterhoeven
2013-10-15 7:17 ` Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).