[PATCH] perf tools: use ansi versions of asm and volatile

[PATCH] perf tools: use ansi versions of asm and volatile

[Ramkumar Ramachandra]

asm and volatile are provided for backward compatibility; use the ansi
versions __asm__ and __volatile__.

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 tools/perf/tests/rdpmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/rdpmc.c b/tools/perf/tests/rdpmc.c
index ff94886..a05be61 100644
--- a/tools/perf/tests/rdpmc.c
+++ b/tools/perf/tests/rdpmc.c
@@ -9,7 +9,7 @@
 
 #if defined(__x86_64__) || defined(__i386__)
 
-#define barrier() asm volatile("" ::: "memory")
+#define barrier() __asm__ __volatile__("" ::: "memory")
 
 static u64 rdpmc(unsigned int counter)
 {
-- 
1.8.4.477.g5d89aa9

Re: [PATCH] perf tools: use ansi versions of asm and volatile

[Peter Zijlstra]

On Tue, Oct 15, 2013 at 04:16:26PM +0530, Ramkumar Ramachandra wrote:
> asm and volatile are provided for backward compatibility; use the ansi
> versions __asm__ and __volatile__.
> 

I won't object much to this; but I have to note that the entire kernel
tree is loaded with the non-ansi variant and thus we're fairly certain
it will continue working :-)

Re: [PATCH] perf tools: use ansi versions of asm and volatile

[Ramkumar Ramachandra]

Peter Zijlstra wrote:
> On Tue, Oct 15, 2013 at 04:16:26PM +0530, Ramkumar Ramachandra wrote:
>> asm and volatile are provided for backward compatibility; use the ansi
>> versions __asm__ and __volatile__.
>>
>
> I won't object much to this; but I have to note that the entire kernel
> tree is loaded with the non-ansi variant and thus we're fairly certain
> it will continue working :-)

Oh well, atleast the definition of barrier() is consistent with the
one in linux/compiler-gcc.h.

Re: [PATCH] perf tools: use ansi versions of asm and volatile

[Peter Zijlstra]

On Tue, Oct 15, 2013 at 04:16:26PM +0530, Ramkumar Ramachandra wrote:
> asm and volatile are provided for backward compatibility; use the ansi
> versions __asm__ and __volatile__.

Also, you seem to have 'forgotten' to convert the 31 other instances :-)

# git grep -E "[[:space:]]asm[([:space:]]" tools/perf/ | wc -l
32