* [PATCH] tty: Add C_MSPAR(tty)
@ 2013-10-23 11:18 Andrew Lunn
2013-10-23 13:47 ` Peter Hurley
2013-10-29 18:17 ` Johan Hovold
0 siblings, 2 replies; 7+ messages in thread
From: Andrew Lunn @ 2013-10-23 11:18 UTC (permalink / raw)
To: peter, gregkh, jslaby; +Cc: linux-kernel, jhovold, Andrew Lunn
Add the missing C_MSPAR(tty) macro.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
include/linux/tty.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 64f8646..630678d 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -137,6 +137,7 @@ struct tty_bufhead {
#define C_CLOCAL(tty) _C_FLAG((tty), CLOCAL)
#define C_CIBAUD(tty) _C_FLAG((tty), CIBAUD)
#define C_CRTSCTS(tty) _C_FLAG((tty), CRTSCTS)
+#define C_MSPAR(tty) _C_FLAG((tty), CMSPAR)
#define L_ISIG(tty) _L_FLAG((tty), ISIG)
#define L_ICANON(tty) _L_FLAG((tty), ICANON)
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: Add C_MSPAR(tty)
2013-10-23 11:18 [PATCH] tty: Add C_MSPAR(tty) Andrew Lunn
@ 2013-10-23 13:47 ` Peter Hurley
2013-10-23 13:57 ` Andrew Lunn
2013-10-29 18:17 ` Johan Hovold
1 sibling, 1 reply; 7+ messages in thread
From: Peter Hurley @ 2013-10-23 13:47 UTC (permalink / raw)
To: Andrew Lunn; +Cc: gregkh, jslaby, linux-kernel, jhovold
On 10/23/2013 07:18 AM, Andrew Lunn wrote:
> Add the missing C_MSPAR(tty) macro.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> include/linux/tty.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index 64f8646..630678d 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -137,6 +137,7 @@ struct tty_bufhead {
> #define C_CLOCAL(tty) _C_FLAG((tty), CLOCAL)
> #define C_CIBAUD(tty) _C_FLAG((tty), CIBAUD)
> #define C_CRTSCTS(tty) _C_FLAG((tty), CRTSCTS)
> +#define C_MSPAR(tty) _C_FLAG((tty), CMSPAR)
>
> #define L_ISIG(tty) _L_FLAG((tty), ISIG)
> #define L_ICANON(tty) _L_FLAG((tty), ICANON)
Is this to support an out-of-tree driver?
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: Add C_MSPAR(tty)
2013-10-23 13:47 ` Peter Hurley
@ 2013-10-23 13:57 ` Andrew Lunn
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Lunn @ 2013-10-23 13:57 UTC (permalink / raw)
To: Peter Hurley; +Cc: Andrew Lunn, gregkh, jslaby, linux-kernel, jhovold
On Wed, Oct 23, 2013 at 09:47:50AM -0400, Peter Hurley wrote:
> On 10/23/2013 07:18 AM, Andrew Lunn wrote:
> >Add the missing C_MSPAR(tty) macro.
> >
> >Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> >---
> > include/linux/tty.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/include/linux/tty.h b/include/linux/tty.h
> >index 64f8646..630678d 100644
> >--- a/include/linux/tty.h
> >+++ b/include/linux/tty.h
> >@@ -137,6 +137,7 @@ struct tty_bufhead {
> > #define C_CLOCAL(tty) _C_FLAG((tty), CLOCAL)
> > #define C_CIBAUD(tty) _C_FLAG((tty), CIBAUD)
> > #define C_CRTSCTS(tty) _C_FLAG((tty), CRTSCTS)
> >+#define C_MSPAR(tty) _C_FLAG((tty), CMSPAR)
> >
> > #define L_ISIG(tty) _L_FLAG((tty), ISIG)
> > #define L_ICANON(tty) _L_FLAG((tty), ICANON)
>
> Is this to support an out-of-tree driver?
Hi Peter
It is to support a driver i'm trying to get accepted. It is a USB
serial driver which was posted for the forth time today to the USB
list:
http://article.gmane.org/gmane.linux.usb.general/96740
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: Add C_MSPAR(tty)
2013-10-23 11:18 [PATCH] tty: Add C_MSPAR(tty) Andrew Lunn
2013-10-23 13:47 ` Peter Hurley
@ 2013-10-29 18:17 ` Johan Hovold
2013-10-29 22:15 ` Andrew Lunn
1 sibling, 1 reply; 7+ messages in thread
From: Johan Hovold @ 2013-10-29 18:17 UTC (permalink / raw)
To: Andrew Lunn; +Cc: peter, gregkh, jslaby, linux-kernel, jhovold
On Wed, Oct 23, 2013 at 01:18:21PM +0200, Andrew Lunn wrote:
> Add the missing C_MSPAR(tty) macro.
Please rename the macro C_CMSPAR to be consistent with the other
termios-flag macros (with C_BAUD being the exception that confirms the
rule).
Thanks,
Johan
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> include/linux/tty.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index 64f8646..630678d 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -137,6 +137,7 @@ struct tty_bufhead {
> #define C_CLOCAL(tty) _C_FLAG((tty), CLOCAL)
> #define C_CIBAUD(tty) _C_FLAG((tty), CIBAUD)
> #define C_CRTSCTS(tty) _C_FLAG((tty), CRTSCTS)
> +#define C_MSPAR(tty) _C_FLAG((tty), CMSPAR)
>
> #define L_ISIG(tty) _L_FLAG((tty), ISIG)
> #define L_ICANON(tty) _L_FLAG((tty), ICANON)
> --
> 1.8.4.rc3
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: Add C_MSPAR(tty)
2013-10-29 18:17 ` Johan Hovold
@ 2013-10-29 22:15 ` Andrew Lunn
2013-10-29 22:24 ` Greg KH
2013-10-30 11:32 ` Johan Hovold
0 siblings, 2 replies; 7+ messages in thread
From: Andrew Lunn @ 2013-10-29 22:15 UTC (permalink / raw)
To: Johan Hovold; +Cc: Andrew Lunn, peter, gregkh, jslaby, linux-kernel
On Tue, Oct 29, 2013 at 07:17:46PM +0100, Johan Hovold wrote:
> On Wed, Oct 23, 2013 at 01:18:21PM +0200, Andrew Lunn wrote:
> > Add the missing C_MSPAR(tty) macro.
>
> Please rename the macro C_CMSPAR to be consistent with the other
> termios-flag macros (with C_BAUD being the exception that confirms the
> rule).
Hi Johan
O.K, i will rename it.
Should i add this to the MOXA patch series, or submit is separately?
I'm just thinking about dependencies. It will probably be easier to
take both through one tree.
Thanks
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: Add C_MSPAR(tty)
2013-10-29 22:15 ` Andrew Lunn
@ 2013-10-29 22:24 ` Greg KH
2013-10-30 11:32 ` Johan Hovold
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2013-10-29 22:24 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Johan Hovold, peter, jslaby, linux-kernel
On Tue, Oct 29, 2013 at 11:15:21PM +0100, Andrew Lunn wrote:
> On Tue, Oct 29, 2013 at 07:17:46PM +0100, Johan Hovold wrote:
> > On Wed, Oct 23, 2013 at 01:18:21PM +0200, Andrew Lunn wrote:
> > > Add the missing C_MSPAR(tty) macro.
> >
> > Please rename the macro C_CMSPAR to be consistent with the other
> > termios-flag macros (with C_BAUD being the exception that confirms the
> > rule).
>
> Hi Johan
>
> O.K, i will rename it.
>
> Should i add this to the MOXA patch series, or submit is separately?
> I'm just thinking about dependencies. It will probably be easier to
> take both through one tree.
I'll take both through the same tree, so might as well make it part of
the same patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tty: Add C_MSPAR(tty)
2013-10-29 22:15 ` Andrew Lunn
2013-10-29 22:24 ` Greg KH
@ 2013-10-30 11:32 ` Johan Hovold
1 sibling, 0 replies; 7+ messages in thread
From: Johan Hovold @ 2013-10-30 11:32 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Johan Hovold, peter, gregkh, jslaby, linux-kernel
On Tue, Oct 29, 2013 at 11:15:21PM +0100, Andrew Lunn wrote:
> On Tue, Oct 29, 2013 at 07:17:46PM +0100, Johan Hovold wrote:
> > On Wed, Oct 23, 2013 at 01:18:21PM +0200, Andrew Lunn wrote:
> > > Add the missing C_MSPAR(tty) macro.
> >
> > Please rename the macro C_CMSPAR to be consistent with the other
> > termios-flag macros (with C_BAUD being the exception that confirms the
> > rule).
>
> Hi Johan
>
> O.K, i will rename it.
>
> Should i add this to the MOXA patch series, or submit is separately?
> I'm just thinking about dependencies. It will probably be easier to
> take both through one tree.
Yeah, you're right. I was gonna mention this in my review of v4 (it's
under way). Submit them as a two-part series for v5 and Greg can take
them both through the usb tree.
Thanks,
Johan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-10-30 11:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-23 11:18 [PATCH] tty: Add C_MSPAR(tty) Andrew Lunn
2013-10-23 13:47 ` Peter Hurley
2013-10-23 13:57 ` Andrew Lunn
2013-10-29 18:17 ` Johan Hovold
2013-10-29 22:15 ` Andrew Lunn
2013-10-29 22:24 ` Greg KH
2013-10-30 11:32 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).