* [PATCH 0/2] Staging: vt6656: fix two coding style issues
@ 2013-10-24 5:26 Johannes Löthberg
2013-10-24 5:26 ` [PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c Johannes Löthberg
2013-10-24 5:26 ` [PATCH 2/2] Staging: vt6656: fix code indenting error " Johannes Löthberg
0 siblings, 2 replies; 4+ messages in thread
From: Johannes Löthberg @ 2013-10-24 5:26 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Andres More
Cc: devel, linux-kernel, Johannes Löthberg
This patchset fixes two coding style issues reported by checkpatch.pl in
drivers/staging/vt6656, one warning and one error
Johannes Löthberg (2):
Staging: vt6656: fix a brace coding style issue in power.c
Staging: vt6656: fix code indenting error in power.c
drivers/staging/vt6656/power.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
1.8.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c
2013-10-24 5:26 [PATCH 0/2] Staging: vt6656: fix two coding style issues Johannes Löthberg
@ 2013-10-24 5:26 ` Johannes Löthberg
2013-10-24 5:26 ` [PATCH 2/2] Staging: vt6656: fix code indenting error " Johannes Löthberg
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Löthberg @ 2013-10-24 5:26 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Andres More
Cc: devel, linux-kernel, Johannes Löthberg
This patch fixes a brace warning in power.c found by checkpatch.pl
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
---
drivers/staging/vt6656/power.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
index edc8975..3002061 100644
--- a/drivers/staging/vt6656/power.c
+++ b/drivers/staging/vt6656/power.c
@@ -233,9 +233,8 @@ void PSvSendPSPOLL(struct vnt_private *pDevice)
pTxPacket->cbPayloadLen = 0;
/* log failure if sending failed */
- if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING) {
+ if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING)
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send PS-Poll packet failed..\n");
- }
}
/*
--
1.8.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] Staging: vt6656: fix code indenting error in power.c
2013-10-24 5:26 [PATCH 0/2] Staging: vt6656: fix two coding style issues Johannes Löthberg
2013-10-24 5:26 ` [PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c Johannes Löthberg
@ 2013-10-24 5:26 ` Johannes Löthberg
2013-10-27 13:53 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Löthberg @ 2013-10-24 5:26 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Andres More
Cc: devel, linux-kernel, Johannes Löthberg
This patch fixes a code indentation error found by checkpatch.pl
where a line was indented with spaces instead of tabs
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
---
drivers/staging/vt6656/power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
index 3002061..a14a2bf 100644
--- a/drivers/staging/vt6656/power.c
+++ b/drivers/staging/vt6656/power.c
@@ -268,7 +268,7 @@ int PSbSendNullPacket(struct vnt_private *pDevice)
+ sizeof(struct vnt_tx_mgmt));
flags = WLAN_SET_FC_FTYPE(WLAN_TYPE_DATA) |
- WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
+ WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
if (pDevice->bEnablePSMode)
flags |= WLAN_SET_FC_PWRMGT(1);
--
1.8.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Staging: vt6656: fix code indenting error in power.c
2013-10-24 5:26 ` [PATCH 2/2] Staging: vt6656: fix code indenting error " Johannes Löthberg
@ 2013-10-27 13:53 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2013-10-27 13:53 UTC (permalink / raw)
To: Johannes Löthberg; +Cc: Forest Bond, Andres More, devel, linux-kernel
On Thu, Oct 24, 2013 at 07:26:47AM +0200, Johannes Löthberg wrote:
> This patch fixes a code indentation error found by checkpatch.pl
> where a line was indented with spaces instead of tabs
>
> Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
> ---
> drivers/staging/vt6656/power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
> index 3002061..a14a2bf 100644
> --- a/drivers/staging/vt6656/power.c
> +++ b/drivers/staging/vt6656/power.c
> @@ -268,7 +268,7 @@ int PSbSendNullPacket(struct vnt_private *pDevice)
> + sizeof(struct vnt_tx_mgmt));
>
> flags = WLAN_SET_FC_FTYPE(WLAN_TYPE_DATA) |
> - WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
> + WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
No, indent this line properly using tabs to where the spaces were,
that's the correct location.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-27 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-24 5:26 [PATCH 0/2] Staging: vt6656: fix two coding style issues Johannes Löthberg
2013-10-24 5:26 ` [PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c Johannes Löthberg
2013-10-24 5:26 ` [PATCH 2/2] Staging: vt6656: fix code indenting error " Johannes Löthberg
2013-10-27 13:53 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).