* [PATCH] perf probe: add '--demangle'/'--no-demangle'
@ 2013-10-28 8:04 Azat Khuzhin
2013-11-15 7:25 ` [tip:perf/urgent] perf probe: Add '--demangle'/'--no-demangle' tip-bot for Azat Khuzhin
0 siblings, 1 reply; 2+ messages in thread
From: Azat Khuzhin @ 2013-10-28 8:04 UTC (permalink / raw)
To: linux-kernel
Cc: Azat Khuzhin, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo
You can't pass demangled name into "perf probe", because of special chars:
./perf probe -f -x /tmp/a.out 'foo(int)'
Semantic error :There is non-digit char in line number.
And you can't even pass without demangling (because it search symbol in
DSO with demangle=true):
./perf probe -f -x /tmp/a.out _Z3fooi
no symbols found in /tmp/a.out, maybe install a debug package?
However:
nm /tmp/a.out | grep foo
000000000040056d T _Z3fooi
After this patch, using the next command:
./perf probe -f --no-demangle -x /tmp/a.out _Z3fooi
probe will be successfully added.
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
---
tools/perf/builtin-probe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index e8a66f9..7620f2e 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -325,6 +325,8 @@ int cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
opt_set_filter),
OPT_CALLBACK('x', "exec", NULL, "executable|path",
"target executable name or path", opt_set_target),
+ OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
+ "Disable symbol demangling"),
OPT_END()
};
int ret;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:perf/urgent] perf probe: Add '--demangle'/'--no-demangle'
2013-10-28 8:04 [PATCH] perf probe: add '--demangle'/'--no-demangle' Azat Khuzhin
@ 2013-11-15 7:25 ` tip-bot for Azat Khuzhin
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Azat Khuzhin @ 2013-11-15 7:25 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, paulus, mingo, hpa, mingo, a.p.zijlstra,
a3at.mail, tglx
Commit-ID: 35e17b2450e09968f9702d4048c228199af171bc
Gitweb: http://git.kernel.org/tip/35e17b2450e09968f9702d4048c228199af171bc
Author: Azat Khuzhin <a3at.mail@gmail.com>
AuthorDate: Mon, 28 Oct 2013 12:04:24 +0400
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 14 Nov 2013 16:06:28 -0300
perf probe: Add '--demangle'/'--no-demangle'
You can't pass demangled name into "perf probe", because of special chars:
./perf probe -f -x /tmp/a.out 'foo(int)'
Semantic error :There is non-digit char in line number.
And you can't even pass without demangling (because it search symbol in
DSO with demangle=true):
./perf probe -f -x /tmp/a.out _Z3fooi
no symbols found in /tmp/a.out, maybe install a debug package?
However:
nm /tmp/a.out | grep foo
000000000040056d T _Z3fooi
After this patch, using the next command:
./perf probe -f --no-demangle -x /tmp/a.out _Z3fooi
probe will be successfully added.
Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1382947464-31266-1-git-send-email-a3at.mail@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-probe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 89acc17..6ea9e85 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -325,6 +325,8 @@ int cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
opt_set_filter),
OPT_CALLBACK('x', "exec", NULL, "executable|path",
"target executable name or path", opt_set_target),
+ OPT_BOOLEAN(0, "demangle", &symbol_conf.demangle,
+ "Disable symbol demangling"),
OPT_END()
};
int ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-15 7:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-28 8:04 [PATCH] perf probe: add '--demangle'/'--no-demangle' Azat Khuzhin
2013-11-15 7:25 ` [tip:perf/urgent] perf probe: Add '--demangle'/'--no-demangle' tip-bot for Azat Khuzhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).