* [PATCH] perf tools: Allow multiple cpus record for -p option
@ 2013-11-01 15:52 Jiri Olsa
2013-11-05 7:38 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Olsa @ 2013-11-01 15:52 UTC (permalink / raw)
To: linux-kernel
Cc: Jiri Olsa, Adrian Hunter, Corey Ashford, David Ahern,
Frederic Weisbecker, Ingo Molnar, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Arnaldo Carvalho de Melo
Currently we don't create default CPU map for task related
target, like:
$ perf record -p <pid>
This makes record command to disable inherited events.
which is not desired behaviour (we have special option
for that (-i) anyway).
Fixing this by creating default CPU map for task related
processes.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 0582f67..52bb127 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -804,7 +804,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist,
return -1;
if (perf_target__has_task(target))
- evlist->cpus = cpu_map__dummy_new();
+ evlist->cpus = cpu_map__new(target->cpu_list);
else if (!perf_target__has_cpu(target) && !target->uses_mmap)
evlist->cpus = cpu_map__dummy_new();
else
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] perf tools: Allow multiple cpus record for -p option
2013-11-01 15:52 [PATCH] perf tools: Allow multiple cpus record for -p option Jiri Olsa
@ 2013-11-05 7:38 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2013-11-05 7:38 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Adrian Hunter, Corey Ashford, David Ahern,
Frederic Weisbecker, Ingo Molnar, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
On Fri, 1 Nov 2013 16:52:45 +0100, Jiri Olsa wrote:
> Currently we don't create default CPU map for task related
> target, like:
>
> $ perf record -p <pid>
>
> This makes record command to disable inherited events.
> which is not desired behaviour (we have special option
> for that (-i) anyway).
>
> Fixing this by creating default CPU map for task related
> processes.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/evlist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 0582f67..52bb127 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -804,7 +804,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist,
> return -1;
>
> if (perf_target__has_task(target))
> - evlist->cpus = cpu_map__dummy_new();
> + evlist->cpus = cpu_map__new(target->cpu_list);
Just a side note, if the target has task, the cpu list should be NULL as
task target has a precedence. Please see perf_target__validate().
But I'm fine with the change itself. :)
Thanks,
Namhyung
> else if (!perf_target__has_cpu(target) && !target->uses_mmap)
> evlist->cpus = cpu_map__dummy_new();
> else
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-05 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-01 15:52 [PATCH] perf tools: Allow multiple cpus record for -p option Jiri Olsa
2013-11-05 7:38 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).