From: Luca Coelho <luca@coelho.fi>
To: Felipe Balbi <balbi@ti.com>
Cc: mturquette@linaro.org,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
james.hogan@imgtec.com
Subject: Re: [PATCH] clk: add flags to distinguish xtal clocks
Date: Fri, 08 Nov 2013 21:16:53 +0200 [thread overview]
Message-ID: <1383938213.4264.4.camel@porter.coelho.fi> (raw)
In-Reply-To: <1383933648-28595-1-git-send-email-balbi@ti.com>
Hi Felipe,
On Fri, 2013-11-08 at 12:00 -0600, Felipe Balbi wrote:
> From: Luciano Coelho <luca@coelho.fi>
>
> Add a flag that indicate whether the clock is a crystal or not.
>
> Additionally, parse a new device tree binding in clk-fixed-rate to set
> this flag.
>
> If clock-xtal isn't set, the clock framework will assume clock to be
> generated by an oscillator. There's only one user for this binding
> right now which is Texas Instruments' WiLink devices which need to know
> details about the clock in order to initialize the underlying WiFi HW
> correctly.
>
> Signed-off-by: Luciano Coelho <luca@coelho.fi>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
> Dropped CLK_IS_TYPE_DEFINED flag and just assume that if the flag
> isn't there, default behavior will be taken.
I don't think this is a good idea, because how would code that relies on
the CLK_IS_TYPE_XTAL flag know whether 0 means that the clock is *not*
crystal or if the flag is simply not defined?
There are many clocks which *are* crystal but don't define this flag
(obviously, because it didn't exist). That's the reason why I added the
CLK_IS_TYPE_DEFINED flag...
If you want to get rid of this flag, you should traverse all clocks and
set the CLK_IS_TYPE_XTAL on all those that are crystals.
--
Cheers,
Luca.
next prev parent reply other threads:[~2013-11-08 19:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 21:05 [RFC] clk: add flags to distinguish xtal clocks Luciano Coelho
[not found] ` <20130704222538.10823.2559@quantum>
2013-07-04 22:37 ` Luciano Coelho
[not found] ` <20130704231953.10823.94331@quantum>
2013-07-05 7:54 ` Luciano Coelho
2013-07-29 13:50 ` Luciano Coelho
[not found] ` <20131007074424.7445.52119@quantum>
2013-10-08 15:27 ` Felipe Balbi
2013-10-16 10:24 ` Luca Coelho
2013-10-23 9:24 ` Mike Turquette
2013-10-23 11:35 ` Luca Coelho
2013-11-08 18:00 ` [PATCH] " Felipe Balbi
2013-11-08 19:16 ` Luca Coelho [this message]
2013-11-10 11:37 ` Maxime Ripard
2013-11-11 19:42 ` Felipe Balbi
2013-11-11 19:50 ` Luca Coelho
2013-11-11 20:59 ` Maxime Ripard
2013-11-12 8:05 ` Luca Coelho
2013-11-13 14:40 ` Maxime Ripard
2013-11-11 20:54 ` Maxime Ripard
2013-11-11 16:27 ` Stephen Warren
2013-11-11 19:43 ` Felipe Balbi
2013-07-05 13:12 ` [RFC] " James Hogan
2013-07-05 13:21 ` Felipe Balbi
2013-07-05 13:22 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383938213.4264.4.camel@porter.coelho.fi \
--to=luca@coelho.fi \
--cc=balbi@ti.com \
--cc=james.hogan@imgtec.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).