* [PATCH] perf trace: Fix syscall summary duration order
@ 2013-11-12 14:10 Pekka Enberg
2013-11-12 14:15 ` David Ahern
2013-11-12 21:56 ` [tip:perf/urgent] perf trace: Change " tip-bot for Pekka Enberg
0 siblings, 2 replies; 3+ messages in thread
From: Pekka Enberg @ 2013-11-12 14:10 UTC (permalink / raw)
To: linux-kernel
Cc: Pekka Enberg, David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo
Switch duration order to minimum, average, maximum for the '--summary'
command line option because it's more natural to read.
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---
tools/perf/builtin-trace.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 329b783..f841d2a 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2085,7 +2085,7 @@ static size_t trace__fprintf_threads_header(FILE *fp)
printed = fprintf(fp, "\n _____________________________________________________________________________\n");
printed += fprintf(fp, " __) Summary of events (__\n\n");
printed += fprintf(fp, " [ task - pid ] [ events ] [ ratio ] [ runtime ]\n");
- printed += fprintf(fp, " syscall count min max avg stddev\n");
+ printed += fprintf(fp, " syscall count min avg max stddev\n");
printed += fprintf(fp, " msec msec msec %%\n");
printed += fprintf(fp, " _____________________________________________________________________________\n\n");
@@ -2121,8 +2121,8 @@ static size_t thread__dump_stats(struct thread_trace *ttrace,
sc = &trace->syscalls.table[inode->i];
printed += fprintf(fp, "%24s %14s : ", "", sc->name);
printed += fprintf(fp, "%5" PRIu64 " %8.3f %8.3f",
- n, min, max);
- printed += fprintf(fp, " %8.3f %6.2f\n", avg, pct);
+ n, min, avg);
+ printed += fprintf(fp, " %8.3f %6.2f\n", max, pct);
}
inode = intlist__next(inode);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf trace: Fix syscall summary duration order
2013-11-12 14:10 [PATCH] perf trace: Fix syscall summary duration order Pekka Enberg
@ 2013-11-12 14:15 ` David Ahern
2013-11-12 21:56 ` [tip:perf/urgent] perf trace: Change " tip-bot for Pekka Enberg
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2013-11-12 14:15 UTC (permalink / raw)
To: Pekka Enberg, linux-kernel; +Cc: Ingo Molnar, Arnaldo Carvalho de Melo
On 11/12/13, 7:10 AM, Pekka Enberg wrote:
> Switch duration order to minimum, average, maximum for the '--summary'
> command line option because it's more natural to read.
>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> ---
> tools/perf/builtin-trace.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I would change the 'Fix' in the summary line to 'Change'. Other than that...
Acked-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/urgent] perf trace: Change syscall summary duration order
2013-11-12 14:10 [PATCH] perf trace: Fix syscall summary duration order Pekka Enberg
2013-11-12 14:15 ` David Ahern
@ 2013-11-12 21:56 ` tip-bot for Pekka Enberg
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Pekka Enberg @ 2013-11-12 21:56 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, linux-kernel, mingo, hpa, mingo, penberg, dsahern, tglx
Commit-ID: 7f7a4138c66e857cc5bbf6e248a47379765349b5
Gitweb: http://git.kernel.org/tip/7f7a4138c66e857cc5bbf6e248a47379765349b5
Author: Pekka Enberg <penberg@kernel.org>
AuthorDate: Tue, 12 Nov 2013 16:10:10 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 12 Nov 2013 13:00:38 -0300
perf trace: Change syscall summary duration order
Switch duration order to minimum, average, maximum for the '--summary'
command line option because it's more natural to read.
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Link: http://lkml.kernel.org/r/1384265410-12344-1-git-send-email-penberg@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 8d6ea8f..8990fbe 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -2093,7 +2093,7 @@ static size_t trace__fprintf_threads_header(FILE *fp)
printed = fprintf(fp, "\n _____________________________________________________________________________\n");
printed += fprintf(fp, " __) Summary of events (__\n\n");
printed += fprintf(fp, " [ task - pid ] [ events ] [ ratio ] [ runtime ]\n");
- printed += fprintf(fp, " syscall count min max avg stddev\n");
+ printed += fprintf(fp, " syscall count min avg max stddev\n");
printed += fprintf(fp, " msec msec msec %%\n");
printed += fprintf(fp, " _____________________________________________________________________________\n\n");
@@ -2129,8 +2129,8 @@ static size_t thread__dump_stats(struct thread_trace *ttrace,
sc = &trace->syscalls.table[inode->i];
printed += fprintf(fp, "%24s %14s : ", "", sc->name);
printed += fprintf(fp, "%5" PRIu64 " %8.3f %8.3f",
- n, min, max);
- printed += fprintf(fp, " %8.3f %6.2f\n", avg, pct);
+ n, min, avg);
+ printed += fprintf(fp, " %8.3f %6.2f\n", max, pct);
}
inode = intlist__next(inode);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-12 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-12 14:10 [PATCH] perf trace: Fix syscall summary duration order Pekka Enberg
2013-11-12 14:15 ` David Ahern
2013-11-12 21:56 ` [tip:perf/urgent] perf trace: Change " tip-bot for Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).