[PATCH] gpiolib: fix of_find_gpio() when OF not defined

[PATCH] gpiolib: fix of_find_gpio() when OF not defined

[Alexandre Courbot]

The prototype for static GPIO lookup functions has been updated to use
an explicit type for GPIO lookup flags. Unfortunately the definition of
of_find_gpio() when CONFIG_OF is not defined has been omitted, which
triggers a warning. This patch fixes this.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
--
This fixes the kbuild test robot warning about
"gpiolib: use dedicated flags for GPIO properties". Hopefully this can
be squashed into this same patch. Apologies for the trouble.
---
 drivers/gpio/gpiolib.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 48d1a67ed488..463496160a94 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2299,7 +2299,8 @@ static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
 }
 #else
 static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,
-				      unsigned int idx, unsigned long *flags)
+				      unsigned int idx,
+				      enum gpio_lookup_flags *flags)
 {
 	return ERR_PTR(-ENODEV);
 }
-- 
1.8.4.2

Re: [PATCH] gpiolib: fix of_find_gpio() when OF not defined

[Linus Walleij]

On Tue, Nov 19, 2013 at 2:37 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:

> The prototype for static GPIO lookup functions has been updated to use
> an explicit type for GPIO lookup flags. Unfortunately the definition of
> of_find_gpio() when CONFIG_OF is not defined has been omitted, which
> triggers a warning. This patch fixes this.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> --
> This fixes the kbuild test robot warning about
> "gpiolib: use dedicated flags for GPIO properties". Hopefully this can
> be squashed into this same patch. Apologies for the trouble.

Thanks!

Patch applied for fixes.

Yours,
Linus Walleij