* [PATCH] bus: brcmstb_gisb: Rework dependencies
@ 2016-04-13 18:17 Florian Fainelli
2016-04-16 20:01 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2016-04-13 18:17 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-mips, Florian Fainelli, Ray Jui, Scott Branden,
Russell King, Suzuki K Poulose, Olof Johansson, Arnd Bergmann,
Punit Agrawal, Mark Rutland, Masahiro Yamada, Chen-Yu Tsai,
open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...,
open list
Do not have the machine Kconfig entry point need to select
BRCMSTB_GISB_ARB, instead, just let it be default ARCH_BRCMSTB which is
a better way to deal with this. While at it, also make it default
BMIPS_GENERIC so the legacy MIPS-based STB platforms can benefit from
the same thing.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/arm/mach-bcm/Kconfig | 1 -
drivers/bus/Kconfig | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 7ef121472cdd..af10ff27a2ed 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -173,7 +173,6 @@ config ARCH_BRCMSTB
select ARM_GIC
select ARM_ERRATA_798181 if SMP
select HAVE_ARM_ARCH_TIMER
- select BRCMSTB_GISB_ARB
select BRCMSTB_L2_IRQ
select BCM7120_L2_IRQ
select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index d4a3a3133da5..85c66e5028c1 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -58,6 +58,8 @@ config ARM_CCN
config BRCMSTB_GISB_ARB
bool "Broadcom STB GISB bus arbiter"
depends on ARM || MIPS
+ default ARCH_BRCMSTB
+ default BMIPS_GENERIC
help
Driver for the Broadcom Set Top Box System-on-a-chip internal bus
arbiter. This driver provides timeout and target abort error handling
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: brcmstb_gisb: Rework dependencies
2016-04-13 18:17 [PATCH] bus: brcmstb_gisb: Rework dependencies Florian Fainelli
@ 2016-04-16 20:01 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-04-16 20:01 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-arm-kernel, linux-mips, Ray Jui, Scott Branden,
Russell King, Suzuki K Poulose, Olof Johansson, Punit Agrawal,
Mark Rutland, Masahiro Yamada, Chen-Yu Tsai,
open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...,
open list
On Wednesday 13 April 2016 11:17:48 Florian Fainelli wrote:
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -58,6 +58,8 @@ config ARM_CCN
> config BRCMSTB_GISB_ARB
> bool "Broadcom STB GISB bus arbiter"
> depends on ARM || MIPS
> + default ARCH_BRCMSTB
> + default BMIPS_GENERIC
>
I think having two 'default' statements is not clear to human
readers, how about changing it to
default ARCH_BRCMSTB || BMIPS_GENERIC
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-16 20:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-13 18:17 [PATCH] bus: brcmstb_gisb: Rework dependencies Florian Fainelli
2016-04-16 20:01 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).