From: Chase Southwood <chase.southwood@yahoo.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Chase Southwood <chase.southwoo@yahoo.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"abbotti@mev.co.uk" <abbotti@mev.co.uk>
Subject: Re: [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters
Date: Fri, 28 Feb 2014 00:03:59 -0800 (PST) [thread overview]
Message-ID: <1393574639.1751.YahooMailNeo@web164003.mail.gq1.yahoo.com> (raw)
In-Reply-To: <20140228075650.GI26776@mwanda>
>On Friday, February 28, 2014 1:57 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote:
>>> On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote:
>> > hwdrv_apci1564.c had numerous lines over the column limit. This patch
>> > splits all such lines to bring them in compliance with coding style.
>> >
>> > Signed-off-by: Chase Southwood <chase.southwoo@yahoo.com>
>> > ---
>> > .../comedi/drivers/addi-data/hwdrv_apci1564.c | 50 ++++++++++++++++------
>> > 1 file changed, 36 insertions(+), 14 deletions(-)
>> >
>> > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
>> > index 2b47fa1..77030c5 100644
>> > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
>> > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c
>> > @@ -324,11 +324,15 @@ static int i_APCI1564_ConfigTimerCounterWatchdog(struct comedi_device *dev,
>> > inl(devpriv->i_IobaseAmcc + APCI1564_TIMER +
>> > APCI1564_TCW_PROG);
>> > ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;
>> > - outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER + APCI1564_TCW_PROG); /* Stop The Timer */
>> > + /* Stop The Timer */
>> > + outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER +
>> > + APCI1564_TCW_PROG);
>>
>> Just make a helper function so that you can call it like this:
>>
>> static void outl_1564_timer(struct addi_private *devpriv, unsigned int cmd,
>> unsigned int reg)
>> {
>> outl(cmd, devpriv->i_IobaseAmcc + APCI1564_TIMER, reg);
> ^^^
>Should be "devpriv->i_IobaseAmcc + APCI1564_TIMER + reg" obviously.
>
>
>regards,
>dan carpenter
You got it, I'll do it this way and resend.
Thanks,
Chase
next prev parent reply other threads:[~2014-02-28 8:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 7:31 [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters Chase Southwood
2014-02-28 7:32 ` [PATCH 2/2] Staging: comedi: addi-data: remove unnecessary variable initializations in hwdrv_apci1564.c Chase Southwood
2014-02-28 7:52 ` [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters Dan Carpenter
2014-02-28 7:56 ` Dan Carpenter
2014-02-28 8:03 ` Chase Southwood [this message]
2014-02-28 9:15 ` [PATCH 1/2 v2] Staging: comedi: " Chase Southwood
2014-02-28 9:42 ` Dan Carpenter
2014-02-28 9:53 ` Chase Southwood
2014-02-28 22:32 ` Greg KH
2014-03-01 5:32 ` Chase Southwood
2014-02-28 9:16 ` [PATCH 2/2 v2] Staging: comedi: addi-data: remove unnecessary variable initializations in hwdrv_apci1564.c Chase Southwood
2014-03-01 10:28 ` [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions " Chase Southwood
2014-03-01 12:44 ` Dan Carpenter
2014-03-01 12:50 ` Dan Carpenter
2014-03-02 0:12 ` Chase Southwood
2014-03-02 0:26 ` Chase Southwood
2014-03-03 2:52 ` [PATCH v2 1/2] Staging: comedi: introduce {outl,inl}_amcc() and {outl,inl}_iobase() " Chase Southwood
2014-03-03 9:27 ` Dan Carpenter
2014-03-05 0:39 ` Greg KH
2014-03-05 5:35 ` Chase Southwood
2014-03-03 2:52 ` [PATCH v2 2/2] Staging: comedi: use inl() and outl() helper functions Chase Southwood
2014-03-03 9:40 ` Dan Carpenter
2014-03-03 19:17 ` [PATCH 1/2] Staging: comedi: introduce outl_1564_* and inl_1564_* helper functions in hwdrv_apci1564.c Hartley Sweeten
2014-03-01 10:28 ` [PATCH 2/2] Staging: comedi: use " Chase Southwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393574639.1751.YahooMailNeo@web164003.mail.gq1.yahoo.com \
--to=chase.southwood@yahoo.com \
--cc=abbotti@mev.co.uk \
--cc=chase.southwoo@yahoo.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).