linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
@ 2014-01-25 22:29 Richard Weinberger
  2014-01-26 23:30 ` Laurent Pinchart
  2014-02-27  6:58 ` Zhang Rui
  0 siblings, 2 replies; 8+ messages in thread
From: Richard Weinberger @ 2014-01-25 22:29 UTC (permalink / raw)
  To: rui.zhang
  Cc: eduardo.valentin, linux-pm, linux-kernel, horms,
	laurent.pinchart+renesas, Richard Weinberger

Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST)
broke build on archs wihout io memory.

On archs like S390 or um this driver cannot build nor work.
Make it depend on HAS_IOMEM to bypass build failures.

drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource'
drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource'

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/thermal/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 35c0664..88efa8f 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -136,6 +136,7 @@ config SPEAR_THERMAL
 config RCAR_THERMAL
 	tristate "Renesas R-Car thermal driver"
 	depends on ARCH_SHMOBILE || COMPILE_TEST
+	depends on HAS_IO_MEM
 	help
 	  Enable this to plug the R-Car thermal sensor driver into the Linux
 	  thermal framework.
-- 
1.8.1.4


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-01-25 22:29 [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Richard Weinberger
@ 2014-01-26 23:30 ` Laurent Pinchart
  2014-01-26 23:34   ` Richard Weinberger
  2014-02-27  6:58 ` Zhang Rui
  1 sibling, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2014-01-26 23:30 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: rui.zhang, eduardo.valentin, linux-pm, linux-kernel, horms,
	laurent.pinchart+renesas

Hi Richard,

Thank you for the patch.

On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote:
> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with
> COMPILE_TEST) broke build on archs wihout io memory.
> 
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
> 
> drivers/thermal/rcar_thermal.c:404: undefined reference to
> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined
> reference to `devm_ioremap_resource'
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
>  drivers/thermal/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 35c0664..88efa8f 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
>  config RCAR_THERMAL
>  	tristate "Renesas R-Car thermal driver"
>  	depends on ARCH_SHMOBILE || COMPILE_TEST
> +	depends on HAS_IO_MEM

Shouldn't that be HAS_IOMEM ?

>  	help
>  	  Enable this to plug the R-Car thermal sensor driver into the Linux
>  	  thermal framework.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-01-26 23:30 ` Laurent Pinchart
@ 2014-01-26 23:34   ` Richard Weinberger
  0 siblings, 0 replies; 8+ messages in thread
From: Richard Weinberger @ 2014-01-26 23:34 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: rui.zhang, eduardo.valentin, linux-pm, linux-kernel, horms,
	laurent.pinchart+renesas

Am 27.01.2014 00:30, schrieb Laurent Pinchart:
> Hi Richard,
> 
> Thank you for the patch.
> 
> On Saturday 25 January 2014 23:29:14 Richard Weinberger wrote:
>> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with
>> COMPILE_TEST) broke build on archs wihout io memory.
>>
>> On archs like S390 or um this driver cannot build nor work.
>> Make it depend on HAS_IOMEM to bypass build failures.
>>
>> drivers/thermal/rcar_thermal.c:404: undefined reference to
>> `devm_ioremap_resource' drivers/thermal/rcar_thermal.c:426: undefined
>> reference to `devm_ioremap_resource'
>>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>>  drivers/thermal/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 35c0664..88efa8f 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
>>  config RCAR_THERMAL
>>  	tristate "Renesas R-Car thermal driver"
>>  	depends on ARCH_SHMOBILE || COMPILE_TEST
>> +	depends on HAS_IO_MEM
> 
> Shouldn't that be HAS_IOMEM ?

m(

Of course...will resend tomorrow.

>>  	help
>>  	  Enable this to plug the R-Car thermal sensor driver into the Linux
>>  	  thermal framework.
> 

Thanks,
//richard

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-01-25 22:29 [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Richard Weinberger
  2014-01-26 23:30 ` Laurent Pinchart
@ 2014-02-27  6:58 ` Zhang Rui
  2014-02-28  0:44   ` Kuninori Morimoto
  1 sibling, 1 reply; 8+ messages in thread
From: Zhang Rui @ 2014-02-27  6:58 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: eduardo.valentin, linux-pm, linux-kernel, horms,
	laurent.pinchart+renesas, Kuninori Morimoto

On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote:
> Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST)
> broke build on archs wihout io memory.
> 
> On archs like S390 or um this driver cannot build nor work.
> Make it depend on HAS_IOMEM to bypass build failures.
> 
> drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource'
> drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Richard Weinberger <richard@nod.at>

Kuninori,

are you okay with this patch?

thanks,
rui

> ---
>  drivers/thermal/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 35c0664..88efa8f 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
>  config RCAR_THERMAL
>  	tristate "Renesas R-Car thermal driver"
>  	depends on ARCH_SHMOBILE || COMPILE_TEST
> +	depends on HAS_IO_MEM
>  	help
>  	  Enable this to plug the R-Car thermal sensor driver into the Linux
>  	  thermal framework.



^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-02-27  6:58 ` Zhang Rui
@ 2014-02-28  0:44   ` Kuninori Morimoto
  2014-02-28  8:21     ` Richard Weinberger
  0 siblings, 1 reply; 8+ messages in thread
From: Kuninori Morimoto @ 2014-02-28  0:44 UTC (permalink / raw)
  To: Zhang Rui
  Cc: Richard Weinberger, eduardo.valentin, linux-pm, linux-kernel,
	horms, laurent.pinchart+renesas


Hi Zhang

> On Sat, 2014-01-25 at 23:29 +0100, Richard Weinberger wrote:
> > Commit beeb5a1e (thermal: rcar-thermal: Enable driver compilation with COMPILE_TEST)
> > broke build on archs wihout io memory.
> > 
> > On archs like S390 or um this driver cannot build nor work.
> > Make it depend on HAS_IOMEM to bypass build failures.
> > 
> > drivers/thermal/rcar_thermal.c:404: undefined reference to `devm_ioremap_resource'
> > drivers/thermal/rcar_thermal.c:426: undefined reference to `devm_ioremap_resource'
> > 
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> 
> Kuninori,
> 
> are you okay with this patch?
(snip)
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 35c0664..88efa8f 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -136,6 +136,7 @@ config SPEAR_THERMAL
> >  config RCAR_THERMAL
> >  	tristate "Renesas R-Car thermal driver"
> >  	depends on ARCH_SHMOBILE || COMPILE_TEST
> > +	depends on HAS_IO_MEM
> >  	help
> >  	  Enable this to plug the R-Car thermal sensor driver into the Linux
> >  	  thermal framework.

I guess

 - HAS_IO_MEM
 + HAS_IOMEM


${LINUX}/lib/Makefile say

obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-02-28  0:44   ` Kuninori Morimoto
@ 2014-02-28  8:21     ` Richard Weinberger
  2014-02-28  9:30       ` Kuninori Morimoto
  0 siblings, 1 reply; 8+ messages in thread
From: Richard Weinberger @ 2014-02-28  8:21 UTC (permalink / raw)
  To: Kuninori Morimoto, Zhang Rui
  Cc: eduardo.valentin, linux-pm, linux-kernel, horms,
	laurent.pinchart+renesas

Am 28.02.2014 01:44, schrieb Kuninori Morimoto:
>>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>>> index 35c0664..88efa8f 100644
>>> --- a/drivers/thermal/Kconfig
>>> +++ b/drivers/thermal/Kconfig
>>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
>>>  config RCAR_THERMAL
>>>  	tristate "Renesas R-Car thermal driver"
>>>  	depends on ARCH_SHMOBILE || COMPILE_TEST
>>> +	depends on HAS_IO_MEM
>>>  	help
>>>  	  Enable this to plug the R-Car thermal sensor driver into the Linux
>>>  	  thermal framework.
> 
> I guess
> 
>  - HAS_IO_MEM
>  + HAS_IOMEM

Yeah, this has been resolved in v2:
https://lkml.org/lkml/2014/1/27/59

Thanks,
//richard

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-02-28  8:21     ` Richard Weinberger
@ 2014-02-28  9:30       ` Kuninori Morimoto
  2014-03-03 14:46         ` Zhang Rui
  0 siblings, 1 reply; 8+ messages in thread
From: Kuninori Morimoto @ 2014-02-28  9:30 UTC (permalink / raw)
  To: Richard Weinberger
  Cc: Zhang Rui, eduardo.valentin, linux-pm, linux-kernel, horms,
	laurent.pinchart+renesas


Hi Richard, Zhang

> >>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> >>> index 35c0664..88efa8f 100644
> >>> --- a/drivers/thermal/Kconfig
> >>> +++ b/drivers/thermal/Kconfig
> >>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
> >>>  config RCAR_THERMAL
> >>>  	tristate "Renesas R-Car thermal driver"
> >>>  	depends on ARCH_SHMOBILE || COMPILE_TEST
> >>> +	depends on HAS_IO_MEM
> >>>  	help
> >>>  	  Enable this to plug the R-Car thermal sensor driver into the Linux
> >>>  	  thermal framework.
> > 
> > I guess
> > 
> >  - HAS_IO_MEM
> >  + HAS_IOMEM
> 
> Yeah, this has been resolved in v2:
> https://lkml.org/lkml/2014/1/27/59

Nice !

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM
  2014-02-28  9:30       ` Kuninori Morimoto
@ 2014-03-03 14:46         ` Zhang Rui
  0 siblings, 0 replies; 8+ messages in thread
From: Zhang Rui @ 2014-03-03 14:46 UTC (permalink / raw)
  To: Kuninori Morimoto
  Cc: Richard Weinberger, eduardo.valentin, linux-pm, linux-kernel,
	horms, laurent.pinchart+renesas

On Fri, 2014-02-28 at 01:30 -0800, Kuninori Morimoto wrote:
> Hi Richard, Zhang
> 
> > >>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > >>> index 35c0664..88efa8f 100644
> > >>> --- a/drivers/thermal/Kconfig
> > >>> +++ b/drivers/thermal/Kconfig
> > >>> @@ -136,6 +136,7 @@ config SPEAR_THERMAL
> > >>>  config RCAR_THERMAL
> > >>>  	tristate "Renesas R-Car thermal driver"
> > >>>  	depends on ARCH_SHMOBILE || COMPILE_TEST
> > >>> +	depends on HAS_IO_MEM
> > >>>  	help
> > >>>  	  Enable this to plug the R-Car thermal sensor driver into the Linux
> > >>>  	  thermal framework.
> > > 
> > > I guess
> > > 
> > >  - HAS_IO_MEM
> > >  + HAS_IOMEM
> > 
> > Yeah, this has been resolved in v2:
> > https://lkml.org/lkml/2014/1/27/59
> 
> Nice !
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 

applied.

thanks,
rui



^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-03-03 14:46 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-25 22:29 [PATCH 2/2] thermal,rcar_thermal: Add dependency on HAS_IOMEM Richard Weinberger
2014-01-26 23:30 ` Laurent Pinchart
2014-01-26 23:34   ` Richard Weinberger
2014-02-27  6:58 ` Zhang Rui
2014-02-28  0:44   ` Kuninori Morimoto
2014-02-28  8:21     ` Richard Weinberger
2014-02-28  9:30       ` Kuninori Morimoto
2014-03-03 14:46         ` Zhang Rui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).