* [PATCH v2 0/4] tps65917: Drivers for TPS65917 PMIC
@ 2014-05-20 9:11 Keerthy
2014-05-20 9:11 ` [PATCH v2 1/4] MFD: DT bindings for the TPS65917 family MFD Keerthy
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 9:11 UTC (permalink / raw)
To: devicetree
Cc: robh+dt, mark.rutland, sameo, grant.likely, ian, linux-doc,
linux-kernel, broonie, swarren, lee.jones, linux-omap, Keerthy
The TPS65917 chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:
- Regulators.
- GPADC.
- Over Temperature warning and Shut down.
This patch series adds support for TPS65917 mfd device. At this time only
the regulator functionality is made available.
The closest drivers are PALMAS series drivers.
The register set is changed. Bit-field defenitions are changed.
Hence based on the PALMAS drivers and created a new set of drivers
with code changes as required.
The patches are boot tested on DRA72-EVM.
Keerthy (4):
MFD: DT bindings for the TPS65917 family MFD
Regulators: Add TPS65917 Bindings
mfd: tps65917: Add driver for the TPS65917 PMIC
regulator: tps65917: Add Regulator driver for TPS65917 PMIC
Documentation/devicetree/bindings/mfd/tps65917.txt | 35 +
.../bindings/regulator/tps65917-pmic.txt | 67 +
drivers/mfd/Kconfig | 12 +
drivers/mfd/Makefile | 1 +
drivers/mfd/tps65917.c | 573 ++++++++
drivers/regulator/Kconfig | 12 +
drivers/regulator/Makefile | 1 +
drivers/regulator/tps65917-regulator.c | 810 +++++++++++
include/linux/mfd/tps65917.h | 1509 ++++++++++++++++++++
9 files changed, 3020 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/tps65917.txt
create mode 100644 Documentation/devicetree/bindings/regulator/tps65917-pmic.txt
create mode 100644 drivers/mfd/tps65917.c
create mode 100644 drivers/regulator/tps65917-regulator.c
create mode 100644 include/linux/mfd/tps65917.h
--
1.7.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/4] MFD: DT bindings for the TPS65917 family MFD
2014-05-20 9:11 [PATCH v2 0/4] tps65917: Drivers for TPS65917 PMIC Keerthy
@ 2014-05-20 9:11 ` Keerthy
2014-05-20 9:11 ` [PATCH v2 2/4] regulator: Add TPS65917 Bindings Keerthy
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 9:11 UTC (permalink / raw)
To: devicetree
Cc: robh+dt, mark.rutland, sameo, grant.likely, ian, linux-doc,
linux-kernel, broonie, swarren, lee.jones, linux-omap, Keerthy
Add the various binding files for the TPS65917 family of chips. There is a
top level MFD binding then a seperate binding for regulators IP blocks on chips.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Documentation/devicetree/bindings/mfd/tps65917.txt | 35 ++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/tps65917.txt
diff --git a/Documentation/devicetree/bindings/mfd/tps65917.txt b/Documentation/devicetree/bindings/mfd/tps65917.txt
new file mode 100644
index 0000000..287a713
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/tps65917.txt
@@ -0,0 +1,35 @@
+* TPS65917 device tree bindings
+
+The TI TPS65917 family of PMICs.
+
+Required properties:
+- compatible : Should be from the list
+ ti,tps65917
+- interrupt-controller : TPS65917 has its own internal IRQs
+- #interrupt-cells : should be set to 2 for IRQ number and flags
+ The first cell is the IRQ number.
+ The second cell is the flags, encoded as the trigger masks from
+ Documentation/devicetree/bindings/interrupts.txt
+- interrupt-parent : The parent interrupt controller.
+
+Optional properties:
+ ti,mux-padX : set the pad register X (1-2) to the correct muxing for the
+ hardware, if not set will use muxing in OTP.
+
+Example:
+
+tps65917 {
+ compatible = "ti,tps65917";
+ reg = <0x58>
+ interrupt-parent = <&intc>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic {
+ compatible = "ti,tps65917-pmic";
+ ....
+ };
+}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/4] regulator: Add TPS65917 Bindings
2014-05-20 9:11 [PATCH v2 0/4] tps65917: Drivers for TPS65917 PMIC Keerthy
2014-05-20 9:11 ` [PATCH v2 1/4] MFD: DT bindings for the TPS65917 family MFD Keerthy
@ 2014-05-20 9:11 ` Keerthy
2014-05-20 9:11 ` [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC Keerthy
2014-05-20 9:11 ` [PATCH v2 4/4] regulator: tps65917: Add Regulator driver for " Keerthy
3 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 9:11 UTC (permalink / raw)
To: devicetree
Cc: robh+dt, mark.rutland, sameo, grant.likely, ian, linux-doc,
linux-kernel, broonie, swarren, lee.jones, linux-omap, Keerthy
Add TPS65917 Regulator Bindings.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../bindings/regulator/tps65917-pmic.txt | 67 ++++++++++++++++++++
1 file changed, 67 insertions(+)
create mode 100644 Documentation/devicetree/bindings/regulator/tps65917-pmic.txt
diff --git a/Documentation/devicetree/bindings/regulator/tps65917-pmic.txt b/Documentation/devicetree/bindings/regulator/tps65917-pmic.txt
new file mode 100644
index 0000000..96d1fb7
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/tps65917-pmic.txt
@@ -0,0 +1,67 @@
+* tps65917 regulator IP block devicetree bindings
+
+Required properties:
+- compatible : Should be
+ ti,tps65917-pmic
+
+- interrupt-parent : The parent interrupt controller which is tps65917.
+- interrupts : The interrupt number and the type which can be looked up here:
+ arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h
+- interrupts-name: The names of the individual interrupts.
+
+Optional nodes:
+- regulators : Must contain a sub-node per regulator from the list below.
+ Each sub-node should contain the constraints and initialization
+ information for that regulator. See regulator.txt for a
+ description of standard properties for these sub-nodes.
+ Additional custom properties are listed below.
+
+ Optional sub-node properties:
+ ti,warm-reset - maintain voltage during warm reset(boolean)
+ ti,roof-floor - This takes as optional argument on platform supporting
+ the rail from desired external control. If there is no argument then
+ it will be assume that it is controlled by NSLEEP pin.
+ The valid value for external pins are:
+ ENABLE1 then 1,
+ ENABLE2 then 2 or
+ NSLEEP then 3.
+ ti,mode-sleep - mode to adopt in pmic sleep 0 - off, 1 - auto,
+ 2 - eco, 3 - forced pwm
+ ti,smps-range - OTP has the wrong range set for the hardware so override
+ 0 - low range, 1 - high range.
+
+- ti,system-power-controller: Telling whether or not this pmic is controlling
+ the system power.
+
+Example:
+
+#include <dt-bindings/interrupt-controller/irq.h>
+
+pmic {
+ compatible = "ti,tps65917-pmic";
+ interrupt-parent = <&tps65917>;
+ interrupts = <14 IRQ_TYPE_NONE>;
+ interrupts-name = "short-irq";
+
+ ti,system-power-controller;
+
+ regulators {
+ smps1_reg : smps1 {
+ regulator-name = "smps1";
+ regulator-min-microvolt = < 600000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ ti,warm-reset;
+ ti,roof-floor = <1>; /* ENABLE1 control */
+ ti,mode-sleep = <0>;
+ ti,smps-range = <1>;
+ };
+
+ ldo1_reg: ldo1 {
+ regulator-name = "ldo1";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+ };
+};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC
2014-05-20 9:11 [PATCH v2 0/4] tps65917: Drivers for TPS65917 PMIC Keerthy
2014-05-20 9:11 ` [PATCH v2 1/4] MFD: DT bindings for the TPS65917 family MFD Keerthy
2014-05-20 9:11 ` [PATCH v2 2/4] regulator: Add TPS65917 Bindings Keerthy
@ 2014-05-20 9:11 ` Keerthy
2014-05-20 13:58 ` Lee Jones
2014-05-20 14:15 ` Nishanth Menon
2014-05-20 9:11 ` [PATCH v2 4/4] regulator: tps65917: Add Regulator driver for " Keerthy
3 siblings, 2 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 9:11 UTC (permalink / raw)
To: devicetree
Cc: robh+dt, mark.rutland, sameo, grant.likely, ian, linux-doc,
linux-kernel, broonie, swarren, lee.jones, linux-omap, Keerthy
The TPS65917 chip is a power management IC for Portable Navigation Systems
and Tablet Computing devices. It contains the following components:
- Regulators.
- Over Temperature warning and Shut down.
This patch adds support for tps65917 mfd device. At this time only
the regulator functionality is made available.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Changes in V2:
Added volatile register check as some of the registers
in the set are volatile.
drivers/mfd/Kconfig | 12 +
drivers/mfd/Makefile | 1 +
drivers/mfd/tps65917.c | 573 ++++++++++++++++
include/linux/mfd/tps65917.h | 1509 ++++++++++++++++++++++++++++++++++++++++++
4 files changed, 2095 insertions(+)
create mode 100644 drivers/mfd/tps65917.c
create mode 100644 include/linux/mfd/tps65917.h
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3383412..ac73e58 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -925,6 +925,18 @@ config MFD_TPS65912_SPI
If you say yes here you get support for the TPS65912 series of
PM chips with SPI interface.
+config MFD_TPS65917
+ bool "TI TPS65917 series chips"
+ select MFD_CORE
+ select REGMAP_I2C
+ select REGMAP_IRQ
+ depends on I2C=y
+ help
+ If you say yes here you get support for the TPS65917
+ PMIC chips from Texas Instruments. The device provides
+ 5 confgurable SPMSs and 5 LDOs, thermal protection module,
+ GPADC.
+
config MFD_TPS80031
bool "TI TPS80031/TPS80032 Power Management chips"
depends on I2C=y
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 2851275..248a60b 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -69,6 +69,7 @@ tps65912-objs := tps65912-core.o tps65912-irq.o
obj-$(CONFIG_MFD_TPS65912) += tps65912.o
obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o
obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o
+obj-$(CONFIG_MFD_TPS65917) += tps65917.o
obj-$(CONFIG_MFD_TPS80031) += tps80031.o
obj-$(CONFIG_MENELAUS) += menelaus.o
diff --git a/drivers/mfd/tps65917.c b/drivers/mfd/tps65917.c
new file mode 100644
index 0000000..dbd67c5
--- /dev/null
+++ b/drivers/mfd/tps65917.c
@@ -0,0 +1,573 @@
+/*
+ * TI TPS65917 Integrated power management chipsets
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether expressed or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License version 2 for more details.
+ */
+
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/init.h>
+#include <linux/slab.h>
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/regmap.h>
+#include <linux/err.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/tps65917.h>
+#include <linux/of_device.h>
+
+#define TPS65917_EXT_REQ (TPS65917_EXT_CONTROL_ENABLE1 | \
+ TPS65917_EXT_CONTROL_ENABLE2 | \
+ TPS65917_EXT_CONTROL_NSLEEP)
+
+struct tps65917_sleep_requestor_info {
+ int id;
+ int reg_offset;
+ int bit_pos;
+};
+
+#define EXTERNAL_REQUESTOR(_id, _offset, _pos) \
+ [TPS65917_EXTERNAL_REQSTR_ID_##_id] = { \
+ .id = TPS65917_EXTERNAL_REQSTR_ID_##_id, \
+ .reg_offset = _offset, \
+ .bit_pos = _pos, \
+ }
+
+static struct tps65917_sleep_requestor_info sleep_req_info[] = {
+ EXTERNAL_REQUESTOR(REGEN1, 0, 0),
+ EXTERNAL_REQUESTOR(REGEN2, 0, 1),
+ EXTERNAL_REQUESTOR(REGEN3, 0, 6),
+ EXTERNAL_REQUESTOR(SMPS1, 1, 0),
+ EXTERNAL_REQUESTOR(SMPS2, 1, 1),
+ EXTERNAL_REQUESTOR(SMPS3, 1, 2),
+ EXTERNAL_REQUESTOR(SMPS4, 1, 3),
+ EXTERNAL_REQUESTOR(SMPS5, 1, 4),
+ EXTERNAL_REQUESTOR(LDO1, 2, 0),
+ EXTERNAL_REQUESTOR(LDO2, 2, 1),
+ EXTERNAL_REQUESTOR(LDO3, 2, 2),
+ EXTERNAL_REQUESTOR(LDO4, 2, 3),
+ EXTERNAL_REQUESTOR(LDO5, 2, 4),
+};
+
+static int tps65917_voltaile_regs[] = {
+ TPS65917_SMPS1_CTRL,
+ TPS65917_SMPS2_CTRL,
+ TPS65917_SMPS3_CTRL,
+ TPS65917_SMPS4_CTRL,
+ TPS65917_SMPS5_CTRL,
+ TPS65917_LDO1_CTRL,
+ TPS65917_LDO2_CTRL,
+ TPS65917_LDO3_CTRL,
+ TPS65917_LDO4_CTRL,
+ TPS65917_LDO5_CTRL,
+};
+
+static bool is_volatile_reg(struct device *dev, unsigned int reg)
+{
+ int i;
+
+ /*
+ * Caching all the required regulator registers.
+ */
+
+ for (i = 0; i < 11; i++)
+ if (reg == tps65917_voltaile_regs[i])
+ return true;
+
+ return false;
+}
+
+static const struct regmap_config tps65917_regmap_config[TPS65917_NUM_CLIENTS] = {
+ {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .volatile_reg = is_volatile_reg,
+ .cache_type = REGCACHE_NONE,
+ .max_register = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
+ TPS65917_PU_PD_INPUT_CTRL4),
+ },
+ {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .cache_type = REGCACHE_NONE,
+ .max_register = TPS65917_BASE_TO_REG(TPS65917_GPADC_BASE,
+ TPS65917_GPADC_SMPS_VSEL_MONITORING),
+ },
+ {
+ .reg_bits = 8,
+ .val_bits = 8,
+ .cache_type = REGCACHE_NONE,
+ .max_register = TPS65917_BASE_TO_REG(TPS65917_TRIM_GPADC_BASE,
+ TPS65917_GPADC_TRIM16),
+ },
+};
+
+static const struct regmap_irq tps65917_irqs[] = {
+ /* INT1 IRQs */
+ [TPS65917_RESERVED1] = {
+ .mask = TPS65917_RESERVED,
+ },
+ [TPS65917_PWRON_IRQ] = {
+ .mask = TPS65917_INT1_STATUS_PWRON,
+ },
+ [TPS65917_LONG_PRESS_KEY_IRQ] = {
+ .mask = TPS65917_INT1_STATUS_LONG_PRESS_KEY,
+ },
+ [TPS65917_RESERVED2] = {
+ .mask = TPS65917_RESERVED,
+ },
+ [TPS65917_PWRDOWN_IRQ] = {
+ .mask = TPS65917_INT1_STATUS_PWRDOWN,
+ },
+ [TPS65917_HOTDIE_IRQ] = {
+ .mask = TPS65917_INT1_STATUS_HOTDIE,
+ },
+ [TPS65917_VSYS_MON_IRQ] = {
+ .mask = TPS65917_INT1_STATUS_VSYS_MON,
+ },
+ [TPS65917_RESERVED3] = {
+ .mask = TPS65917_RESERVED,
+ },
+ /* INT2 IRQs*/
+ [TPS65917_RESERVED4] = {
+ .mask = TPS65917_RESERVED,
+ .reg_offset = 1,
+ },
+ [TPS65917_OTP_ERROR_IRQ] = {
+ .mask = TPS65917_INT2_STATUS_OTP_ERROR,
+ .reg_offset = 1,
+ },
+ [TPS65917_WDT_IRQ] = {
+ .mask = TPS65917_INT2_STATUS_WDT,
+ .reg_offset = 1,
+ },
+ [TPS65917_RESERVED5] = {
+ .mask = TPS65917_RESERVED,
+ .reg_offset = 1,
+ },
+ [TPS65917_RESET_IN_IRQ] = {
+ .mask = TPS65917_INT2_STATUS_RESET_IN,
+ .reg_offset = 1,
+ },
+ [TPS65917_FSD_IRQ] = {
+ .mask = TPS65917_INT2_STATUS_FSD,
+ .reg_offset = 1,
+ },
+ [TPS65917_SHORT_IRQ] = {
+ .mask = TPS65917_INT2_STATUS_SHORT,
+ .reg_offset = 1,
+ },
+ [TPS65917_RESERVED6] = {
+ .mask = TPS65917_RESERVED,
+ .reg_offset = 1,
+ },
+ /* INT3 IRQs */
+ [TPS65917_GPADC_AUTO_0_IRQ] = {
+ .mask = TPS65917_INT3_STATUS_GPADC_AUTO_0,
+ .reg_offset = 2,
+ },
+ [TPS65917_GPADC_AUTO_1_IRQ] = {
+ .mask = TPS65917_INT3_STATUS_GPADC_AUTO_1,
+ .reg_offset = 2,
+ },
+ [TPS65917_GPADC_EOC_SW_IRQ] = {
+ .mask = TPS65917_INT3_STATUS_GPADC_EOC_SW,
+ .reg_offset = 2,
+ },
+ [TPS65917_RESREVED6] = {
+ .mask = TPS65917_RESERVED6,
+ .reg_offset = 2,
+ },
+ [TPS65917_RESERVED7] = {
+ .mask = TPS65917_RESERVED,
+ .reg_offset = 2,
+ },
+ [TPS65917_RESERVED8] = {
+ .mask = TPS65917_RESERVED,
+ .reg_offset = 2,
+ },
+ [TPS65917_RESERVED9] = {
+ .mask = TPS65917_RESERVED,
+ .reg_offset = 2,
+ },
+ [TPS65917_VBUS_IRQ] = {
+ .mask = TPS65917_INT3_STATUS_VBUS,
+ .reg_offset = 2,
+ },
+ /* INT4 IRQs */
+ [TPS65917_GPIO_0_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_0,
+ .reg_offset = 3,
+ },
+ [TPS65917_GPIO_1_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_1,
+ .reg_offset = 3,
+ },
+ [TPS65917_GPIO_2_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_2,
+ .reg_offset = 3,
+ },
+ [TPS65917_GPIO_3_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_3,
+ .reg_offset = 3,
+ },
+ [TPS65917_GPIO_4_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_4,
+ .reg_offset = 3,
+ },
+ [TPS65917_GPIO_5_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_5,
+ .reg_offset = 3,
+ },
+ [TPS65917_GPIO_6_IRQ] = {
+ .mask = TPS65917_INT4_STATUS_GPIO_6,
+ .reg_offset = 3,
+ },
+ [TPS65917_RESERVED10] = {
+ .mask = TPS65917_RESERVED10,
+ .reg_offset = 3,
+ },
+};
+
+static struct regmap_irq_chip tps65917_irq_chip = {
+ .name = "tps65917",
+ .irqs = tps65917_irqs,
+ .num_irqs = ARRAY_SIZE(tps65917_irqs),
+
+ .num_regs = 4,
+ .irq_reg_stride = 5,
+ .status_base = TPS65917_BASE_TO_REG(TPS65917_INTERRUPT_BASE,
+ TPS65917_INT1_STATUS),
+ .mask_base = TPS65917_BASE_TO_REG(TPS65917_INTERRUPT_BASE,
+ TPS65917_INT1_MASK),
+};
+
+int tps65917_ext_control_req_config(struct tps65917 *tps65917,
+ enum tps65917_external_requestor_id id,
+ int ext_ctrl, bool enable)
+{
+ int preq_mask_bit = 0;
+ int reg_add = 0;
+ int bit_pos;
+ int ret;
+
+ if (!(ext_ctrl & TPS65917_EXT_REQ))
+ return 0;
+
+ if (id >= TPS65917_EXTERNAL_REQSTR_ID_MAX)
+ return 0;
+
+ if (ext_ctrl & TPS65917_EXT_CONTROL_NSLEEP) {
+ reg_add = TPS65917_NSLEEP_RES_ASSIGN;
+ preq_mask_bit = 0;
+ } else if (ext_ctrl & TPS65917_EXT_CONTROL_ENABLE1) {
+ reg_add = TPS65917_ENABLE1_RES_ASSIGN;
+ preq_mask_bit = 1;
+ } else if (ext_ctrl & TPS65917_EXT_CONTROL_ENABLE2) {
+ reg_add = TPS65917_ENABLE2_RES_ASSIGN;
+ preq_mask_bit = 2;
+ }
+
+ bit_pos = sleep_req_info[id].bit_pos;
+ reg_add += sleep_req_info[id].reg_offset;
+ if (enable)
+ ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
+ reg_add, BIT(bit_pos), BIT(bit_pos));
+ else
+ ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
+ reg_add, BIT(bit_pos), 0);
+ if (ret < 0) {
+ dev_err(tps65917->dev, "Resource reg 0x%02x update failed %d\n",
+ reg_add, ret);
+ return ret;
+ }
+
+ /* Unmask the PREQ */
+ ret = tps65917_update_bits(tps65917, TPS65917_PMU_CONTROL_BASE,
+ TPS65917_POWER_CTRL, BIT(preq_mask_bit), 0);
+ if (ret < 0) {
+ dev_err(tps65917->dev, "POWER_CTRL register update failed %d\n",
+ ret);
+ return ret;
+ }
+ return ret;
+}
+EXPORT_SYMBOL_GPL(tps65917_ext_control_req_config);
+
+static int tps65917_set_pdata_irq_flag(struct i2c_client *i2c,
+ struct tps65917_platform_data *pdata)
+{
+ struct irq_data *irq_data = irq_get_irq_data(i2c->irq);
+ if (!irq_data) {
+ dev_err(&i2c->dev, "Invalid IRQ: %d\n", i2c->irq);
+ return -EINVAL;
+ }
+
+ pdata->irq_flags = irqd_get_trigger_type(irq_data);
+ dev_info(&i2c->dev, "Irq flag is 0x%08x\n", pdata->irq_flags);
+ return 0;
+}
+
+static void tps65917_dt_to_pdata(struct i2c_client *i2c,
+ struct tps65917_platform_data *pdata)
+{
+ struct device_node *node = i2c->dev.of_node;
+ int ret;
+ u32 prop;
+
+ ret = of_property_read_u32(node, "ti,mux-pad1", &prop);
+ if (!ret) {
+ pdata->mux_from_pdata = 1;
+ pdata->pad1 = prop;
+ }
+
+ ret = of_property_read_u32(node, "ti,mux-pad2", &prop);
+ if (!ret) {
+ pdata->mux_from_pdata = 1;
+ pdata->pad2 = prop;
+ }
+
+ /* The default for this register is all masked */
+ ret = of_property_read_u32(node, "ti,power-ctrl", &prop);
+ if (!ret)
+ pdata->power_ctrl = prop;
+ else
+ pdata->power_ctrl = TPS65917_POWER_CTRL_NSLEEP_MASK |
+ TPS65917_POWER_CTRL_ENABLE1_MASK |
+ TPS65917_POWER_CTRL_ENABLE2_MASK;
+ if (i2c->irq)
+ tps65917_set_pdata_irq_flag(i2c, pdata);
+
+ pdata->pm_off = of_property_read_bool(node,
+ "ti,system-power-controller");
+}
+
+static struct tps65917 *tps65917_dev;
+
+static const struct of_device_id of_tps65917_match_tbl[] = {
+ {
+ .compatible = "ti,tps65917",
+ },
+ { },
+};
+MODULE_DEVICE_TABLE(of, of_tps65917_match_tbl);
+
+static int tps65917_i2c_probe(struct i2c_client *i2c,
+ const struct i2c_device_id *id)
+{
+ struct tps65917 *tps65917;
+ struct tps65917_platform_data *pdata;
+ struct device_node *node = i2c->dev.of_node;
+ int ret = 0, i;
+ unsigned int reg, addr, *features;
+ int slave;
+ const struct of_device_id *match;
+
+ pdata = dev_get_platdata(&i2c->dev);
+
+ if (node && !pdata) {
+ pdata = devm_kzalloc(&i2c->dev, sizeof(*pdata), GFP_KERNEL);
+
+ if (!pdata)
+ return -ENOMEM;
+
+ tps65917_dt_to_pdata(i2c, pdata);
+ }
+
+ if (!pdata)
+ return -EINVAL;
+
+ tps65917 = devm_kzalloc(&i2c->dev, sizeof(struct tps65917), GFP_KERNEL);
+ if (tps65917 == NULL)
+ return -ENOMEM;
+
+ i2c_set_clientdata(i2c, tps65917);
+ tps65917->dev = &i2c->dev;
+ tps65917->irq = i2c->irq;
+
+ match = of_match_device(of_tps65917_match_tbl, &i2c->dev);
+
+ if (!match)
+ return -ENODATA;
+
+ features = (unsigned int *)match->data;
+
+ for (i = 0; i < TPS65917_NUM_CLIENTS; i++) {
+ if (i == 0) {
+ tps65917->i2c_clients[i] = i2c;
+ } else {
+ tps65917->i2c_clients[i] =
+ i2c_new_dummy(i2c->adapter,
+ i2c->addr + i);
+ if (!tps65917->i2c_clients[i]) {
+ dev_err(tps65917->dev,
+ "can't attach client %d\n", i);
+ ret = -ENOMEM;
+ goto err_i2c;
+ }
+ tps65917->i2c_clients[i]->dev.of_node = of_node_get(node);
+ }
+ tps65917->regmap[i] = devm_regmap_init_i2c(tps65917->i2c_clients[i],
+ &tps65917_regmap_config[i]);
+ if (IS_ERR(tps65917->regmap[i])) {
+ ret = PTR_ERR(tps65917->regmap[i]);
+ dev_err(tps65917->dev,
+ "Failed to allocate regmap %d, err: %d\n",
+ i, ret);
+ goto err_i2c;
+ }
+ }
+
+ if (!tps65917->irq) {
+ dev_warn(tps65917->dev, "IRQ missing: skipping irq request\n");
+ goto no_irq;
+ }
+
+ /* Change interrupt line output polarity */
+ if (pdata->irq_flags & IRQ_TYPE_LEVEL_HIGH)
+ reg = TPS65917_POLARITY_CTRL_INT_POLARITY;
+ else
+ reg = 0;
+ ret = tps65917_update_bits(tps65917, TPS65917_PU_PD_OD_BASE,
+ TPS65917_POLARITY_CTRL,
+ TPS65917_POLARITY_CTRL_INT_POLARITY, reg);
+ if (ret < 0) {
+ dev_err(tps65917->dev, "POLARITY_CTRL updat failed: %d\n", ret);
+ goto err_i2c;
+ }
+
+ /* Change IRQ into clear on read mode for efficiency */
+ slave = TPS65917_BASE_TO_SLAVE(TPS65917_INTERRUPT_BASE);
+ addr = TPS65917_BASE_TO_REG(TPS65917_INTERRUPT_BASE, TPS65917_INT_CTRL);
+ reg = TPS65917_INT_CTRL_INT_CLEAR;
+
+ regmap_write(tps65917->regmap[slave], addr, reg);
+
+ ret = regmap_add_irq_chip(tps65917->regmap[slave], tps65917->irq,
+ IRQF_ONESHOT | pdata->irq_flags, 0,
+ &tps65917_irq_chip,
+ &tps65917->irq_data);
+ if (ret < 0)
+ goto err_i2c;
+
+no_irq:
+ slave = TPS65917_BASE_TO_SLAVE(TPS65917_PU_PD_OD_BASE);
+ addr = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
+ TPS65917_PRIMARY_SECONDARY_PAD1);
+
+ if (pdata->mux_from_pdata) {
+ reg = pdata->pad1;
+ ret = regmap_write(tps65917->regmap[slave], addr, reg);
+ if (ret)
+ goto err_irq;
+ } else {
+ ret = regmap_read(tps65917->regmap[slave], addr, ®);
+ if (ret)
+ goto err_irq;
+ }
+
+ addr = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
+ TPS65917_PRIMARY_SECONDARY_PAD2);
+
+ if (pdata->mux_from_pdata) {
+ reg = pdata->pad2;
+ ret = regmap_write(tps65917->regmap[slave], addr, reg);
+ if (ret)
+ goto err_irq;
+ } else {
+ ret = regmap_read(tps65917->regmap[slave], addr, ®);
+ if (ret)
+ goto err_irq;
+ }
+
+ reg = pdata->power_ctrl;
+
+ slave = TPS65917_BASE_TO_SLAVE(TPS65917_PMU_CONTROL_BASE);
+ addr = TPS65917_BASE_TO_REG(TPS65917_PMU_CONTROL_BASE,
+ TPS65917_POWER_CTRL);
+
+ ret = regmap_write(tps65917->regmap[slave], addr, reg);
+ if (ret)
+ goto err_irq;
+
+ /*
+ * If we are probing with DT do this the DT way and return here
+ * otherwise continue and add devices using mfd helpers.
+ */
+ if (node) {
+ ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
+ if (ret < 0)
+ goto err_irq;
+ else if (pdata->pm_off && !pm_power_off)
+ tps65917_dev = tps65917;
+ }
+
+ return ret;
+
+err_irq:
+ regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
+err_i2c:
+ for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
+ if (tps65917->i2c_clients[i])
+ i2c_unregister_device(tps65917->i2c_clients[i]);
+ }
+ return ret;
+}
+
+static int tps65917_i2c_remove(struct i2c_client *i2c)
+{
+ struct tps65917 *tps65917 = i2c_get_clientdata(i2c);
+ int i;
+
+ regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
+
+ for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
+ if (tps65917->i2c_clients[i])
+ i2c_unregister_device(tps65917->i2c_clients[i]);
+ }
+
+ return 0;
+}
+
+static const struct i2c_device_id tps65917_i2c_id[] = {
+ { "tps65917", },
+};
+MODULE_DEVICE_TABLE(i2c, tps65917_i2c_id);
+
+static struct i2c_driver tps65917_i2c_driver = {
+ .driver = {
+ .name = "tps65917",
+ .of_match_table = of_tps65917_match_tbl,
+ .owner = THIS_MODULE,
+ },
+ .probe = tps65917_i2c_probe,
+ .remove = tps65917_i2c_remove,
+ .id_table = tps65917_i2c_id,
+};
+
+static int __init tps65917_i2c_init(void)
+{
+ return i2c_add_driver(&tps65917_i2c_driver);
+}
+/* init early so consumer devices can complete system boot */
+subsys_initcall(tps65917_i2c_init);
+
+static void __exit tps65917_i2c_exit(void)
+{
+ i2c_del_driver(&tps65917_i2c_driver);
+}
+module_exit(tps65917_i2c_exit);
+
+MODULE_AUTHOR("J Keerthy <j-keerthy@ti.com>");
+MODULE_DESCRIPTION("TPS65917 chip family multi-function driver");
+MODULE_LICENSE("GPL v2");
diff --git a/include/linux/mfd/tps65917.h b/include/linux/mfd/tps65917.h
new file mode 100644
index 0000000..8232e22
--- /dev/null
+++ b/include/linux/mfd/tps65917.h
@@ -0,0 +1,1509 @@
+/*
+ * TI TPS65917
+ *
+ * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether expressed or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License version 2 for more details.
+ */
+
+#ifndef __LINUX_MFD_TPS65917_H
+#define __LINUX_MFD_TPS65917_H
+
+#include <linux/regmap.h>
+#include <linux/regulator/driver.h>
+
+#define TPS65917_NUM_CLIENTS 3
+
+/* The ID_REVISION NUMBERS */
+#define TPS65917_CHIP_ID 0xC035
+#define TPS65917_RESERVED -1
+
+struct tps65917 {
+ struct device *dev;
+
+ struct i2c_client *i2c_clients[TPS65917_NUM_CLIENTS];
+ struct regmap *regmap[TPS65917_NUM_CLIENTS];
+
+ /* Stored chip id */
+ int id;
+
+ struct tps65917_pmic *pmic;
+
+ /* IRQ Data */
+ int irq;
+ u32 irq_mask;
+ /* mutext for irq */
+ struct mutex irq_lock;
+ struct regmap_irq_chip_data *irq_data;
+};
+
+struct tps65917_reg_init {
+ /* warm_rest controls the voltage levels after a warm reset
+ *
+ * 0: reload default values from OTP on warm reset
+ * 1: maintain voltage from VSEL on warm reset
+ */
+ int warm_reset;
+
+ /* roof_floor controls whether the regulator uses the i2c style
+ * of DVS or uses the method where a GPIO or other control method is
+ * attached to the NSLEEP/ENABLE1/ENABLE2 pins
+ *
+ * For SMPS
+ *
+ * 0: i2c selection of voltage
+ * 1: pin selection of voltage.
+ *
+ * For LDO unused
+ */
+ int roof_floor;
+
+ /* sleep_mode is the mode loaded to MODE_SLEEP bits as defined in
+ * the data sheet.
+ *
+ * For SMPS
+ *
+ * 0: Off
+ * 1: AUTO
+ * 2: ECO
+ * 3: Forced PWM
+ *
+ * For LDO
+ *
+ * 0: Off
+ * 1: On
+ */
+ int mode_sleep;
+
+ /* voltage_sel is the bitfield loaded onto the SMPSX_VOLTAGE
+ * register. Set this is the default voltage set in OTP needs
+ * to be overridden.
+ */
+ u8 vsel;
+};
+
+enum tps65917_regulators {
+ /* SMPS regulators */
+ TPS65917_REG_SMPS1,
+ TPS65917_REG_SMPS2,
+ TPS65917_REG_SMPS3,
+ TPS65917_REG_SMPS4,
+ TPS65917_REG_SMPS5,
+ /* LDO regulators */
+ TPS65917_REG_LDO1,
+ TPS65917_REG_LDO2,
+ TPS65917_REG_LDO3,
+ TPS65917_REG_LDO4,
+ TPS65917_REG_LDO5,
+ TPS65917_REG_REGEN1,
+ TPS65917_REG_REGEN2,
+ TPS65917_REG_REGEN3,
+
+ /* Total number of regulators */
+ TPS65917_NUM_REGS,
+};
+
+struct tps65917_pmic_platform_data {
+ /* An array of pointers to regulator init data indexed by regulator
+ * ID
+ */
+ struct regulator_init_data *reg_data[TPS65917_NUM_REGS];
+
+ /* An array of pointers to structures containing sleep mode and DVS
+ * configuration for regulators indexed by ID
+ */
+ struct tps65917_reg_init *reg_init[TPS65917_NUM_REGS];
+};
+
+
+struct tps65917_platform_data {
+ int irq_flags;
+ int gpio_base;
+
+ /* bit value to be loaded to the POWER_CTRL register */
+ u8 power_ctrl;
+
+ /*
+ * boolean to select if we want to configure muxing here
+ * then the two value to load into the registers if true
+ */
+ int mux_from_pdata;
+ u8 pad1, pad2;
+ bool pm_off;
+
+ struct tps65917_pmic_platform_data *pmic_pdata;
+};
+
+/* Define the tps65917 IRQ numbers */
+enum tps65917_irqs {
+ /* INT1 registers */
+ TPS65917_RESERVED1,
+ TPS65917_PWRON_IRQ,
+ TPS65917_LONG_PRESS_KEY_IRQ,
+ TPS65917_RESERVED2,
+ TPS65917_PWRDOWN_IRQ,
+ TPS65917_HOTDIE_IRQ,
+ TPS65917_VSYS_MON_IRQ,
+ TPS65917_RESERVED3,
+ /* INT2 registers */
+ TPS65917_RESERVED4,
+ TPS65917_OTP_ERROR_IRQ,
+ TPS65917_WDT_IRQ,
+ TPS65917_RESERVED5,
+ TPS65917_RESET_IN_IRQ,
+ TPS65917_FSD_IRQ,
+ TPS65917_SHORT_IRQ,
+ TPS65917_RESERVED6,
+ /* INT3 registers */
+ TPS65917_GPADC_AUTO_0_IRQ,
+ TPS65917_GPADC_AUTO_1_IRQ,
+ TPS65917_GPADC_EOC_SW_IRQ,
+ TPS65917_RESREVED6,
+ TPS65917_RESERVED7,
+ TPS65917_RESERVED8,
+ TPS65917_RESERVED9,
+ TPS65917_VBUS_IRQ,
+ /* INT4 registers */
+ TPS65917_GPIO_0_IRQ,
+ TPS65917_GPIO_1_IRQ,
+ TPS65917_GPIO_2_IRQ,
+ TPS65917_GPIO_3_IRQ,
+ TPS65917_GPIO_4_IRQ,
+ TPS65917_GPIO_5_IRQ,
+ TPS65917_GPIO_6_IRQ,
+ TPS65917_RESERVED10,
+ /* Total Number IRQs */
+ TPS65917_NUM_IRQ,
+};
+
+/* External controll signal name */
+enum {
+ TPS65917_EXT_CONTROL_ENABLE1 = 0x1,
+ TPS65917_EXT_CONTROL_ENABLE2 = 0x2,
+ TPS65917_EXT_CONTROL_NSLEEP = 0x4,
+};
+
+/*
+ * TPS65917 device resources can be controlled externally for
+ * enabling/disabling it rather than register write through i2c.
+ * Add the external controlled requestor ID for different resources.
+ */
+enum tps65917_external_requestor_id {
+ TPS65917_EXTERNAL_REQSTR_ID_REGEN1,
+ TPS65917_EXTERNAL_REQSTR_ID_REGEN2,
+ TPS65917_EXTERNAL_REQSTR_ID_REGEN3,
+ TPS65917_EXTERNAL_REQSTR_ID_SMPS1,
+ TPS65917_EXTERNAL_REQSTR_ID_SMPS2,
+ TPS65917_EXTERNAL_REQSTR_ID_SMPS3,
+ TPS65917_EXTERNAL_REQSTR_ID_SMPS4,
+ TPS65917_EXTERNAL_REQSTR_ID_SMPS5,
+ TPS65917_EXTERNAL_REQSTR_ID_LDO1,
+ TPS65917_EXTERNAL_REQSTR_ID_LDO2,
+ TPS65917_EXTERNAL_REQSTR_ID_LDO3,
+ TPS65917_EXTERNAL_REQSTR_ID_LDO4,
+ TPS65917_EXTERNAL_REQSTR_ID_LDO5,
+ /* Last entry */
+ TPS65917_EXTERNAL_REQSTR_ID_MAX,
+};
+
+struct tps65917_pmic {
+ struct tps65917 *tps65917;
+ struct device *dev;
+ struct regulator_desc desc[TPS65917_NUM_REGS];
+ struct regulator_dev *rdev[TPS65917_NUM_REGS];
+ /* pmic mutex */
+ struct mutex mutex;
+ int smps12;
+ int range[TPS65917_REG_SMPS5];
+ unsigned int ramp_delay[TPS65917_REG_SMPS5];
+ unsigned int current_reg_mode[TPS65917_REG_SMPS5];
+};
+
+/* helper macro to get correct slave number */
+#define TPS65917_BASE_TO_SLAVE(x) ((x >> 8) - 1)
+#define TPS65917_BASE_TO_REG(x, y) ((x & 0xff) + y)
+
+/* Base addresses of IP blocks in TPS65917 */
+#define TPS65917_SMPS_DVS_BASE 0x20
+#define TPS65917_VALIDITY_BASE 0x118
+#define TPS65917_SMPS_BASE 0x120
+#define TPS65917_LDO_BASE 0x150
+#define TPS65917_DVFS_BASE 0x180
+#define TPS65917_PMU_CONTROL_BASE 0x1A0
+#define TPS65917_RESOURCE_BASE 0x1D4
+#define TPS65917_PU_PD_OD_BASE 0x1F0
+#define TPS65917_LED_BASE 0x200
+#define TPS65917_INTERRUPT_BASE 0x210
+#define TPS65917_GPIO_BASE 0x280
+#define TPS65917_GPADC_BASE 0x2C0
+#define TPS65917_TRIM_GPADC_BASE 0x3CD
+
+/* Registers for function BACKUP */
+#define TPS65917_BACKUP0 0x0
+#define TPS65917_BACKUP1 0x1
+#define TPS65917_BACKUP2 0x2
+#define TPS65917_BACKUP3 0x3
+#define TPS65917_BACKUP4 0x4
+#define TPS65917_BACKUP5 0x5
+#define TPS65917_BACKUP6 0x6
+#define TPS65917_BACKUP7 0x7
+
+/* Bit definitions for BACKUP0 */
+#define TPS65917_BACKUP0_BACKUP_MASK 0xff
+#define TPS65917_BACKUP0_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP1 */
+#define TPS65917_BACKUP1_BACKUP_MASK 0xff
+#define TPS65917_BACKUP1_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP2 */
+#define TPS65917_BACKUP2_BACKUP_MASK 0xff
+#define TPS65917_BACKUP2_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP3 */
+#define TPS65917_BACKUP3_BACKUP_MASK 0xff
+#define TPS65917_BACKUP3_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP4 */
+#define TPS65917_BACKUP4_BACKUP_MASK 0xff
+#define TPS65917_BACKUP4_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP5 */
+#define TPS65917_BACKUP5_BACKUP_MASK 0xff
+#define TPS65917_BACKUP5_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP6 */
+#define TPS65917_BACKUP6_BACKUP_MASK 0xff
+#define TPS65917_BACKUP6_BACKUP_SHIFT 0
+
+/* Bit definitions for BACKUP7 */
+#define TPS65917_BACKUP7_BACKUP_MASK 0xff
+#define TPS65917_BACKUP7_BACKUP_SHIFT 0
+
+/* Registers for function SMPS */
+#define TPS65917_SMPS1_CTRL 0x0
+#define TPS65917_SMPS1_FORCE 0x2
+#define TPS65917_SMPS1_VOLTAGE 0x3
+#define TPS65917_SMPS2_CTRL 0x4
+#define TPS65917_SMPS2_FORCE 0x6
+#define TPS65917_SMPS2_VOLTAGE 0x7
+#define TPS65917_SMPS3_CTRL 0xC
+#define TPS65917_SMPS3_FORCE 0xE
+#define TPS65917_SMPS3_VOLTAGE 0xF
+#define TPS65917_SMPS4_CTRL 0x10
+#define TPS65917_SMPS4_VOLTAGE 0x13
+#define TPS65917_SMPS5_CTRL 0x18
+#define TPS65917_SMPS5_VOLTAGE 0x1B
+#define TPS65917_SMPS_CTRL 0x24
+#define TPS65917_SMPS_PD_CTRL 0x25
+#define TPS65917_SMPS_THERMAL_EN 0x27
+#define TPS65917_SMPS_THERMAL_STATUS 0x28
+#define TPS65917_SMPS_SHORT_STATUS 0x29
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN 0x2A
+#define TPS65917_SMPS_POWERGOOD_MASK1 0x2B
+#define TPS65917_SMPS_POWERGOOD_MASK2 0x2C
+
+/* Bit definitions for SMPS1_CTRL */
+#define TPS65917_SMPS1_CTRL_WR_S 0x80
+#define TPS65917_SMPS1_CTRL_WR_S_SHIFT 7
+#define TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN 0x40
+#define TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN_SHIFT 6
+#define TPS65917_SMPS1_CTRL_STATUS_MASK 0x30
+#define TPS65917_SMPS1_CTRL_STATUS_SHIFT 4
+#define TPS65917_SMPS1_CTRL_MODE_SLEEP_MASK 0x0c
+#define TPS65917_SMPS1_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK 0x03
+#define TPS65917_SMPS1_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for SMPS1_FORCE */
+#define TPS65917_SMPS1_FORCE_CMD 0x80
+#define TPS65917_SMPS1_FORCE_CMD_SHIFT 7
+#define TPS65917_SMPS1_FORCE_VSEL_MASK 0x7f
+#define TPS65917_SMPS1_FORCE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS1_VOLTAGE */
+#define TPS65917_SMPS1_VOLTAGE_RANGE 0x80
+#define TPS65917_SMPS1_VOLTAGE_RANGE_SHIFT 7
+#define TPS65917_SMPS1_VOLTAGE_VSEL_MASK 0x7f
+#define TPS65917_SMPS1_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS2_CTRL */
+#define TPS65917_SMPS2_CTRL_WR_S 0x80
+#define TPS65917_SMPS2_CTRL_WR_S_SHIFT 7
+#define TPS65917_SMPS2_CTRL_ROOF_FLOOR_EN 0x40
+#define TPS65917_SMPS2_CTRL_ROOF_FLOOR_EN_SHIFT 6
+#define TPS65917_SMPS2_CTRL_STATUS_MASK 0x30
+#define TPS65917_SMPS2_CTRL_STATUS_SHIFT 4
+#define TPS65917_SMPS2_CTRL_MODE_SLEEP_MASK 0x0c
+#define TPS65917_SMPS2_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_SMPS2_CTRL_MODE_ACTIVE_MASK 0x03
+#define TPS65917_SMPS2_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for SMPS2_FORCE */
+#define TPS65917_SMPS2_FORCE_CMD 0x80
+#define TPS65917_SMPS2_FORCE_CMD_SHIFT 7
+#define TPS65917_SMPS2_FORCE_VSEL_MASK 0x7f
+#define TPS65917_SMPS2_FORCE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS2_VOLTAGE */
+#define TPS65917_SMPS2_VOLTAGE_RANGE 0x80
+#define TPS65917_SMPS2_VOLTAGE_RANGE_SHIFT 7
+#define TPS65917_SMPS2_VOLTAGE_VSEL_MASK 0x7f
+#define TPS65917_SMPS2_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS3_CTRL */
+#define TPS65917_SMPS3_CTRL_WR_S 0x80
+#define TPS65917_SMPS3_CTRL_WR_S_SHIFT 7
+#define TPS65917_SMPS3_CTRL_ROOF_FLOOR_EN 0x40
+#define TPS65917_SMPS3_CTRL_ROOF_FLOOR_EN_SHIFT 6
+#define TPS65917_SMPS3_CTRL_STATUS_MASK 0x30
+#define TPS65917_SMPS3_CTRL_STATUS_SHIFT 4
+#define TPS65917_SMPS3_CTRL_MODE_SLEEP_MASK 0x0c
+#define TPS65917_SMPS3_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_SMPS3_CTRL_MODE_ACTIVE_MASK 0x03
+#define TPS65917_SMPS3_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for SMPS3_FORCE */
+#define TPS65917_SMPS3_FORCE_CMD 0x80
+#define TPS65917_SMPS3_FORCE_CMD_SHIFT 7
+#define TPS65917_SMPS3_FORCE_VSEL_MASK 0x7f
+#define TPS65917_SMPS3_FORCE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS3_VOLTAGE */
+#define TPS65917_SMPS3_VOLTAGE_RANGE 0x80
+#define TPS65917_SMPS3_VOLTAGE_RANGE_SHIFT 7
+#define TPS65917_SMPS3_VOLTAGE_VSEL_MASK 0x7f
+#define TPS65917_SMPS3_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS4_CTRL */
+#define TPS65917_SMPS4_CTRL_WR_S 0x80
+#define TPS65917_SMPS4_CTRL_WR_S_SHIFT 7
+#define TPS65917_SMPS4_CTRL_ROOF_FLOOR_EN 0x40
+#define TPS65917_SMPS4_CTRL_ROOF_FLOOR_EN_SHIFT 6
+#define TPS65917_SMPS4_CTRL_STATUS_MASK 0x30
+#define TPS65917_SMPS4_CTRL_STATUS_SHIFT 4
+#define TPS65917_SMPS4_CTRL_MODE_SLEEP_MASK 0x0c
+#define TPS65917_SMPS4_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_SMPS4_CTRL_MODE_ACTIVE_MASK 0x03
+#define TPS65917_SMPS4_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for SMPS4_VOLTAGE */
+#define TPS65917_SMPS4_VOLTAGE_RANGE 0x80
+#define TPS65917_SMPS4_VOLTAGE_RANGE_SHIFT 7
+#define TPS65917_SMPS4_VOLTAGE_VSEL_MASK 0x7f
+#define TPS65917_SMPS4_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS5_CTRL */
+#define TPS65917_SMPS5_CTRL_WR_S 0x80
+#define TPS65917_SMPS5_CTRL_WR_S_SHIFT 7
+#define TPS65917_SMPS5_CTRL_ROOF_FLOOR_EN 0x40
+#define TPS65917_SMPS5_CTRL_ROOF_FLOOR_EN_SHIFT 6
+#define TPS65917_SMPS5_CTRL_STATUS_MASK 0x30
+#define TPS65917_SMPS5_CTRL_STATUS_SHIFT 4
+#define TPS65917_SMPS5_CTRL_MODE_SLEEP_MASK 0x0c
+#define TPS65917_SMPS5_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_SMPS5_CTRL_MODE_ACTIVE_MASK 0x03
+#define TPS65917_SMPS5_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for SMPS5_VOLTAGE */
+#define TPS65917_SMPS5_VOLTAGE_RANGE 0x80
+#define TPS65917_SMPS5_VOLTAGE_RANGE_SHIFT 7
+#define TPS65917_SMPS5_VOLTAGE_VSEL_MASK 0x7f
+#define TPS65917_SMPS5_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for SMPS_CTRL */
+#define TPS65917_SMPS_CTRL_SMPS1_SMPS12_EN 0x10
+#define TPS65917_SMPS_CTRL_SMPS1_SMPS12_EN_SHIFT 4
+#define TPS65917_SMPS_CTRL_SMPS12_PHASE_CTRL 0x3
+#define TPS65917_SMPS_CTRL_SMPS12_PHASE_CTRL_SHIFT 0
+
+/* Bit definitions for SMPS_PD_CTRL */
+#define TPS65917_SMPS_PD_CTRL_SMPS5 0x40
+#define TPS65917_SMPS_PD_CTRL_SMPS5_SHIFT 6
+#define TPS65917_SMPS_PD_CTRL_SMPS4 0x10
+#define TPS65917_SMPS_PD_CTRL_SMPS4_SHIFT 4
+#define TPS65917_SMPS_PD_CTRL_SMPS3 0x08
+#define TPS65917_SMPS_PD_CTRL_SMPS3_SHIFT 3
+#define TPS65917_SMPS_PD_CTRL_SMPS2 0x02
+#define TPS65917_SMPS_PD_CTRL_SMPS2_SHIFT 1
+#define TPS65917_SMPS_PD_CTRL_SMPS1 0x01
+#define TPS65917_SMPS_PD_CTRL_SMPS1_SHIFT 0
+
+/* Bit definitions for SMPS_THERMAL_EN */
+#define TPS65917_SMPS_THERMAL_EN_SMPS5 0x40
+#define TPS65917_SMPS_THERMAL_EN_SMPS5_SHIFT 6
+#define TPS65917_SMPS_THERMAL_EN_SMPS3 0x08
+#define TPS65917_SMPS_THERMAL_EN_SMPS3_SHIFT 3
+#define TPS65917_SMPS_THERMAL_EN_SMPS12 0x01
+#define TPS65917_SMPS_THERMAL_EN_SMPS12_SHIFT 0
+
+/* Bit definitions for SMPS_THERMAL_STATUS */
+#define TPS65917_SMPS_THERMAL_STATUS_SMPS5 0x40
+#define TPS65917_SMPS_THERMAL_STATUS_SMPS5_SHIFT 6
+#define TPS65917_SMPS_THERMAL_STATUS_SMPS3 0x08
+#define TPS65917_SMPS_THERMAL_STATUS_SMPS3_SHIFT 3
+#define TPS65917_SMPS_THERMAL_STATUS_SMPS12 0x01
+#define TPS65917_SMPS_THERMAL_STATUS_SMPS12_SHIFT 0
+
+/* Bit definitions for SMPS_SHORT_STATUS */
+#define TPS65917_SMPS_SHORT_STATUS_SMPS5 0x40
+#define TPS65917_SMPS_SHORT_STATUS_SMPS5_SHIFT 6
+#define TPS65917_SMPS_SHORT_STATUS_SMPS4 0x10
+#define TPS65917_SMPS_SHORT_STATUS_SMPS4_SHIFT 4
+#define TPS65917_SMPS_SHORT_STATUS_SMPS3 0x08
+#define TPS65917_SMPS_SHORT_STATUS_SMPS3_SHIFT 3
+#define TPS65917_SMPS_SHORT_STATUS_SMPS2 0x02
+#define TPS65917_SMPS_SHORT_STATUS_SMPS2_SHIFT 1
+#define TPS65917_SMPS_SHORT_STATUS_SMPS1 0x01
+#define TPS65917_SMPS_SHORT_STATUS_SMPS1_SHIFT 0
+
+/* Bit definitions for SMPS_NEGATIVE_CURRENT_LIMIT_EN */
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS5 0x40
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS5_SHIFT 6
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS4 0x10
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS4_SHIFT 4
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS3 0x08
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS3_SHIFT 3
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS2 0x02
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS2_SHIFT 1
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS1 0x01
+#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN_SMPS1_SHIFT 0
+
+/* Bit definitions for SMPS_POWERGOOD_MASK1 */
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS5 0x40
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS5_SHIFT 6
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS4 0x10
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS4_SHIFT 4
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS3 0x08
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS3_SHIFT 3
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS2 0x02
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS2_SHIFT 1
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS1 0x01
+#define TPS65917_SMPS_POWERGOOD_MASK1_SMPS1_SHIFT 0
+
+/* Bit definitions for SMPS_POWERGOOD_MASK2 */
+#define TPS65917_SMPS_POWERGOOD_MASK2_POWERGOOD_TYPE_SELECT 0x80
+#define TPS65917_SMPS_POWERGOOD_MASK2_POWERGOOD_TYPE_SELECT_SHIFT 7
+#define TPS65917_SMPS_POWERGOOD_MASK2_OVC_ALARM_SHIFT 0x10
+#define TPS65917_SMPS_POWERGOOD_MASK2_OVC_ALARM 4
+
+/* Bit definitions for SMPS_PLL_CTRL */
+
+#define TPS65917_SMPS_PLL_CTRL_PLL_EN_PLL_BYPASS_SHIFT 0x8
+#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_EN_BYPASS 3
+#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_BYPASS_CLK_SHIFT 0x4
+#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_BYPASS_CLK 2
+
+
+/* Registers for function LDO */
+#define TPS65917_LDO1_CTRL 0x0
+#define TPS65917_LDO1_VOLTAGE 0x1
+#define TPS65917_LDO2_CTRL 0x2
+#define TPS65917_LDO2_VOLTAGE 0x3
+#define TPS65917_LDO3_CTRL 0x4
+#define TPS65917_LDO3_VOLTAGE 0x5
+#define TPS65917_LDO4_CTRL 0xE
+#define TPS65917_LDO4_VOLTAGE 0xF
+#define TPS65917_LDO5_CTRL 0x12
+#define TPS65917_LDO5_VOLTAGE 0x13
+#define TPS65917_LDO_PD_CTRL1 0x1B
+#define TPS65917_LDO_PD_CTRL2 0x1C
+#define TPS65917_LDO_SHORT_STATUS1 0x1D
+#define TPS65917_LDO_SHORT_STATUS2 0x1E
+#define TPS65917_LDO_PD_CTRL3 0x2D
+#define TPS65917_LDO_SHORT_STATUS3 0x2E
+
+/* Bit definitions for LDO1_CTRL */
+#define TPS65917_LDO1_CTRL_WR_S 0x80
+#define TPS65917_LDO1_CTRL_WR_S_SHIFT 7
+#define TPS65917_LDO1_CTRL_BYPASS_EN 0x40
+#define TPS65917_LDO1_CTRL_BYPASS_EN_SHIFT 0x6
+#define TPS65917_LDO1_CTRL_STATUS 0x10
+#define TPS65917_LDO1_CTRL_STATUS_SHIFT 4
+#define TPS65917_LDO1_CTRL_MODE_SLEEP 0x04
+#define TPS65917_LDO1_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_LDO1_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_LDO1_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for LDO1_VOLTAGE */
+#define TPS65917_LDO1_VOLTAGE_VSEL_MASK 0x3f
+#define TPS65917_LDO1_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for LDO2_CTRL */
+#define TPS65917_LDO2_CTRL_WR_S 0x80
+#define TPS65917_LDO2_CTRL_WR_S_SHIFT 7
+#define TPS65917_LDO2_CTRL_BYPASS_EN 0x40
+#define TPS65917_LDO2_CTRL_BYPASS_EN_SHIFT 0x6
+#define TPS65917_LDO2_CTRL_STATUS 0x10
+#define TPS65917_LDO2_CTRL_STATUS_SHIFT 4
+#define TPS65917_LDO2_CTRL_MODE_SLEEP 0x04
+#define TPS65917_LDO2_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_LDO2_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_LDO2_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for LDO2_VOLTAGE */
+#define TPS65917_LDO2_VOLTAGE_VSEL_MASK 0x3f
+#define TPS65917_LDO2_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for LDO3_CTRL */
+#define TPS65917_LDO3_CTRL_WR_S 0x80
+#define TPS65917_LDO3_CTRL_WR_S_SHIFT 7
+#define TPS65917_LDO3_CTRL_STATUS 0x10
+#define TPS65917_LDO3_CTRL_STATUS_SHIFT 4
+#define TPS65917_LDO3_CTRL_MODE_SLEEP 0x04
+#define TPS65917_LDO3_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_LDO3_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_LDO3_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for LDO3_VOLTAGE */
+#define TPS65917_LDO3_VOLTAGE_VSEL_MASK 0x3f
+#define TPS65917_LDO3_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for LDO4_CTRL */
+#define TPS65917_LDO4_CTRL_WR_S 0x80
+#define TPS65917_LDO4_CTRL_WR_S_SHIFT 7
+#define TPS65917_LDO4_CTRL_STATUS 0x10
+#define TPS65917_LDO4_CTRL_STATUS_SHIFT 4
+#define TPS65917_LDO4_CTRL_MODE_SLEEP 0x04
+#define TPS65917_LDO4_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_LDO4_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_LDO4_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for LDO4_VOLTAGE */
+#define TPS65917_LDO4_VOLTAGE_VSEL_MASK 0x3f
+#define TPS65917_LDO4_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for LDO5_CTRL */
+#define TPS65917_LDO5_CTRL_WR_S 0x80
+#define TPS65917_LDO5_CTRL_WR_S_SHIFT 7
+#define TPS65917_LDO5_CTRL_STATUS 0x10
+#define TPS65917_LDO5_CTRL_STATUS_SHIFT 4
+#define TPS65917_LDO5_CTRL_MODE_SLEEP 0x04
+#define TPS65917_LDO5_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_LDO5_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_LDO5_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for LDO5_VOLTAGE */
+#define TPS65917_LDO5_VOLTAGE_VSEL_MASK 0x3f
+#define TPS65917_LDO5_VOLTAGE_VSEL_SHIFT 0
+
+/* Bit definitions for LDO_PD_CTRL1 */
+#define TPS65917_LDO_PD_CTRL1_LDO4 0x80
+#define TPS65917_LDO_PD_CTRL1_LDO4_SHIFT 7
+#define TPS65917_LDO_PD_CTRL1_LDO2 0x02
+#define TPS65917_LDO_PD_CTRL1_LDO2_SHIFT 1
+#define TPS65917_LDO_PD_CTRL1_LDO1 0x01
+#define TPS65917_LDO_PD_CTRL1_LDO1_SHIFT 0
+
+/* Bit definitions for LDO_PD_CTRL2 */
+#define TPS65917_LDO_PD_CTRL2_LDO3 0x04
+#define TPS65917_LDO_PD_CTRL2_LDO3_SHIFT 2
+#define TPS65917_LDO_PD_CTRL2_LDO5 0x02
+#define TPS65917_LDO_PD_CTRL2_LDO5_SHIFT 1
+
+/* Bit definitions for LDO_PD_CTRL3 */
+#define TPS65917_LDO_PD_CTRL2_LDOVANA 0x80
+#define TPS65917_LDO_PD_CTRL2_LDOVANA_SHIFT 7
+
+/* Bit definitions for LDO_SHORT_STATUS1 */
+#define TPS65917_LDO_SHORT_STATUS1_LDO4 0x80
+#define TPS65917_LDO_SHORT_STATUS1_LDO4_SHIFT 7
+#define TPS65917_LDO_SHORT_STATUS1_LDO2 0x02
+#define TPS65917_LDO_SHORT_STATUS1_LDO2_SHIFT 1
+#define TPS65917_LDO_SHORT_STATUS1_LDO1 0x01
+#define TPS65917_LDO_SHORT_STATUS1_LDO1_SHIFT 0
+
+/* Bit definitions for LDO_SHORT_STATUS2 */
+#define TPS65917_LDO_SHORT_STATUS2_LDO3 0x04
+#define TPS65917_LDO_SHORT_STATUS2_LDO3_SHIFT 2
+#define TPS65917_LDO_SHORT_STATUS2_LDO5 0x02
+#define TPS65917_LDO_SHORT_STATUS2_LDO5_SHIFT 1
+
+/* Bit definitions for LDO_SHORT_STATUS2 */
+#define TPS65917_LDO_SHORT_STATUS2_LDOVANA 0x80
+#define TPS65917_LDO_SHORT_STATUS2_LDOVANA_SHIFT 7
+
+/* Registers for function PMU_CONTROL */
+#define TPS65917_DEV_CTRL 0x0
+#define TPS65917_POWER_CTRL 0x1
+#define TPS65917_VSYS_LO 0x2
+#define TPS65917_VSYS_MON 0x3
+#define TPS65917_WATCHDOG 0x5
+#define TPS65917_VRTC_CTRL 0x8
+#define TPS65917_LONG_PRESS_KEY 0x9
+#define TPS65917_OSC_THERM_CTRL 0xA
+#define TPS65917_SWOFF_HWRST 0xF
+#define TPS65917_SWOFF_COLDRST 0x10
+#define TPS65917_SWOFF_STATUS 0x11
+#define TPS65917_PMU_CONFIG 0x12
+#define TPS65917_PMU_CTRL2 0x13
+#define TPS65917_PMU_SECONDARY_INT 0x15
+#define TPS65917_SW_REVISION 0x17
+#define TPS65917_PMU_SECONDARY_INT2 0x19
+
+/* Bit definitions for DEV_CTRL */
+#define TPS65917_DEV_CTRL_DEV_STATUS_MASK 0x0c
+#define TPS65917_DEV_CTRL_DEV_STATUS_SHIFT 2
+#define TPS65917_DEV_CTRL_SW_RST 0x02
+#define TPS65917_DEV_CTRL_SW_RST_SHIFT 1
+#define TPS65917_DEV_CTRL_DEV_ON 0x01
+#define TPS65917_DEV_CTRL_DEV_ON_SHIFT 0
+
+/* Bit definitions for POWER_CTRL */
+#define TPS65917_POWER_CTRL_ENABLE2_MASK 0x04
+#define TPS65917_POWER_CTRL_ENABLE2_MASK_SHIFT 2
+#define TPS65917_POWER_CTRL_ENABLE1_MASK 0x02
+#define TPS65917_POWER_CTRL_ENABLE1_MASK_SHIFT 1
+#define TPS65917_POWER_CTRL_NSLEEP_MASK 0x01
+#define TPS65917_POWER_CTRL_NSLEEP_MASK_SHIFT 0
+
+/* Bit definitions for VSYS_LO */
+#define TPS65917_VSYS_LO_THRESHOLD_MASK 0x1f
+#define TPS65917_VSYS_LO_THRESHOLD_SHIFT 0
+
+/* Bit definitions for VSYS_MON */
+#define TPS65917_VSYS_MON_ENABLE 0x80
+#define TPS65917_VSYS_MON_ENABLE_SHIFT 7
+#define TPS65917_VSYS_MON_THRESHOLD_MASK 0x3f
+#define TPS65917_VSYS_MON_THRESHOLD_SHIFT 0
+
+/* Bit definitions for WATCHDOG */
+#define TPS65917_WATCHDOG_LOCK 0x20
+#define TPS65917_WATCHDOG_LOCK_SHIFT 5
+#define TPS65917_WATCHDOG_ENABLE 0x10
+#define TPS65917_WATCHDOG_ENABLE_SHIFT 4
+#define TPS65917_WATCHDOG_MODE 0x08
+#define TPS65917_WATCHDOG_MODE_SHIFT 3
+#define TPS65917_WATCHDOG_TIMER_MASK 0x07
+#define TPS65917_WATCHDOG_TIMER_SHIFT 0
+
+/* Bit definitions for VRTC_CTRL */
+#define TPS65917_VRTC_CTRL_VRTC_18_15 0x80
+#define TPS65917_VRTC_CTRL_VRTC_18_15_SHIFT 7
+#define TPS65917_VRTC_CTRL_VRTC_EN_SLP 0x40
+#define TPS65917_VRTC_CTRL_VRTC_EN_SLP_SHIFT 6
+#define TPS65917_VRTC_CTRL_VRTC_EN_OFF 0x20
+#define TPS65917_VRTC_CTRL_VRTC_EN_OFF_SHIFT 5
+#define TPS65917_VRTC_CTRL_VRTC_PWEN 0x10
+#define TPS65917_VRTC_CTRL_SHIFT 4
+
+/* Bit definitions for LONG_PRESS_KEY */
+#define TPS65917_LONG_PRESS_KEY_LPK_LOCK 0x80
+#define TPS65917_LONG_PRESS_KEY_LPK_LOCK_SHIFT 7
+#define TPS65917_LONG_PRESS_KEY_LPK_TIME_MASK 0x0c
+#define TPS65917_LONG_PRESS_KEY_LPK_TIME_SHIFT 2
+
+/* Bit definitions for OSC_THERM_CTRL */
+#define TPS65917_OSC_THERM_CTRL_VANA_ON_IN_SLEEP 0x80
+#define TPS65917_OSC_THERM_CTRL_VANA_ON_IN_SLEEP_SHIFT 7
+#define TPS65917_OSC_THERM_CTRL_INT_MASK_IN_SLEEP 0x40
+#define TPS65917_OSC_THERM_CTRL_INT_MASK_IN_SLEEP_SHIFT 6
+#define TPS65917_OSC_THERM_CTRL_RC15MHZ_ON_IN_SLEEP 0x20
+#define TPS65917_OSC_THERM_CTRL_RC15MHZ_ON_IN_SLEEP_SHIFT 5
+#define TPS65917_OSC_THERM_CTRL_THERM_OFF_IN_SLEEP 0x10
+#define TPS65917_OSC_THERM_CTRL_THERM_OFF_IN_SLEEP_SHIFT 4
+#define TPS65917_OSC_THERM_CTRL_THERM_HD_SEL_MASK 0x0c
+#define TPS65917_OSC_THERM_CTRL_THERM_HD_SEL_SHIFT 2
+
+/* Bit definitions for SWOFF_HWRST */
+#define TPS65917_SWOFF_HWRST_PWRON_LPK 0x80
+#define TPS65917_SWOFF_HWRST_PWRON_LPK_SHIFT 7
+#define TPS65917_SWOFF_HWRST_PWRDOWN 0x40
+#define TPS65917_SWOFF_HWRST_PWRDOWN_SHIFT 6
+#define TPS65917_SWOFF_HWRST_WTD 0x20
+#define TPS65917_SWOFF_HWRST_WTD_SHIFT 5
+#define TPS65917_SWOFF_HWRST_TSHUT 0x10
+#define TPS65917_SWOFF_HWRST_TSHUT_SHIFT 4
+#define TPS65917_SWOFF_HWRST_RESET_IN 0x08
+#define TPS65917_SWOFF_HWRST_RESET_IN_SHIFT 3
+#define TPS65917_SWOFF_HWRST_SW_RST 0x04
+#define TPS65917_SWOFF_HWRST_SW_RST_SHIFT 2
+#define TPS65917_SWOFF_HWRST_VSYS_LO 0x02
+#define TPS65917_SWOFF_HWRST_VSYS_LO_SHIFT 1
+#define TPS65917_SWOFF_HWRST_GPADC_SHUTDOWN 0x01
+#define TPS65917_SWOFF_HWRST_GPADC_SHUTDOWN_SHIFT 0
+
+/* Bit definitions for SWOFF_COLDRST */
+#define TPS65917_SWOFF_COLDRST_PWRON_LPK 0x80
+#define TPS65917_SWOFF_COLDRST_PWRON_LPK_SHIFT 7
+#define TPS65917_SWOFF_COLDRST_PWRDOWN 0x40
+#define TPS65917_SWOFF_COLDRST_PWRDOWN_SHIFT 6
+#define TPS65917_SWOFF_COLDRST_WTD 0x20
+#define TPS65917_SWOFF_COLDRST_WTD_SHIFT 5
+#define TPS65917_SWOFF_COLDRST_TSHUT 0x10
+#define TPS65917_SWOFF_COLDRST_TSHUT_SHIFT 4
+#define TPS65917_SWOFF_COLDRST_RESET_IN 0x08
+#define TPS65917_SWOFF_COLDRST_RESET_IN_SHIFT 3
+#define TPS65917_SWOFF_COLDRST_SW_RST 0x04
+#define TPS65917_SWOFF_COLDRST_SW_RST_SHIFT 2
+#define TPS65917_SWOFF_COLDRST_VSYS_LO 0x02
+#define TPS65917_SWOFF_COLDRST_VSYS_LO_SHIFT 1
+#define TPS65917_SWOFF_COLDRST_GPADC_SHUTDOWN 0x01
+#define TPS65917_SWOFF_COLDRST_GPADC_SHUTDOWN_SHIFT 0
+
+/* Bit definitions for SWOFF_STATUS */
+#define TPS65917_SWOFF_STATUS_PWRON_LPK 0x80
+#define TPS65917_SWOFF_STATUS_PWRON_LPK_SHIFT 7
+#define TPS65917_SWOFF_STATUS_PWRDOWN 0x40
+#define TPS65917_SWOFF_STATUS_PWRDOWN_SHIFT 6
+#define TPS65917_SWOFF_STATUS_WTD 0x20
+#define TPS65917_SWOFF_STATUS_WTD_SHIFT 5
+#define TPS65917_SWOFF_STATUS_TSHUT 0x10
+#define TPS65917_SWOFF_STATUS_TSHUT_SHIFT 4
+#define TPS65917_SWOFF_STATUS_RESET_IN 0x08
+#define TPS65917_SWOFF_STATUS_RESET_IN_SHIFT 3
+#define TPS65917_SWOFF_STATUS_SW_RST 0x04
+#define TPS65917_SWOFF_STATUS_SW_RST_SHIFT 2
+#define TPS65917_SWOFF_STATUS_VSYS_LO 0x02
+#define TPS65917_SWOFF_STATUS_VSYS_LO_SHIFT 1
+#define TPS65917_SWOFF_STATUS_GPADC_SHUTDOWN 0x01
+#define TPS65917_SWOFF_STATUS_GPADC_SHUTDOWN_SHIFT 0
+
+/* Bit definitions for PMU_CONFIG */
+#define TPS65917_PMU_CONFIG_HIGH_VCC_SENSE 0x40
+#define TPS65917_PMU_CONFIG_HIGH_VCC_SENSE_SHIFT 6
+#define TPS65917_PMU_CONFIG_PLL_AUTO_CTRL_MASK 0x30
+#define TPS65917_PMU_CONFIG_PLL_AUTO_CTRL_SHIFT 4
+#define TPS65917_PMU_CONFIG_SWOFF_DLY_MASK 0x0c
+#define TPS65917_PMU_CONFIG_SWOFF_DLY_SHIFT 2
+#define TPS65917_PMU_CONFIG_AUTODEVON 0x01
+#define TPS65917_PMU_CONFIG_AUTODEVON_SHIFT 0
+
+/* Bit definitions for PMU_CTRL2 */
+#define TPS65917_PMU_CTRL2_INT_LINE_DIS 0x8
+#define TPS65917_PMU_CTRL2_INT_LINE_DIS_SHIFT 4
+#define TPS65917_PMU_CTRL2_WDT_HOLD_IN_SLEEP 0x4
+#define TPS65917_PMU_CTRL2_WDT_HOLD_IN_SLEEP_SHIFT 3
+#define TPS65917_PMU_CTRL2_PWRDOWN_FASTOFF 0x2
+#define TPS65917_PMU_CTRL2_PWRDOWN_FASTOFF_SHIFT 1
+#define TPS65917_PMU_CTRL2_TSHUT_FASTOFF 0x1
+#define TPS65917_PMU_CTRL2_TSHUT_FASTOFF_SHIFT 0
+
+/* Bit definitions for PMU_SECONDARY_INT */
+#define TPS65917_PMU_SECONDARY_INT_FSD_INT_SRC 0x10
+#define TPS65917_PMU_SECONDARY_INT_FSD_INT_SRC_SHIFT 4
+#define TPS65917_PMU_SECONDARY_INT_FSB_MASK 0x01
+#define TPS65917_PMU_SECONDARY_INT_FSB_MASK_SHIFT 0
+
+/* Bit definitions for SW_REVISION */
+#define TPS65917_SW_REVISION_SW_REVISION_MASK 0xff
+#define TPS65917_SW_REVISION_SW_REVISION_SHIFT 0
+
+/* Bit definitions for PMU_SECONDARY_INT2 */
+#define TPS65917_PMU_SECONDARY_INT2_DVFS_INT_SRC 0x10
+#define TPS65917_PMU_SECONDARY_INT2_DVFS_INT_SRC_SHIFT 4
+#define TPS65917_PMU_SECONDARY_INT2_DVFS_MASK 0x01
+#define TPS65917_PMU_SECONDARY_INT2_DVFS_MASK_SHIFT 0
+
+/* Registers for function RESOURCE */
+#define TPS65917_REGEN1_CTRL 0x2
+#define TPS65917_PLLEN_CTRL 0x3
+#define TPS65917_NSLEEP_RES_ASSIGN 0x6
+#define TPS65917_NSLEEP_SMPS_ASSIGN 0x7
+#define TPS65917_NSLEEP_LDO_ASSIGN1 0x8
+#define TPS65917_NSLEEP_LDO_ASSIGN2 0x9
+#define TPS65917_ENABLE1_RES_ASSIGN 0xA
+#define TPS65917_ENABLE1_SMPS_ASSIGN 0xB
+#define TPS65917_ENABLE1_LDO_ASSIGN1 0xC
+#define TPS65917_ENABLE1_LDO_ASSIGN2 0xD
+#define TPS65917_ENABLE2_RES_ASSIGN 0xE
+#define TPS65917_ENABLE2_SMPS_ASSIGN 0xF
+#define TPS65917_ENABLE2_LDO_ASSIGN1 0x10
+#define TPS65917_ENABLE2_LDO_ASSIGN2 0x11
+#define TPS65917_REGEN2_CTRL 0x12
+#define TPS65917_REGEN3_CTRL 0x13
+
+/* Bit definitions for REGEN1_CTRL */
+#define TPS65917_REGEN1_CTRL_STATUS 0x10
+#define TPS65917_REGEN1_CTRL_STATUS_SHIFT 4
+#define TPS65917_REGEN1_CTRL_MODE_SLEEP 0x04
+#define TPS65917_REGEN1_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_REGEN1_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_REGEN1_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for PLLEN_CTRL */
+#define TPS65917_PLLEN_CTRL_STATUS 0x10
+#define TPS65917_PLLEN_CTRL_STATUS_SHIFT 4
+#define TPS65917_PLLEN_CTRL_MODE_SLEEP 0x04
+#define TPS65917_PLLEN_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_PLLEN_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_PLLEN_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for REGEN2_CTRL */
+#define TPS65917_REGEN2_CTRL_STATUS 0x10
+#define TPS65917_REGEN2_CTRL_STATUS_SHIFT 4
+#define TPS65917_REGEN2_CTRL_MODE_SLEEP 0x04
+#define TPS65917_REGEN2_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_REGEN2_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_REGEN2_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Bit definitions for NSLEEP_RES_ASSIGN */
+#define TPS65917_NSLEEP_RES_ASSIGN_PLL_EN 0x08
+#define TPS65917_NSLEEP_RES_ASSIGN_PLL_EN_SHIFT 3
+#define TPS65917_NSLEEP_RES_ASSIGN_REGEN3 0x04
+#define TPS65917_NSLEEP_RES_ASSIGN_REGEN3_SHIFT 2
+#define TPS65917_NSLEEP_RES_ASSIGN_REGEN2 0x02
+#define TPS65917_NSLEEP_RES_ASSIGN_REGEN2_SHIFT 1
+#define TPS65917_NSLEEP_RES_ASSIGN_REGEN1 0x01
+#define TPS65917_NSLEEP_RES_ASSIGN_REGEN1_SHIFT 0
+
+/* Bit definitions for NSLEEP_SMPS_ASSIGN */
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS5 0x40
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS5_SHIFT 6
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS4 0x10
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS4_SHIFT 4
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS3 0x08
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS3_SHIFT 3
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS2 0x02
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS2_SHIFT 1
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS1 0x01
+#define TPS65917_NSLEEP_SMPS_ASSIGN_SMPS1_SHIFT 0
+
+/* Bit definitions for NSLEEP_LDO_ASSIGN1 */
+#define TPS65917_NSLEEP_LDO_ASSIGN1_LDO4 0x80
+#define TPS65917_NSLEEP_LDO_ASSIGN1_LDO4_SHIFT 7
+#define TPS65917_NSLEEP_LDO_ASSIGN1_LDO2 0x02
+#define TPS65917_NSLEEP_LDO_ASSIGN1_LDO2_SHIFT 1
+#define TPS65917_NSLEEP_LDO_ASSIGN1_LDO1 0x01
+#define TPS65917_NSLEEP_LDO_ASSIGN1_LDO1_SHIFT 0
+
+/* Bit definitions for NSLEEP_LDO_ASSIGN2 */
+#define TPS65917_NSLEEP_LDO_ASSIGN2_LDO3 0x04
+#define TPS65917_NSLEEP_LDO_ASSIGN2_LDO3_SHIFT 2
+#define TPS65917_NSLEEP_LDO_ASSIGN2_LDO5 0x02
+#define TPS65917_NSLEEP_LDO_ASSIGN2_LDO5_SHIFT 1
+
+/* Bit definitions for ENABLE1_RES_ASSIGN */
+#define TPS65917_ENABLE1_RES_ASSIGN_PLLEN 0x8
+#define TPS65917_ENABLE1_RES_ASSIGN_PLLEN_SHIFT 3
+#define TPS65917_ENABLE1_RES_ASSIGN_REGEN3 0x04
+#define TPS65917_ENABLE1_RES_ASSIGN_REGEN3_SHIFT 2
+#define TPS65917_ENABLE1_RES_ASSIGN_REGEN2 0x02
+#define TPS65917_ENABLE1_RES_ASSIGN_REGEN2_SHIFT 1
+#define TPS65917_ENABLE1_RES_ASSIGN_REGEN1 0x01
+#define TPS65917_ENABLE1_RES_ASSIGN_REGEN1_SHIFT 0
+
+/* Bit definitions for ENABLE1_SMPS_ASSIGN */
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS5 0x40
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS5_SHIFT 6
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS4 0x10
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS4_SHIFT 4
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS3 0x08
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS3_SHIFT 3
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS2 0x02
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS2_SHIFT 1
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS1 0x01
+#define TPS65917_ENABLE1_SMPS_ASSIGN_SMPS1_SHIFT 0
+
+/* Bit definitions for ENABLE1_LDO_ASSIGN1 */
+#define TPS65917_ENABLE1_LDO_ASSIGN1_LDO4 0x80
+#define TPS65917_ENABLE1_LDO_ASSIGN1_LDO4_SHIFT 7
+#define TPS65917_ENABLE1_LDO_ASSIGN1_LDO2 0x02
+#define TPS65917_ENABLE1_LDO_ASSIGN1_LDO2_SHIFT 1
+#define TPS65917_ENABLE1_LDO_ASSIGN1_LDO1 0x01
+#define TPS65917_ENABLE1_LDO_ASSIGN1_LDO1_SHIFT 0
+
+/* Bit definitions for ENABLE1_LDO_ASSIGN2 */
+#define TPS65917_ENABLE1_LDO_ASSIGN2_LDO3 0x04
+#define TPS65917_ENABLE1_LDO_ASSIGN2_LDO3_SHIFT 2
+#define TPS65917_ENABLE1_LDO_ASSIGN2_LDO5 0x02
+#define TPS65917_ENABLE1_LDO_ASSIGN2_LDO5_SHIFT 1
+
+/* Bit definitions for ENABLE2_RES_ASSIGN */
+#define TPS65917_ENABLE2_RES_ASSIGN_PLLEN 0x08
+#define TPS65917_ENABLE2_RES_ASSIGN_PLLEN_SHIFT 3
+#define TPS65917_ENABLE2_RES_ASSIGN_REGEN3 0x04
+#define TPS65917_ENABLE2_RES_ASSIGN_REGEN3_SHIFT 2
+#define TPS65917_ENABLE2_RES_ASSIGN_REGEN2 0x02
+#define TPS65917_ENABLE2_RES_ASSIGN_REGEN2_SHIFT 1
+#define TPS65917_ENABLE2_RES_ASSIGN_REGEN1 0x01
+#define TPS65917_ENABLE2_RES_ASSIGN_REGEN1_SHIFT 0
+
+/* Bit definitions for ENABLE2_SMPS_ASSIGN */
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS5 0x40
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS5_SHIFT 6
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS4 0x10
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS4_SHIFT 4
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS3 0x08
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS3_SHIFT 3
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS2 0x02
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS2_SHIFT 1
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS1 0x01
+#define TPS65917_ENABLE2_SMPS_ASSIGN_SMPS1_SHIFT 0
+
+/* Bit definitions for ENABLE2_LDO_ASSIGN1 */
+#define TPS65917_ENABLE2_LDO_ASSIGN1_LDO4 0x80
+#define TPS65917_ENABLE2_LDO_ASSIGN1_LDO4_SHIFT 7
+#define TPS65917_ENABLE2_LDO_ASSIGN1_LDO2 0x02
+#define TPS65917_ENABLE2_LDO_ASSIGN1_LDO2_SHIFT 1
+#define TPS65917_ENABLE2_LDO_ASSIGN1_LDO1 0x01
+#define TPS65917_ENABLE2_LDO_ASSIGN1_LDO1_SHIFT 0
+
+/* Bit definitions for ENABLE2_LDO_ASSIGN2 */
+#define TPS65917_ENABLE2_LDO_ASSIGN2_LDO3 0x04
+#define TPS65917_ENABLE2_LDO_ASSIGN2_LDO3_SHIFT 2
+#define TPS65917_ENABLE2_LDO_ASSIGN2_LDO5 0x02
+#define TPS65917_ENABLE2_LDO_ASSIGN2_LDO5_SHIFT 1
+
+/* Bit definitions for REGEN3_CTRL */
+#define TPS65917_REGEN3_CTRL_STATUS 0x10
+#define TPS65917_REGEN3_CTRL_STATUS_SHIFT 4
+#define TPS65917_REGEN3_CTRL_MODE_SLEEP 0x04
+#define TPS65917_REGEN3_CTRL_MODE_SLEEP_SHIFT 2
+#define TPS65917_REGEN3_CTRL_MODE_ACTIVE 0x01
+#define TPS65917_REGEN3_CTRL_MODE_ACTIVE_SHIFT 0
+
+/* Registers for function PAD_CONTROL */
+#define TPS65917_OD_OUTPUT_CTRL2 0x2
+#define TPS65917_PU_PD_INPUT_CTRL1 0x4
+#define TPS65917_PU_PD_INPUT_CTRL2 0x5
+#define TPS65917_PU_PD_INPUT_CTRL3 0x6
+#define TPS65917_OD_OUTPUT_CTRL 0x8
+#define TPS65917_POLARITY_CTRL 0x9
+#define TPS65917_PRIMARY_SECONDARY_PAD1 0xA
+#define TPS65917_PRIMARY_SECONDARY_PAD2 0xB
+#define TPS65917_I2C_SPI 0xC
+#define TPS65917_PU_PD_INPUT_CTRL4 0xD
+
+/* Bit definitions for PU_PD_INPUT_CTRL1 */
+#define TPS65917_PU_PD_INPUT_CTRL1_RESET_IN_PD 0x40
+#define TPS65917_PU_PD_INPUT_CTRL1_RESET_IN_PD_SHIFT 6
+#define TPS65917_PU_PD_INPUT_CTRL1_PWRDOWN_PD 0x04
+#define TPS65917_PU_PD_INPUT_CTRL1_PWRDOWN_PD_SHIFT 2
+#define TPS65917_PU_PD_INPUT_CTRL1_NRESWARM_PD 0x1
+#define TPS65917_PU_PD_INPUT_CTRL1_NRESWARM_PD_SHIFT 0
+
+/* Bit definitions for PU_PD_INPUT_CTRL2 */
+#define TPS65917_PU_PD_INPUT_CTRL2_ENABLE2_PD 0x10
+#define TPS65917_PU_PD_INPUT_CTRL2_ENABLE2_PD_SHIFT 4
+#define TPS65917_PU_PD_INPUT_CTRL2_ENABLE1_PU 0x08
+#define TPS65917_PU_PD_INPUT_CTRL2_ENABLE1_PU_SHIFT 3
+#define TPS65917_PU_PD_INPUT_CTRL2_ENABLE1_PD 0x04
+#define TPS65917_PU_PD_INPUT_CTRL2_ENABLE1_PD_SHIFT 2
+#define TPS65917_PU_PD_INPUT_CTRL2_NSLEEP_PU 0x02
+#define TPS65917_PU_PD_INPUT_CTRL2_NSLEEP_PU_SHIFT 1
+#define TPS65917_PU_PD_INPUT_CTRL2_NSLEEP_PD 0x01
+#define TPS65917_PU_PD_INPUT_CTRL2_NSLEEP_PD_SHIFT 0
+
+/* Bit definitions for PU_PD_INPUT_CTRL3 */
+#define TPS65917_PU_PD_INPUT_CTRL3_SYNCDCDC_PD 0x40
+#define TPS65917_PU_PD_INPUT_CTRL3_SYNCDCDC_PD_SHIFT 6
+#define TPS65917_PU_PD_INPUT_CTRL3_POWERHOLD_PD 0x04
+#define TPS65917_PU_PD_INPUT_CTRL3_POWERHOLD_PD_SHIFT 2
+
+/* Bit definitions for OD_OUTPUT_CTRL */
+#define TPS65917_OD_OUTPUT_CTRL_INT_OD 0x08
+#define TPS65917_OD_OUTPUT_CTRL_INT_OD_SHIFT 3
+
+/* Bit definitions for POLARITY_CTRL */
+#define TPS65917_POLARITY_CTRL_INT_POLARITY 0x80
+#define TPS65917_POLARITY_CTRL_INT_POLARITY_SHIFT 7
+#define TPS65917_POLARITY_CTRL_GPIO_6_POLARITY 0x40
+#define TPS65917_POLARITY_CTRL_GPIO_6_POLARITY_SHIFT 6
+#define TPS65917_POLARITY_CTRL_GPIO_5_POLARITY 0x20
+#define TPS65917_POLARITY_CTRL_GPIO_5_POLARITY_SHIFT 5
+#define TPS65917_POLARITY_CTRL_GPIO_4_POLARITY 0x10
+#define TPS65917_POLARITY_CTRL_GPIO_4_POLARITY_SHIFT 4
+#define TPS65917_POLARITY_CTRL_GPIO_3_POLARITY 0x08
+#define TPS65917_POLARITY_CTRL_GPIO_3_POLARITY_SHIFT 3
+#define TPS65917_POLARITY_CTRL_GPIO_2_POLARITY 0x04
+#define TPS65917_POLARITY_CTRL_GPIO_2_POLARITY_SHIFT 2
+#define TPS65917_POLARITY_CTRL_GPIO_1_POLARITY 0x02
+#define TPS65917_POLARITY_CTRL_GPIO_1_POLARITY_SHIFT 1
+#define TPS65917_POLARITY_CTRL_GPIO_0_POLARITY 0x01
+#define TPS65917_POLARITY_CTRL_GPIO_0_POLARITY_SHIFT 0
+
+/* Bit definitions for PRIMARY_SECONDARY_PAD1 */
+#define TPS65917_PRIMARY_SECONDARY_PAD1_GPIO_3 0xC0
+#define TPS65917_PRIMARY_SECONDARY_PAD1_GPIO_3_SHIFT 6
+#define TPS65917_PRIMARY_SECONDARY_PAD1_GPIO_2 0x30
+#define TPS65917_PRIMARY_SECONDARY_PAD1_GPIO_2_SHIFT 4
+#define TPS65917_PRIMARY_SECONDARY_GPIO_1 0xC
+#define TPS65917_PRIMARY_SECONDARY_GPIO_1_SHIFT 2
+#define TPS65917_PRIMARY_SECONDARY_PAD1_GPIO_0 0x03
+#define TPS65917_PRIMARY_SECONDARY_PAD1_GPIO_0_SHIFT 0
+
+/* Bit definitions for PRIMARY_SECONDARY_PAD2 */
+#define TPS65917_PRIMARY_SECONDARY_PAD2_SYNCCLKOUT_MASK 0x40
+#define TPS65917_PRIMARY_SECONDARY_PAD2_SYNCCLKOUT_SHIFT 6
+#define TPS65917_PRIMARY_SECONDARY_PAD2_GPIO_6 0x30
+#define TPS65917_PRIMARY_SECONDARY_PAD2_GPIO_6_SHIFT 4
+#define TPS65917_PRIMARY_SECONDARY_PAD2_GPIO_5 0xC
+#define TPS65917_PRIMARY_SECONDARY_PAD2_GPIO_5_SHIFT 2
+#define TPS65917_PRIMARY_SECONDARY_PAD2_GPIO_4 0x3
+#define TPS65917_PRIMARY_SECONDARY_PAD2_GPIO_4_SHIFT 0
+
+/* Bit definitions for I2C_SPI */
+#define TPS65917_I2C_SPI_I2C2OTP_EN 0x80
+#define TPS65917_I2C_SPI_I2C2OTP_EN_SHIFT 7
+#define TPS65917_I2C_SPI_I2C2OTP_PAGESEL 0x40
+#define TPS65917_I2C_SPI_I2C2OTP_PAGESEL_SHIFT 6
+#define TPS65917_I2C_SPI_ID_I2C2 0x20
+#define TPS65917_I2C_SPI_ID_I2C2_SHIFT 5
+#define TPS65917_I2C_SPI_I2C_SPI 0x10
+#define TPS65917_I2C_SPI_I2C_SPI_SHIFT 4
+#define TPS65917_I2C_SPI_ID_I2C1_MASK 0x0f
+#define TPS65917_I2C_SPI_ID_I2C1_SHIFT 0
+
+/* Bit definitions for PU_PD_INPUT_CTRL4 */
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS2_DAT_PD 0x40
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS2_DAT_PD_SHIFT 6
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS2_CLK_PD 0x10
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS2_CLK_PD_SHIFT 4
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS1_DAT_PD 0x04
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS1_DAT_PD_SHIFT 2
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS1_CLK_PD 0x01
+#define TPS65917_PU_PD_INPUT_CTRL4_DVFS1_CLK_PD_SHIFT 0
+
+/* Bit definitions for PRIMARY_SECONDARY_PAD3 */
+#define TPS65917_PRIMARY_SECONDARY_PAD3_DVFS2 0x02
+#define TPS65917_PRIMARY_SECONDARY_PAD3_DVFS2_SHIFT 1
+#define TPS65917_PRIMARY_SECONDARY_PAD3_DVFS1 0x01
+#define TPS65917_PRIMARY_SECONDARY_PAD3_DVFS1_SHIFT 0
+
+/* Registers for function INTERRUPT */
+#define TPS65917_INT1_STATUS 0x0
+#define TPS65917_INT1_MASK 0x1
+#define TPS65917_INT1_LINE_STATE 0x2
+#define TPS65917_INT2_STATUS 0x5
+#define TPS65917_INT2_MASK 0x6
+#define TPS65917_INT2_LINE_STATE 0x7
+#define TPS65917_INT3_STATUS 0xA
+#define TPS65917_INT3_MASK 0xB
+#define TPS65917_INT3_LINE_STATE 0xC
+#define TPS65917_INT4_STATUS 0xF
+#define TPS65917_INT4_MASK 0x10
+#define TPS65917_INT4_LINE_STATE 0x11
+#define TPS65917_INT4_EDGE_DETECT1 0x12
+#define TPS65917_INT4_EDGE_DETECT2 0x13
+#define TPS65917_INT_CTRL 0x14
+
+/* Bit definitions for INT1_STATUS */
+#define TPS65917_INT1_STATUS_VSYS_MON 0x40
+#define TPS65917_INT1_STATUS_VSYS_MON_SHIFT 6
+#define TPS65917_INT1_STATUS_HOTDIE 0x20
+#define TPS65917_INT1_STATUS_HOTDIE_SHIFT 5
+#define TPS65917_INT1_STATUS_PWRDOWN 0x10
+#define TPS65917_INT1_STATUS_PWRDOWN_SHIFT 4
+#define TPS65917_INT1_STATUS_LONG_PRESS_KEY 0x04
+#define TPS65917_INT1_STATUS_LONG_PRESS_KEY_SHIFT 2
+#define TPS65917_INT1_STATUS_PWRON 0x02
+#define TPS65917_INT1_STATUS_PWRON_SHIFT 1
+
+/* Bit definitions for INT1_MASK */
+#define TPS65917_INT1_MASK_VSYS_MON 0x40
+#define TPS65917_INT1_MASK_VSYS_MON_SHIFT 6
+#define TPS65917_INT1_MASK_HOTDIE 0x20
+#define TPS65917_INT1_MASK_HOTDIE_SHIFT 5
+#define TPS65917_INT1_MASK_PWRDOWN 0x10
+#define TPS65917_INT1_MASK_PWRDOWN_SHIFT 4
+#define TPS65917_INT1_MASK_LONG_PRESS_KEY 0x04
+#define TPS65917_INT1_MASK_LONG_PRESS_KEY_SHIFT 2
+#define TPS65917_INT1_MASK_PWRON 0x02
+#define TPS65917_INT1_MASK_PWRON_SHIFT 1
+
+/* Bit definitions for INT1_LINE_STATE */
+#define TPS65917_INT1_LINE_STATE_VSYS_MON 0x40
+#define TPS65917_INT1_LINE_STATE_VSYS_MON_SHIFT 6
+#define TPS65917_INT1_LINE_STATE_HOTDIE 0x20
+#define TPS65917_INT1_LINE_STATE_HOTDIE_SHIFT 5
+#define TPS65917_INT1_LINE_STATE_PWRDOWN 0x10
+#define TPS65917_INT1_LINE_STATE_PWRDOWN_SHIFT 4
+#define TPS65917_INT1_LINE_STATE_LONG_PRESS_KEY 0x04
+#define TPS65917_INT1_LINE_STATE_LONG_PRESS_KEY_SHIFT 2
+#define TPS65917_INT1_LINE_STATE_PWRON 0x02
+#define TPS65917_INT1_LINE_STATE_PWRON_SHIFT 1
+
+/* Bit definitions for INT2_STATUS */
+#define TPS65917_INT2_STATUS_SHORT 0x40
+#define TPS65917_INT2_STATUS_SHORT_SHIFT 6
+#define TPS65917_INT2_STATUS_FSD 0x20
+#define TPS65917_INT2_STATUS_FSD_SHIFT 5
+#define TPS65917_INT2_STATUS_RESET_IN 0x10
+#define TPS65917_INT2_STATUS_RESET_IN_SHIFT 4
+#define TPS65917_INT2_STATUS_WDT 0x04
+#define TPS65917_INT2_STATUS_WDT_SHIFT 2
+#define TPS65917_INT2_STATUS_OTP_ERROR 0x02
+#define TPS65917_INT2_STATUS_OTP_ERROR_SHIFT 1
+
+/* Bit definitions for INT2_MASK */
+#define TPS65917_INT2_MASK_SHORT 0x40
+#define TPS65917_INT2_MASK_SHORT_SHIFT 6
+#define TPS65917_INT2_MASK_FSD 0x20
+#define TPS65917_INT2_MASK_FSD_SHIFT 5
+#define TPS65917_INT2_MASK_RESET_IN 0x10
+#define TPS65917_INT2_MASK_RESET_IN_SHIFT 4
+#define TPS65917_INT2_MASK_WDT 0x04
+#define TPS65917_INT2_MASK_WDT_SHIFT 2
+#define TPS65917_INT2_MASK_OTP_ERROR_TIMER 0x02
+#define TPS65917_INT2_MASK_OTP_ERROR_SHIFT 1
+
+/* Bit definitions for INT2_LINE_STATE */
+#define TPS65917_INT2_LINE_STATE_SHORT 0x40
+#define TPS65917_INT2_LINE_STATE_SHORT_SHIFT 6
+#define TPS65917_INT2_LINE_STATE_FSD 0x20
+#define TPS65917_INT2_LINE_STATE_FSD_SHIFT 5
+#define TPS65917_INT2_LINE_STATE_RESET_IN 0x10
+#define TPS65917_INT2_LINE_STATE_RESET_IN_SHIFT 4
+#define TPS65917_INT2_LINE_STATE_WDT 0x04
+#define TPS65917_INT2_LINE_STATE_WDT_SHIFT 2
+#define TPS65917_INT2_LINE_STATE_OTP_ERROR 0x02
+#define TPS65917_INT2_LINE_STATE_OTP_ERROR_SHIFT 1
+
+/* Bit definitions for INT3_STATUS */
+#define TPS65917_INT3_STATUS_VBUS 0x80
+#define TPS65917_INT3_STATUS_VBUS_SHIFT 7
+#define TPS65917_INT3_STATUS_GPADC_EOC_SW 0x04
+#define TPS65917_INT3_STATUS_GPADC_EOC_SW_SHIFT 2
+#define TPS65917_INT3_STATUS_GPADC_AUTO_1 0x02
+#define TPS65917_INT3_STATUS_GPADC_AUTO_1_SHIFT 1
+#define TPS65917_INT3_STATUS_GPADC_AUTO_0 0x01
+#define TPS65917_INT3_STATUS_GPADC_AUTO_0_SHIFT 0
+
+/* Bit definitions for INT3_MASK */
+#define TPS65917_INT3_MASK_VBUS 0x80
+#define TPS65917_INT3_MASK_VBUS_SHIFT 7
+#define TPS65917_INT3_MASK_GPADC_EOC_SW 0x04
+#define TPS65917_INT3_MASK_GPADC_EOC_SW_SHIFT 2
+#define TPS65917_INT3_MASK_GPADC_AUTO_1 0x02
+#define TPS65917_INT3_MASK_GPADC_AUTO_1_SHIFT 1
+#define TPS65917_INT3_MASK_GPADC_AUTO_0 0x01
+#define TPS65917_INT3_MASK_GPADC_AUTO_0_SHIFT 0
+
+/* Bit definitions for INT3_LINE_STATE */
+#define TPS65917_INT3_LINE_STATE_VBUS 0x80
+#define TPS65917_INT3_LINE_STATE_VBUS_SHIFT 7
+#define TPS65917_INT3_LINE_STATE_GPADC_EOC_SW 0x04
+#define TPS65917_INT3_LINE_STATE_GPADC_EOC_SW_SHIFT 2
+#define TPS65917_INT3_LINE_STATE_GPADC_AUTO_1 0x02
+#define TPS65917_INT3_LINE_STATE_GPADC_AUTO_1_SHIFT 1
+#define TPS65917_INT3_LINE_STATE_GPADC_AUTO_0 0x01
+#define TPS65917_INT3_LINE_STATE_GPADC_AUTO_0_SHIFT 0
+
+/* Bit definitions for INT4_STATUS */
+#define TPS65917_INT4_STATUS_GPIO_6 0x40
+#define TPS65917_INT4_STATUS_GPIO_6_SHIFT 6
+#define TPS65917_INT4_STATUS_GPIO_5 0x20
+#define TPS65917_INT4_STATUS_GPIO_5_SHIFT 5
+#define TPS65917_INT4_STATUS_GPIO_4 0x10
+#define TPS65917_INT4_STATUS_GPIO_4_SHIFT 4
+#define TPS65917_INT4_STATUS_GPIO_3 0x08
+#define TPS65917_INT4_STATUS_GPIO_3_SHIFT 3
+#define TPS65917_INT4_STATUS_GPIO_2 0x04
+#define TPS65917_INT4_STATUS_GPIO_2_SHIFT 2
+#define TPS65917_INT4_STATUS_GPIO_1 0x02
+#define TPS65917_INT4_STATUS_GPIO_1_SHIFT 1
+#define TPS65917_INT4_STATUS_GPIO_0 0x01
+#define TPS65917_INT4_STATUS_GPIO_0_SHIFT 0
+
+/* Bit definitions for INT4_MASK */
+#define TPS65917_INT4_MASK_GPIO_6 0x40
+#define TPS65917_INT4_MASK_GPIO_6_SHIFT 6
+#define TPS65917_INT4_MASK_GPIO_5 0x20
+#define TPS65917_INT4_MASK_GPIO_5_SHIFT 5
+#define TPS65917_INT4_MASK_GPIO_4 0x10
+#define TPS65917_INT4_MASK_GPIO_4_SHIFT 4
+#define TPS65917_INT4_MASK_GPIO_3 0x08
+#define TPS65917_INT4_MASK_GPIO_3_SHIFT 3
+#define TPS65917_INT4_MASK_GPIO_2 0x04
+#define TPS65917_INT4_MASK_GPIO_2_SHIFT 2
+#define TPS65917_INT4_MASK_GPIO_1 0x02
+#define TPS65917_INT4_MASK_GPIO_1_SHIFT 1
+#define TPS65917_INT4_MASK_GPIO_0 0x01
+#define TPS65917_INT4_MASK_GPIO_0_SHIFT 0
+
+/* Bit definitions for INT4_LINE_STATE */
+#define TPS65917_INT4_LINE_STATE_GPIO_6 0x40
+#define TPS65917_INT4_LINE_STATE_GPIO_6_SHIFT 6
+#define TPS65917_INT4_LINE_STATE_GPIO_5 0x20
+#define TPS65917_INT4_LINE_STATE_GPIO_5_SHIFT 5
+#define TPS65917_INT4_LINE_STATE_GPIO_4 0x10
+#define TPS65917_INT4_LINE_STATE_GPIO_4_SHIFT 4
+#define TPS65917_INT4_LINE_STATE_GPIO_3 0x08
+#define TPS65917_INT4_LINE_STATE_GPIO_3_SHIFT 3
+#define TPS65917_INT4_LINE_STATE_GPIO_2 0x04
+#define TPS65917_INT4_LINE_STATE_GPIO_2_SHIFT 2
+#define TPS65917_INT4_LINE_STATE_GPIO_1 0x02
+#define TPS65917_INT4_LINE_STATE_GPIO_1_SHIFT 1
+#define TPS65917_INT4_LINE_STATE_GPIO_0 0x01
+#define TPS65917_INT4_LINE_STATE_GPIO_0_SHIFT 0
+
+/* Bit definitions for INT4_EDGE_DETECT1 */
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_3_RISING 0x80
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_3_RISING_SHIFT 7
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_3_FALLING 0x40
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_3_FALLING_SHIFT 6
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_2_RISING 0x20
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_2_RISING_SHIFT 5
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_2_FALLING 0x10
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_2_FALLING_SHIFT 4
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_1_RISING 0x08
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_1_RISING_SHIFT 3
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_1_FALLING 0x04
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_1_FALLING_SHIFT 2
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_0_RISING 0x02
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_0_RISING_SHIFT 1
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_0_FALLING 0x01
+#define TPS65917_INT4_EDGE_DETECT1_GPIO_0_FALLING_SHIFT 0
+
+/* Bit definitions for INT4_EDGE_DETECT2 */
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_6_RISING 0x20
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_6_RISING_SHIFT 5
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_6_FALLING 0x10
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_6_FALLING_SHIFT 4
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_5_RISING 0x08
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_5_RISING_SHIFT 3
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_5_FALLING 0x04
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_5_FALLING_SHIFT 2
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_4_RISING 0x02
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_4_RISING_SHIFT 1
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_4_FALLING 0x01
+#define TPS65917_INT4_EDGE_DETECT2_GPIO_4_FALLING_SHIFT 0
+
+/* Bit definitions for INT_CTRL */
+#define TPS65917_INT_CTRL_INT_PENDING 0x04
+#define TPS65917_INT_CTRL_INT_PENDING_SHIFT 2
+#define TPS65917_INT_CTRL_INT_CLEAR 0x01
+#define TPS65917_INT_CTRL_INT_CLEAR_SHIFT 0
+
+
+/* Registers for function GPIO */
+#define TPS65917_GPIO_DATA_IN 0x0
+#define TPS65917_GPIO_DATA_DIR 0x1
+#define TPS65917_GPIO_DATA_OUT 0x2
+#define TPS65917_GPIO_DEBOUNCE_EN 0x3
+#define TPS65917_GPIO_CLEAR_DATA_OUT 0x4
+#define TPS65917_GPIO_SET_DATA_OUT 0x5
+#define TPS65917_PU_PD_GPIO_CTRL1 0x6
+#define TPS65917_PU_PD_GPIO_CTRL2 0x7
+#define TPS65917_OD_OUTPUT_GPIO_CTRL 0x8
+
+/* Bit definitions for GPIO_DATA_IN */
+#define TPS65917_GPIO_DATA_IN_GPIO_6_IN 0x40
+#define TPS65917_GPIO_DATA_IN_GPIO_6_IN_SHIFT 6
+#define TPS65917_GPIO_DATA_IN_GPIO_5_IN 0x20
+#define TPS65917_GPIO_DATA_IN_GPIO_5_IN_SHIFT 5
+#define TPS65917_GPIO_DATA_IN_GPIO_4_IN 0x10
+#define TPS65917_GPIO_DATA_IN_GPIO_4_IN_SHIFT 4
+#define TPS65917_GPIO_DATA_IN_GPIO_3_IN 0x08
+#define TPS65917_GPIO_DATA_IN_GPIO_3_IN_SHIFT 3
+#define TPS65917_GPIO_DATA_IN_GPIO_2_IN 0x04
+#define TPS65917_GPIO_DATA_IN_GPIO_2_IN_SHIFT 2
+#define TPS65917_GPIO_DATA_IN_GPIO_1_IN 0x02
+#define TPS65917_GPIO_DATA_IN_GPIO_1_IN_SHIFT 1
+#define TPS65917_GPIO_DATA_IN_GPIO_0_IN 0x01
+#define TPS65917_GPIO_DATA_IN_GPIO_0_IN_SHIFT 0
+
+/* Bit definitions for GPIO_DATA_DIR */
+#define TPS65917_GPIO_DATA_DIR_GPIO_6_DIR 0x40
+#define TPS65917_GPIO_DATA_DIR_GPIO_6_DIR_SHIFT 6
+#define TPS65917_GPIO_DATA_DIR_GPIO_5_DIR 0x20
+#define TPS65917_GPIO_DATA_DIR_GPIO_5_DIR_SHIFT 5
+#define TPS65917_GPIO_DATA_DIR_GPIO_4_DIR 0x10
+#define TPS65917_GPIO_DATA_DIR_GPIO_4_DIR_SHIFT 4
+#define TPS65917_GPIO_DATA_DIR_GPIO_3_DIR 0x08
+#define TPS65917_GPIO_DATA_DIR_GPIO_3_DIR_SHIFT 3
+#define TPS65917_GPIO_DATA_DIR_GPIO_2_DIR 0x04
+#define TPS65917_GPIO_DATA_DIR_GPIO_2_DIR_SHIFT 2
+#define TPS65917_GPIO_DATA_DIR_GPIO_1_DIR 0x02
+#define TPS65917_GPIO_DATA_DIR_GPIO_1_DIR_SHIFT 1
+#define TPS65917_GPIO_DATA_DIR_GPIO_0_DIR 0x01
+#define TPS65917_GPIO_DATA_DIR_GPIO_0_DIR_SHIFT 0
+
+/* Bit definitions for GPIO_DATA_OUT */
+#define TPS65917_GPIO_DATA_OUT_GPIO_6_OUT 0x40
+#define TPS65917_GPIO_DATA_OUT_GPIO_6_OUT_SHIFT 6
+#define TPS65917_GPIO_DATA_OUT_GPIO_5_OUT 0x20
+#define TPS65917_GPIO_DATA_OUT_GPIO_5_OUT_SHIFT 5
+#define TPS65917_GPIO_DATA_OUT_GPIO_4_OUT 0x10
+#define TPS65917_GPIO_DATA_OUT_GPIO_4_OUT_SHIFT 4
+#define TPS65917_GPIO_DATA_OUT_GPIO_3_OUT 0x08
+#define TPS65917_GPIO_DATA_OUT_GPIO_3_OUT_SHIFT 3
+#define TPS65917_GPIO_DATA_OUT_GPIO_2_OUT 0x04
+#define TPS65917_GPIO_DATA_OUT_GPIO_2_OUT_SHIFT 2
+#define TPS65917_GPIO_DATA_OUT_GPIO_1_OUT 0x02
+#define TPS65917_GPIO_DATA_OUT_GPIO_1_OUT_SHIFT 1
+#define TPS65917_GPIO_DATA_OUT_GPIO_0_OUT 0x01
+#define TPS65917_GPIO_DATA_OUT_GPIO_0_OUT_SHIFT 0
+
+/* Bit definitions for GPIO_DEBOUNCE_EN */
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_6_DEBOUNCE_EN 0x40
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_6_DEBOUNCE_EN_SHIFT 6
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_5_DEBOUNCE_EN 0x20
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_5_DEBOUNCE_EN_SHIFT 5
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_4_DEBOUNCE_EN 0x10
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_4_DEBOUNCE_EN_SHIFT 4
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_3_DEBOUNCE_EN 0x08
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_3_DEBOUNCE_EN_SHIFT 3
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_2_DEBOUNCE_EN 0x04
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_2_DEBOUNCE_EN_SHIFT 2
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_1_DEBOUNCE_EN 0x02
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_1_DEBOUNCE_EN_SHIFT 1
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_0_DEBOUNCE_EN 0x01
+#define TPS65917_GPIO_DEBOUNCE_EN_GPIO_0_DEBOUNCE_EN_SHIFT 0
+
+/* Bit definitions for GPIO_CLEAR_DATA_OUT */
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_6_CLEAR_DATA_OUT 0x40
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_6_CLEAR_DATA_OUT_SHIFT 6
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_5_CLEAR_DATA_OUT 0x20
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_5_CLEAR_DATA_OUT_SHIFT 5
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_4_CLEAR_DATA_OUT 0x10
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_4_CLEAR_DATA_OUT_SHIFT 4
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_3_CLEAR_DATA_OUT 0x08
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_3_CLEAR_DATA_OUT_SHIFT 3
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_2_CLEAR_DATA_OUT 0x04
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_2_CLEAR_DATA_OUT_SHIFT 2
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_1_CLEAR_DATA_OUT 0x02
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_1_CLEAR_DATA_OUT_SHIFT 1
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_0_CLEAR_DATA_OUT 0x01
+#define TPS65917_GPIO_CLEAR_DATA_OUT_GPIO_0_CLEAR_DATA_OUT_SHIFT 0
+
+/* Bit definitions for GPIO_SET_DATA_OUT */
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_6_SET_DATA_OUT 0x40
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_6_SET_DATA_OUT_SHIFT 6
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_5_SET_DATA_OUT 0x20
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_5_SET_DATA_OUT_SHIFT 5
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_4_SET_DATA_OUT 0x10
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_4_SET_DATA_OUT_SHIFT 4
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_3_SET_DATA_OUT 0x08
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_3_SET_DATA_OUT_SHIFT 3
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_2_SET_DATA_OUT 0x04
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_2_SET_DATA_OUT_SHIFT 2
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_1_SET_DATA_OUT 0x02
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_1_SET_DATA_OUT_SHIFT 1
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_0_SET_DATA_OUT 0x01
+#define TPS65917_GPIO_SET_DATA_OUT_GPIO_0_SET_DATA_OUT_SHIFT 0
+
+/* Bit definitions for PU_PD_GPIO_CTRL1 */
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_3_PD 0x40
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_3_PD_SHIFT 6
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_2_PU 0x20
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_2_PU_SHIFT 5
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_2_PD 0x10
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_2_PD_SHIFT 4
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_1_PD 0x04
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_1_PD_SHIFT 2
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_0_PD 0x01
+#define TPS65917_PU_PD_GPIO_CTRL1_GPIO_0_PD_SHIFT 0
+
+/* Bit definitions for PU_PD_GPIO_CTRL2 */
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_6_PD 0x10
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_6_PD_SHIFT 4
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_5_PD 0x04
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_5_PD_SHIFT 2
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_4_PU 0x02
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_4_PU_SHIFT 1
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_4_PD 0x01
+#define TPS65917_PU_PD_GPIO_CTRL2_GPIO_4_PD_SHIFT 0
+
+/* Bit definitions for OD_OUTPUT_GPIO_CTRL */
+#define TPS65917_OD_OUTPUT_GPIO_CTRL_GPIO_4_OD 0x10
+#define TPS65917_OD_OUTPUT_GPIO_CTRL_GPIO_4_OD_SHIFT 4
+#define TPS65917_OD_OUTPUT_GPIO_CTRL_GPIO_2_OD 0x04
+#define TPS65917_OD_OUTPUT_GPIO_CTRL_GPIO_2_OD_SHIFT 2
+
+/* Registers for function GPADC */
+#define TPS65917_GPADC_CTRL1 0x0
+#define TPS65917_GPADC_AUTO_CTRL 0x3
+#define TPS65917_GPADC_STATUS 0x4
+#define TPS65917_GPADC_AUTO_SELECT 0x8
+#define TPS65917_GPADC_AUTO_CONV0_LSB 0x9
+#define TPS65917_GPADC_AUTO_CONV0_MSB 0xA
+#define TPS65917_GPADC_AUTO_CONV1_LSB 0xB
+#define TPS65917_GPADC_AUTO_CONV1_MSB 0xC
+#define TPS65917_GPADC_SW_SELECT 0xD
+#define TPS65917_GPADC_SW_CONV0_LSB 0xE
+#define TPS65917_GPADC_SW_CONV0_MSB 0xF
+#define TPS65917_GPADC_THRES_CONV0_LSB 0x10
+#define TPS65917_GPADC_THRES_CONV0_MSB 0x11
+#define TPS65917_GPADC_THRES_CONV1_LSB 0x12
+#define TPS65917_GPADC_THRES_CONV1_MSB 0x13
+#define TPS65917_GPADC_SMPS_ILMONITOR_EN 0x14
+#define TPS65917_GPADC_SMPS_VSEL_MONITORING 0x15
+
+#define TPS65917_GPADC_TRIM1 0x0
+#define TPS65917_GPADC_TRIM2 0x1
+#define TPS65917_GPADC_TRIM3 0x2
+#define TPS65917_GPADC_TRIM4 0x3
+#define TPS65917_GPADC_TRIM5 0x4
+#define TPS65917_GPADC_TRIM6 0x5
+#define TPS65917_GPADC_TRIM7 0x6
+#define TPS65917_GPADC_TRIM8 0x7
+#define TPS65917_GPADC_TRIM9 0x8
+#define TPS65917_GPADC_TRIM10 0x9
+#define TPS65917_GPADC_TRIM11 0xA
+#define TPS65917_GPADC_TRIM12 0xB
+#define TPS65917_GPADC_TRIM13 0xC
+#define TPS65917_GPADC_TRIM14 0xD
+#define TPS65917_GPADC_TRIM15 0xE
+#define TPS65917_GPADC_TRIM16 0xF
+
+static inline int tps65917_read(struct tps65917 *tps65917, unsigned int base,
+ unsigned int reg, unsigned int *val)
+{
+ unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
+ int slave_id = TPS65917_BASE_TO_SLAVE(base);
+
+ return regmap_read(tps65917->regmap[slave_id], addr, val);
+}
+
+static inline int tps65917_write(struct tps65917 *tps65917, unsigned int base,
+ unsigned int reg, unsigned int value)
+{
+ unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
+ int slave_id = TPS65917_BASE_TO_SLAVE(base);
+
+ return regmap_write(tps65917->regmap[slave_id], addr, value);
+}
+
+static inline int tps65917_bulk_write(struct tps65917 *tps65917,
+ unsigned int base,
+ unsigned int reg, const void *val,
+ size_t val_count)
+{
+ unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
+ int slave_id = TPS65917_BASE_TO_SLAVE(base);
+
+ return regmap_bulk_write(tps65917->regmap[slave_id], addr,
+ val, val_count);
+}
+
+static inline int tps65917_bulk_read(struct tps65917 *tps65917,
+ unsigned int base,
+ unsigned int reg, void *val,
+ size_t val_count)
+{
+ unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
+ int slave_id = TPS65917_BASE_TO_SLAVE(base);
+
+ return regmap_bulk_read(tps65917->regmap[slave_id], addr,
+ val, val_count);
+}
+
+static inline int tps65917_update_bits(struct tps65917 *tps65917,
+ unsigned int base, unsigned int reg,
+ unsigned int mask, unsigned int val)
+{
+ unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
+ int slave_id = TPS65917_BASE_TO_SLAVE(base);
+
+ return regmap_update_bits(tps65917->regmap[slave_id], addr, mask, val);
+}
+
+static inline int tps65917_irq_get_virq(struct tps65917 *tps65917, int irq)
+{
+ return regmap_irq_get_virq(tps65917->irq_data, irq);
+}
+
+int tps65917_ext_control_req_config(struct tps65917 *tps65917,
+ enum tps65917_external_requestor_id ext_control_req_id,
+ int ext_ctrl, bool enable);
+
+#endif /* __LINUX_MFD_TPS65917_H */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 4/4] regulator: tps65917: Add Regulator driver for TPS65917 PMIC
2014-05-20 9:11 [PATCH v2 0/4] tps65917: Drivers for TPS65917 PMIC Keerthy
` (2 preceding siblings ...)
2014-05-20 9:11 ` [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC Keerthy
@ 2014-05-20 9:11 ` Keerthy
3 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 9:11 UTC (permalink / raw)
To: devicetree
Cc: robh+dt, mark.rutland, sameo, grant.likely, ian, linux-doc,
linux-kernel, broonie, swarren, lee.jones, linux-omap, Keerthy
This patch adds support for TPS65917 PMIC regulators.
The regulators set consists of 5 SMPSs and 5 LDOs. The output
voltages are configurable and are meant to supply power to the
main processor and other components.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Comments fixed in V2:
Used the standard functions in helpers.c
Added a NULL entry in of_tps65917_match_tbl table.
Used linear ranges instead of open coded function.
drivers/regulator/Kconfig | 12 +
drivers/regulator/Makefile | 1 +
drivers/regulator/tps65917-regulator.c | 810 ++++++++++++++++++++++++++++++++
3 files changed, 823 insertions(+)
create mode 100644 drivers/regulator/tps65917-regulator.c
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 903eb37..6455a6e 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -581,6 +581,18 @@ config REGULATOR_TPS65912
help
This driver supports TPS65912 voltage regulator chip.
+config REGULATOR_TPS65917
+ tristate "TI TPS65917 PMIC Regulators"
+ depends on MFD_TPS65917
+ help
+ If you wish to control the regulators on the TPS65917 series of
+ chips say Y here. This will enable support for all the software
+ controllable SMPS/LDO regulators.
+
+ The regulators available on TPS65917 series chips vary depending
+ on the muxing. This is handled automatically in the driver by
+ reading the mux info from OTP.
+
config REGULATOR_TPS80031
tristate "TI TPS80031/TPS80032 power regualtor driver"
depends on MFD_TPS80031
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 12ef277..115ee53 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -76,6 +76,7 @@ obj-$(CONFIG_REGULATOR_TPS6524X) += tps6524x-regulator.o
obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o
obj-$(CONFIG_REGULATOR_TPS65910) += tps65910-regulator.o
obj-$(CONFIG_REGULATOR_TPS65912) += tps65912-regulator.o
+obj-$(CONFIG_REGULATOR_TPS65917) += tps65917-regulator.o
obj-$(CONFIG_REGULATOR_TPS80031) += tps80031-regulator.o
obj-$(CONFIG_REGULATOR_TWL4030) += twl-regulator.o
obj-$(CONFIG_REGULATOR_VEXPRESS) += vexpress.o
diff --git a/drivers/regulator/tps65917-regulator.c b/drivers/regulator/tps65917-regulator.c
new file mode 100644
index 0000000..929bd50
--- /dev/null
+++ b/drivers/regulator/tps65917-regulator.c
@@ -0,0 +1,810 @@
+/*
+ * Driver for Regulator part of TPS65917 PMIC
+ *
+ * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed "as is" WITHOUT ANY WARRANTY of any
+ * kind, whether expressed or implied; without even the implied warranty
+ * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License version 2 for more details.
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/err.h>
+#include <linux/platform_device.h>
+#include <linux/regulator/driver.h>
+#include <linux/regulator/machine.h>
+#include <linux/slab.h>
+#include <linux/regmap.h>
+#include <linux/mfd/tps65917.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/regulator/of_regulator.h>
+
+struct regs_info {
+ char *name;
+ char *sname;
+ u8 vsel_addr;
+ u8 ctrl_addr;
+ int sleep_id;
+};
+
+static const struct regulator_linear_range smps_low_ranges[] = {
+ REGULATOR_LINEAR_RANGE(500000, 0x1, 0x6, 0),
+ REGULATOR_LINEAR_RANGE(510000, 0x7, 0x79, 10000),
+ REGULATOR_LINEAR_RANGE(1650000, 0x7A, 0x7f, 0),
+};
+
+static const struct regulator_linear_range smps_high_ranges[] = {
+ REGULATOR_LINEAR_RANGE(1000000, 0x1, 0x6, 0),
+ REGULATOR_LINEAR_RANGE(1020000, 0x7, 0x79, 20000),
+ REGULATOR_LINEAR_RANGE(3300000, 0x7A, 0x7f, 0),
+};
+
+static const struct regs_info tps65917_regs_info[] = {
+ {
+ .name = "SMPS1",
+ .sname = "smps1-in",
+ .vsel_addr = TPS65917_SMPS1_VOLTAGE,
+ .ctrl_addr = TPS65917_SMPS1_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_SMPS1,
+ },
+ {
+ .name = "SMPS2",
+ .sname = "smps2-in",
+ .vsel_addr = TPS65917_SMPS2_VOLTAGE,
+ .ctrl_addr = TPS65917_SMPS2_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_SMPS2,
+ },
+ {
+ .name = "SMPS3",
+ .sname = "smps3-in",
+ .vsel_addr = TPS65917_SMPS3_VOLTAGE,
+ .ctrl_addr = TPS65917_SMPS3_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_SMPS3,
+ },
+ {
+ .name = "SMPS4",
+ .sname = "smps4-in",
+ .vsel_addr = TPS65917_SMPS4_VOLTAGE,
+ .ctrl_addr = TPS65917_SMPS4_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_SMPS4,
+ },
+ {
+ .name = "SMPS5",
+ .sname = "smps5-in",
+ .vsel_addr = TPS65917_SMPS5_VOLTAGE,
+ .ctrl_addr = TPS65917_SMPS5_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_SMPS5,
+ },
+ {
+ .name = "LDO1",
+ .sname = "ldo1-in",
+ .vsel_addr = TPS65917_LDO1_VOLTAGE,
+ .ctrl_addr = TPS65917_LDO1_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_LDO1,
+ },
+ {
+ .name = "LDO2",
+ .sname = "ldo2-in",
+ .vsel_addr = TPS65917_LDO2_VOLTAGE,
+ .ctrl_addr = TPS65917_LDO2_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_LDO2,
+ },
+ {
+ .name = "LDO3",
+ .sname = "ldo3-in",
+ .vsel_addr = TPS65917_LDO3_VOLTAGE,
+ .ctrl_addr = TPS65917_LDO3_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_LDO3,
+ },
+ {
+ .name = "LDO4",
+ .sname = "ldo4-in",
+ .vsel_addr = TPS65917_LDO4_VOLTAGE,
+ .ctrl_addr = TPS65917_LDO4_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_LDO4,
+ },
+ {
+ .name = "LDO5",
+ .sname = "ldo5-in",
+ .vsel_addr = TPS65917_LDO5_VOLTAGE,
+ .ctrl_addr = TPS65917_LDO5_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_LDO5,
+ },
+ {
+ .name = "REGEN1",
+ .ctrl_addr = TPS65917_REGEN1_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_REGEN1,
+ },
+ {
+ .name = "REGEN2",
+ .ctrl_addr = TPS65917_REGEN2_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_REGEN2,
+ },
+ {
+ .name = "REGEN3",
+ .ctrl_addr = TPS65917_REGEN3_CTRL,
+ .sleep_id = TPS65917_EXTERNAL_REQSTR_ID_REGEN3,
+ },
+};
+
+#define SMPS_CTRL_MODE_OFF 0x00
+#define SMPS_CTRL_MODE_ON 0x01
+#define SMPS_CTRL_MODE_ECO 0x02
+#define SMPS_CTRL_MODE_PWM 0x03
+
+#define TPS65917_SMPS_NUM_VOLTAGES 122
+#define TPS65917_LDO_NUM_VOLTAGES 50
+
+#define REGULATOR_SLAVE 0
+
+static int tps65917_smps_read(struct tps65917 *tps65917, unsigned int reg,
+ unsigned int *dest)
+{
+ unsigned int addr;
+
+ addr = TPS65917_BASE_TO_REG(TPS65917_SMPS_BASE, reg);
+
+ return regmap_read(tps65917->regmap[REGULATOR_SLAVE], addr, dest);
+}
+
+static int tps65917_smps_write(struct tps65917 *tps65917, unsigned int reg,
+ unsigned int value)
+{
+ unsigned int addr;
+
+ addr = TPS65917_BASE_TO_REG(TPS65917_SMPS_BASE, reg);
+
+ return regmap_write(tps65917->regmap[REGULATOR_SLAVE], addr, value);
+}
+
+static int tps65917_ldo_read(struct tps65917 *tps65917, unsigned int reg,
+ unsigned int *dest)
+{
+ unsigned int addr;
+
+ addr = TPS65917_BASE_TO_REG(TPS65917_LDO_BASE, reg);
+
+ return regmap_read(tps65917->regmap[REGULATOR_SLAVE], addr, dest);
+}
+
+static int tps65917_ldo_write(struct tps65917 *tps65917, unsigned int reg,
+ unsigned int value)
+{
+ unsigned int addr;
+
+ addr = TPS65917_BASE_TO_REG(TPS65917_LDO_BASE, reg);
+
+ return regmap_write(tps65917->regmap[REGULATOR_SLAVE], addr, value);
+}
+
+static int tps65917_set_mode_smps(struct regulator_dev *dev, unsigned int mode)
+{
+ struct tps65917_pmic *pmic = rdev_get_drvdata(dev);
+ int id = rdev_get_id(dev);
+ unsigned int reg;
+ bool rail_enable = true;
+
+ tps65917_smps_read(pmic->tps65917, tps65917_regs_info[id].ctrl_addr,
+ ®);
+ reg &= ~TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK;
+
+ if (reg == SMPS_CTRL_MODE_OFF)
+ rail_enable = false;
+
+ switch (mode) {
+ case REGULATOR_MODE_NORMAL:
+ reg |= SMPS_CTRL_MODE_ON;
+ break;
+ case REGULATOR_MODE_IDLE:
+ reg |= SMPS_CTRL_MODE_ECO;
+ break;
+ case REGULATOR_MODE_FAST:
+ reg |= SMPS_CTRL_MODE_PWM;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ pmic->current_reg_mode[id] = reg & TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK;
+ if (rail_enable)
+ tps65917_smps_write(pmic->tps65917,
+ tps65917_regs_info[id].ctrl_addr, reg);
+ return 0;
+}
+
+static unsigned int tps65917_get_mode_smps(struct regulator_dev *dev)
+{
+ struct tps65917_pmic *pmic = rdev_get_drvdata(dev);
+ int id = rdev_get_id(dev);
+ unsigned int reg;
+
+ reg = pmic->current_reg_mode[id] & TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK;
+
+ switch (reg) {
+ case SMPS_CTRL_MODE_ON:
+ return REGULATOR_MODE_NORMAL;
+ case SMPS_CTRL_MODE_ECO:
+ return REGULATOR_MODE_IDLE;
+ case SMPS_CTRL_MODE_PWM:
+ return REGULATOR_MODE_FAST;
+ }
+
+ return 0;
+}
+
+static struct regulator_ops tps65917_ops_smps = {
+ .is_enabled = regulator_is_enabled_regmap,
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .set_mode = tps65917_set_mode_smps,
+ .get_mode = tps65917_get_mode_smps,
+ .get_voltage_sel = regulator_get_voltage_sel_regmap,
+ .set_voltage_sel = regulator_set_voltage_sel_regmap,
+ .list_voltage = regulator_list_voltage_linear_range,
+ .map_voltage = regulator_map_voltage_linear_range,
+ .set_voltage_time_sel = regulator_set_voltage_time_sel,
+};
+
+static struct regulator_ops tps65917_ops_ext_control_smps = {
+ .set_mode = tps65917_set_mode_smps,
+ .get_mode = tps65917_get_mode_smps,
+ .get_voltage_sel = regulator_get_voltage_sel_regmap,
+ .set_voltage_sel = regulator_set_voltage_sel_regmap,
+ .list_voltage = regulator_list_voltage_linear_range,
+ .map_voltage = regulator_map_voltage_linear_range,
+};
+
+static struct regulator_ops tps65917_ops_ldo = {
+ .is_enabled = regulator_is_enabled_regmap,
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .get_voltage_sel = regulator_get_voltage_sel_regmap,
+ .set_voltage_sel = regulator_set_voltage_sel_regmap,
+ .list_voltage = regulator_list_voltage_linear,
+ .map_voltage = regulator_map_voltage_linear,
+ .set_voltage_time_sel = regulator_set_voltage_time_sel,
+};
+
+static struct regulator_ops tps65917_ops_ext_control_ldo = {
+ .get_voltage_sel = regulator_get_voltage_sel_regmap,
+ .set_voltage_sel = regulator_set_voltage_sel_regmap,
+ .list_voltage = regulator_list_voltage_linear,
+ .map_voltage = regulator_map_voltage_linear,
+};
+
+static struct regulator_ops tps65917_ops_extreg = {
+ .is_enabled = regulator_is_enabled_regmap,
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+};
+
+static struct regulator_ops tps65917_ops_ext_control_extreg = {
+};
+
+static int tps65917_regulator_config_external(struct tps65917 *tps65917, int id,
+ struct tps65917_reg_init *reg_init)
+{
+ int sleep_id = tps65917_regs_info[id].sleep_id;
+ int ret;
+
+ ret = tps65917_ext_control_req_config(tps65917, sleep_id,
+ reg_init->roof_floor, true);
+ if (ret < 0)
+ dev_err(tps65917->dev,
+ "Ext control config for regulator %d failed %d\n",
+ id, ret);
+ return ret;
+}
+
+/*
+ * setup the hardware based sleep configuration of the SMPS/LDO regulators
+ * from the platform data. This is different to the software based control
+ * supported by the regulator framework as it is controlled by toggling
+ * pins on the PMIC such as PREQ, SYSEN, ...
+ */
+static int tps65917_smps_init(struct tps65917 *tps65917, int id,
+ struct tps65917_reg_init *reg_init)
+{
+ unsigned int reg;
+ unsigned int addr;
+ int ret;
+
+ addr = tps65917_regs_info[id].ctrl_addr;
+
+ ret = tps65917_smps_read(tps65917, addr, ®);
+ if (ret)
+ return ret;
+
+ if (reg_init->warm_reset)
+ reg |= TPS65917_SMPS1_CTRL_WR_S;
+ else
+ reg &= ~TPS65917_SMPS1_CTRL_WR_S;
+
+ if (reg_init->roof_floor)
+ reg |= TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN;
+ else
+ reg &= ~TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN;
+
+ reg &= ~TPS65917_SMPS1_CTRL_MODE_SLEEP_MASK;
+ if (reg_init->mode_sleep)
+ reg |= reg_init->mode_sleep <<
+ TPS65917_SMPS1_CTRL_MODE_SLEEP_SHIFT;
+
+
+ ret = tps65917_smps_write(tps65917, addr, reg);
+ if (ret)
+ return ret;
+
+ if (tps65917_regs_info[id].vsel_addr && reg_init->vsel) {
+ addr = tps65917_regs_info[id].vsel_addr;
+
+ reg = reg_init->vsel;
+
+ ret = tps65917_smps_write(tps65917, addr, reg);
+ if (ret)
+ return ret;
+ }
+
+ if (reg_init->roof_floor) {
+ /* Enable externally controlled regulator */
+ addr = tps65917_regs_info[id].ctrl_addr;
+ ret = tps65917_smps_read(tps65917, addr, ®);
+ if (ret < 0)
+ return ret;
+
+ if (!(reg & TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK)) {
+ reg |= SMPS_CTRL_MODE_ON;
+ ret = tps65917_smps_write(tps65917, addr, reg);
+ if (ret < 0)
+ return ret;
+ }
+ return tps65917_regulator_config_external(tps65917, id,
+ reg_init);
+ }
+ return 0;
+}
+
+static int tps65917_ldo_init(struct tps65917 *tps65917, int id,
+ struct tps65917_reg_init *reg_init)
+{
+ unsigned int reg;
+ unsigned int addr;
+ int ret;
+
+ addr = tps65917_regs_info[id].ctrl_addr;
+
+ ret = tps65917_ldo_read(tps65917, addr, ®);
+ if (ret)
+ return ret;
+
+ if (reg_init->warm_reset)
+ reg |= TPS65917_LDO1_CTRL_WR_S;
+ else
+ reg &= ~TPS65917_LDO1_CTRL_WR_S;
+
+ if (reg_init->mode_sleep)
+ reg |= TPS65917_LDO1_CTRL_MODE_SLEEP;
+ else
+ reg &= ~TPS65917_LDO1_CTRL_MODE_SLEEP;
+
+ ret = tps65917_ldo_write(tps65917, addr, reg);
+ if (ret)
+ return ret;
+
+ if (reg_init->roof_floor) {
+ /* Enable externally controlled regulator */
+ addr = tps65917_regs_info[id].ctrl_addr;
+ ret = tps65917_update_bits(tps65917, TPS65917_LDO_BASE,
+ addr, TPS65917_LDO1_CTRL_MODE_ACTIVE,
+ TPS65917_LDO1_CTRL_MODE_ACTIVE);
+ if (ret < 0) {
+ dev_err(tps65917->dev,
+ "LDO Register 0x%02x update failed %d\n",
+ addr, ret);
+ return ret;
+ }
+ return tps65917_regulator_config_external(tps65917, id,
+ reg_init);
+ }
+ return 0;
+}
+
+static int tps65917_extreg_init(struct tps65917 *tps65917, int id,
+ struct tps65917_reg_init *reg_init)
+{
+ unsigned int addr;
+ int ret;
+ unsigned int val = 0;
+
+ addr = tps65917_regs_info[id].ctrl_addr;
+
+ if (reg_init->mode_sleep)
+ val = TPS65917_REGEN1_CTRL_MODE_SLEEP;
+
+ ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
+ addr, TPS65917_REGEN1_CTRL_MODE_SLEEP, val);
+ if (ret < 0) {
+ dev_err(tps65917->dev, "Resource reg 0x%02x update failed %d\n",
+ addr, ret);
+ return ret;
+ }
+
+ if (reg_init->roof_floor) {
+ /* Enable externally controlled regulator */
+ addr = tps65917_regs_info[id].ctrl_addr;
+ ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
+ addr, TPS65917_REGEN1_CTRL_MODE_ACTIVE,
+ TPS65917_REGEN1_CTRL_MODE_ACTIVE);
+ if (ret < 0) {
+ dev_err(tps65917->dev,
+ "Resource Register 0x%02x update failed %d\n",
+ addr, ret);
+ return ret;
+ }
+ return tps65917_regulator_config_external(tps65917, id,
+ reg_init);
+ }
+ return 0;
+}
+
+static struct of_regulator_match tps65917_matches[] = {
+ { .name = "smps1", },
+ { .name = "smps2", },
+ { .name = "smps3", },
+ { .name = "smps4", },
+ { .name = "smps5", },
+ { .name = "ldo1", },
+ { .name = "ldo2", },
+ { .name = "ldo3", },
+ { .name = "ldo4", },
+ { .name = "ldo5", },
+ { .name = "regen1", },
+ { .name = "regen2", },
+ { .name = "regen3", },
+ { .name = "sysen1", },
+ { .name = "sysen2", },
+};
+
+static void tps65917_dt_to_pdata(struct device *dev,
+ struct device_node *node,
+ struct tps65917_pmic_platform_data *pdata)
+{
+ struct device_node *regulators;
+ u32 prop;
+ int idx, ret;
+
+ node = of_node_get(node);
+ regulators = of_get_child_by_name(node, "regulators");
+ if (!regulators) {
+ dev_info(dev, "regulator node not found\n");
+ return;
+ }
+
+ ret = of_regulator_match(dev, regulators, tps65917_matches,
+ TPS65917_NUM_REGS);
+ of_node_put(regulators);
+ if (ret < 0) {
+ dev_err(dev, "Error parsing regulator init data: %d\n", ret);
+ return;
+ }
+
+ for (idx = 0; idx < TPS65917_NUM_REGS; idx++) {
+ if (!tps65917_matches[idx].init_data ||
+ !tps65917_matches[idx].of_node)
+ continue;
+
+ pdata->reg_data[idx] = tps65917_matches[idx].init_data;
+
+ pdata->reg_init[idx] = devm_kzalloc(dev,
+ sizeof(struct tps65917_reg_init), GFP_KERNEL);
+
+ pdata->reg_init[idx]->warm_reset =
+ of_property_read_bool(tps65917_matches[idx].of_node,
+ "ti,warm-reset");
+
+ ret = of_property_read_u32(tps65917_matches[idx].of_node,
+ "ti,roof-floor", &prop);
+ /* EINVAL: Property not found */
+ if (ret != -EINVAL) {
+ int econtrol;
+
+ /* use default value, when no value is specified */
+ econtrol = TPS65917_EXT_CONTROL_NSLEEP;
+ if (!ret) {
+ switch (prop) {
+ case 1:
+ econtrol = TPS65917_EXT_CONTROL_ENABLE1;
+ break;
+ case 2:
+ econtrol = TPS65917_EXT_CONTROL_ENABLE2;
+ break;
+ case 3:
+ econtrol = TPS65917_EXT_CONTROL_NSLEEP;
+ break;
+ default:
+ WARN_ON(1);
+ dev_warn(dev,
+ "%s: Invalid roof-floor option: %u\n",
+ tps65917_matches[idx].name, prop);
+ break;
+ }
+ }
+ pdata->reg_init[idx]->roof_floor = econtrol;
+ }
+
+ ret = of_property_read_u32(tps65917_matches[idx].of_node,
+ "ti,mode-sleep", &prop);
+ if (!ret)
+ pdata->reg_init[idx]->mode_sleep = prop;
+
+ ret = of_property_read_bool(tps65917_matches[idx].of_node,
+ "ti,smps-range");
+ if (ret)
+ pdata->reg_init[idx]->vsel =
+ TPS65917_SMPS1_VOLTAGE_RANGE;
+ }
+}
+
+
+static int tps65917_regulators_probe(struct platform_device *pdev)
+{
+ struct tps65917 *tps65917 = dev_get_drvdata(pdev->dev.parent);
+ struct tps65917_pmic_platform_data *pdata;
+ struct device_node *node = pdev->dev.of_node;
+ struct regulator_dev *rdev;
+ struct regulator_config config = { };
+ struct tps65917_pmic *pmic;
+ struct tps65917_reg_init *reg_init;
+ int id = 0, ret;
+ unsigned int addr, reg;
+
+ pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
+
+ if (!pdata)
+ return -ENOMEM;
+
+ tps65917_dt_to_pdata(&pdev->dev, node, pdata);
+
+ pmic = devm_kzalloc(&pdev->dev, sizeof(*pmic), GFP_KERNEL);
+ if (!pmic)
+ return -ENOMEM;
+
+ pmic->dev = &pdev->dev;
+ pmic->tps65917 = tps65917;
+ tps65917->pmic = pmic;
+ platform_set_drvdata(pdev, pmic);
+
+ ret = tps65917_smps_read(tps65917, TPS65917_SMPS_CTRL, ®);
+ if (ret)
+ return ret;
+
+ if (reg & TPS65917_SMPS_CTRL_SMPS1_SMPS12_EN)
+ pmic->smps12 = 1;
+
+ config.regmap = tps65917->regmap[REGULATOR_SLAVE];
+ config.dev = &pdev->dev;
+ config.driver_data = pmic;
+
+ for (id = 0; id < TPS65917_REG_LDO1; id++) {
+ /*
+ * Miss out regulators which are not available due
+ * to slaving configurations.
+ */
+ if ((id == TPS65917_REG_SMPS2) && pmic->smps12)
+ continue;
+
+ /* Initialise sleep/init values from platform data */
+ if (pdata && pdata->reg_init[id]) {
+ reg_init = pdata->reg_init[id];
+ ret = tps65917_smps_init(tps65917, id, reg_init);
+ if (ret)
+ return ret;
+ } else {
+ reg_init = NULL;
+ }
+
+ /* Register the regulators */
+ pmic->desc[id].name = tps65917_regs_info[id].name;
+ pmic->desc[id].id = id;
+
+ /*
+ * Read and store the RANGE bit for later use
+ * This must be done before regulator is probed,
+ * otherwise we error in probe with unsupportable
+ * ranges. Read the current smps mode for later use.
+ */
+ addr = tps65917_regs_info[id].vsel_addr;
+
+ ret = tps65917_smps_read(pmic->tps65917, addr, ®);
+ if (ret)
+ return ret;
+ if (reg & TPS65917_SMPS1_VOLTAGE_RANGE)
+ pmic->range[id] = 1;
+
+ if (reg_init && reg_init->roof_floor)
+ pmic->desc[id].ops =
+ &tps65917_ops_ext_control_smps;
+ else
+ pmic->desc[id].ops = &tps65917_ops_smps;
+ pmic->desc[id].n_voltages = TPS65917_SMPS_NUM_VOLTAGES;
+ pmic->desc[id].vsel_reg =
+ TPS65917_BASE_TO_REG(TPS65917_SMPS_BASE,
+ tps65917_regs_info[id].vsel_addr);
+ if (pmic->range[id])
+ pmic->desc[id].linear_ranges = smps_high_ranges;
+ else
+ pmic->desc[id].linear_ranges = smps_low_ranges;
+ pmic->desc[id].vsel_mask =
+ TPS65917_SMPS1_VOLTAGE_VSEL_MASK;
+
+ pmic->desc[id].n_linear_ranges = 3;
+ pmic->desc[id].ramp_delay = 2500;
+
+ /* Read the smps mode for later use. */
+ addr = tps65917_regs_info[id].ctrl_addr;
+ ret = tps65917_smps_read(pmic->tps65917, addr, ®);
+ if (ret)
+ return ret;
+ pmic->current_reg_mode[id] = reg &
+ TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK;
+
+ pmic->desc[id].type = REGULATOR_VOLTAGE;
+ pmic->desc[id].owner = THIS_MODULE;
+
+ if (pdata)
+ config.init_data = pdata->reg_data[id];
+ else
+ config.init_data = NULL;
+
+ pmic->desc[id].supply_name = tps65917_regs_info[id].sname;
+ config.of_node = tps65917_matches[id].of_node;
+
+ rdev = devm_regulator_register(&pdev->dev, &pmic->desc[id],
+ &config);
+ if (IS_ERR(rdev)) {
+ dev_err(&pdev->dev,
+ "failed to register %s regulator\n",
+ pdev->name);
+ return PTR_ERR(rdev);
+ }
+
+ /* Save regulator for cleanup */
+ pmic->rdev[id] = rdev;
+ }
+
+ /* Start this loop from the id left from previous loop */
+ for (; id < TPS65917_NUM_REGS; id++) {
+ if (pdata && pdata->reg_init[id])
+ reg_init = pdata->reg_init[id];
+ else
+ reg_init = NULL;
+
+ /* Miss out regulators which are not available due
+ * to alternate functions.
+ */
+
+ /* Register the regulators */
+ pmic->desc[id].name = tps65917_regs_info[id].name;
+ pmic->desc[id].id = id;
+ pmic->desc[id].type = REGULATOR_VOLTAGE;
+ pmic->desc[id].owner = THIS_MODULE;
+
+ if (id < TPS65917_REG_REGEN1) {
+ pmic->desc[id].n_voltages = TPS65917_LDO_NUM_VOLTAGES;
+ if (reg_init && reg_init->roof_floor)
+ pmic->desc[id].ops =
+ &tps65917_ops_ext_control_ldo;
+ else
+ pmic->desc[id].ops = &tps65917_ops_ldo;
+ pmic->desc[id].min_uV = 900000;
+ pmic->desc[id].uV_step = 50000;
+ pmic->desc[id].linear_min_sel = 1;
+ pmic->desc[id].enable_time = 500;
+ pmic->desc[id].vsel_reg =
+ TPS65917_BASE_TO_REG(TPS65917_LDO_BASE,
+ tps65917_regs_info[id].vsel_addr);
+ pmic->desc[id].vsel_mask =
+ TPS65917_LDO1_VOLTAGE_VSEL_MASK;
+ pmic->desc[id].enable_reg =
+ TPS65917_BASE_TO_REG(TPS65917_LDO_BASE,
+ tps65917_regs_info[id].ctrl_addr);
+ pmic->desc[id].enable_mask =
+ TPS65917_LDO1_CTRL_MODE_ACTIVE;
+ /*
+ * To be confirmed. Discussion on going with PMIC Team.
+ * It is of the order of ~60mV/uS.
+ */
+ pmic->desc[id].ramp_delay = 2500;
+ } else {
+ pmic->desc[id].n_voltages = 1;
+ if (reg_init && reg_init->roof_floor)
+ pmic->desc[id].ops =
+ &tps65917_ops_ext_control_extreg;
+ else
+ pmic->desc[id].ops = &tps65917_ops_extreg;
+ pmic->desc[id].enable_reg =
+ TPS65917_BASE_TO_REG(TPS65917_RESOURCE_BASE,
+ tps65917_regs_info[id].ctrl_addr);
+ pmic->desc[id].enable_mask =
+ TPS65917_REGEN1_CTRL_MODE_ACTIVE;
+ }
+
+ if (pdata)
+ config.init_data = pdata->reg_data[id];
+ else
+ config.init_data = NULL;
+
+ pmic->desc[id].supply_name = tps65917_regs_info[id].sname;
+ config.of_node = tps65917_matches[id].of_node;
+
+ rdev = devm_regulator_register(&pdev->dev, &pmic->desc[id],
+ &config);
+ if (IS_ERR(rdev)) {
+ dev_err(&pdev->dev,
+ "failed to register %s regulator\n",
+ pdev->name);
+ return PTR_ERR(rdev);
+ }
+
+ /* Save regulator for cleanup */
+ pmic->rdev[id] = rdev;
+
+ /* Initialise sleep/init values from platform data */
+ if (pdata) {
+ reg_init = pdata->reg_init[id];
+ if (reg_init) {
+ if (id < TPS65917_REG_REGEN1)
+ ret = tps65917_ldo_init(tps65917,
+ id, reg_init);
+ else
+ ret = tps65917_extreg_init(tps65917,
+ id, reg_init);
+ if (ret)
+ return ret;
+ }
+ }
+ }
+
+
+ return 0;
+}
+
+static struct of_device_id of_tps65917_match_tbl[] = {
+ { .compatible = "ti,tps65917-pmic", },
+ { }
+};
+
+static struct platform_driver tps65917_driver = {
+ .driver = {
+ .name = "tps65917-pmic",
+ .of_match_table = of_tps65917_match_tbl,
+ .owner = THIS_MODULE,
+ },
+ .probe = tps65917_regulators_probe,
+};
+
+static int __init tps65917_init(void)
+{
+ return platform_driver_register(&tps65917_driver);
+}
+subsys_initcall(tps65917_init);
+
+static void __exit tps65917_exit(void)
+{
+ platform_driver_unregister(&tps65917_driver);
+}
+module_exit(tps65917_exit);
+
+MODULE_AUTHOR("J Keerthy <j-keerthy@ti.com>");
+MODULE_DESCRIPTION("TPS65917 voltage regulator driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:tps65917-pmic");
+MODULE_DEVICE_TABLE(of, of_tps65917_match_tbl);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC
2014-05-20 9:11 ` [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC Keerthy
@ 2014-05-20 13:58 ` Lee Jones
2014-05-20 17:24 ` Keerthy
2014-05-20 14:15 ` Nishanth Menon
1 sibling, 1 reply; 9+ messages in thread
From: Lee Jones @ 2014-05-20 13:58 UTC (permalink / raw)
To: Keerthy
Cc: devicetree, robh+dt, mark.rutland, sameo, grant.likely, ian,
linux-doc, linux-kernel, broonie, swarren, linux-omap
> The TPS65917 chip is a power management IC for Portable Navigation Systems
> and Tablet Computing devices. It contains the following components:
>
> - Regulators.
> - Over Temperature warning and Shut down.
>
> This patch adds support for tps65917 mfd device. At this time only
> the regulator functionality is made available.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> Changes in V2:
>
> Added volatile register check as some of the registers
> in the set are volatile.
>
> drivers/mfd/Kconfig | 12 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/tps65917.c | 573 ++++++++++++++++
We have quite the collection of tps* files now in MFD. How different
are they really? Is consolidation possible?
> include/linux/mfd/tps65917.h | 1509 ++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 2095 insertions(+)
> create mode 100644 drivers/mfd/tps65917.c
> create mode 100644 include/linux/mfd/tps65917.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3383412..ac73e58 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -925,6 +925,18 @@ config MFD_TPS65912_SPI
> If you say yes here you get support for the TPS65912 series of
> PM chips with SPI interface.
>
> +config MFD_TPS65917
> + bool "TI TPS65917 series chips"
> + select MFD_CORE
> + select REGMAP_I2C
> + select REGMAP_IRQ
> + depends on I2C=y
> + help
> + If you say yes here you get support for the TPS65917
> + PMIC chips from Texas Instruments. The device provides
> + 5 confgurable SPMSs and 5 LDOs, thermal protection module,
> + GPADC.
> +
> config MFD_TPS80031
> bool "TI TPS80031/TPS80032 Power Management chips"
> depends on I2C=y
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 2851275..248a60b 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -69,6 +69,7 @@ tps65912-objs := tps65912-core.o tps65912-irq.o
> obj-$(CONFIG_MFD_TPS65912) += tps65912.o
> obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o
> obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o
> +obj-$(CONFIG_MFD_TPS65917) += tps65917.o
> obj-$(CONFIG_MFD_TPS80031) += tps80031.o
> obj-$(CONFIG_MENELAUS) += menelaus.o
>
> diff --git a/drivers/mfd/tps65917.c b/drivers/mfd/tps65917.c
> new file mode 100644
> index 0000000..dbd67c5
> --- /dev/null
> +++ b/drivers/mfd/tps65917.c
> @@ -0,0 +1,573 @@
> +/*
> + * TI TPS65917 Integrated power management chipsets
> + *
> + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether expressed or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License version 2 for more details.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/moduleparam.h>
> +#include <linux/init.h>
> +#include <linux/slab.h>
> +#include <linux/i2c.h>
> +#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/regmap.h>
> +#include <linux/err.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/tps65917.h>
> +#include <linux/of_device.h>
> +
> +#define TPS65917_EXT_REQ (TPS65917_EXT_CONTROL_ENABLE1 | \
> + TPS65917_EXT_CONTROL_ENABLE2 | \
> + TPS65917_EXT_CONTROL_NSLEEP)
> +
> +struct tps65917_sleep_requestor_info {
> + int id;
> + int reg_offset;
> + int bit_pos;
> +};
> +
> +#define EXTERNAL_REQUESTOR(_id, _offset, _pos) \
> + [TPS65917_EXTERNAL_REQSTR_ID_##_id] = { \
> + .id = TPS65917_EXTERNAL_REQSTR_ID_##_id, \
> + .reg_offset = _offset, \
> + .bit_pos = _pos, \
> + }
> +
> +static struct tps65917_sleep_requestor_info sleep_req_info[] = {
> + EXTERNAL_REQUESTOR(REGEN1, 0, 0),
> + EXTERNAL_REQUESTOR(REGEN2, 0, 1),
> + EXTERNAL_REQUESTOR(REGEN3, 0, 6),
> + EXTERNAL_REQUESTOR(SMPS1, 1, 0),
> + EXTERNAL_REQUESTOR(SMPS2, 1, 1),
> + EXTERNAL_REQUESTOR(SMPS3, 1, 2),
> + EXTERNAL_REQUESTOR(SMPS4, 1, 3),
> + EXTERNAL_REQUESTOR(SMPS5, 1, 4),
> + EXTERNAL_REQUESTOR(LDO1, 2, 0),
> + EXTERNAL_REQUESTOR(LDO2, 2, 1),
> + EXTERNAL_REQUESTOR(LDO3, 2, 2),
> + EXTERNAL_REQUESTOR(LDO4, 2, 3),
> + EXTERNAL_REQUESTOR(LDO5, 2, 4),
> +};
> +
> +static int tps65917_voltaile_regs[] = {
> + TPS65917_SMPS1_CTRL,
> + TPS65917_SMPS2_CTRL,
> + TPS65917_SMPS3_CTRL,
> + TPS65917_SMPS4_CTRL,
> + TPS65917_SMPS5_CTRL,
> + TPS65917_LDO1_CTRL,
> + TPS65917_LDO2_CTRL,
> + TPS65917_LDO3_CTRL,
> + TPS65917_LDO4_CTRL,
> + TPS65917_LDO5_CTRL,
> +};
> +
> +static bool is_volatile_reg(struct device *dev, unsigned int reg)
> +{
> + int i;
> +
> + /*
> + * Caching all the required regulator registers.
> + */
> +
> + for (i = 0; i < 11; i++)
Are you sure? Looks like 10 to me.
Use ARRAY_SIZE(tps65917_voltaile_regs) instead
> + if (reg == tps65917_voltaile_regs[i])
> + return true;
> +
> + return false;
> +}
[...]
> +int tps65917_ext_control_req_config(struct tps65917 *tps65917,
> + enum tps65917_external_requestor_id id,
> + int ext_ctrl, bool enable)
> +{
> + int preq_mask_bit = 0;
> + int reg_add = 0;
> + int bit_pos;
> + int ret;
> +
> + if (!(ext_ctrl & TPS65917_EXT_REQ))
> + return 0;
> +
> + if (id >= TPS65917_EXTERNAL_REQSTR_ID_MAX)
> + return 0;
> +
> + if (ext_ctrl & TPS65917_EXT_CONTROL_NSLEEP) {
> + reg_add = TPS65917_NSLEEP_RES_ASSIGN;
> + preq_mask_bit = 0;
> + } else if (ext_ctrl & TPS65917_EXT_CONTROL_ENABLE1) {
> + reg_add = TPS65917_ENABLE1_RES_ASSIGN;
> + preq_mask_bit = 1;
> + } else if (ext_ctrl & TPS65917_EXT_CONTROL_ENABLE2) {
> + reg_add = TPS65917_ENABLE2_RES_ASSIGN;
> + preq_mask_bit = 2;
> + }
> +
> + bit_pos = sleep_req_info[id].bit_pos;
> + reg_add += sleep_req_info[id].reg_offset;
New line here.
> + if (enable)
> + ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
> + reg_add, BIT(bit_pos), BIT(bit_pos));
> + else
> + ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
> + reg_add, BIT(bit_pos), 0);
Would prefer:
ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
reg_add, BIT(bit_pos),
enable ? BIT(bit_pos) : 0);
> + if (ret < 0) {
> + dev_err(tps65917->dev, "Resource reg 0x%02x update failed %d\n",
> + reg_add, ret);
> + return ret;
> + }
> +
> + /* Unmask the PREQ */
> + ret = tps65917_update_bits(tps65917, TPS65917_PMU_CONTROL_BASE,
> + TPS65917_POWER_CTRL, BIT(preq_mask_bit), 0);
> + if (ret < 0) {
> + dev_err(tps65917->dev, "POWER_CTRL register update failed %d\n",
> + ret);
> + return ret;
> + }
> + return ret;
Just display the error - the function returns 'ret' regardless.
> +}
> +EXPORT_SYMBOL_GPL(tps65917_ext_control_req_config);
> +
> +static int tps65917_set_pdata_irq_flag(struct i2c_client *i2c,
> + struct tps65917_platform_data *pdata)
> +{
> + struct irq_data *irq_data = irq_get_irq_data(i2c->irq);
New line here.
> + if (!irq_data) {
> + dev_err(&i2c->dev, "Invalid IRQ: %d\n", i2c->irq);
> + return -EINVAL;
> + }
> +
> + pdata->irq_flags = irqd_get_trigger_type(irq_data);
> + dev_info(&i2c->dev, "Irq flag is 0x%08x\n", pdata->irq_flags);
Is this line really required?
New line here.
> + return 0;
> +}
> +
> +static void tps65917_dt_to_pdata(struct i2c_client *i2c,
> + struct tps65917_platform_data *pdata)
> +{
> + struct device_node *node = i2c->dev.of_node;
What kind of node?
Personally, I'd prefer the use of 'np' as a variable name.
> + int ret;
> + u32 prop;
> +
> + ret = of_property_read_u32(node, "ti,mux-pad1", &prop);
> + if (!ret) {
> + pdata->mux_from_pdata = 1;
This should be a bool.
> + pdata->pad1 = prop;
> + }
> +
> + ret = of_property_read_u32(node, "ti,mux-pad2", &prop);
> + if (!ret) {
> + pdata->mux_from_pdata = 1;
As above.
> + pdata->pad2 = prop;
> + }
> +
> + /* The default for this register is all masked */
> + ret = of_property_read_u32(node, "ti,power-ctrl", &prop);
> + if (!ret)
> + pdata->power_ctrl = prop;
> + else
> + pdata->power_ctrl = TPS65917_POWER_CTRL_NSLEEP_MASK |
> + TPS65917_POWER_CTRL_ENABLE1_MASK |
> + TPS65917_POWER_CTRL_ENABLE2_MASK;
> + if (i2c->irq)
> + tps65917_set_pdata_irq_flag(i2c, pdata);
What's the point of tps65917_set_pdata_irq_flag() providing a return
value and then not checking it?
> + pdata->pm_off = of_property_read_bool(node,
> + "ti,system-power-controller");
> +}
> +
> +static struct tps65917 *tps65917_dev;
This is never used.
> +static const struct of_device_id of_tps65917_match_tbl[] = {
> + {
> + .compatible = "ti,tps65917",
> + },
This can all sit on one line.
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, of_tps65917_match_tbl);
> +
> +static int tps65917_i2c_probe(struct i2c_client *i2c,
> + const struct i2c_device_id *id)
> +{
> + struct tps65917 *tps65917;
> + struct tps65917_platform_data *pdata;
> + struct device_node *node = i2c->dev.of_node;
> + int ret = 0, i;
Break these into separate declarations.
Nit: Put them with the other int declaration(s).
> + unsigned int reg, addr, *features;
> + int slave;
> + const struct of_device_id *match;
> +
> + pdata = dev_get_platdata(&i2c->dev);
> +
> + if (node && !pdata) {
> + pdata = devm_kzalloc(&i2c->dev, sizeof(*pdata), GFP_KERNEL);
> +
Remove this line.
> + if (!pdata)
> + return -ENOMEM;
> +
> + tps65917_dt_to_pdata(i2c, pdata);
I'm sure we can fail here.
> + }
> +
> + if (!pdata)
> + return -EINVAL;
> +
> + tps65917 = devm_kzalloc(&i2c->dev, sizeof(struct tps65917), GFP_KERNEL);
> + if (tps65917 == NULL)
if (!tps65917)
> + return -ENOMEM;
> +
> + i2c_set_clientdata(i2c, tps65917);
Do this at the end after a clean start-up.
> + tps65917->dev = &i2c->dev;
> + tps65917->irq = i2c->irq;
Or just save i2c.
> + match = of_match_device(of_tps65917_match_tbl, &i2c->dev);
> +
Remove this line.
> + if (!match)
> + return -ENODATA;
> +
> + features = (unsigned int *)match->data;
This will be NULL, please remove it.
In fact, why are you even checking for a match?
You only support one device.
> + for (i = 0; i < TPS65917_NUM_CLIENTS; i++) {
> + if (i == 0) {
> + tps65917->i2c_clients[i] = i2c;
> + } else {
> + tps65917->i2c_clients[i] =
> + i2c_new_dummy(i2c->adapter,
> + i2c->addr + i);
> + if (!tps65917->i2c_clients[i]) {
> + dev_err(tps65917->dev,
> + "can't attach client %d\n", i);
> + ret = -ENOMEM;
> + goto err_i2c;
> + }
> + tps65917->i2c_clients[i]->dev.of_node = of_node_get(node);
> + }
New line here.
> + tps65917->regmap[i] = devm_regmap_init_i2c(tps65917->i2c_clients[i],
> + &tps65917_regmap_config[i]);
> + if (IS_ERR(tps65917->regmap[i])) {
> + ret = PTR_ERR(tps65917->regmap[i]);
> + dev_err(tps65917->dev,
> + "Failed to allocate regmap %d, err: %d\n",
> + i, ret);
> + goto err_i2c;
> + }
> + }
> +
> + if (!tps65917->irq) {
> + dev_warn(tps65917->dev, "IRQ missing: skipping irq request\n");
> + goto no_irq;
> + }
> +
> + /* Change interrupt line output polarity */
> + if (pdata->irq_flags & IRQ_TYPE_LEVEL_HIGH)
> + reg = TPS65917_POLARITY_CTRL_INT_POLARITY;
> + else
> + reg = 0;
> + ret = tps65917_update_bits(tps65917, TPS65917_PU_PD_OD_BASE,
> + TPS65917_POLARITY_CTRL,
> + TPS65917_POLARITY_CTRL_INT_POLARITY, reg);
Do you need to do this if reg == 0?
> + if (ret < 0) {
> + dev_err(tps65917->dev, "POLARITY_CTRL updat failed: %d\n", ret);
> + goto err_i2c;
> + }
> +
> + /* Change IRQ into clear on read mode for efficiency */
> + slave = TPS65917_BASE_TO_SLAVE(TPS65917_INTERRUPT_BASE);
> + addr = TPS65917_BASE_TO_REG(TPS65917_INTERRUPT_BASE, TPS65917_INT_CTRL);
> + reg = TPS65917_INT_CTRL_INT_CLEAR;
> +
> + regmap_write(tps65917->regmap[slave], addr, reg);
> +
> + ret = regmap_add_irq_chip(tps65917->regmap[slave], tps65917->irq,
> + IRQF_ONESHOT | pdata->irq_flags, 0,
> + &tps65917_irq_chip,
> + &tps65917->irq_data);
> + if (ret < 0)
> + goto err_i2c;
> +
> +no_irq:
> + slave = TPS65917_BASE_TO_SLAVE(TPS65917_PU_PD_OD_BASE);
> + addr = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
> + TPS65917_PRIMARY_SECONDARY_PAD1);
> +
> + if (pdata->mux_from_pdata) {
> + reg = pdata->pad1;
> + ret = regmap_write(tps65917->regmap[slave], addr, reg);
> + if (ret)
> + goto err_irq;
> + } else {
> + ret = regmap_read(tps65917->regmap[slave], addr, ®);
> + if (ret)
> + goto err_irq;
> + }
Comment this to let us know what you're trying to do.
> + addr = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
> + TPS65917_PRIMARY_SECONDARY_PAD2);
> +
> + if (pdata->mux_from_pdata) {
> + reg = pdata->pad2;
> + ret = regmap_write(tps65917->regmap[slave], addr, reg);
> + if (ret)
> + goto err_irq;
> + } else {
> + ret = regmap_read(tps65917->regmap[slave], addr, ®);
> + if (ret)
> + goto err_irq;
> + }
Same here.
> + reg = pdata->power_ctrl;
> +
> + slave = TPS65917_BASE_TO_SLAVE(TPS65917_PMU_CONTROL_BASE);
> + addr = TPS65917_BASE_TO_REG(TPS65917_PMU_CONTROL_BASE,
> + TPS65917_POWER_CTRL);
> +
> + ret = regmap_write(tps65917->regmap[slave], addr, reg);
> + if (ret)
> + goto err_irq;
And here.
> + /*
> + * If we are probing with DT do this the DT way and return here
> + * otherwise continue and add devices using mfd helpers.
MFD
> + */
> + if (node) {
> + ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
What is it you're registering here? I don't see any child devices
anywhere.
> + if (ret < 0)
> + goto err_irq;
> + else if (pdata->pm_off && !pm_power_off)
No need for the else.
> + tps65917_dev = tps65917;
What does this do?
> + }
> +
> + return ret;
Where does it continue and add devices using the MFD helpers?
> +err_irq:
> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
> +err_i2c:
> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
> + if (tps65917->i2c_clients[i])
> + i2c_unregister_device(tps65917->i2c_clients[i]);
> + }
New line here.
> + return ret;
> +}
> +
> +static int tps65917_i2c_remove(struct i2c_client *i2c)
> +{
> + struct tps65917 *tps65917 = i2c_get_clientdata(i2c);
> + int i;
> +
> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
> +
> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
> + if (tps65917->i2c_clients[i])
> + i2c_unregister_device(tps65917->i2c_clients[i]);
> + }
> +
> + return 0;
> +}
> +
> +static const struct i2c_device_id tps65917_i2c_id[] = {
> + { "tps65917", },
> +};
> +MODULE_DEVICE_TABLE(i2c, tps65917_i2c_id);
> +
> +static struct i2c_driver tps65917_i2c_driver = {
> + .driver = {
> + .name = "tps65917",
> + .of_match_table = of_tps65917_match_tbl,
of_match_ptr()
> + .owner = THIS_MODULE,
> + },
> + .probe = tps65917_i2c_probe,
> + .remove = tps65917_i2c_remove,
> + .id_table = tps65917_i2c_id,
> +};
> +
> +static int __init tps65917_i2c_init(void)
> +{
> + return i2c_add_driver(&tps65917_i2c_driver);
> +}
> +/* init early so consumer devices can complete system boot */
Defer?
> +subsys_initcall(tps65917_i2c_init);
> +
> +static void __exit tps65917_i2c_exit(void)
> +{
> + i2c_del_driver(&tps65917_i2c_driver);
> +}
> +module_exit(tps65917_i2c_exit);
> +
> +MODULE_AUTHOR("J Keerthy <j-keerthy@ti.com>");
> +MODULE_DESCRIPTION("TPS65917 chip family multi-function driver");
Multi-Function Driver
> +MODULE_LICENSE("GPL v2");
> diff --git a/include/linux/mfd/tps65917.h b/include/linux/mfd/tps65917.h
> new file mode 100644
> index 0000000..8232e22
> --- /dev/null
> +++ b/include/linux/mfd/tps65917.h
> @@ -0,0 +1,1509 @@
> +/*
> + * TI TPS65917
> + *
> + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether expressed or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License version 2 for more details.
> + */
> +
> +#ifndef __LINUX_MFD_TPS65917_H
> +#define __LINUX_MFD_TPS65917_H
> +
> +#include <linux/regmap.h>
> +#include <linux/regulator/driver.h>
> +
> +#define TPS65917_NUM_CLIENTS 3
> +
> +/* The ID_REVISION NUMBERS */
> +#define TPS65917_CHIP_ID 0xC035
> +#define TPS65917_RESERVED -1
Line up with tabs.
> +struct tps65917 {
> + struct device *dev;
> +
> + struct i2c_client *i2c_clients[TPS65917_NUM_CLIENTS];
> + struct regmap *regmap[TPS65917_NUM_CLIENTS];
> +
> + /* Stored chip id */
> + int id;
Where is this used?
> + struct tps65917_pmic *pmic;
> +
> + /* IRQ Data */
> + int irq;
> + u32 irq_mask;
> + /* mutext for irq */
> + struct mutex irq_lock;
> + struct regmap_irq_chip_data *irq_data;
> +};
> +
> +struct tps65917_reg_init {
> + /* warm_rest controls the voltage levels after a warm reset
> + *
> + * 0: reload default values from OTP on warm reset
> + * 1: maintain voltage from VSEL on warm reset
> + */
Unusual looking comment, please correct.
> + int warm_reset;
Looks like a bool to me.
> + /* roof_floor controls whether the regulator uses the i2c style
> + * of DVS or uses the method where a GPIO or other control method is
> + * attached to the NSLEEP/ENABLE1/ENABLE2 pins
> + *
> + * For SMPS
> + *
> + * 0: i2c selection of voltage
> + * 1: pin selection of voltage.
> + *
> + * For LDO unused
> + */
Same here. Top line should not be populated.
> + int roof_floor;
Only two values is a bool.
> + /* sleep_mode is the mode loaded to MODE_SLEEP bits as defined in
> + * the data sheet.
> + *
> + * For SMPS
> + *
> + * 0: Off
> + * 1: AUTO
> + * 2: ECO
> + * 3: Forced PWM
> + *
> + * For LDO
> + *
> + * 0: Off
> + * 1: On
> + */
> + int mode_sleep;
> +
> + /* voltage_sel is the bitfield loaded onto the SMPSX_VOLTAGE
> + * register. Set this is the default voltage set in OTP needs
> + * to be overridden.
> + */
> + u8 vsel;
> +};
> +
> +enum tps65917_regulators {
> + /* SMPS regulators */
> + TPS65917_REG_SMPS1,
> + TPS65917_REG_SMPS2,
> + TPS65917_REG_SMPS3,
> + TPS65917_REG_SMPS4,
> + TPS65917_REG_SMPS5,
> + /* LDO regulators */
> + TPS65917_REG_LDO1,
> + TPS65917_REG_LDO2,
> + TPS65917_REG_LDO3,
> + TPS65917_REG_LDO4,
> + TPS65917_REG_LDO5,
> + TPS65917_REG_REGEN1,
> + TPS65917_REG_REGEN2,
> + TPS65917_REG_REGEN3,
> +
> + /* Total number of regulators */
> + TPS65917_NUM_REGS,
> +};
> +
> +struct tps65917_pmic_platform_data {
> + /* An array of pointers to regulator init data indexed by regulator
> + * ID
> + */
Odd multi-line comments throughout.
> + struct regulator_init_data *reg_data[TPS65917_NUM_REGS];
> +
> + /* An array of pointers to structures containing sleep mode and DVS
> + * configuration for regulators indexed by ID
> + */
> + struct tps65917_reg_init *reg_init[TPS65917_NUM_REGS];
> +};
> +
> +
> +struct tps65917_platform_data {
> + int irq_flags;
> + int gpio_base;
> +
> + /* bit value to be loaded to the POWER_CTRL register */
> + u8 power_ctrl;
> +
> + /*
> + * boolean to select if we want to configure muxing here
> + * then the two value to load into the registers if true
> + */
> + int mux_from_pdata;
> + u8 pad1, pad2;
> + bool pm_off;
> +
> + struct tps65917_pmic_platform_data *pmic_pdata;
> +};
> +
> +/* Define the tps65917 IRQ numbers */
> +enum tps65917_irqs {
> + /* INT1 registers */
> + TPS65917_RESERVED1,
> + TPS65917_PWRON_IRQ,
> + TPS65917_LONG_PRESS_KEY_IRQ,
> + TPS65917_RESERVED2,
> + TPS65917_PWRDOWN_IRQ,
> + TPS65917_HOTDIE_IRQ,
> + TPS65917_VSYS_MON_IRQ,
> + TPS65917_RESERVED3,
> + /* INT2 registers */
> + TPS65917_RESERVED4,
> + TPS65917_OTP_ERROR_IRQ,
> + TPS65917_WDT_IRQ,
> + TPS65917_RESERVED5,
> + TPS65917_RESET_IN_IRQ,
> + TPS65917_FSD_IRQ,
> + TPS65917_SHORT_IRQ,
> + TPS65917_RESERVED6,
> + /* INT3 registers */
> + TPS65917_GPADC_AUTO_0_IRQ,
> + TPS65917_GPADC_AUTO_1_IRQ,
> + TPS65917_GPADC_EOC_SW_IRQ,
> + TPS65917_RESREVED6,
> + TPS65917_RESERVED7,
> + TPS65917_RESERVED8,
> + TPS65917_RESERVED9,
> + TPS65917_VBUS_IRQ,
> + /* INT4 registers */
> + TPS65917_GPIO_0_IRQ,
> + TPS65917_GPIO_1_IRQ,
> + TPS65917_GPIO_2_IRQ,
> + TPS65917_GPIO_3_IRQ,
> + TPS65917_GPIO_4_IRQ,
> + TPS65917_GPIO_5_IRQ,
> + TPS65917_GPIO_6_IRQ,
> + TPS65917_RESERVED10,
> + /* Total Number IRQs */
> + TPS65917_NUM_IRQ,
> +};
> +
> +/* External controll signal name */
Spelling.
> +enum {
> + TPS65917_EXT_CONTROL_ENABLE1 = 0x1,
> + TPS65917_EXT_CONTROL_ENABLE2 = 0x2,
> + TPS65917_EXT_CONTROL_NSLEEP = 0x4,
> +};
> +
> +/*
> + * TPS65917 device resources can be controlled externally for
> + * enabling/disabling it rather than register write through i2c.
> + * Add the external controlled requestor ID for different resources.
> + */
> +enum tps65917_external_requestor_id {
> + TPS65917_EXTERNAL_REQSTR_ID_REGEN1,
> + TPS65917_EXTERNAL_REQSTR_ID_REGEN2,
> + TPS65917_EXTERNAL_REQSTR_ID_REGEN3,
> + TPS65917_EXTERNAL_REQSTR_ID_SMPS1,
> + TPS65917_EXTERNAL_REQSTR_ID_SMPS2,
> + TPS65917_EXTERNAL_REQSTR_ID_SMPS3,
> + TPS65917_EXTERNAL_REQSTR_ID_SMPS4,
> + TPS65917_EXTERNAL_REQSTR_ID_SMPS5,
> + TPS65917_EXTERNAL_REQSTR_ID_LDO1,
> + TPS65917_EXTERNAL_REQSTR_ID_LDO2,
> + TPS65917_EXTERNAL_REQSTR_ID_LDO3,
> + TPS65917_EXTERNAL_REQSTR_ID_LDO4,
> + TPS65917_EXTERNAL_REQSTR_ID_LDO5,
> + /* Last entry */
> + TPS65917_EXTERNAL_REQSTR_ID_MAX,
> +};
> +
> +struct tps65917_pmic {
> + struct tps65917 *tps65917;
> + struct device *dev;
> + struct regulator_desc desc[TPS65917_NUM_REGS];
> + struct regulator_dev *rdev[TPS65917_NUM_REGS];
> + /* pmic mutex */
> + struct mutex mutex;
> + int smps12;
> + int range[TPS65917_REG_SMPS5];
> + unsigned int ramp_delay[TPS65917_REG_SMPS5];
> + unsigned int current_reg_mode[TPS65917_REG_SMPS5];
> +};
> +
> +/* helper macro to get correct slave number */
> +#define TPS65917_BASE_TO_SLAVE(x) ((x >> 8) - 1)
> +#define TPS65917_BASE_TO_REG(x, y) ((x & 0xff) + y)
> +
> +/* Base addresses of IP blocks in TPS65917 */
> +#define TPS65917_SMPS_DVS_BASE 0x20
> +#define TPS65917_VALIDITY_BASE 0x118
> +#define TPS65917_SMPS_BASE 0x120
> +#define TPS65917_LDO_BASE 0x150
> +#define TPS65917_DVFS_BASE 0x180
> +#define TPS65917_PMU_CONTROL_BASE 0x1A0
> +#define TPS65917_RESOURCE_BASE 0x1D4
> +#define TPS65917_PU_PD_OD_BASE 0x1F0
> +#define TPS65917_LED_BASE 0x200
> +#define TPS65917_INTERRUPT_BASE 0x210
> +#define TPS65917_GPIO_BASE 0x280
> +#define TPS65917_GPADC_BASE 0x2C0
> +#define TPS65917_TRIM_GPADC_BASE 0x3CD
> +
> +/* Registers for function BACKUP */
> +#define TPS65917_BACKUP0 0x0
> +#define TPS65917_BACKUP1 0x1
> +#define TPS65917_BACKUP2 0x2
> +#define TPS65917_BACKUP3 0x3
> +#define TPS65917_BACKUP4 0x4
> +#define TPS65917_BACKUP5 0x5
> +#define TPS65917_BACKUP6 0x6
> +#define TPS65917_BACKUP7 0x7
> +
> +/* Bit definitions for BACKUP0 */
> +#define TPS65917_BACKUP0_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP0_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP1 */
> +#define TPS65917_BACKUP1_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP1_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP2 */
> +#define TPS65917_BACKUP2_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP2_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP3 */
> +#define TPS65917_BACKUP3_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP3_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP4 */
> +#define TPS65917_BACKUP4_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP4_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP5 */
> +#define TPS65917_BACKUP5_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP5_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP6 */
> +#define TPS65917_BACKUP6_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP6_BACKUP_SHIFT 0
> +
> +/* Bit definitions for BACKUP7 */
> +#define TPS65917_BACKUP7_BACKUP_MASK 0xff
> +#define TPS65917_BACKUP7_BACKUP_SHIFT 0
If they do not differ, remove the number and consolidate:
/* Bit definitions for BACKUP{0-7} */
#define TPS65917_BACKUP_BACKUP_MASK 0xff
#define TPS65917_BACKUP_BACKUP_SHIFT 0
> +/* Registers for function SMPS */
> +#define TPS65917_SMPS1_CTRL 0x0
> +#define TPS65917_SMPS1_FORCE 0x2
> +#define TPS65917_SMPS1_VOLTAGE 0x3
> +#define TPS65917_SMPS2_CTRL 0x4
> +#define TPS65917_SMPS2_FORCE 0x6
> +#define TPS65917_SMPS2_VOLTAGE 0x7
> +#define TPS65917_SMPS3_CTRL 0xC
> +#define TPS65917_SMPS3_FORCE 0xE
> +#define TPS65917_SMPS3_VOLTAGE 0xF
> +#define TPS65917_SMPS4_CTRL 0x10
> +#define TPS65917_SMPS4_VOLTAGE 0x13
> +#define TPS65917_SMPS5_CTRL 0x18
> +#define TPS65917_SMPS5_VOLTAGE 0x1B
> +#define TPS65917_SMPS_CTRL 0x24
> +#define TPS65917_SMPS_PD_CTRL 0x25
> +#define TPS65917_SMPS_THERMAL_EN 0x27
> +#define TPS65917_SMPS_THERMAL_STATUS 0x28
> +#define TPS65917_SMPS_SHORT_STATUS 0x29
> +#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN 0x2A
> +#define TPS65917_SMPS_POWERGOOD_MASK1 0x2B
> +#define TPS65917_SMPS_POWERGOOD_MASK2 0x2C
> +
> +/* Bit definitions for SMPS1_CTRL */
> +#define TPS65917_SMPS1_CTRL_WR_S 0x80
> +#define TPS65917_SMPS1_CTRL_WR_S_SHIFT 7
> +#define TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN 0x40
> +#define TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN_SHIFT 6
> +#define TPS65917_SMPS1_CTRL_STATUS_MASK 0x30
> +#define TPS65917_SMPS1_CTRL_STATUS_SHIFT 4
> +#define TPS65917_SMPS1_CTRL_MODE_SLEEP_MASK 0x0c
> +#define TPS65917_SMPS1_CTRL_MODE_SLEEP_SHIFT 2
> +#define TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK 0x03
> +#define TPS65917_SMPS1_CTRL_MODE_ACTIVE_SHIFT 0
Pick a base and stick with it. I suggest hex throughout.
[...]
> +/* Bit definitions for SMPS_PLL_CTRL */
> +
> +#define TPS65917_SMPS_PLL_CTRL_PLL_EN_PLL_BYPASS_SHIFT 0x8
> +#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_EN_BYPASS 3
> +#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_BYPASS_CLK_SHIFT 0x4
> +#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_BYPASS_CLK 2
> +
> +
Remove this line.
> +/* Registers for function LDO */
> +#define TPS65917_LDO1_CTRL 0x0
> +#define TPS65917_LDO1_VOLTAGE 0x1
> +#define TPS65917_LDO2_CTRL 0x2
> +#define TPS65917_LDO2_VOLTAGE 0x3
> +#define TPS65917_LDO3_CTRL 0x4
> +#define TPS65917_LDO3_VOLTAGE 0x5
> +#define TPS65917_LDO4_CTRL 0xE
> +#define TPS65917_LDO4_VOLTAGE 0xF
Also standardise the number of digits represented and either
capitalise none or all of the hex letters.
[...]
> +static inline int tps65917_read(struct tps65917 *tps65917, unsigned int base,
> + unsigned int reg, unsigned int *val)
> +{
> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
Extra ' '.
> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
> +
> + return regmap_read(tps65917->regmap[slave_id], addr, val);
> +}
> +
> +static inline int tps65917_write(struct tps65917 *tps65917, unsigned int base,
> + unsigned int reg, unsigned int value)
> +{
> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
> +
> + return regmap_write(tps65917->regmap[slave_id], addr, value);
> +}
> +
> +static inline int tps65917_bulk_write(struct tps65917 *tps65917,
> + unsigned int base,
> + unsigned int reg, const void *val,
> + size_t val_count)
> +{
> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
> +
> + return regmap_bulk_write(tps65917->regmap[slave_id], addr,
> + val, val_count);
> +}
> +
> +static inline int tps65917_bulk_read(struct tps65917 *tps65917,
> + unsigned int base,
> + unsigned int reg, void *val,
> + size_t val_count)
> +{
> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
> +
> + return regmap_bulk_read(tps65917->regmap[slave_id], addr,
> + val, val_count);
> +}
> +
> +static inline int tps65917_update_bits(struct tps65917 *tps65917,
> + unsigned int base, unsigned int reg,
> + unsigned int mask, unsigned int val)
> +{
> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
> +
> + return regmap_update_bits(tps65917->regmap[slave_id], addr, mask, val);
> +}
> +
> +static inline int tps65917_irq_get_virq(struct tps65917 *tps65917, int irq)
> +{
> + return regmap_irq_get_virq(tps65917->irq_data, irq);
> +}
This is quite a lot of overhead. Are you sure you require them?
> +int tps65917_ext_control_req_config(struct tps65917 *tps65917,
> + enum tps65917_external_requestor_id ext_control_req_id,
> + int ext_ctrl, bool enable);
> +
> +#endif /* __LINUX_MFD_TPS65917_H */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC
2014-05-20 9:11 ` [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC Keerthy
2014-05-20 13:58 ` Lee Jones
@ 2014-05-20 14:15 ` Nishanth Menon
2014-05-20 17:40 ` Keerthy
1 sibling, 1 reply; 9+ messages in thread
From: Nishanth Menon @ 2014-05-20 14:15 UTC (permalink / raw)
To: Keerthy, devicetree
Cc: robh+dt, mark.rutland, sameo, grant.likely, ian, linux-doc,
linux-kernel, broonie, swarren, lee.jones, linux-omap
On 05/20/2014 04:11 AM, Keerthy wrote:
[...]
> +config MFD_TPS65917
> + bool "TI TPS65917 series chips"
> + select MFD_CORE
> + select REGMAP_I2C
> + select REGMAP_IRQ
> + depends on I2C=y
^^ why =y?
> + help
> + If you say yes here you get support for the TPS65917
> + PMIC chips from Texas Instruments. The device provides
> + 5 confgurable SPMSs and 5 LDOs, thermal protection module,
> + GPADC.
> +
> config MFD_TPS80031
> bool "TI TPS80031/TPS80032 Power Management chips"
> depends on I2C=y
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 2851275..248a60b 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -69,6 +69,7 @@ tps65912-objs := tps65912-core.o tps65912-irq.o
> obj-$(CONFIG_MFD_TPS65912) += tps65912.o
> obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o
> obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o
> +obj-$(CONFIG_MFD_TPS65917) += tps65917.o
> obj-$(CONFIG_MFD_TPS80031) += tps80031.o
> obj-$(CONFIG_MENELAUS) += menelaus.o
>
> diff --git a/drivers/mfd/tps65917.c b/drivers/mfd/tps65917.c
> new file mode 100644
> index 0000000..dbd67c5
> --- /dev/null
> +++ b/drivers/mfd/tps65917.c
> @@ -0,0 +1,573 @@
> +/*
> + * TI TPS65917 Integrated power management chipsets
> + *
> + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether expressed or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License version 2 for more details.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/moduleparam.h>
> +#include <linux/init.h>
> +#include <linux/slab.h>
> +#include <linux/i2c.h>
> +#include <linux/interrupt.h>
> +#include <linux/irq.h>
> +#include <linux/regmap.h>
> +#include <linux/err.h>
> +#include <linux/mfd/core.h>
> +#include <linux/mfd/tps65917.h>
> +#include <linux/of_device.h>
<snip>
> +
> +static int tps65917_voltaile_regs[] = {
> + TPS65917_SMPS1_CTRL,
> + TPS65917_SMPS2_CTRL,
> + TPS65917_SMPS3_CTRL,
> + TPS65917_SMPS4_CTRL,
> + TPS65917_SMPS5_CTRL,
> + TPS65917_LDO1_CTRL,
> + TPS65917_LDO2_CTRL,
> + TPS65917_LDO3_CTRL,
> + TPS65917_LDO4_CTRL,
> + TPS65917_LDO5_CTRL,
> +};
> +
> +static bool is_volatile_reg(struct device *dev, unsigned int reg)
> +{
> + int i;
> +
> + /*
> + * Caching all the required regulator registers.
> + */
> +
> + for (i = 0; i < 11; i++)
> + if (reg == tps65917_voltaile_regs[i])
> + return true;
> +
> + return false;
> +}
> +
> +static const struct regmap_config tps65917_regmap_config[TPS65917_NUM_CLIENTS] = {
> + {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .volatile_reg = is_volatile_reg,
> + .cache_type = REGCACHE_NONE,
Assume you wanted cached here, since you are marking certain registers
as volatile?
[...]
>
> +};
> +
> +int tps65917_ext_control_req_config(struct tps65917 *tps65917,
> + enum tps65917_external_requestor_id id,
> + int ext_ctrl, bool enable)
> +{
kernel doc style documentation
[...]
> +static struct tps65917 *tps65917_dev;
> +
> +static const struct of_device_id of_tps65917_match_tbl[] = {
> + {
> + .compatible = "ti,tps65917",
> + },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, of_tps65917_match_tbl);
> +
> +static int tps65917_i2c_probe(struct i2c_client *i2c,
> + const struct i2c_device_id *id)
> +{
[...]
> + /*
> + * If we are probing with DT do this the DT way and return here
> + * otherwise continue and add devices using mfd helpers.
> + */
> + if (node) {
> + ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
> + if (ret < 0)
> + goto err_irq;
> + else if (pdata->pm_off && !pm_power_off)
> + tps65917_dev = tps65917;
and where is the actual power off function?
> + }
> +
> + return ret;
> +
> +err_irq:
> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
> +err_i2c:
> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
> + if (tps65917->i2c_clients[i])
> + i2c_unregister_device(tps65917->i2c_clients[i]);
> + }
> + return ret;
> +}
> +
> +static int tps65917_i2c_remove(struct i2c_client *i2c)
> +{
> + struct tps65917 *tps65917 = i2c_get_clientdata(i2c);
> + int i;
> +
> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
> +
> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
> + if (tps65917->i2c_clients[i])
> + i2c_unregister_device(tps65917->i2c_clients[i]);
> + }
> +
> + return 0;
> +}
> +
> +static const struct i2c_device_id tps65917_i2c_id[] = {
> + { "tps65917", },
> +};
> +MODULE_DEVICE_TABLE(i2c, tps65917_i2c_id);
> +
> +static struct i2c_driver tps65917_i2c_driver = {
> + .driver = {
> + .name = "tps65917",
> + .of_match_table = of_tps65917_match_tbl,
> + .owner = THIS_MODULE,
> + },
> + .probe = tps65917_i2c_probe,
> + .remove = tps65917_i2c_remove,
> + .id_table = tps65917_i2c_id,
> +};
> +
> +static int __init tps65917_i2c_init(void)
> +{
> + return i2c_add_driver(&tps65917_i2c_driver);
> +}
> +/* init early so consumer devices can complete system boot */
> +subsys_initcall(tps65917_i2c_init);
Should we let them just defer?
[...]
> diff --git a/include/linux/mfd/tps65917.h b/include/linux/mfd/tps65917.h
> new file mode 100644
> index 0000000..8232e22
> --- /dev/null
> +++ b/include/linux/mfd/tps65917.h
> +
> +struct tps65917 {
> + struct device *dev;
> +
> + struct i2c_client *i2c_clients[TPS65917_NUM_CLIENTS];
> + struct regmap *regmap[TPS65917_NUM_CLIENTS];
> +
> + /* Stored chip id */
> + int id;
> +
> + struct tps65917_pmic *pmic;
> +
> + /* IRQ Data */
> + int irq;
> + u32 irq_mask;
> + /* mutext for irq */
> + struct mutex irq_lock;
> + struct regmap_irq_chip_data *irq_data;
> +};
For all structures, could you use kerneldoc style documentation?
See: Documentation/kernel-doc-nano-HOWTO.txt +273
> +static inline int tps65917_read(struct tps65917 *tps65917, unsigned int base,
> + unsigned int reg, unsigned int *val)
Again for all functions expected to be called by other driver(such as
regulator) to mfd, kernel-doc style documentation?
[...]
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC
2014-05-20 13:58 ` Lee Jones
@ 2014-05-20 17:24 ` Keerthy
0 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 17:24 UTC (permalink / raw)
To: Lee Jones
Cc: Keerthy, devicetree, robh+dt, mark.rutland, sameo, grant.likely,
ian, linux-doc, linux-kernel, broonie, swarren, linux-omap
Hi Lee Jones,
Thanks for the review.
On Tuesday 20 May 2014 07:28 PM, Lee Jones wrote:
>> The TPS65917 chip is a power management IC for Portable Navigation Systems
>> and Tablet Computing devices. It contains the following components:
>>
>> - Regulators.
>> - Over Temperature warning and Shut down.
>>
>> This patch adds support for tps65917 mfd device. At this time only
>> the regulator functionality is made available.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> Changes in V2:
>>
>> Added volatile register check as some of the registers
>> in the set are volatile.
>>
>> drivers/mfd/Kconfig | 12 +
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/tps65917.c | 573 ++++++++++++++++
> We have quite the collection of tps* files now in MFD. How different
> are they really? Is consolidation possible?
Unfortunately yes! This is pretty similar to Palmas. Register offsets
are completely different and i have already compensated TPS659038
which essentially had the same register set.
I am pretty much based on Palmas driver but most of the register offsets
are different and this is a much smaller and simpler PMIC. Hence
adding a new driver.
>
>> include/linux/mfd/tps65917.h | 1509 ++++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 2095 insertions(+)
>> create mode 100644 drivers/mfd/tps65917.c
>> create mode 100644 include/linux/mfd/tps65917.h
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 3383412..ac73e58 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -925,6 +925,18 @@ config MFD_TPS65912_SPI
>> If you say yes here you get support for the TPS65912 series of
>> PM chips with SPI interface.
>>
>> +config MFD_TPS65917
>> + bool "TI TPS65917 series chips"
>> + select MFD_CORE
>> + select REGMAP_I2C
>> + select REGMAP_IRQ
>> + depends on I2C=y
>> + help
>> + If you say yes here you get support for the TPS65917
>> + PMIC chips from Texas Instruments. The device provides
>> + 5 confgurable SPMSs and 5 LDOs, thermal protection module,
>> + GPADC.
>> +
>> config MFD_TPS80031
>> bool "TI TPS80031/TPS80032 Power Management chips"
>> depends on I2C=y
>> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
>> index 2851275..248a60b 100644
>> --- a/drivers/mfd/Makefile
>> +++ b/drivers/mfd/Makefile
>> @@ -69,6 +69,7 @@ tps65912-objs := tps65912-core.o tps65912-irq.o
>> obj-$(CONFIG_MFD_TPS65912) += tps65912.o
>> obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o
>> obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o
>> +obj-$(CONFIG_MFD_TPS65917) += tps65917.o
>> obj-$(CONFIG_MFD_TPS80031) += tps80031.o
>> obj-$(CONFIG_MENELAUS) += menelaus.o
>>
>> diff --git a/drivers/mfd/tps65917.c b/drivers/mfd/tps65917.c
>> new file mode 100644
>> index 0000000..dbd67c5
>> --- /dev/null
>> +++ b/drivers/mfd/tps65917.c
>> @@ -0,0 +1,573 @@
>> +/*
>> + * TI TPS65917 Integrated power management chipsets
>> + *
>> + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
>> + * kind, whether expressed or implied; without even the implied warranty
>> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License version 2 for more details.
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/moduleparam.h>
>> +#include <linux/init.h>
>> +#include <linux/slab.h>
>> +#include <linux/i2c.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/irq.h>
>> +#include <linux/regmap.h>
>> +#include <linux/err.h>
>> +#include <linux/mfd/core.h>
>> +#include <linux/mfd/tps65917.h>
>> +#include <linux/of_device.h>
>> +
>> +#define TPS65917_EXT_REQ (TPS65917_EXT_CONTROL_ENABLE1 | \
>> + TPS65917_EXT_CONTROL_ENABLE2 | \
>> + TPS65917_EXT_CONTROL_NSLEEP)
>> +
>> +struct tps65917_sleep_requestor_info {
>> + int id;
>> + int reg_offset;
>> + int bit_pos;
>> +};
>> +
>> +#define EXTERNAL_REQUESTOR(_id, _offset, _pos) \
>> + [TPS65917_EXTERNAL_REQSTR_ID_##_id] = { \
>> + .id = TPS65917_EXTERNAL_REQSTR_ID_##_id, \
>> + .reg_offset = _offset, \
>> + .bit_pos = _pos, \
>> + }
>> +
>> +static struct tps65917_sleep_requestor_info sleep_req_info[] = {
>> + EXTERNAL_REQUESTOR(REGEN1, 0, 0),
>> + EXTERNAL_REQUESTOR(REGEN2, 0, 1),
>> + EXTERNAL_REQUESTOR(REGEN3, 0, 6),
>> + EXTERNAL_REQUESTOR(SMPS1, 1, 0),
>> + EXTERNAL_REQUESTOR(SMPS2, 1, 1),
>> + EXTERNAL_REQUESTOR(SMPS3, 1, 2),
>> + EXTERNAL_REQUESTOR(SMPS4, 1, 3),
>> + EXTERNAL_REQUESTOR(SMPS5, 1, 4),
>> + EXTERNAL_REQUESTOR(LDO1, 2, 0),
>> + EXTERNAL_REQUESTOR(LDO2, 2, 1),
>> + EXTERNAL_REQUESTOR(LDO3, 2, 2),
>> + EXTERNAL_REQUESTOR(LDO4, 2, 3),
>> + EXTERNAL_REQUESTOR(LDO5, 2, 4),
>> +};
>> +
>> +static int tps65917_voltaile_regs[] = {
>> + TPS65917_SMPS1_CTRL,
>> + TPS65917_SMPS2_CTRL,
>> + TPS65917_SMPS3_CTRL,
>> + TPS65917_SMPS4_CTRL,
>> + TPS65917_SMPS5_CTRL,
>> + TPS65917_LDO1_CTRL,
>> + TPS65917_LDO2_CTRL,
>> + TPS65917_LDO3_CTRL,
>> + TPS65917_LDO4_CTRL,
>> + TPS65917_LDO5_CTRL,
>> +};
>> +
>> +static bool is_volatile_reg(struct device *dev, unsigned int reg)
>> +{
>> + int i;
>> +
>> + /*
>> + * Caching all the required regulator registers.
>> + */
>> +
>> + for (i = 0; i < 11; i++)
> Are you sure? Looks like 10 to me.
>
> Use ARRAY_SIZE(tps65917_voltaile_regs) instead
I will use
ARRAY_SIZE(tps65917_voltaile_regs)
.
>
>> + if (reg == tps65917_voltaile_regs[i])
>> + return true;
>> +
>> + return false;
>> +}
> [...]
>
>> +int tps65917_ext_control_req_config(struct tps65917 *tps65917,
>> + enum tps65917_external_requestor_id id,
>> + int ext_ctrl, bool enable)
>> +{
>> + int preq_mask_bit = 0;
>> + int reg_add = 0;
>> + int bit_pos;
>> + int ret;
>> +
>> + if (!(ext_ctrl & TPS65917_EXT_REQ))
>> + return 0;
>> +
>> + if (id >= TPS65917_EXTERNAL_REQSTR_ID_MAX)
>> + return 0;
>> +
>> + if (ext_ctrl & TPS65917_EXT_CONTROL_NSLEEP) {
>> + reg_add = TPS65917_NSLEEP_RES_ASSIGN;
>> + preq_mask_bit = 0;
>> + } else if (ext_ctrl & TPS65917_EXT_CONTROL_ENABLE1) {
>> + reg_add = TPS65917_ENABLE1_RES_ASSIGN;
>> + preq_mask_bit = 1;
>> + } else if (ext_ctrl & TPS65917_EXT_CONTROL_ENABLE2) {
>> + reg_add = TPS65917_ENABLE2_RES_ASSIGN;
>> + preq_mask_bit = 2;
>> + }
>> +
>> + bit_pos = sleep_req_info[id].bit_pos;
>> + reg_add += sleep_req_info[id].reg_offset;
> New line here.
Ok.
>> + if (enable)
>> + ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
>> + reg_add, BIT(bit_pos), BIT(bit_pos));
>> + else
>> + ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
>> + reg_add, BIT(bit_pos), 0);
> Would prefer:
>
> ret = tps65917_update_bits(tps65917, TPS65917_RESOURCE_BASE,
> reg_add, BIT(bit_pos),
> enable ? BIT(bit_pos) : 0);
Ok. I will do it this way.
>> + if (ret < 0) {
>> + dev_err(tps65917->dev, "Resource reg 0x%02x update failed %d\n",
>> + reg_add, ret);
>> + return ret;
>> + }
>> +
>> + /* Unmask the PREQ */
>> + ret = tps65917_update_bits(tps65917, TPS65917_PMU_CONTROL_BASE,
>> + TPS65917_POWER_CTRL, BIT(preq_mask_bit), 0);
>> + if (ret < 0) {
>> + dev_err(tps65917->dev, "POWER_CTRL register update failed %d\n",
>> + ret);
>> + return ret;
>> + }
>> + return ret;
> Just display the error - the function returns 'ret' regardless.
Ok.
>
>> +}
>> +EXPORT_SYMBOL_GPL(tps65917_ext_control_req_config);
>> +
>> +static int tps65917_set_pdata_irq_flag(struct i2c_client *i2c,
>> + struct tps65917_platform_data *pdata)
>> +{
>> + struct irq_data *irq_data = irq_get_irq_data(i2c->irq);
> New line here.
Ok
>
>> + if (!irq_data) {
>> + dev_err(&i2c->dev, "Invalid IRQ: %d\n", i2c->irq);
>> + return -EINVAL;
>> + }
>> +
>> + pdata->irq_flags = irqd_get_trigger_type(irq_data);
>> + dev_info(&i2c->dev, "Irq flag is 0x%08x\n", pdata->irq_flags);
> Is this line really required?
>
> New line here.
Yeah this is more dev_dbg. I will make it dev_dbg message.
>> + return 0;
>> +}
>> +
>> +static void tps65917_dt_to_pdata(struct i2c_client *i2c,
>> + struct tps65917_platform_data *pdata)
>> +{
>> + struct device_node *node = i2c->dev.of_node;
> What kind of node?
>
> Personally, I'd prefer the use of 'np' as a variable name.
Ok.
>> + int ret;
>> + u32 prop;
>> +
>> + ret = of_property_read_u32(node, "ti,mux-pad1", &prop);
>> + if (!ret) {
>> + pdata->mux_from_pdata = 1;
> This should be a bool.
>
>> + pdata->pad1 = prop;
>> + }
>> +
>> + ret = of_property_read_u32(node, "ti,mux-pad2", &prop);
>> + if (!ret) {
>> + pdata->mux_from_pdata = 1;
> As above.
Ok.
>
>> + pdata->pad2 = prop;
>> + }
>> +
>> + /* The default for this register is all masked */n
>> + ret = of_property_read_u32(node, "ti,power-ctrl", &prop);
>> + if (!ret)
>> + pdata->power_ctrl = prop;
>> + else
>> + pdata->power_ctrl = TPS65917_POWER_CTRL_NSLEEP_MASK |
>> + TPS65917_POWER_CTRL_ENABLE1_MASK |
>> + TPS65917_POWER_CTRL_ENABLE2_MASK;
>> + if (i2c->irq)
>> + tps65917_set_pdata_irq_flag(i2c, pdata);
> What's the point of tps65917_set_pdata_irq_flag() providing a return
> value and then not checking it?
Yes. I will remove this check. Largely borrowed from Palmas driver.
>
>> + pdata->pm_off = of_property_read_bool(node,
>> + "ti,system-power-controller");
>> +}
>> +
>> +static struct tps65917 *tps65917_dev;
> This is never used.
>
>> +static const struct of_device_id of_tps65917_match_tbl[] = {
>> + {
>> + .compatible = "ti,tps65917",
>> + },
> This can all sit on one line.
Ok.
>
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, of_tps65917_match_tbl);
>> +
>> +static int tps65917_i2c_probe(struct i2c_client *i2c,
>> + const struct i2c_device_id *id)
>> +{
>> + struct tps65917 *tps65917;
>> + struct tps65917_platform_data *pdata;
>> + struct device_node *node = i2c->dev.of_node;
>> + int ret = 0, i;
> Break these into separate declarations.
>
> Nit: Put them with the other int declaration(s).
Ok.
>
>> + unsigned int reg, addr, *features;
>> + int slave;
>> + const struct of_device_id *match;
>> +
>> + pdata = dev_get_platdata(&i2c->dev);
>> +
>> + if (node && !pdata) {
>> + pdata = devm_kzalloc(&i2c->dev, sizeof(*pdata), GFP_KERNEL);
>> +
> Remove this line.
Ok.
>> + if (!pdata)
>> + return -ENOMEM;
>> +
>> + tps65917_dt_to_pdata(i2c, pdata);
> I'm sure we can fail here.
They are optional properties. Hence no check.
>
>> + }
>> +
>> + if (!pdata)
>> + return -EINVAL;
>> +
>> + tps65917 = devm_kzalloc(&i2c->dev, sizeof(struct tps65917), GFP_KERNEL);
>> + if (tps65917 == NULL)
> if (!tps65917)
Ok
>
>> + return -ENOMEM;
>> +
>> + i2c_set_clientdata(i2c, tps65917);
> Do this at the end after a clean start-up.
>
>> + tps65917->dev = &i2c->dev;
>> + tps65917->irq = i2c->irq;
> Or just save i2c.
>
>> + match = of_match_device(of_tps65917_match_tbl, &i2c->dev);
>> +
> Remove this line.
Ok
>> + if (!match)
>> + return -ENODATA;
>> +
>> + features = (unsigned int *)match->data;
> This will be NULL, please remove it.
>
> In fact, why are you even checking for a match?
>
> You only support one device.
Ok. Yes agreed.
>
>> + for (i = 0; i < TPS65917_NUM_CLIENTS; i++) {
>> + if (i == 0) {
>> + tps65917->i2c_clients[i] = i2c;
>> + } else {
>> + tps65917->i2c_clients[i] =
>> + i2c_new_dummy(i2c->adapter,
>> + i2c->addr + i);
>> + if (!tps65917->i2c_clients[i]) {
>> + dev_err(tps65917->dev,
>> + "can't attach client %d\n", i);
>> + ret = -ENOMEM;
>> + goto err_i2c;
>> + }
>> + tps65917->i2c_clients[i]->dev.of_node = of_node_get(node);
>> + }
> New line here.
Ok.
>> + tps65917->regmap[i] = devm_regmap_init_i2c(tps65917->i2c_clients[i],
>> + &tps65917_regmap_config[i]);
>> + if (IS_ERR(tps65917->regmap[i])) {
>> + ret = PTR_ERR(tps65917->regmap[i]);
>> + dev_err(tps65917->dev,
>> + "Failed to allocate regmap %d, err: %d\n",
>> + i, ret);
>> + goto err_i2c;
>> + }
>> + }
>> +
>> + if (!tps65917->irq) {
>> + dev_warn(tps65917->dev, "IRQ missing: skipping irq request\n");
>> + goto no_irq;
>> + }
>> +
>> + /* Change interrupt line output polarity */
>> + if (pdata->irq_flags & IRQ_TYPE_LEVEL_HIGH)
>> + reg = TPS65917_POLARITY_CTRL_INT_POLARITY;
>> + else
>> + reg = 0;
>> + ret = tps65917_update_bits(tps65917, TPS65917_PU_PD_OD_BASE,
>> + TPS65917_POLARITY_CTRL,
>> + TPS65917_POLARITY_CTRL_INT_POLARITY, reg);
> Do you need to do this if reg == 0?
No. This can go under if.
>
>> + if (ret < 0) {
>> + dev_err(tps65917->dev, "POLARITY_CTRL updat failed: %d\n", ret);
>> + goto err_i2c;
>> + }
>> +
>> + /* Change IRQ into clear on read mode for efficiency */
>> + slave = TPS65917_BASE_TO_SLAVE(TPS65917_INTERRUPT_BASE);
>> + addr = TPS65917_BASE_TO_REG(TPS65917_INTERRUPT_BASE, TPS65917_INT_CTRL);
>> + reg = TPS65917_INT_CTRL_INT_CLEAR;
>> +
>> + regmap_write(tps65917->regmap[slave], addr, reg);
>> +
>> + ret = regmap_add_irq_chip(tps65917->regmap[slave], tps65917->irq,
>> + IRQF_ONESHOT | pdata->irq_flags, 0,
>> + &tps65917_irq_chip,
>> + &tps65917->irq_data);
>> + if (ret < 0)
>> + goto err_i2c;
>> +
>> +no_irq:
>> + slave = TPS65917_BASE_TO_SLAVE(TPS65917_PU_PD_OD_BASE);
>> + addr = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
>> + TPS65917_PRIMARY_SECONDARY_PAD1);
>> +
>> + if (pdata->mux_from_pdata) {
>> + reg = pdata->pad1;
>> + ret = regmap_write(tps65917->regmap[slave], addr, reg);
>> + if (ret)
>> + goto err_irq;
>> + } else {
>> + ret = regmap_read(tps65917->regmap[slave], addr, ®);
>> + if (ret)
>> + goto err_irq;
>> + }
> Comment this to let us know what you're trying to do.
Ok.
>> + addr = TPS65917_BASE_TO_REG(TPS65917_PU_PD_OD_BASE,
>> + TPS65917_PRIMARY_SECONDARY_PAD2);
>> +
>> + if (pdata->mux_from_pdata) {
>> + reg = pdata->pad2;
>> + ret = regmap_write(tps65917->regmap[slave], addr, reg);
>> + if (ret)
>> + goto err_irq;
>> + } else {
>> + ret = regmap_read(tps65917->regmap[slave], addr, ®);
>> + if (ret)
>> + goto err_irq;
>> + }
> Same here.
Ok.
>> + reg = pdata->power_ctrl;
>> +
>> + slave = TPS65917_BASE_TO_SLAVE(TPS65917_PMU_CONTROL_BASE);
>> + addr = TPS65917_BASE_TO_REG(TPS65917_PMU_CONTROL_BASE,
>> + TPS65917_POWER_CTRL);
>> +
>> + ret = regmap_write(tps65917->regmap[slave], addr, reg);
>> + if (ret)
>> + goto err_irq;
> And here.
>
>> + /*
>> + * If we are probing with DT do this the DT way and return here
>> + * otherwise continue and add devices using mfd helpers.
> MFD
Ok
>
>> + */
>> + if (node) {
>> + ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
> What is it you're registering here? I don't see any child devices
> anywhere.
>
>> + if (ret < 0)
>> + goto err_irq;
>> + else if (pdata->pm_off && !pm_power_off)
> No need for the else.
Ok
>
>> + tps65917_dev = tps65917;
> What does this do?
>
>> + }
>> +
>> + return ret;
> Where does it continue and add devices using the MFD helpers?
I will remove this part.
>
>> +err_irq:
>> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
>> +err_i2c:
>> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
>> + if (tps65917->i2c_clients[i])
>> + i2c_unregister_device(tps65917->i2c_clients[i]);
>> + }
> New line here.
Ok.
>
>> + return ret;
>> +}
>> +
>> +static int tps65917_i2c_remove(struct i2c_client *i2c)
>> +{
>> + struct tps65917 *tps65917 = i2c_get_clientdata(i2c);
>> + int i;
>> +
>> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
>> +
>> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
>> + if (tps65917->i2c_clients[i])
>> + i2c_unregister_device(tps65917->i2c_clients[i]);
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static const struct i2c_device_id tps65917_i2c_id[] = {
>> + { "tps65917", },
>> +};
>> +MODULE_DEVICE_TABLE(i2c, tps65917_i2c_id);
>> +
>> +static struct i2c_driver tps65917_i2c_driver = {
>> + .driver = {
>> + .name = "tps65917",
>> + .of_match_table = of_tps65917_match_tbl,
> of_match_ptr()
Ok
>
>> + .owner = THIS_MODULE,
>> + },
>> + .probe = tps65917_i2c_probe,
>> + .remove = tps65917_i2c_remove,
>> + .id_table = tps65917_i2c_id,
>> +};
>> +
>> +static int __init tps65917_i2c_init(void)
>> +{
>> + return i2c_add_driver(&tps65917_i2c_driver);
>> +}
>> +/* init early so consumer devices can complete system boot */
> Defer?
>
>> +subsys_initcall(tps65917_i2c_init);
>> +
>> +static void __exit tps65917_i2c_exit(void)
>> +{
>> + i2c_del_driver(&tps65917_i2c_driver);
>> +}
>> +module_exit(tps65917_i2c_exit);
>> +
>> +MODULE_AUTHOR("J Keerthy <j-keerthy@ti.com>");
>> +MODULE_DESCRIPTION("TPS65917 chip family multi-function driver");
> Multi-Function Driver
>
ok
>> +MODULE_LICENSE("GPL v2");
>> diff --git a/include/linux/mfd/tps65917.h b/include/linux/mfd/tps65917.h
>> new file mode 100644
>> index 0000000..8232e22
>> --- /dev/null
>> +++ b/include/linux/mfd/tps65917.h
>> @@ -0,0 +1,1509 @@
>> +/*
>> + * TI TPS65917
>> + *
>> + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
>> + * kind, whether expressed or implied; without even the implied warranty
>> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License version 2 for more details.
>> + */
>> +
>> +#ifndef __LINUX_MFD_TPS65917_H
>> +#define __LINUX_MFD_TPS65917_H
>> +
>> +#include <linux/regmap.h>
>> +#include <linux/regulator/driver.h>
>> +
>> +#define TPS65917_NUM_CLIENTS 3
>> +
>> +/* The ID_REVISION NUMBERS */
>> +#define TPS65917_CHIP_ID 0xC035
>> +#define TPS65917_RESERVED -1
> Line up with tabs.
Ok
>> +struct tps65917 {
>> + struct device *dev;
>> +
>> + struct i2c_client *i2c_clients[TPS65917_NUM_CLIENTS];
>> + struct regmap *regmap[TPS65917_NUM_CLIENTS];
>> +
>> + /* Stored chip id */
>> + int id;
> Where is this used?
for this driver this seems redundant. I will remove this.
>> + struct tps65917_pmic *pmic;
>> +
>> + /* IRQ Data */
>> + int irq;
>> + u32 irq_mask;
>> + /* mutext for irq */
>> + struct mutex irq_lock;
>> + struct regmap_irq_chip_data *irq_data;
>> +};
>> +
>> +struct tps65917_reg_init {
>> + /* warm_rest controls the voltage levels after a warm reset
>> + *
>> + * 0: reload default values from OTP on warm reset
>> + * 1: maintain voltage from VSEL on warm reset
>> + */
> Unusual looking comment, please correct.
>
>> + int warm_reset;
> Looks like a bool to me.
I will change it to bool
>> + /* roof_floor controls whether the regulator uses the i2c style
>> + * of DVS or uses the method where a GPIO or other control method is
>> + * attached to the NSLEEP/ENABLE1/ENABLE2 pins
>> + *
>> + * For SMPS
>> + *
>> + * 0: i2c selection of voltage
>> + * 1: pin selection of voltage.
>> + *
>> + * For LDO unused
>> + */
> Same here. Top line should not be populated.
Ok
>> + int roof_floor;
> Only two values is a bool.
ok
>> + /* sleep_mode is the mode loaded to MODE_SLEEP bits as defined in
>> + * the data sheet.
>> + *
>> + * For SMPS
>> + *
>> + * 0: Off
>> + * 1: AUTO
>> + * 2: ECO
>> + * 3: Forced PWM
>> + *
>> + * For LDO
>> + *
>> + * 0: Off
>> + * 1: On
>> + */
>> + int mode_sleep;
>> +
>> + /* voltage_sel is the bitfield loaded onto the SMPSX_VOLTAGE
>> + * register. Set this is the default voltage set in OTP needs
>> + * to be overridden.
>> + */
>> + u8 vsel;
>> +};
>> +
>> +enum tps65917_regulators {
>> + /* SMPS regulators */
>> + TPS65917_REG_SMPS1,
>> + TPS65917_REG_SMPS2,
>> + TPS65917_REG_SMPS3,
>> + TPS65917_REG_SMPS4,
>> + TPS65917_REG_SMPS5,
>> + /* LDO regulators */
>> + TPS65917_REG_LDO1,
>> + TPS65917_REG_LDO2,
>> + TPS65917_REG_LDO3,
>> + TPS65917_REG_LDO4,
>> + TPS65917_REG_LDO5,
>> + TPS65917_REG_REGEN1,
>> + TPS65917_REG_REGEN2,
>> + TPS65917_REG_REGEN3,
>> +
>> + /* Total number of regulators */
>> + TPS65917_NUM_REGS,
>> +};
>> +
>> +struct tps65917_pmic_platform_data {
>> + /* An array of pointers to regulator init data indexed by regulator
>> + * ID
>> + */
> Odd multi-line comments throughout.
oops. I will correct this.
>
>> + struct regulator_init_data *reg_data[TPS65917_NUM_REGS];
>> +
>> + /* An array of pointers to structures containing sleep mode and DVS
>> + * configuration for regulators indexed by ID
>> + */
>> + struct tps65917_reg_init *reg_init[TPS65917_NUM_REGS];
>> +};
>> +
>> +
>> +struct tps65917_platform_data {
>> + int irq_flags;
>> + int gpio_base;
>> +
>> + /* bit value to be loaded to the POWER_CTRL register */
>> + u8 power_ctrl;
>> +
>> + /*
>> + * boolean to select if we want to configure muxing here
>> + * then the two value to load into the registers if true
>> + */
>> + int mux_from_pdata;
>> + u8 pad1, pad2;
>> + bool pm_off;
>> +
>> + struct tps65917_pmic_platform_data *pmic_pdata;
>> +};
>> +
>> +/* Define the tps65917 IRQ numbers */
>> +enum tps65917_irqs {
>> + /* INT1 registers */
>> + TPS65917_RESERVED1,
>> + TPS65917_PWRON_IRQ,
>> + TPS65917_LONG_PRESS_KEY_IRQ,
>> + TPS65917_RESERVED2,
>> + TPS65917_PWRDOWN_IRQ,
>> + TPS65917_HOTDIE_IRQ,
>> + TPS65917_VSYS_MON_IRQ,
>> + TPS65917_RESERVED3,
>> + /* INT2 registers */
>> + TPS65917_RESERVED4,
>> + TPS65917_OTP_ERROR_IRQ,
>> + TPS65917_WDT_IRQ,
>> + TPS65917_RESERVED5,
>> + TPS65917_RESET_IN_IRQ,
>> + TPS65917_FSD_IRQ,
>> + TPS65917_SHORT_IRQ,
>> + TPS65917_RESERVED6,
>> + /* INT3 registers */
>> + TPS65917_GPADC_AUTO_0_IRQ,
>> + TPS65917_GPADC_AUTO_1_IRQ,
>> + TPS65917_GPADC_EOC_SW_IRQ,
>> + TPS65917_RESREVED6,
>> + TPS65917_RESERVED7,
>> + TPS65917_RESERVED8,
>> + TPS65917_RESERVED9,
>> + TPS65917_VBUS_IRQ,
>> + /* INT4 registers */
>> + TPS65917_GPIO_0_IRQ,
>> + TPS65917_GPIO_1_IRQ,
>> + TPS65917_GPIO_2_IRQ,
>> + TPS65917_GPIO_3_IRQ,
>> + TPS65917_GPIO_4_IRQ,
>> + TPS65917_GPIO_5_IRQ,
>> + TPS65917_GPIO_6_IRQ,
>> + TPS65917_RESERVED10,
>> + /* Total Number IRQs */
>> + TPS65917_NUM_IRQ,
>> +};
>> +
>> +/* External controll signal name */
> Spelling.
I will correct this.
>
>> +enum {
>> + TPS65917_EXT_CONTROL_ENABLE1 = 0x1,
>> + TPS65917_EXT_CONTROL_ENABLE2 = 0x2,
>> + TPS65917_EXT_CONTROL_NSLEEP = 0x4,
>> +};
>> +
>> +/*
>> + * TPS65917 device resources can be controlled externally for
>> + * enabling/disabling it rather than register write through i2c.
>> + * Add the external controlled requestor ID for different resources.
>> + */
>> +enum tps65917_external_requestor_id {
>> + TPS65917_EXTERNAL_REQSTR_ID_REGEN1,
>> + TPS65917_EXTERNAL_REQSTR_ID_REGEN2,
>> + TPS65917_EXTERNAL_REQSTR_ID_REGEN3,
>> + TPS65917_EXTERNAL_REQSTR_ID_SMPS1,
>> + TPS65917_EXTERNAL_REQSTR_ID_SMPS2,
>> + TPS65917_EXTERNAL_REQSTR_ID_SMPS3,
>> + TPS65917_EXTERNAL_REQSTR_ID_SMPS4,
>> + TPS65917_EXTERNAL_REQSTR_ID_SMPS5,
>> + TPS65917_EXTERNAL_REQSTR_ID_LDO1,
>> + TPS65917_EXTERNAL_REQSTR_ID_LDO2,
>> + TPS65917_EXTERNAL_REQSTR_ID_LDO3,
>> + TPS65917_EXTERNAL_REQSTR_ID_LDO4,
>> + TPS65917_EXTERNAL_REQSTR_ID_LDO5,
>> + /* Last entry */
>> + TPS65917_EXTERNAL_REQSTR_ID_MAX,
>> +};
>> +
>> +struct tps65917_pmic {
>> + struct tps65917 *tps65917;
>> + struct device *dev;
>> + struct regulator_desc desc[TPS65917_NUM_REGS];
>> + struct regulator_dev *rdev[TPS65917_NUM_REGS];
>> + /* pmic mutex */
>> + struct mutex mutex;
>> + int smps12;
>> + int range[TPS65917_REG_SMPS5];
>> + unsigned int ramp_delay[TPS65917_REG_SMPS5];
>> + unsigned int current_reg_mode[TPS65917_REG_SMPS5];
>> +};
>> +
>> +/* helper macro to get correct slave number */
>> +#define TPS65917_BASE_TO_SLAVE(x) ((x >> 8) - 1)
>> +#define TPS65917_BASE_TO_REG(x, y) ((x & 0xff) + y)
>> +
>> +/* Base addresses of IP blocks in TPS65917 */
>> +#define TPS65917_SMPS_DVS_BASE 0x20
>> +#define TPS65917_VALIDITY_BASE 0x118
>> +#define TPS65917_SMPS_BASE 0x120
>> +#define TPS65917_LDO_BASE 0x150
>> +#define TPS65917_DVFS_BASE 0x180
>> +#define TPS65917_PMU_CONTROL_BASE 0x1A0
>> +#define TPS65917_RESOURCE_BASE 0x1D4
>> +#define TPS65917_PU_PD_OD_BASE 0x1F0
>> +#define TPS65917_LED_BASE 0x200
>> +#define TPS65917_INTERRUPT_BASE 0x210
>> +#define TPS65917_GPIO_BASE 0x280
>> +#define TPS65917_GPADC_BASE 0x2C0
>> +#define TPS65917_TRIM_GPADC_BASE 0x3CD
>> +
>> +/* Registers for function BACKUP */
>> +#define TPS65917_BACKUP0 0x0
>> +#define TPS65917_BACKUP1 0x1
>> +#define TPS65917_BACKUP2 0x2
>> +#define TPS65917_BACKUP3 0x3
>> +#define TPS65917_BACKUP4 0x4
>> +#define TPS65917_BACKUP5 0x5
>> +#define TPS65917_BACKUP6 0x6
>> +#define TPS65917_BACKUP7 0x7
>> +
>> +/* Bit definitions for BACKUP0 */
>> +#define TPS65917_BACKUP0_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP0_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP1 */
>> +#define TPS65917_BACKUP1_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP1_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP2 */
>> +#define TPS65917_BACKUP2_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP2_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP3 */
>> +#define TPS65917_BACKUP3_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP3_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP4 */
>> +#define TPS65917_BACKUP4_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP4_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP5 */
>> +#define TPS65917_BACKUP5_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP5_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP6 */
>> +#define TPS65917_BACKUP6_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP6_BACKUP_SHIFT 0
>> +
>> +/* Bit definitions for BACKUP7 */
>> +#define TPS65917_BACKUP7_BACKUP_MASK 0xff
>> +#define TPS65917_BACKUP7_BACKUP_SHIFT 0
> If they do not differ, remove the number and consolidate:
>
> /* Bit definitions for BACKUP{0-7} */
> #define TPS65917_BACKUP_BACKUP_MASK 0xff
> #define TPS65917_BACKUP_BACKUP_SHIFT 0
Ok
>> +/* Registers for function SMPS */
>> +#define TPS65917_SMPS1_CTRL 0x0
>> +#define TPS65917_SMPS1_FORCE 0x2
>> +#define TPS65917_SMPS1_VOLTAGE 0x3
>> +#define TPS65917_SMPS2_CTRL 0x4
>> +#define TPS65917_SMPS2_FORCE 0x6
>> +#define TPS65917_SMPS2_VOLTAGE 0x7
>> +#define TPS65917_SMPS3_CTRL 0xC
>> +#define TPS65917_SMPS3_FORCE 0xE
>> +#define TPS65917_SMPS3_VOLTAGE 0xF
>> +#define TPS65917_SMPS4_CTRL 0x10
>> +#define TPS65917_SMPS4_VOLTAGE 0x13
>> +#define TPS65917_SMPS5_CTRL 0x18
>> +#define TPS65917_SMPS5_VOLTAGE 0x1B
>> +#define TPS65917_SMPS_CTRL 0x24
>> +#define TPS65917_SMPS_PD_CTRL 0x25
>> +#define TPS65917_SMPS_THERMAL_EN 0x27
>> +#define TPS65917_SMPS_THERMAL_STATUS 0x28
>> +#define TPS65917_SMPS_SHORT_STATUS 0x29
>> +#define TPS65917_SMPS_NEGATIVE_CURRENT_LIMIT_EN 0x2A
>> +#define TPS65917_SMPS_POWERGOOD_MASK1 0x2B
>> +#define TPS65917_SMPS_POWERGOOD_MASK2 0x2C
>> +
>> +/* Bit definitions for SMPS1_CTRL */
>> +#define TPS65917_SMPS1_CTRL_WR_S 0x80
>> +#define TPS65917_SMPS1_CTRL_WR_S_SHIFT 7
>> +#define TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN 0x40
>> +#define TPS65917_SMPS1_CTRL_ROOF_FLOOR_EN_SHIFT 6
>> +#define TPS65917_SMPS1_CTRL_STATUS_MASK 0x30
>> +#define TPS65917_SMPS1_CTRL_STATUS_SHIFT 4
>> +#define TPS65917_SMPS1_CTRL_MODE_SLEEP_MASK 0x0c
>> +#define TPS65917_SMPS1_CTRL_MODE_SLEEP_SHIFT 2
>> +#define TPS65917_SMPS1_CTRL_MODE_ACTIVE_MASK 0x03
>> +#define TPS65917_SMPS1_CTRL_MODE_ACTIVE_SHIFT 0
> Pick a base and stick with it. I suggest hex throughout.
Ok
> [...]
>
>> +/* Bit definitions for SMPS_PLL_CTRL */
>> +
>> +#define TPS65917_SMPS_PLL_CTRL_PLL_EN_PLL_BYPASS_SHIFT 0x8
>> +#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_EN_BYPASS 3
>> +#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_BYPASS_CLK_SHIFT 0x4
>> +#define TPS65917_SMPS_PLL_CTRL_PLL_PLL_BYPASS_CLK 2
>> +
>> +
> Remove this line.
Ok
>> +/* Registers for function LDO */
>> +#define TPS65917_LDO1_CTRL 0x0
>> +#define TPS65917_LDO1_VOLTAGE 0x1
>> +#define TPS65917_LDO2_CTRL 0x2
>> +#define TPS65917_LDO2_VOLTAGE 0x3
>> +#define TPS65917_LDO3_CTRL 0x4
>> +#define TPS65917_LDO3_VOLTAGE 0x5
>> +#define TPS65917_LDO4_CTRL 0xE
>> +#define TPS65917_LDO4_VOLTAGE 0xF
> Also standardise the number of digits represented and either
Ok
> capitalise none or all of the hex letters.
Ok
> [...]
>
>> +static inline int tps65917_read(struct tps65917 *tps65917, unsigned int base,
>> + unsigned int reg, unsigned int *val)
>> +{
>> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
> Extra ' '.
I will remove.
>
>> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
>> +
>> + return regmap_read(tps65917->regmap[slave_id], addr, val);
>> +}
>> +
>> +static inline int tps65917_write(struct tps65917 *tps65917, unsigned int base,
>> + unsigned int reg, unsigned int value)
>> +{
>> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
>> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
>> +
>> + return regmap_write(tps65917->regmap[slave_id], addr, value);
>> +}
>> +
>> +static inline int tps65917_bulk_write(struct tps65917 *tps65917,
>> + unsigned int base,
>> + unsigned int reg, const void *val,
>> + size_t val_count)
>> +{
>> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
>> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
>> +
>> + return regmap_bulk_write(tps65917->regmap[slave_id], addr,
>> + val, val_count);
>> +}
>> +
>> +static inline int tps65917_bulk_read(struct tps65917 *tps65917,
>> + unsigned int base,
>> + unsigned int reg, void *val,
>> + size_t val_count)
>> +{
>> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
>> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
>> +
>> + return regmap_bulk_read(tps65917->regmap[slave_id], addr,
>> + val, val_count);
>> +}
>> +
>> +static inline int tps65917_update_bits(struct tps65917 *tps65917,
>> + unsigned int base, unsigned int reg,
>> + unsigned int mask, unsigned int val)
>> +{
>> + unsigned int addr = TPS65917_BASE_TO_REG(base, reg);
>> + int slave_id = TPS65917_BASE_TO_SLAVE(base);
>> +
>> + return regmap_update_bits(tps65917->regmap[slave_id], addr, mask, val);
>> +}
>> +
>> +static inline int tps65917_irq_get_virq(struct tps65917 *tps65917, int irq)
>> +{
>> + return regmap_irq_get_virq(tps65917->irq_data, irq);
>> +}
> This is quite a lot of overhead. Are you sure you require them?
I will relook at this.
>
>> +int tps65917_ext_control_req_config(struct tps65917 *tps65917,
>> + enum tps65917_external_requestor_id ext_control_req_id,
>> + int ext_ctrl, bool enable);
>> +
>> +#endif /* __LINUX_MFD_TPS65917_H */
Thanks,
Keerthy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC
2014-05-20 14:15 ` Nishanth Menon
@ 2014-05-20 17:40 ` Keerthy
0 siblings, 0 replies; 9+ messages in thread
From: Keerthy @ 2014-05-20 17:40 UTC (permalink / raw)
To: Nishanth Menon
Cc: Keerthy, devicetree, robh+dt, mark.rutland, sameo, grant.likely,
ian, linux-doc, linux-kernel, broonie, swarren, lee.jones,
linux-omap
Hi Nishanth,
On Tuesday 20 May 2014 07:45 PM, Nishanth Menon wrote:
> On 05/20/2014 04:11 AM, Keerthy wrote:
> [...]
>> +config MFD_TPS65917
>> + bool "TI TPS65917 series chips"
>> + select MFD_CORE
>> + select REGMAP_I2C
>> + select REGMAP_IRQ
>> + depends on I2C=y
> ^^ why =y?
Palmas derived. I will knock off the 'y'
>> + help
>> + If you say yes here you get support for the TPS65917
>> + PMIC chips from Texas Instruments. The device provides
>> + 5 confgurable SPMSs and 5 LDOs, thermal protection module,
>> + GPADC.
>> +
>> config MFD_TPS80031
>> bool "TI TPS80031/TPS80032 Power Management chips"
>> depends on I2C=y
>> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
>> index 2851275..248a60b 100644
>> --- a/drivers/mfd/Makefile
>> +++ b/drivers/mfd/Makefile
>> @@ -69,6 +69,7 @@ tps65912-objs := tps65912-core.o tps65912-irq.o
>> obj-$(CONFIG_MFD_TPS65912) += tps65912.o
>> obj-$(CONFIG_MFD_TPS65912_I2C) += tps65912-i2c.o
>> obj-$(CONFIG_MFD_TPS65912_SPI) += tps65912-spi.o
>> +obj-$(CONFIG_MFD_TPS65917) += tps65917.o
>> obj-$(CONFIG_MFD_TPS80031) += tps80031.o
>> obj-$(CONFIG_MENELAUS) += menelaus.o
>>
>> diff --git a/drivers/mfd/tps65917.c b/drivers/mfd/tps65917.c
>> new file mode 100644
>> index 0000000..dbd67c5
>> --- /dev/null
>> +++ b/drivers/mfd/tps65917.c
>> @@ -0,0 +1,573 @@
>> +/*
>> + * TI TPS65917 Integrated power management chipsets
>> + *
>> + * Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com/
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
>> + * kind, whether expressed or implied; without even the implied warranty
>> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License version 2 for more details.
>> + */
>> +
>> +#include <linux/module.h>
>> +#include <linux/moduleparam.h>
>> +#include <linux/init.h>
>> +#include <linux/slab.h>
>> +#include <linux/i2c.h>
>> +#include <linux/interrupt.h>
>> +#include <linux/irq.h>
>> +#include <linux/regmap.h>
>> +#include <linux/err.h>
>> +#include <linux/mfd/core.h>
>> +#include <linux/mfd/tps65917.h>
>> +#include <linux/of_device.h>
> <snip>
>> +
>> +static int tps65917_voltaile_regs[] = {
>> + TPS65917_SMPS1_CTRL,
>> + TPS65917_SMPS2_CTRL,
>> + TPS65917_SMPS3_CTRL,
>> + TPS65917_SMPS4_CTRL,
>> + TPS65917_SMPS5_CTRL,
>> + TPS65917_LDO1_CTRL,
>> + TPS65917_LDO2_CTRL,
>> + TPS65917_LDO3_CTRL,
>> + TPS65917_LDO4_CTRL,
>> + TPS65917_LDO5_CTRL,
>> +};
>> +
>> +static bool is_volatile_reg(struct device *dev, unsigned int reg)
>> +{
>> + int i;
>> +
>> + /*
>> + * Caching all the required regulator registers.
>> + */
>> +
>> + for (i = 0; i < 11; i++)
>> + if (reg == tps65917_voltaile_regs[i])
>> + return true;
>> +
>> + return false;
>> +}
>> +
>> +static const struct regmap_config tps65917_regmap_config[TPS65917_NUM_CLIENTS] = {
>> + {
>> + .reg_bits = 8,
>> + .val_bits = 8,
>> + .volatile_reg = is_volatile_reg,
>> + .cache_type = REGCACHE_NONE,
> Assume you wanted cached here, since you are marking certain registers
> as volatile?
> [...]
Yes. I will correct this.
>> +};
>> +
>> +int tps65917_ext_control_req_config(struct tps65917 *tps65917,
>> + enum tps65917_external_requestor_id id,
>> + int ext_ctrl, bool enable)
>> +{
> kernel doc style documentation
> [...]
>
>> +static struct tps65917 *tps65917_dev;
>> +
>> +static const struct of_device_id of_tps65917_match_tbl[] = {
>> + {
>> + .compatible = "ti,tps65917",
>> + },
>> + { },
>> +};
>> +MODULE_DEVICE_TABLE(of, of_tps65917_match_tbl);
>> +
>> +static int tps65917_i2c_probe(struct i2c_client *i2c,
>> + const struct i2c_device_id *id)
>> +{
> [...]
>> + /*
>> + * If we are probing with DT do this the DT way and return here
>> + * otherwise continue and add devices using mfd helpers.
>> + */
>> + if (node) {
>> + ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
>> + if (ret < 0)
>> + goto err_irq;
>> + else if (pdata->pm_off && !pm_power_off)
>> + tps65917_dev = tps65917;
> and where is the actual power off function?
I will add that.
>
>> + }
>> +
>> + return ret;
>> +
>> +err_irq:
>> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
>> +err_i2c:
>> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
>> + if (tps65917->i2c_clients[i])
>> + i2c_unregister_device(tps65917->i2c_clients[i]);
>> + }
>> + return ret;
>> +}
>> +
>> +static int tps65917_i2c_remove(struct i2c_client *i2c)
>> +{
>> + struct tps65917 *tps65917 = i2c_get_clientdata(i2c);
>> + int i;
>> +
>> + regmap_del_irq_chip(tps65917->irq, tps65917->irq_data);
>> +
>> + for (i = 1; i < TPS65917_NUM_CLIENTS; i++) {
>> + if (tps65917->i2c_clients[i])
>> + i2c_unregister_device(tps65917->i2c_clients[i]);
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static const struct i2c_device_id tps65917_i2c_id[] = {
>> + { "tps65917", },
>> +};
>> +MODULE_DEVICE_TABLE(i2c, tps65917_i2c_id);
>> +
>> +static struct i2c_driver tps65917_i2c_driver = {
>> + .driver = {
>> + .name = "tps65917",
>> + .of_match_table = of_tps65917_match_tbl,
>> + .owner = THIS_MODULE,
>> + },
>> + .probe = tps65917_i2c_probe,
>> + .remove = tps65917_i2c_remove,
>> + .id_table = tps65917_i2c_id,
>> +};
>> +
>> +static int __init tps65917_i2c_init(void)
>> +{
>> + return i2c_add_driver(&tps65917_i2c_driver);
>> +}
>> +/* init early so consumer devices can complete system boot */
>> +subsys_initcall(tps65917_i2c_init);
> Should we let them just defer?
>
> [...]
Guess most drivers in the mfd folder use subsys_initcall
>
>> diff --git a/include/linux/mfd/tps65917.h b/include/linux/mfd/tps65917.h
>> new file mode 100644
>> index 0000000..8232e22
>> --- /dev/null
>> +++ b/include/linux/mfd/tps65917.h
>> +
>> +struct tps65917 {
>> + struct device *dev;
>> +
>> + struct i2c_client *i2c_clients[TPS65917_NUM_CLIENTS];
>> + struct regmap *regmap[TPS65917_NUM_CLIENTS];
>> +
>> + /* Stored chip id */
>> + int id;
>> +
>> + struct tps65917_pmic *pmic;
>> +
>> + /* IRQ Data */
>> + int irq;
>> + u32 irq_mask;
>> + /* mutext for irq */
>> + struct mutex irq_lock;
>> + struct regmap_irq_chip_data *irq_data;
>> +};
> For all structures, could you use kerneldoc style documentation?
> See: Documentation/kernel-doc-nano-HOWTO.txt +273
>
>
>> +static inline int tps65917_read(struct tps65917 *tps65917, unsigned int base,
>> + unsigned int reg, unsigned int *val)
> Again for all functions expected to be called by other driver(such as
> regulator) to mfd, kernel-doc style documentation?
>
> [...]
>
Ok.
Thanks,
Keerthy
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-05-20 17:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-20 9:11 [PATCH v2 0/4] tps65917: Drivers for TPS65917 PMIC Keerthy
2014-05-20 9:11 ` [PATCH v2 1/4] MFD: DT bindings for the TPS65917 family MFD Keerthy
2014-05-20 9:11 ` [PATCH v2 2/4] regulator: Add TPS65917 Bindings Keerthy
2014-05-20 9:11 ` [PATCH v2 3/4] mfd: tps65917: Add driver for the TPS65917 PMIC Keerthy
2014-05-20 13:58 ` Lee Jones
2014-05-20 17:24 ` Keerthy
2014-05-20 14:15 ` Nishanth Menon
2014-05-20 17:40 ` Keerthy
2014-05-20 9:11 ` [PATCH v2 4/4] regulator: tps65917: Add Regulator driver for " Keerthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).