* [PATCH] sound: soc: samsung: dma.c: Fix to remove null pointer checks that could never happen
@ 2014-05-22 20:21 Rickard Strandqvist
2014-05-23 3:10 ` Tushar Behera
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-05-22 20:21 UTC (permalink / raw)
To: Ben Dooks, Kukjin Kim
Cc: Rickard Strandqvist, Sangbeom Kim, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, linux-arm-kernel,
linux-samsung-soc, alsa-devel, linux-kernel
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
sound/soc/samsung/dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c
index dc09b71..0f17ae0 100644
--- a/sound/soc/samsung/dma.c
+++ b/sound/soc/samsung/dma.c
@@ -124,8 +124,7 @@ static void audio_buffdone(void *data)
if (prtd->dma_pos >= prtd->dma_end)
prtd->dma_pos = prtd->dma_start;
- if (substream)
- snd_pcm_period_elapsed(substream);
+ snd_pcm_period_elapsed(substream);
spin_lock(&prtd->lock);
if (!samsung_dma_has_circular()) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: soc: samsung: dma.c: Fix to remove null pointer checks that could never happen
2014-05-22 20:21 [PATCH] sound: soc: samsung: dma.c: Fix to remove null pointer checks that could never happen Rickard Strandqvist
@ 2014-05-23 3:10 ` Tushar Behera
0 siblings, 0 replies; 2+ messages in thread
From: Tushar Behera @ 2014-05-23 3:10 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Ben Dooks, Kukjin Kim, Sangbeom Kim, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, linux-arm-kernel,
linux-samsung-soc, Linux-ALSA, lkml
On 23 May 2014 01:51, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Removal of null pointer checks that could never happen
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
The subject should probably be (at least should start with "ASoC: samsung:")
"ASoC: samsung: Remove redundant null pointer check from dma.c"
With that change,
Reviewed-by: Tushar Behera <tushar.behera@linaro.org>
> sound/soc/samsung/dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c
> index dc09b71..0f17ae0 100644
> --- a/sound/soc/samsung/dma.c
> +++ b/sound/soc/samsung/dma.c
> @@ -124,8 +124,7 @@ static void audio_buffdone(void *data)
> if (prtd->dma_pos >= prtd->dma_end)
> prtd->dma_pos = prtd->dma_start;
>
> - if (substream)
> - snd_pcm_period_elapsed(substream);
> + snd_pcm_period_elapsed(substream);
>
> spin_lock(&prtd->lock);
> if (!samsung_dma_has_circular()) {
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Tushar Behera
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-23 3:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 20:21 [PATCH] sound: soc: samsung: dma.c: Fix to remove null pointer checks that could never happen Rickard Strandqvist
2014-05-23 3:10 ` Tushar Behera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).