linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU_DEBUG
@ 2014-05-22 20:55 Paul Bolle
  2014-05-23 10:10 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2014-05-22 20:55 UTC (permalink / raw)
  To: Linus Walleij, Samuel Ortiz, Lee Jones; +Cc: linux-arm-kernel, linux-kernel

A check for CONFIG_DBX500_PRCMU_DEBUG was added in v3.6. But there's no
Kconfig symbol DBX500_PRCMU_DEBUG. So remove this check.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested. Note that db8500_prcmu_debug_dump() is nowhere to be found in
the tree.

This check has been in the tree for less than two years. Am I being
impatient here?

 drivers/mfd/db8500-prcmu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 7694e0700d34..c248bde367ab 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -2303,9 +2303,6 @@ int prcmu_ac_wake_req(void)
 
 	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
 			msecs_to_jiffies(5000))) {
-#if defined(CONFIG_DBX500_PRCMU_DEBUG)
-		db8500_prcmu_debug_dump(__func__, true, true);
-#endif
 		pr_crit("prcmu: %s timed out (5 s) waiting for a reply.\n",
 			__func__);
 		ret = -EFAULT;
-- 
1.9.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU_DEBUG
  2014-05-22 20:55 [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU_DEBUG Paul Bolle
@ 2014-05-23 10:10 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-05-23 10:10 UTC (permalink / raw)
  To: Paul Bolle; +Cc: Linus Walleij, Samuel Ortiz, linux-arm-kernel, linux-kernel

> A check for CONFIG_DBX500_PRCMU_DEBUG was added in v3.6. But there's no
> Kconfig symbol DBX500_PRCMU_DEBUG. So remove this check.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested. Note that db8500_prcmu_debug_dump() is nowhere to be found in
> the tree.
> 
> This check has been in the tree for less than two years. Am I being
> impatient here?
> 
>  drivers/mfd/db8500-prcmu.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index 7694e0700d34..c248bde367ab 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2303,9 +2303,6 @@ int prcmu_ac_wake_req(void)
>  
>  	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
>  			msecs_to_jiffies(5000))) {
> -#if defined(CONFIG_DBX500_PRCMU_DEBUG)
> -		db8500_prcmu_debug_dump(__func__, true, true);
> -#endif
>  		pr_crit("prcmu: %s timed out (5 s) waiting for a reply.\n",
>  			__func__);
>  		ret = -EFAULT;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-23 10:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 20:55 [PATCH] mfd: db8500-prcmu: remove check for CONFIG_DBX500_PRCMU_DEBUG Paul Bolle
2014-05-23 10:10 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).