* [PATCH] spi: core: Ignore unsupported spi-[tr]x-bus-width property values
@ 2014-05-26 12:05 Geert Uytterhoeven
2014-05-26 14:29 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-05-26 12:05 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-spi, linux-kernel, Geert Uytterhoeven
Rejecting unsupported values of spi-tx-bus-width and spi-rx-bus-width
may break compatibility with future DTs. Just ignore them, falling back
to Single SPI Transfers.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
I thought I sent this before, but I can't find any evidence
drivers/spi/spi.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 074f55f5d5ec..d4f9670b51bc 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1270,11 +1270,10 @@ static void of_register_spi_devices(struct spi_master *master)
spi->mode |= SPI_TX_QUAD;
break;
default:
- dev_err(&master->dev,
- "spi-tx-bus-width %d not supported\n",
- value);
- spi_dev_put(spi);
- continue;
+ dev_warn(&master->dev,
+ "spi-tx-bus-width %d not supported\n",
+ value);
+ break;
}
}
@@ -1289,11 +1288,10 @@ static void of_register_spi_devices(struct spi_master *master)
spi->mode |= SPI_RX_QUAD;
break;
default:
- dev_err(&master->dev,
- "spi-rx-bus-width %d not supported\n",
- value);
- spi_dev_put(spi);
- continue;
+ dev_warn(&master->dev,
+ "spi-rx-bus-width %d not supported\n",
+ value);
+ break;
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: core: Ignore unsupported spi-[tr]x-bus-width property values
2014-05-26 12:05 [PATCH] spi: core: Ignore unsupported spi-[tr]x-bus-width property values Geert Uytterhoeven
@ 2014-05-26 14:29 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-05-26 14:29 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-spi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
On Mon, May 26, 2014 at 02:05:25PM +0200, Geert Uytterhoeven wrote:
> Rejecting unsupported values of spi-tx-bus-width and spi-rx-bus-width
> may break compatibility with future DTs. Just ignore them, falling back
> to Single SPI Transfers.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-26 14:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-26 12:05 [PATCH] spi: core: Ignore unsupported spi-[tr]x-bus-width property values Geert Uytterhoeven
2014-05-26 14:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).