* [PATCH] tools: power: cpupower: bench: parse.c: Cleaning up use of a non-allocated file resource
@ 2014-05-31 0:25 Rickard Strandqvist
0 siblings, 0 replies; only message in thread
From: Rickard Strandqvist @ 2014-05-31 0:25 UTC (permalink / raw)
To: Dominik Brodowski, Thomas Renninger; +Cc: Rickard Strandqvist, linux-kernel
Removing the risk of using a non-allocated file resource
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
tools/power/cpupower/bench/parse.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c
index 543bba1..abc026a 100644
--- a/tools/power/cpupower/bench/parse.c
+++ b/tools/power/cpupower/bench/parse.c
@@ -103,13 +103,16 @@ FILE *prepare_output(const char *dirname)
output = fopen(filename, "w+");
if (output == NULL) {
perror("fopen");
- fprintf(stderr, "error: unable to open logfile\n");
+ fprintf(stderr, "error: unable to open logfile: %s\n",
+ filename);
+ goto out;
}
fprintf(stdout, "Logfile: %s\n", filename);
- free(filename);
fprintf(output, "#round load sleep performance powersave percentage\n");
+out:
+ free(filename);
return output;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-05-31 0:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-31 0:25 [PATCH] tools: power: cpupower: bench: parse.c: Cleaning up use of a non-allocated file resource Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).