linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] ARM: at91/dt: clock fixes
@ 2014-06-13 13:43 Alexandre Belloni
  2014-06-13 13:43 ` [PATCH 1/3] ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values Alexandre Belloni
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-06-13 13:43 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-arm-kernel, linux-kernel, Alexandre Belloni

Some clocks were not properly defined:
 - ICPLL and OUT values for PLLA got mixed on sam9x5 and sam9n12
 - mainck was not correctly defined on sam9261

Alexandre Belloni (3):
  ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values
  ARM: at91/dt: sam9n12: correct PLLA ICPLL and OUT values
  ARM: at91/dt: sam9261: correctly define mainck

 arch/arm/boot/dts/at91sam9261.dtsi | 10 ++++++++--
 arch/arm/boot/dts/at91sam9n12.dtsi |  4 ++--
 arch/arm/boot/dts/at91sam9x5.dtsi  |  4 ++--
 3 files changed, 12 insertions(+), 6 deletions(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/3] ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values
  2014-06-13 13:43 [PATCH 0/3] ARM: at91/dt: clock fixes Alexandre Belloni
@ 2014-06-13 13:43 ` Alexandre Belloni
  2014-06-13 13:43 ` [PATCH 2/3] ARM: at91/dt: sam9n12: " Alexandre Belloni
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-06-13 13:43 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-arm-kernel, linux-kernel, Alexandre Belloni

ICPLL can only take 0 or 1, it got mixed with OUT which can be in the [0-3]
range.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index 1a57298636a5..d6133f497207 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -140,8 +140,8 @@
 								       595000000 650000000 3 0
 								       545000000 600000000 0 1
 								       495000000 555000000 1 1
-								       445000000 500000000 1 2
-								       400000000 450000000 1 3>;
+								       445000000 500000000 2 1
+								       400000000 450000000 3 1>;
 				};
 
 				plladiv: plladivck {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] ARM: at91/dt: sam9n12: correct PLLA ICPLL and OUT values
  2014-06-13 13:43 [PATCH 0/3] ARM: at91/dt: clock fixes Alexandre Belloni
  2014-06-13 13:43 ` [PATCH 1/3] ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values Alexandre Belloni
@ 2014-06-13 13:43 ` Alexandre Belloni
  2014-06-13 13:43 ` [PATCH 3/3] ARM: at91/dt: sam9261: correctly define mainck Alexandre Belloni
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-06-13 13:43 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-arm-kernel, linux-kernel, Alexandre Belloni

ICPLL can only take 0 or 1, it got mixed with OUT which can be in the [0-3]
range.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/boot/dts/at91sam9n12.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi
index d1b82e6635d5..287795985e32 100644
--- a/arch/arm/boot/dts/at91sam9n12.dtsi
+++ b/arch/arm/boot/dts/at91sam9n12.dtsi
@@ -132,8 +132,8 @@
 								      <595000000 650000000 3 0>,
 								      <545000000 600000000 0 1>,
 								      <495000000 555000000 1 1>,
-								      <445000000 500000000 1 2>,
-								      <400000000 450000000 1 3>;
+								      <445000000 500000000 2 1>,
+								      <400000000 450000000 3 1>;
 				};
 
 				plladiv: plladivck {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] ARM: at91/dt: sam9261: correctly define mainck
  2014-06-13 13:43 [PATCH 0/3] ARM: at91/dt: clock fixes Alexandre Belloni
  2014-06-13 13:43 ` [PATCH 1/3] ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values Alexandre Belloni
  2014-06-13 13:43 ` [PATCH 2/3] ARM: at91/dt: sam9n12: " Alexandre Belloni
@ 2014-06-13 13:43 ` Alexandre Belloni
  2014-06-13 14:19 ` [PATCH 0/3] ARM: at91/dt: clock fixes Boris BREZILLON
  2014-06-25 10:37 ` Nicolas Ferre
  4 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2014-06-13 13:43 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-arm-kernel, linux-kernel, Alexandre Belloni

mainck (CKGR_MCFR register) is actually using main_osc (CKGR_MOR register).

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/boot/dts/at91sam9261.dtsi | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91sam9261.dtsi b/arch/arm/boot/dts/at91sam9261.dtsi
index b309c1c6e848..9de312e9bb3e 100644
--- a/arch/arm/boot/dts/at91sam9261.dtsi
+++ b/arch/arm/boot/dts/at91sam9261.dtsi
@@ -581,13 +581,19 @@
 					clocks = <&slow_rc_osc &slow_xtal>;
 				};
 
-				main: mainck {
-					compatible = "atmel,at91rm9200-clk-main";
+				main_osc: main_osc {
+					compatible = "atmel,at91rm9200-clk-main-osc";
 					#clock-cells = <0>;
 					interrupts-extended = <&pmc AT91_PMC_MOSCS>;
 					clocks = <&main_xtal>;
 				};
 
+				main: mainck {
+					compatible = "atmel,at91rm9200-clk-main";
+					#clock-cells = <0>;
+					clocks = <&main_osc>;
+				};
+
 				plla: pllack {
 					compatible = "atmel,at91rm9200-clk-pll";
 					#clock-cells = <0>;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] ARM: at91/dt: clock fixes
  2014-06-13 13:43 [PATCH 0/3] ARM: at91/dt: clock fixes Alexandre Belloni
                   ` (2 preceding siblings ...)
  2014-06-13 13:43 ` [PATCH 3/3] ARM: at91/dt: sam9261: correctly define mainck Alexandre Belloni
@ 2014-06-13 14:19 ` Boris BREZILLON
  2014-06-25 10:37 ` Nicolas Ferre
  4 siblings, 0 replies; 6+ messages in thread
From: Boris BREZILLON @ 2014-06-13 14:19 UTC (permalink / raw)
  To: Alexandre Belloni, Nicolas Ferre
  Cc: Jean-Christophe Plagniol-Villard, linux-arm-kernel, linux-kernel


On 13/06/2014 15:43, Alexandre Belloni wrote:
> Some clocks were not properly defined:
>  - ICPLL and OUT values for PLLA got mixed on sam9x5 and sam9n12
>  - mainck was not correctly defined on sam9261

On the whole series:

Acked-by: Boris BREZILLON <boris.brezillon@free-electrons.com>

Thanks.

Boris
>
> Alexandre Belloni (3):
>   ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values
>   ARM: at91/dt: sam9n12: correct PLLA ICPLL and OUT values
>   ARM: at91/dt: sam9261: correctly define mainck
>
>  arch/arm/boot/dts/at91sam9261.dtsi | 10 ++++++++--
>  arch/arm/boot/dts/at91sam9n12.dtsi |  4 ++--
>  arch/arm/boot/dts/at91sam9x5.dtsi  |  4 ++--
>  3 files changed, 12 insertions(+), 6 deletions(-)
>

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/3] ARM: at91/dt: clock fixes
  2014-06-13 13:43 [PATCH 0/3] ARM: at91/dt: clock fixes Alexandre Belloni
                   ` (3 preceding siblings ...)
  2014-06-13 14:19 ` [PATCH 0/3] ARM: at91/dt: clock fixes Boris BREZILLON
@ 2014-06-25 10:37 ` Nicolas Ferre
  4 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2014-06-25 10:37 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Jean-Christophe Plagniol-Villard, Boris Brezillon,
	linux-arm-kernel, linux-kernel

On 13/06/2014 15:43, Alexandre Belloni :
> Some clocks were not properly defined:
>  - ICPLL and OUT values for PLLA got mixed on sam9x5 and sam9n12
>  - mainck was not correctly defined on sam9261
> 
> Alexandre Belloni (3):
>   ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values
>   ARM: at91/dt: sam9n12: correct PLLA ICPLL and OUT values
>   ARM: at91/dt: sam9261: correctly define mainck

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

and added to the at91-3.16-fixes branch.

Thanks,

>  arch/arm/boot/dts/at91sam9261.dtsi | 10 ++++++++--
>  arch/arm/boot/dts/at91sam9n12.dtsi |  4 ++--
>  arch/arm/boot/dts/at91sam9x5.dtsi  |  4 ++--
>  3 files changed, 12 insertions(+), 6 deletions(-)
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-06-25 10:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-13 13:43 [PATCH 0/3] ARM: at91/dt: clock fixes Alexandre Belloni
2014-06-13 13:43 ` [PATCH 1/3] ARM: at91/dt: sam9x5: correct PLLA ICPLL and OUT values Alexandre Belloni
2014-06-13 13:43 ` [PATCH 2/3] ARM: at91/dt: sam9n12: " Alexandre Belloni
2014-06-13 13:43 ` [PATCH 3/3] ARM: at91/dt: sam9261: correctly define mainck Alexandre Belloni
2014-06-13 14:19 ` [PATCH 0/3] ARM: at91/dt: clock fixes Boris BREZILLON
2014-06-25 10:37 ` Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).