* [PATCH] regulator:act8865: fix build when OF is not enabled
@ 2014-07-07 21:40 Beniamino Galvani
2014-07-08 14:53 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Beniamino Galvani @ 2014-07-07 21:40 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: Axel Lin, Wenyou Yang, linux-kernel, Beniamino Galvani
act8846_matches and act8865_matches are defined only when OF is
enabled. Move references to them to the act8865_pdata_from_dt()
function to avoid a build error when OF is disabled.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
drivers/regulator/act8865-regulator.c | 29 ++++++++++++++++++++---------
1 file changed, 20 insertions(+), 9 deletions(-)
diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
index a5ad69a..afd06f9 100644
--- a/drivers/regulator/act8865-regulator.c
+++ b/drivers/regulator/act8865-regulator.c
@@ -198,12 +198,12 @@ static struct of_regulator_match act8865_matches[] = {
static int act8865_pdata_from_dt(struct device *dev,
struct device_node **of_node,
struct act8865_platform_data *pdata,
- struct of_regulator_match *matches,
- int num_matches)
+ unsigned long type)
{
- int matched, i;
+ int matched, i, num_matches;
struct device_node *np;
struct act8865_regulator_data *regulator;
+ struct of_regulator_match *matches;
np = of_get_child_by_name(dev->of_node, "regulators");
if (!np) {
@@ -211,6 +211,20 @@ static int act8865_pdata_from_dt(struct device *dev,
return -EINVAL;
}
+ switch (type) {
+ case ACT8846:
+ matches = act8846_matches;
+ num_matches = ARRAY_SIZE(act8846_matches);
+ break;
+ case ACT8865:
+ matches = act8865_matches;
+ num_matches = ARRAY_SIZE(act8865_matches);
+ break;
+ default:
+ dev_err(dev, "invalid device id %lu\n", type);
+ return -EINVAL;
+ }
+
matched = of_regulator_match(dev, np, matches, num_matches);
of_node_put(np);
if (matched <= 0)
@@ -238,7 +252,8 @@ static int act8865_pdata_from_dt(struct device *dev,
#else
static inline int act8865_pdata_from_dt(struct device *dev,
struct device_node **of_node,
- struct act8865_platform_data *pdata)
+ struct act8865_platform_data *pdata,
+ unsigned long type)
{
return 0;
}
@@ -265,7 +280,6 @@ static int act8865_pmic_probe(struct i2c_client *client,
{
static const struct regulator_desc *regulators;
struct act8865_platform_data pdata_of, *pdata;
- struct of_regulator_match *matches;
struct device *dev = &client->dev;
struct device_node **of_node;
int i, ret, num_regulators;
@@ -288,12 +302,10 @@ static int act8865_pmic_probe(struct i2c_client *client,
switch (type) {
case ACT8846:
- matches = act8846_matches;
regulators = act8846_regulators;
num_regulators = ARRAY_SIZE(act8846_regulators);
break;
case ACT8865:
- matches = act8865_matches;
regulators = act8865_regulators;
num_regulators = ARRAY_SIZE(act8865_regulators);
break;
@@ -308,8 +320,7 @@ static int act8865_pmic_probe(struct i2c_client *client,
return -ENOMEM;
if (dev->of_node && !pdata) {
- ret = act8865_pdata_from_dt(dev, of_node, &pdata_of, matches,
- num_regulators);
+ ret = act8865_pdata_from_dt(dev, of_node, &pdata_of, type);
if (ret < 0)
return ret;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator:act8865: fix build when OF is not enabled
2014-07-07 21:40 [PATCH] regulator:act8865: fix build when OF is not enabled Beniamino Galvani
@ 2014-07-08 14:53 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-07-08 14:53 UTC (permalink / raw)
To: Beniamino Galvani; +Cc: Liam Girdwood, Axel Lin, Wenyou Yang, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Mon, Jul 07, 2014 at 11:40:47PM +0200, Beniamino Galvani wrote:
> act8846_matches and act8865_matches are defined only when OF is
> enabled. Move references to them to the act8865_pdata_from_dt()
> function to avoid a build error when OF is disabled.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-08 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-07 21:40 [PATCH] regulator:act8865: fix build when OF is not enabled Beniamino Galvani
2014-07-08 14:53 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).