* [PATCH RFC] arm/mach-imximx/iomux-v3: Do not export symbol without public declaration
@ 2014-07-23 13:02 Alexander Stein
2014-07-23 19:41 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2014-07-23 13:02 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Alexander Stein, Russell King, linux-arm-kernel, linux-kernel
Both mxc_iomux_v3_setup_pad and mxc_iomux_v3_setup_multiple_pads are
declared in iomux-v3.h which can't be used in any module. None of the
objects in this directory is tristate. Neither can the header be included
in out-of-tree modules.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
arch/arm/mach-imx/iomux-v3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-imx/iomux-v3.c b/arch/arm/mach-imx/iomux-v3.c
index 9dae74bf47fc..d61f9606fc56 100644
--- a/arch/arm/mach-imx/iomux-v3.c
+++ b/arch/arm/mach-imx/iomux-v3.c
@@ -55,7 +55,6 @@ int mxc_iomux_v3_setup_pad(iomux_v3_cfg_t pad)
return 0;
}
-EXPORT_SYMBOL(mxc_iomux_v3_setup_pad);
int mxc_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t *pad_list, unsigned count)
{
@@ -71,7 +70,6 @@ int mxc_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t *pad_list, unsigned count)
}
return 0;
}
-EXPORT_SYMBOL(mxc_iomux_v3_setup_multiple_pads);
void mxc_iomux_v3_init(void __iomem *iomux_v3_base)
{
--
1.8.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFC] arm/mach-imximx/iomux-v3: Do not export symbol without public declaration
2014-07-23 13:02 [PATCH RFC] arm/mach-imximx/iomux-v3: Do not export symbol without public declaration Alexander Stein
@ 2014-07-23 19:41 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2014-07-23 19:41 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Alexander Stein, Shawn Guo, Sascha Hauer, Russell King, linux-kernel
On Wednesday 23 July 2014, Alexander Stein wrote:
> Both mxc_iomux_v3_setup_pad and mxc_iomux_v3_setup_multiple_pads are
> declared in iomux-v3.h which can't be used in any module. None of the
> objects in this directory is tristate. Neither can the header be included
> in out-of-tree modules.
>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Makese sense, but I think if you do this, it would be reasonable
to do the same for all three iomux implementations (v1, imx31, v3).
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-23 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-23 13:02 [PATCH RFC] arm/mach-imximx/iomux-v3: Do not export symbol without public declaration Alexander Stein
2014-07-23 19:41 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).