* [GIT PULL 00/18] perf/core improvements and fixes
@ 2014-08-15 16:49 Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 01/18] perf probe: Warn user to rebuild target with debuginfo Arnaldo Carvalho de Melo
` (18 more replies)
0 siblings, 19 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alex Converse, Andi Kleen, Anshuman Khandual, Arun Sharma,
Brendan Gregg, Cody P Schafer, David Ahern, Elliott Hughes,
Frederic Weisbecker, Haren Myneni, Jiri Olsa, linuxppc-dev,
Masami Hiramatsu, Michael Ellerman, Namhyung Kim, Naohiro Aota,
Paul Mackerras, Peter Zijlstra, Rodrigo Campos, Stephane Eranian,
Sukadev Bhattiprolu, yrl.pp-manager.tt, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit f373da34282560c60f0c197690eecb1b2dc49fc0:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-08-14 10:38:40 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 759e612bf96627b64fcafe4174b3f6f2dedf2c0d:
perf stat: Use strerror_r instead of strerror (2014-08-15 13:08:40 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
. Warn user to rebuild target with debuginfo in 'perf probe' (Masami Hiramatsu)
. Don't truncate Intel style addresses in 'annotate'. (Alex Converse)
Developer stuff:
. Annotate PMU related list_head members with type info. (Cody P Schafer)
. Add the triplet used for arm64 by Android (Elliott Hughes)
. Replace thread unsafe strerror() with strerror_r() accross the
whole tools/perf/ tree (Masami Hiramatsu)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Alex Converse (1):
perf annotate: Don't truncate Intel style addresses
Cody P Schafer (1):
perf tools: Annotate PMU related list_head members with type info
Elliott Hughes (1):
perf tools: Add arm64 triplets
Masami Hiramatsu (14):
perf probe: Warn user to rebuild target with debuginfo
perf probe: Don't use strerror if strlist__add failed
perf: Use strerror_r instead of strerror
perf probe: Make error messages thread-safe
perf util: Replace strerror with strerror_r for thread-safety
perf top: Use strerror_r instead of strerror
perf trace: Use strerror_r instead of strerror
perf record: Use strerror_r instead of strerror
perf test: Use strerror_r instead of strerror
perf sched: Use strerror_r instead of strerror
perf buildid-cache: Use strerror_r instead of strerror
perf kvm: Use strerror_r instead of strerror
perf help: Use strerror_r instead of strerror
perf stat: Use strerror_r instead of strerror
Namhyung Kim (1):
perf report: Relax -g option parsing not to limit the option order
tools/perf/arch/common.c | 9 +++
tools/perf/builtin-buildid-cache.c | 7 ++-
tools/perf/builtin-help.c | 20 +++++--
tools/perf/builtin-kvm.c | 7 ++-
tools/perf/builtin-probe.c | 5 +-
tools/perf/builtin-record.c | 7 ++-
tools/perf/builtin-sched.c | 4 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/builtin-trace.c | 6 +-
tools/perf/perf.c | 10 +++-
tools/perf/tests/builtin-test.c | 4 +-
tools/perf/tests/mmap-basic.c | 7 ++-
tools/perf/tests/open-syscall-all-cpus.c | 5 +-
tools/perf/tests/open-syscall-tp-fields.c | 7 ++-
tools/perf/tests/open-syscall.c | 3 +-
tools/perf/tests/perf-record.c | 13 +++--
tools/perf/tests/rdpmc.c | 6 +-
tools/perf/tests/sw-clock.c | 6 +-
tools/perf/tests/task-exit.c | 6 +-
tools/perf/util/annotate.c | 12 +++-
tools/perf/util/callchain.c | 95 +++++++++++++------------------
tools/perf/util/cloexec.c | 6 +-
tools/perf/util/data.c | 8 ++-
tools/perf/util/debug.h | 3 +
tools/perf/util/dso.c | 8 ++-
tools/perf/util/evlist.c | 2 +-
tools/perf/util/evsel.c | 7 ++-
tools/perf/util/parse-events.c | 5 +-
tools/perf/util/pmu.c | 4 +-
tools/perf/util/pmu.h | 6 +-
tools/perf/util/probe-event.c | 75 +++++++++++++-----------
tools/perf/util/probe-finder.c | 7 ++-
tools/perf/util/run-command.c | 9 ++-
tools/perf/util/util.c | 5 +-
35 files changed, 234 insertions(+), 154 deletions(-)
^ permalink raw reply [flat|nested] 50+ messages in thread
* [PATCH 01/18] perf probe: Warn user to rebuild target with debuginfo
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 02/18] perf annotate: Don't truncate Intel style addresses Arnaldo Carvalho de Melo
` (17 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Brendan Gregg, David Ahern,
Jiri Olsa, Namhyung Kim, yrl.pp-manager.tt,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Warn user to rebuild target with debuginfo when the perf probe fails to
find debug information in the target binary.
Without this, perf probe just reports the failure, but it's no hint for
users. This gives more hint for users.
Without this:
$ strip perf
$ ./perf probe -x perf -L argv_split
Failed to open debuginfo file.
Error: Failed to show lines.
With this:
$ strip perf
$ ./perf probe -x perf -L argv_split
The /home/fedora/ksrc/linux-3/tools/perf/perf file has no debug information.
Rebuild with -g, or install an appropriate debuginfo package.
Error: Failed to show lines.
The "rebuild with ..." part changes to "rebuild with CONFIG_DEBUG_INFO"
if the target is the kernel or a kernel module.
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://lkml.kernel.org/r/20140815014432.29869.57941.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-event.c | 41 +++++++++++++++++++++++------------------
1 file changed, 23 insertions(+), 18 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 784ea42ad8cb..ac15ff780009 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -258,21 +258,33 @@ static void clear_probe_trace_events(struct probe_trace_event *tevs, int ntevs)
#ifdef HAVE_DWARF_SUPPORT
/* Open new debuginfo of given module */
-static struct debuginfo *open_debuginfo(const char *module)
+static struct debuginfo *open_debuginfo(const char *module, bool silent)
{
const char *path = module;
+ struct debuginfo *ret;
if (!module || !strchr(module, '/')) {
path = kernel_get_module_path(module);
if (!path) {
- pr_err("Failed to find path of %s module.\n",
- module ?: "kernel");
+ if (!silent)
+ pr_err("Failed to find path of %s module.\n",
+ module ?: "kernel");
return NULL;
}
}
- return debuginfo__new(path);
+ ret = debuginfo__new(path);
+ if (!ret && !silent) {
+ pr_warning("The %s file has no debug information.\n", path);
+ if (!module || !strtailcmp(path, ".ko"))
+ pr_warning("Rebuild with CONFIG_DEBUG_INFO=y, ");
+ else
+ pr_warning("Rebuild with -g, ");
+ pr_warning("or install an appropriate debuginfo package.\n");
+ }
+ return ret;
}
+
static int get_text_start_address(const char *exec, unsigned long *address)
{
Elf *elf;
@@ -333,15 +345,13 @@ static int find_perf_probe_point_from_dwarf(struct probe_trace_point *tp,
pr_debug("try to find information at %" PRIx64 " in %s\n", addr,
tp->module ? : "kernel");
- dinfo = open_debuginfo(tp->module);
+ dinfo = open_debuginfo(tp->module, verbose == 0);
if (dinfo) {
ret = debuginfo__find_probe_point(dinfo,
(unsigned long)addr, pp);
debuginfo__delete(dinfo);
- } else {
- pr_debug("Failed to open debuginfo at 0x%" PRIx64 "\n", addr);
+ } else
ret = -ENOENT;
- }
if (ret > 0) {
pp->retprobe = tp->retprobe;
@@ -457,13 +467,11 @@ static int try_to_find_probe_trace_events(struct perf_probe_event *pev,
struct debuginfo *dinfo;
int ntevs, ret = 0;
- dinfo = open_debuginfo(target);
+ dinfo = open_debuginfo(target, !need_dwarf);
if (!dinfo) {
- if (need_dwarf) {
- pr_warning("Failed to open debuginfo file.\n");
+ if (need_dwarf)
return -ENOENT;
- }
pr_debug("Could not open debuginfo. Try to use symbols.\n");
return 0;
}
@@ -620,11 +628,9 @@ static int __show_line_range(struct line_range *lr, const char *module)
char *tmp;
/* Search a line range */
- dinfo = open_debuginfo(module);
- if (!dinfo) {
- pr_warning("Failed to open debuginfo file.\n");
+ dinfo = open_debuginfo(module, false);
+ if (!dinfo)
return -ENOENT;
- }
ret = debuginfo__find_line_range(dinfo, lr);
debuginfo__delete(dinfo);
@@ -772,9 +778,8 @@ int show_available_vars(struct perf_probe_event *pevs, int npevs,
if (ret < 0)
return ret;
- dinfo = open_debuginfo(module);
+ dinfo = open_debuginfo(module, false);
if (!dinfo) {
- pr_warning("Failed to open debuginfo file.\n");
ret = -ENOENT;
goto out;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 02/18] perf annotate: Don't truncate Intel style addresses
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 01/18] perf probe: Warn user to rebuild target with debuginfo Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 03/18] perf tools: Add arm64 triplets Arnaldo Carvalho de Melo
` (16 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Alex Converse, Adrian Hunter, Andi Kleen,
Ingo Molnar, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Alex Converse <aconverse@google.com>
Instructions like "mov r9,QWORD PTR [rdx+0x8]" were being truncated to
"mov r9,QWORD" by code that assuemd operands cannot have spaces.
Signed-off-by: Alex Converse <aconverse@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1408050180-14088-1-git-send-email-aconverse@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 7745fec01a6b..36437527dbb3 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -232,9 +232,16 @@ static int mov__parse(struct ins_operands *ops)
return -1;
target = ++s;
+ comment = strchr(s, '#');
- while (s[0] != '\0' && !isspace(s[0]))
- ++s;
+ if (comment != NULL)
+ s = comment - 1;
+ else
+ s = strchr(s, '\0') - 1;
+
+ while (s > target && isspace(s[0]))
+ --s;
+ s++;
prev = *s;
*s = '\0';
@@ -244,7 +251,6 @@ static int mov__parse(struct ins_operands *ops)
if (ops->target.raw == NULL)
goto out_free_source;
- comment = strchr(s, '#');
if (comment == NULL)
return 0;
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 03/18] perf tools: Add arm64 triplets
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 01/18] perf probe: Warn user to rebuild target with debuginfo Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 02/18] perf annotate: Don't truncate Intel style addresses Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info Arnaldo Carvalho de Melo
` (15 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Elliott Hughes, Ingo Molnar, Paul Mackerras,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Elliott Hughes <enh@google.com>
Adds the triplet used for arm64 by Android. Others will want to add
their own later.
Signed-off-by: Elliott Hughes <enh@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814193920.A7D2D20572@enh.mtv.corp.google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/common.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
index 42faf369211c..49776f190abf 100644
--- a/tools/perf/arch/common.c
+++ b/tools/perf/arch/common.c
@@ -12,6 +12,11 @@ const char *const arm_triplets[] = {
NULL
};
+const char *const arm64_triplets[] = {
+ "aarch64-linux-android-",
+ NULL
+};
+
const char *const powerpc_triplets[] = {
"powerpc-unknown-linux-gnu-",
"powerpc64-unknown-linux-gnu-",
@@ -105,6 +110,8 @@ static const char *normalize_arch(char *arch)
return "x86";
if (!strcmp(arch, "sun4u") || !strncmp(arch, "sparc", 5))
return "sparc";
+ if (!strcmp(arch, "aarch64") || !strcmp(arch, "arm64"))
+ return "arm64";
if (!strncmp(arch, "arm", 3) || !strcmp(arch, "sa110"))
return "arm";
if (!strncmp(arch, "s390", 4))
@@ -159,6 +166,8 @@ static int perf_session_env__lookup_binutils_path(struct perf_session_env *env,
if (!strcmp(arch, "arm"))
path_list = arm_triplets;
+ else if (!strcmp(arch, "arm64"))
+ path_list = arm64_triplets;
else if (!strcmp(arch, "powerpc"))
path_list = powerpc_triplets;
else if (!strcmp(arch, "sh"))
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 03/18] perf tools: Add arm64 triplets Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 05/18] perf report: Relax -g option parsing not to limit the option order Arnaldo Carvalho de Melo
` (14 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Cody P Schafer, Cody P Schafer, Andi Kleen,
Anshuman Khandual, Haren Myneni, Jiri Olsa, Michael Ellerman,
Peter Zijlstra, Stephane Eranian, linuxppc-dev,
Sukadev Bhattiprolu, Arnaldo Carvalho de Melo
From: Cody P Schafer <dev@codyps.com>
So that we can more readily understand in which list heads structs are
stored into.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Cody P Schafer <dev@codyps.com>
Cc: Haren Myneni <hbabu@us.ibm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Michael Ellerman <michaele@au1.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1408087583-32239-6-git-send-email-sukadev@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/pmu.c | 4 ++--
tools/perf/util/pmu.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 7a811eb61f75..9bf582750561 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -14,8 +14,8 @@
struct perf_pmu_alias {
char *name;
- struct list_head terms;
- struct list_head list;
+ struct list_head terms; /* HEAD struct parse_events_term -> list */
+ struct list_head list; /* ELEM */
char unit[UNIT_MAX_LEN+1];
double scale;
};
diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index c14a543ce1f3..1c1e2eecbe1f 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -17,9 +17,9 @@ struct perf_pmu {
char *name;
__u32 type;
struct cpu_map *cpus;
- struct list_head format;
- struct list_head aliases;
- struct list_head list;
+ struct list_head format; /* HEAD struct perf_pmu_format -> list */
+ struct list_head aliases; /* HEAD struct perf_pmu_alias -> list */
+ struct list_head list; /* ELEM */
};
struct perf_pmu *perf_pmu__find(const char *name);
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 05/18] perf report: Relax -g option parsing not to limit the option order
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 06/18] perf probe: Don't use strerror if strlist__add failed Arnaldo Carvalho de Melo
` (13 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, Andi Kleen, Arun Sharma, David Ahern,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Rodrigo Campos, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
Current perf report -g/--call-graph option parser requires for option
argument having following order:
type,min_percent[,print_limit],order,key
But sometimes it's annoying to type all even if one just wants to change
the "order" or "key" setting.
This patch fixes it to remove the ordering restriction so that one can
use just "-g caller", for instance. The only remaining restriction is
that the "print_limit" always comes after the "min_percent".
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Arun Sharma <asharma@fb.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Rodrigo Campos <rodrigo@sdfg.com.ar>
Link: http://lkml.kernel.org/r/1407996100-6359-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/callchain.c | 95 ++++++++++++++++++---------------------------
1 file changed, 38 insertions(+), 57 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 437ee09727e6..08f0fbf5527c 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -28,74 +28,55 @@ __thread struct callchain_cursor callchain_cursor;
int
parse_callchain_report_opt(const char *arg)
{
- char *tok, *tok2;
+ char *tok;
char *endptr;
+ bool minpcnt_set = false;
symbol_conf.use_callchain = true;
if (!arg)
return 0;
- tok = strtok((char *)arg, ",");
- if (!tok)
- return -1;
-
- /* get the output mode */
- if (!strncmp(tok, "graph", strlen(arg))) {
- callchain_param.mode = CHAIN_GRAPH_ABS;
-
- } else if (!strncmp(tok, "flat", strlen(arg))) {
- callchain_param.mode = CHAIN_FLAT;
- } else if (!strncmp(tok, "fractal", strlen(arg))) {
- callchain_param.mode = CHAIN_GRAPH_REL;
- } else if (!strncmp(tok, "none", strlen(arg))) {
- callchain_param.mode = CHAIN_NONE;
- symbol_conf.use_callchain = false;
- return 0;
- } else {
- return -1;
- }
-
- /* get the min percentage */
- tok = strtok(NULL, ",");
- if (!tok)
- goto setup;
-
- callchain_param.min_percent = strtod(tok, &endptr);
- if (tok == endptr)
- return -1;
+ while ((tok = strtok((char *)arg, ",")) != NULL) {
+ if (!strncmp(tok, "none", strlen(tok))) {
+ callchain_param.mode = CHAIN_NONE;
+ symbol_conf.use_callchain = false;
+ return 0;
+ }
- /* get the print limit */
- tok2 = strtok(NULL, ",");
- if (!tok2)
- goto setup;
+ /* try to get the output mode */
+ if (!strncmp(tok, "graph", strlen(tok)))
+ callchain_param.mode = CHAIN_GRAPH_ABS;
+ else if (!strncmp(tok, "flat", strlen(tok)))
+ callchain_param.mode = CHAIN_FLAT;
+ else if (!strncmp(tok, "fractal", strlen(tok)))
+ callchain_param.mode = CHAIN_GRAPH_REL;
+ /* try to get the call chain order */
+ else if (!strncmp(tok, "caller", strlen(tok)))
+ callchain_param.order = ORDER_CALLER;
+ else if (!strncmp(tok, "callee", strlen(tok)))
+ callchain_param.order = ORDER_CALLEE;
+ /* try to get the sort key */
+ else if (!strncmp(tok, "function", strlen(tok)))
+ callchain_param.key = CCKEY_FUNCTION;
+ else if (!strncmp(tok, "address", strlen(tok)))
+ callchain_param.key = CCKEY_ADDRESS;
+ /* try to get the min percent */
+ else if (!minpcnt_set) {
+ callchain_param.min_percent = strtod(tok, &endptr);
+ if (tok == endptr)
+ return -1;
+ minpcnt_set = true;
+ } else {
+ /* try print limit at last */
+ callchain_param.print_limit = strtoul(tok, &endptr, 0);
+ if (tok == endptr)
+ return -1;
+ }
- if (tok2[0] != 'c') {
- callchain_param.print_limit = strtoul(tok2, &endptr, 0);
- tok2 = strtok(NULL, ",");
- if (!tok2)
- goto setup;
+ arg = NULL;
}
- /* get the call chain order */
- if (!strncmp(tok2, "caller", strlen("caller")))
- callchain_param.order = ORDER_CALLER;
- else if (!strncmp(tok2, "callee", strlen("callee")))
- callchain_param.order = ORDER_CALLEE;
- else
- return -1;
-
- /* Get the sort key */
- tok2 = strtok(NULL, ",");
- if (!tok2)
- goto setup;
- if (!strncmp(tok2, "function", strlen("function")))
- callchain_param.key = CCKEY_FUNCTION;
- else if (!strncmp(tok2, "address", strlen("address")))
- callchain_param.key = CCKEY_ADDRESS;
- else
- return -1;
-setup:
if (callchain_register_param(&callchain_param) < 0) {
pr_err("Can't register callchain params\n");
return -1;
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 06/18] perf probe: Don't use strerror if strlist__add failed
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 05/18] perf report: Relax -g option parsing not to limit the option order Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 07/18] perf: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
` (12 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Since the strlist__add doesn't involves any IO, the failure reason must
be ENOMEM or EINVAL, moreover this is just a debug message, we don't
need to show the error string.
And also, if get_probe_trace_command_rawlist() returns NULL, it doesn't
mean the rawlist is empty, there is an error. So caller must use
-ENOMEM for the error.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022230.3545.99254.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/probe-event.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index ac15ff780009..bf39c23b275d 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1881,7 +1881,7 @@ static struct strlist *get_probe_trace_command_rawlist(int fd)
p[idx] = '\0';
ret = strlist__add(sl, buf);
if (ret < 0) {
- pr_debug("strlist__add failed: %s\n", strerror(-ret));
+ pr_debug("strlist__add failed (%d)\n", ret);
strlist__delete(sl);
return NULL;
}
@@ -1940,7 +1940,7 @@ static int __show_perf_probe_events(int fd, bool is_kprobe)
rawlist = get_probe_trace_command_rawlist(fd);
if (!rawlist)
- return -ENOENT;
+ return -ENOMEM;
strlist__for_each(ent, rawlist) {
ret = parse_probe_trace_command(ent->s, &tev);
@@ -2007,6 +2007,8 @@ static struct strlist *get_probe_trace_event_names(int fd, bool include_group)
memset(&tev, 0, sizeof(tev));
rawlist = get_probe_trace_command_rawlist(fd);
+ if (!rawlist)
+ return NULL;
sl = strlist__new(true, NULL);
strlist__for_each(ent, rawlist) {
ret = parse_probe_trace_command(ent->s, &tev);
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 07/18] perf: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 06/18] perf probe: Don't use strerror if strlist__add failed Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 08/18] perf probe: Make error messages thread-safe Arnaldo Carvalho de Melo
` (11 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error messages for thread-safety.
This also introduce STRERR_BUFSIZE macro for the default size of message
buffer for strerror_r.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022232.3545.14026.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/perf.c | 10 +++++++---
tools/perf/util/debug.h | 3 +++
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/tools/perf/perf.c b/tools/perf/perf.c
index 2282d41879a2..452a8474d29d 100644
--- a/tools/perf/perf.c
+++ b/tools/perf/perf.c
@@ -313,6 +313,7 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
int status;
struct stat st;
const char *prefix;
+ char sbuf[STRERR_BUFSIZE];
prefix = NULL;
if (p->option & RUN_SETUP)
@@ -343,7 +344,8 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
status = 1;
/* Check for ENOSPC and EIO errors.. */
if (fflush(stdout)) {
- fprintf(stderr, "write failure on standard output: %s", strerror(errno));
+ fprintf(stderr, "write failure on standard output: %s",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out;
}
if (ferror(stdout)) {
@@ -351,7 +353,8 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
goto out;
}
if (fclose(stdout)) {
- fprintf(stderr, "close failed on standard output: %s", strerror(errno));
+ fprintf(stderr, "close failed on standard output: %s",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out;
}
status = 0;
@@ -466,6 +469,7 @@ void pthread__unblock_sigwinch(void)
int main(int argc, const char **argv)
{
const char *cmd;
+ char sbuf[STRERR_BUFSIZE];
/* The page_size is placed in util object. */
page_size = sysconf(_SC_PAGE_SIZE);
@@ -561,7 +565,7 @@ int main(int argc, const char **argv)
}
fprintf(stderr, "Failed to run command '%s': %s\n",
- cmd, strerror(errno));
+ cmd, strerror_r(errno, sbuf, sizeof(sbuf)));
out:
return 1;
}
diff --git a/tools/perf/util/debug.h b/tools/perf/util/debug.h
index 6944ea3a119b..be264d6f3b30 100644
--- a/tools/perf/util/debug.h
+++ b/tools/perf/util/debug.h
@@ -3,6 +3,7 @@
#define __PERF_DEBUG_H
#include <stdbool.h>
+#include <string.h>
#include "event.h"
#include "../ui/helpline.h"
#include "../ui/progress.h"
@@ -36,6 +37,8 @@ extern int debug_ordered_events;
#define pr_oe_time(t, fmt, ...) pr_time_N(1, debug_ordered_events, t, pr_fmt(fmt), ##__VA_ARGS__)
#define pr_oe_time2(t, fmt, ...) pr_time_N(2, debug_ordered_events, t, pr_fmt(fmt), ##__VA_ARGS__)
+#define STRERR_BUFSIZE 128 /* For the buffer size of strerror_r */
+
int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
void trace_event(union perf_event *event);
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 08/18] perf probe: Make error messages thread-safe
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 07/18] perf: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 09/18] perf util: Replace strerror with strerror_r for thread-safety Arnaldo Carvalho de Melo
` (10 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To make error messages thread-safe, this replaces strerror with
strerror_r for warnings, and just shows the return value instead of
using strerror for debug messages.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022234.3545.22199.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-probe.c | 5 ++++-
tools/perf/util/probe-event.c | 28 +++++++++++++++-------------
tools/perf/util/probe-finder.c | 7 +++++--
3 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index c63fa2925075..347729e29a92 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -290,8 +290,11 @@ static void cleanup_params(void)
static void pr_err_with_code(const char *msg, int err)
{
+ char sbuf[STRERR_BUFSIZE];
+
pr_err("%s", msg);
- pr_debug(" Reason: %s (Code: %d)", strerror(-err), err);
+ pr_debug(" Reason: %s (Code: %d)",
+ strerror_r(-err, sbuf, sizeof(sbuf)), err);
pr_err("\n");
}
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index bf39c23b275d..f73595fc0627 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -573,7 +573,7 @@ static int get_real_path(const char *raw_path, const char *comp_dir,
static int __show_one_line(FILE *fp, int l, bool skip, bool show_num)
{
- char buf[LINEBUF_SIZE];
+ char buf[LINEBUF_SIZE], sbuf[STRERR_BUFSIZE];
const char *color = show_num ? "" : PERF_COLOR_BLUE;
const char *prefix = NULL;
@@ -593,7 +593,8 @@ static int __show_one_line(FILE *fp, int l, bool skip, bool show_num)
return 1;
error:
if (ferror(fp)) {
- pr_warning("File read error: %s\n", strerror(errno));
+ pr_warning("File read error: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -1;
}
return 0;
@@ -626,6 +627,7 @@ static int __show_line_range(struct line_range *lr, const char *module)
FILE *fp;
int ret;
char *tmp;
+ char sbuf[STRERR_BUFSIZE];
/* Search a line range */
dinfo = open_debuginfo(module, false);
@@ -662,7 +664,7 @@ static int __show_line_range(struct line_range *lr, const char *module)
fp = fopen(lr->path, "r");
if (fp == NULL) {
pr_warning("Failed to open %s: %s\n", lr->path,
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -errno;
}
/* Skip to starting line number */
@@ -1410,8 +1412,7 @@ int synthesize_perf_probe_arg(struct perf_probe_arg *pa, char *buf, size_t len)
return tmp - buf;
error:
- pr_debug("Failed to synthesize perf probe argument: %s\n",
- strerror(-ret));
+ pr_debug("Failed to synthesize perf probe argument: %d\n", ret);
return ret;
}
@@ -1460,8 +1461,7 @@ static char *synthesize_perf_probe_point(struct perf_probe_point *pp)
return buf;
error:
- pr_debug("Failed to synthesize perf probe point: %s\n",
- strerror(-ret));
+ pr_debug("Failed to synthesize perf probe point: %d\n", ret);
free(buf);
return NULL;
}
@@ -1787,7 +1787,7 @@ static void clear_probe_trace_event(struct probe_trace_event *tev)
static void print_open_warning(int err, bool is_kprobe)
{
- char sbuf[128];
+ char sbuf[STRERR_BUFSIZE];
if (err == -ENOENT) {
const char *config;
@@ -1817,7 +1817,7 @@ static void print_both_open_warning(int kerr, int uerr)
pr_warning("Please rebuild kernel with CONFIG_KPROBE_EVENTS "
"or/and CONFIG_UPROBE_EVENTS.\n");
else {
- char sbuf[128];
+ char sbuf[STRERR_BUFSIZE];
pr_warning("Failed to open kprobe events: %s.\n",
strerror_r(-kerr, sbuf, sizeof(sbuf)));
pr_warning("Failed to open uprobe events: %s.\n",
@@ -2038,6 +2038,7 @@ static int write_probe_trace_event(int fd, struct probe_trace_event *tev)
{
int ret = 0;
char *buf = synthesize_probe_trace_command(tev);
+ char sbuf[STRERR_BUFSIZE];
if (!buf) {
pr_debug("Failed to synthesize probe trace event.\n");
@@ -2049,7 +2050,7 @@ static int write_probe_trace_event(int fd, struct probe_trace_event *tev)
ret = write(fd, buf, strlen(buf));
if (ret <= 0)
pr_warning("Failed to write event: %s\n",
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
}
free(buf);
return ret;
@@ -2063,7 +2064,7 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
/* Try no suffix */
ret = e_snprintf(buf, len, "%s", base);
if (ret < 0) {
- pr_debug("snprintf() failed: %s\n", strerror(-ret));
+ pr_debug("snprintf() failed: %d\n", ret);
return ret;
}
if (!strlist__has_entry(namelist, buf))
@@ -2079,7 +2080,7 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
for (i = 1; i < MAX_EVENT_INDEX; i++) {
ret = e_snprintf(buf, len, "%s_%d", base, i);
if (ret < 0) {
- pr_debug("snprintf() failed: %s\n", strerror(-ret));
+ pr_debug("snprintf() failed: %d\n", ret);
return ret;
}
if (!strlist__has_entry(namelist, buf))
@@ -2444,7 +2445,8 @@ static int __del_trace_probe_event(int fd, struct str_node *ent)
printf("Removed event: %s\n", ent->s);
return 0;
error:
- pr_warning("Failed to delete event: %s\n", strerror(-ret));
+ pr_warning("Failed to delete event: %s\n",
+ strerror_r(-ret, buf, sizeof(buf)));
return ret;
}
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index dca9145d704c..9c593561aa71 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -281,6 +281,7 @@ static int convert_variable_type(Dwarf_Die *vr_die,
struct probe_trace_arg_ref **ref_ptr = &tvar->ref;
Dwarf_Die type;
char buf[16];
+ char sbuf[STRERR_BUFSIZE];
int bsize, boffs, total;
int ret;
@@ -367,7 +368,7 @@ formatted:
if (ret >= 16)
ret = -E2BIG;
pr_warning("Failed to convert variable type: %s\n",
- strerror(-ret));
+ strerror_r(-ret, sbuf, sizeof(sbuf)));
return ret;
}
tvar->type = strdup(buf);
@@ -779,10 +780,12 @@ static int find_lazy_match_lines(struct intlist *list,
size_t line_len;
ssize_t len;
int count = 0, linenum = 1;
+ char sbuf[STRERR_BUFSIZE];
fp = fopen(fname, "r");
if (!fp) {
- pr_warning("Failed to open %s: %s\n", fname, strerror(errno));
+ pr_warning("Failed to open %s: %s\n", fname,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -errno;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 09/18] perf util: Replace strerror with strerror_r for thread-safety
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 08/18] perf probe: Make error messages thread-safe Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 10/18] perf top: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
` (9 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Replaces all strerror with strerror_r in util for making the perf lib
thread-safe.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022236.3545.3367.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/cloexec.c | 6 ++++--
tools/perf/util/data.c | 8 ++++++--
tools/perf/util/dso.c | 8 ++++++--
tools/perf/util/evlist.c | 2 +-
tools/perf/util/evsel.c | 7 +++++--
tools/perf/util/parse-events.c | 5 ++++-
tools/perf/util/run-command.c | 9 +++++++--
tools/perf/util/util.c | 5 +++--
8 files changed, 36 insertions(+), 14 deletions(-)
diff --git a/tools/perf/util/cloexec.c b/tools/perf/util/cloexec.c
index 4945aa56a017..47b78b3f0325 100644
--- a/tools/perf/util/cloexec.c
+++ b/tools/perf/util/cloexec.c
@@ -3,6 +3,7 @@
#include "../perf.h"
#include "cloexec.h"
#include "asm/bug.h"
+#include "debug.h"
static unsigned long flag = PERF_FLAG_FD_CLOEXEC;
@@ -18,6 +19,7 @@ static int perf_flag_probe(void)
int err;
int cpu;
pid_t pid = -1;
+ char sbuf[STRERR_BUFSIZE];
cpu = sched_getcpu();
if (cpu < 0)
@@ -42,7 +44,7 @@ static int perf_flag_probe(void)
WARN_ONCE(err != EINVAL && err != EBUSY,
"perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected error %d (%s)\n",
- err, strerror(err));
+ err, strerror_r(err, sbuf, sizeof(sbuf)));
/* not supported, confirm error related to PERF_FLAG_FD_CLOEXEC */
fd = sys_perf_event_open(&attr, pid, cpu, -1, 0);
@@ -50,7 +52,7 @@ static int perf_flag_probe(void)
if (WARN_ONCE(fd < 0 && err != EBUSY,
"perf_event_open(..., 0) failed unexpectedly with error %d (%s)\n",
- err, strerror(err)))
+ err, strerror_r(err, sbuf, sizeof(sbuf))))
return -1;
close(fd);
diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
index 29d720cf5844..1921942fc2e0 100644
--- a/tools/perf/util/data.c
+++ b/tools/perf/util/data.c
@@ -50,12 +50,14 @@ static int open_file_read(struct perf_data_file *file)
{
struct stat st;
int fd;
+ char sbuf[STRERR_BUFSIZE];
fd = open(file->path, O_RDONLY);
if (fd < 0) {
int err = errno;
- pr_err("failed to open %s: %s", file->path, strerror(err));
+ pr_err("failed to open %s: %s", file->path,
+ strerror_r(err, sbuf, sizeof(sbuf)));
if (err == ENOENT && !strcmp(file->path, "perf.data"))
pr_err(" (try 'perf record' first)");
pr_err("\n");
@@ -88,6 +90,7 @@ static int open_file_read(struct perf_data_file *file)
static int open_file_write(struct perf_data_file *file)
{
int fd;
+ char sbuf[STRERR_BUFSIZE];
if (check_backup(file))
return -1;
@@ -95,7 +98,8 @@ static int open_file_write(struct perf_data_file *file)
fd = open(file->path, O_CREAT|O_RDWR|O_TRUNC, S_IRUSR|S_IWUSR);
if (fd < 0)
- pr_err("failed to open %s : %s\n", file->path, strerror(errno));
+ pr_err("failed to open %s : %s\n", file->path,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return fd;
}
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index bdafd306fb52..55e39dc1bcda 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -162,13 +162,15 @@ static void close_first_dso(void);
static int do_open(char *name)
{
int fd;
+ char sbuf[STRERR_BUFSIZE];
do {
fd = open(name, O_RDONLY);
if (fd >= 0)
return fd;
- pr_debug("dso open failed, mmap: %s\n", strerror(errno));
+ pr_debug("dso open failed, mmap: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
if (!dso__data_open_cnt || errno != EMFILE)
break;
@@ -530,10 +532,12 @@ static ssize_t cached_read(struct dso *dso, u64 offset, u8 *data, ssize_t size)
static int data_file_size(struct dso *dso)
{
struct stat st;
+ char sbuf[STRERR_BUFSIZE];
if (!dso->data.file_size) {
if (fstat(dso->data.fd, &st)) {
- pr_err("dso mmap failed, fstat: %s\n", strerror(errno));
+ pr_err("dso mmap failed, fstat: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -1;
}
dso->data.file_size = st.st_size;
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 5dcd28c79c6e..a3e28b49128a 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1295,7 +1295,7 @@ int perf_evlist__strerror_open(struct perf_evlist *evlist __maybe_unused,
int err, char *buf, size_t size)
{
int printed, value;
- char sbuf[128], *emsg = strerror_r(err, sbuf, sizeof(sbuf));
+ char sbuf[STRERR_BUFSIZE], *emsg = strerror_r(err, sbuf, sizeof(sbuf));
switch (err) {
case EACCES:
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 01ce14c3575e..b38de5819323 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2027,6 +2027,8 @@ bool perf_evsel__fallback(struct perf_evsel *evsel, int err,
int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
int err, char *msg, size_t size)
{
+ char sbuf[STRERR_BUFSIZE];
+
switch (err) {
case EPERM:
case EACCES:
@@ -2072,8 +2074,9 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
}
return scnprintf(msg, size,
- "The sys_perf_event_open() syscall returned with %d (%s) for event (%s). \n"
+ "The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
"/bin/dmesg may provide additional information.\n"
"No CONFIG_PERF_EVENTS=y kernel support configured?\n",
- err, strerror(err), perf_evsel__name(evsel));
+ err, strerror_r(err, sbuf, sizeof(sbuf)),
+ perf_evsel__name(evsel));
}
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 1e15df10a88c..e34c81a0bcf3 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -10,6 +10,7 @@
#include "symbol.h"
#include "cache.h"
#include "header.h"
+#include "debug.h"
#include <api/fs/debugfs.h>
#include "parse-events-bison.h"
#define YY_EXTRA_TYPE int
@@ -1006,9 +1007,11 @@ void print_tracepoint_events(const char *subsys_glob, const char *event_glob,
struct dirent *sys_next, *evt_next, sys_dirent, evt_dirent;
char evt_path[MAXPATHLEN];
char dir_path[MAXPATHLEN];
+ char sbuf[STRERR_BUFSIZE];
if (debugfs_valid_mountpoint(tracing_events_path)) {
- printf(" [ Tracepoints not available: %s ]\n", strerror(errno));
+ printf(" [ Tracepoints not available: %s ]\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return;
}
diff --git a/tools/perf/util/run-command.c b/tools/perf/util/run-command.c
index da8e9b285f51..34622b53e733 100644
--- a/tools/perf/util/run-command.c
+++ b/tools/perf/util/run-command.c
@@ -1,6 +1,7 @@
#include "cache.h"
#include "run-command.h"
#include "exec_cmd.h"
+#include "debug.h"
static inline void close_pair(int fd[2])
{
@@ -19,6 +20,7 @@ int start_command(struct child_process *cmd)
{
int need_in, need_out, need_err;
int fdin[2], fdout[2], fderr[2];
+ char sbuf[STRERR_BUFSIZE];
/*
* In case of errors we must keep the promise to close FDs
@@ -99,7 +101,7 @@ int start_command(struct child_process *cmd)
if (cmd->dir && chdir(cmd->dir))
die("exec %s: cd to %s failed (%s)", cmd->argv[0],
- cmd->dir, strerror(errno));
+ cmd->dir, strerror_r(errno, sbuf, sizeof(sbuf)));
if (cmd->env) {
for (; *cmd->env; cmd->env++) {
if (strchr(*cmd->env, '='))
@@ -153,6 +155,8 @@ int start_command(struct child_process *cmd)
static int wait_or_whine(pid_t pid)
{
+ char sbuf[STRERR_BUFSIZE];
+
for (;;) {
int status, code;
pid_t waiting = waitpid(pid, &status, 0);
@@ -160,7 +164,8 @@ static int wait_or_whine(pid_t pid)
if (waiting < 0) {
if (errno == EINTR)
continue;
- error("waitpid failed (%s)", strerror(errno));
+ error("waitpid failed (%s)",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -ERR_RUN_COMMAND_WAITPID;
}
if (waiting != pid)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 25822bdf7bbf..24e8d871b74e 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -456,6 +456,7 @@ int filename__read_str(const char *filename, char **buf, size_t *sizep)
size_t size = 0, alloc_size = 0;
void *bf = NULL, *nbf;
int fd, n, err = 0;
+ char sbuf[STRERR_BUFSIZE];
fd = open(filename, O_RDONLY);
if (fd < 0)
@@ -476,8 +477,8 @@ int filename__read_str(const char *filename, char **buf, size_t *sizep)
n = read(fd, bf + size, alloc_size - size);
if (n < 0) {
if (size) {
- pr_warning("read failed %d: %s\n",
- errno, strerror(errno));
+ pr_warning("read failed %d: %s\n", errno,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
err = 0;
} else
err = -errno;
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 10/18] perf top: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (8 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 09/18] perf util: Replace strerror with strerror_r for thread-safety Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 11/18] perf trace: " Arnaldo Carvalho de Melo
` (8 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error message for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022238.3545.15569.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 87a6615a40fa..a77ff6ca5fbd 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -899,7 +899,7 @@ try_again:
if (perf_evlist__mmap(evlist, opts->mmap_pages, false) < 0) {
ui__error("Failed to mmap with %d (%s)\n",
- errno, strerror(errno));
+ errno, strerror_r(errno, msg, sizeof(msg)));
goto out_err;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 11/18] perf trace: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (9 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 10/18] perf top: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 12/18] perf record: " Arnaldo Carvalho de Melo
` (7 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error message for thead-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022241.3545.97543.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-trace.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index d080b9cf0354..a9e96ff49c7f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1750,7 +1750,7 @@ static int trace__sys_exit(struct trace *trace, struct perf_evsel *evsel,
signed_print:
fprintf(trace->output, ") = %d", ret);
} else if (ret < 0 && sc->fmt->errmsg) {
- char bf[256];
+ char bf[STRERR_BUFSIZE];
const char *emsg = strerror_r(-ret, bf, sizeof(bf)),
*e = audit_errno_to_name(-ret);
@@ -2044,6 +2044,7 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
int err = -1, i;
unsigned long before;
const bool forks = argc > 0;
+ char sbuf[STRERR_BUFSIZE];
trace->live = true;
@@ -2105,7 +2106,8 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
err = perf_evlist__mmap(evlist, trace->opts.mmap_pages, false);
if (err < 0) {
- fprintf(trace->output, "Couldn't mmap the events: %s\n", strerror(errno));
+ fprintf(trace->output, "Couldn't mmap the events: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 12/18] perf record: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (10 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 11/18] perf trace: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 13/18] perf test: " Arnaldo Carvalho de Melo
` (6 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error messages for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022243.3545.7411.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 4db670d4b8da..87e28a4e33ba 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -161,7 +161,7 @@ try_again:
if (perf_evlist__apply_filters(evlist)) {
error("failed to set filter with %d (%s)\n", errno,
- strerror(errno));
+ strerror_r(errno, msg, sizeof(msg)));
rc = -1;
goto out;
}
@@ -175,7 +175,8 @@ try_again:
"(current value: %u)\n", opts->mmap_pages);
rc = -errno;
} else {
- pr_err("failed to mmap with %d (%s)\n", errno, strerror(errno));
+ pr_err("failed to mmap with %d (%s)\n", errno,
+ strerror_r(errno, msg, sizeof(msg)));
rc = -errno;
}
goto out;
@@ -480,7 +481,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
}
if (forks && workload_exec_errno) {
- char msg[512];
+ char msg[STRERR_BUFSIZE];
const char *emsg = strerror_r(workload_exec_errno, msg, sizeof(msg));
pr_err("Workload failed: %s\n", emsg);
err = -1;
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 13/18] perf test: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (11 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 12/18] perf record: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 14/18] perf sched: " Arnaldo Carvalho de Melo
` (5 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error messages for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022245.3545.91394.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/tests/builtin-test.c | 4 +++-
tools/perf/tests/mmap-basic.c | 7 ++++---
tools/perf/tests/open-syscall-all-cpus.c | 5 +++--
tools/perf/tests/open-syscall-tp-fields.c | 7 +++++--
tools/perf/tests/open-syscall.c | 3 ++-
tools/perf/tests/perf-record.c | 13 +++++++++----
tools/perf/tests/rdpmc.c | 6 ++++--
tools/perf/tests/sw-clock.c | 6 ++++--
tools/perf/tests/task-exit.c | 6 ++++--
9 files changed, 38 insertions(+), 19 deletions(-)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index c6796d22423a..99481361b19f 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -185,9 +185,11 @@ static bool perf_test__matches(int curr, int argc, const char *argv[])
static int run_test(struct test *test)
{
int status, err = -1, child = fork();
+ char sbuf[STRERR_BUFSIZE];
if (child < 0) {
- pr_err("failed to fork test: %s\n", strerror(errno));
+ pr_err("failed to fork test: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -1;
}
diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
index 142263492f6f..9b9622a33932 100644
--- a/tools/perf/tests/mmap-basic.c
+++ b/tools/perf/tests/mmap-basic.c
@@ -31,6 +31,7 @@ int test__basic_mmap(void)
unsigned int nr_events[nsyscalls],
expected_nr_events[nsyscalls], i, j;
struct perf_evsel *evsels[nsyscalls], *evsel;
+ char sbuf[STRERR_BUFSIZE];
threads = thread_map__new(-1, getpid(), UINT_MAX);
if (threads == NULL) {
@@ -49,7 +50,7 @@ int test__basic_mmap(void)
sched_setaffinity(0, sizeof(cpu_set), &cpu_set);
if (sched_setaffinity(0, sizeof(cpu_set), &cpu_set) < 0) {
pr_debug("sched_setaffinity() failed on CPU %d: %s ",
- cpus->map[0], strerror(errno));
+ cpus->map[0], strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_free_cpus;
}
@@ -79,7 +80,7 @@ int test__basic_mmap(void)
if (perf_evsel__open(evsels[i], cpus, threads) < 0) {
pr_debug("failed to open counter: %s, "
"tweak /proc/sys/kernel/perf_event_paranoid?\n",
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
@@ -89,7 +90,7 @@ int test__basic_mmap(void)
if (perf_evlist__mmap(evlist, 128, true) < 0) {
pr_debug("failed to mmap events: %d (%s)\n", errno,
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
diff --git a/tools/perf/tests/open-syscall-all-cpus.c b/tools/perf/tests/open-syscall-all-cpus.c
index 5fecdbd2f5f7..8fa82d1700c7 100644
--- a/tools/perf/tests/open-syscall-all-cpus.c
+++ b/tools/perf/tests/open-syscall-all-cpus.c
@@ -12,6 +12,7 @@ int test__open_syscall_event_on_all_cpus(void)
unsigned int nr_open_calls = 111, i;
cpu_set_t cpu_set;
struct thread_map *threads = thread_map__new(-1, getpid(), UINT_MAX);
+ char sbuf[STRERR_BUFSIZE];
if (threads == NULL) {
pr_debug("thread_map__new\n");
@@ -35,7 +36,7 @@ int test__open_syscall_event_on_all_cpus(void)
if (perf_evsel__open(evsel, cpus, threads) < 0) {
pr_debug("failed to open counter: %s, "
"tweak /proc/sys/kernel/perf_event_paranoid?\n",
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_evsel_delete;
}
@@ -56,7 +57,7 @@ int test__open_syscall_event_on_all_cpus(void)
if (sched_setaffinity(0, sizeof(cpu_set), &cpu_set) < 0) {
pr_debug("sched_setaffinity() failed on CPU %d: %s ",
cpus->map[cpu],
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_close_fd;
}
for (i = 0; i < ncalls; ++i) {
diff --git a/tools/perf/tests/open-syscall-tp-fields.c b/tools/perf/tests/open-syscall-tp-fields.c
index 0785b64ffd6c..922bdb627950 100644
--- a/tools/perf/tests/open-syscall-tp-fields.c
+++ b/tools/perf/tests/open-syscall-tp-fields.c
@@ -22,6 +22,7 @@ int test__syscall_open_tp_fields(void)
struct perf_evlist *evlist = perf_evlist__new();
struct perf_evsel *evsel;
int err = -1, i, nr_events = 0, nr_polls = 0;
+ char sbuf[STRERR_BUFSIZE];
if (evlist == NULL) {
pr_debug("%s: perf_evlist__new\n", __func__);
@@ -48,13 +49,15 @@ int test__syscall_open_tp_fields(void)
err = perf_evlist__open(evlist);
if (err < 0) {
- pr_debug("perf_evlist__open: %s\n", strerror(errno));
+ pr_debug("perf_evlist__open: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
err = perf_evlist__mmap(evlist, UINT_MAX, false);
if (err < 0) {
- pr_debug("perf_evlist__mmap: %s\n", strerror(errno));
+ pr_debug("perf_evlist__mmap: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
diff --git a/tools/perf/tests/open-syscall.c b/tools/perf/tests/open-syscall.c
index c1dc7d25f38c..a33b2daae40f 100644
--- a/tools/perf/tests/open-syscall.c
+++ b/tools/perf/tests/open-syscall.c
@@ -9,6 +9,7 @@ int test__open_syscall_event(void)
struct perf_evsel *evsel;
unsigned int nr_open_calls = 111, i;
struct thread_map *threads = thread_map__new(-1, getpid(), UINT_MAX);
+ char sbuf[STRERR_BUFSIZE];
if (threads == NULL) {
pr_debug("thread_map__new\n");
@@ -24,7 +25,7 @@ int test__open_syscall_event(void)
if (perf_evsel__open_per_thread(evsel, threads) < 0) {
pr_debug("failed to open counter: %s, "
"tweak /proc/sys/kernel/perf_event_paranoid?\n",
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_evsel_delete;
}
diff --git a/tools/perf/tests/perf-record.c b/tools/perf/tests/perf-record.c
index aca1a83dd13a..2ce753c1db63 100644
--- a/tools/perf/tests/perf-record.c
+++ b/tools/perf/tests/perf-record.c
@@ -59,6 +59,7 @@ int test__PERF_RECORD(void)
int err = -1, errs = 0, i, wakeups = 0;
u32 cpu;
int total_events = 0, nr_events[PERF_RECORD_MAX] = { 0, };
+ char sbuf[STRERR_BUFSIZE];
if (evlist == NULL || argv == NULL) {
pr_debug("Not enough memory to create evlist\n");
@@ -100,7 +101,8 @@ int test__PERF_RECORD(void)
err = sched__get_first_possible_cpu(evlist->workload.pid, &cpu_mask);
if (err < 0) {
- pr_debug("sched__get_first_possible_cpu: %s\n", strerror(errno));
+ pr_debug("sched__get_first_possible_cpu: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
@@ -110,7 +112,8 @@ int test__PERF_RECORD(void)
* So that we can check perf_sample.cpu on all the samples.
*/
if (sched_setaffinity(evlist->workload.pid, cpu_mask_size, &cpu_mask) < 0) {
- pr_debug("sched_setaffinity: %s\n", strerror(errno));
+ pr_debug("sched_setaffinity: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
@@ -120,7 +123,8 @@ int test__PERF_RECORD(void)
*/
err = perf_evlist__open(evlist);
if (err < 0) {
- pr_debug("perf_evlist__open: %s\n", strerror(errno));
+ pr_debug("perf_evlist__open: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
@@ -131,7 +135,8 @@ int test__PERF_RECORD(void)
*/
err = perf_evlist__mmap(evlist, opts.mmap_pages, false);
if (err < 0) {
- pr_debug("perf_evlist__mmap: %s\n", strerror(errno));
+ pr_debug("perf_evlist__mmap: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
diff --git a/tools/perf/tests/rdpmc.c b/tools/perf/tests/rdpmc.c
index c04d1f268576..d31f2c4d9f64 100644
--- a/tools/perf/tests/rdpmc.c
+++ b/tools/perf/tests/rdpmc.c
@@ -100,6 +100,7 @@ static int __test__rdpmc(void)
};
u64 delta_sum = 0;
struct sigaction sa;
+ char sbuf[STRERR_BUFSIZE];
sigfillset(&sa.sa_mask);
sa.sa_sigaction = segfault_handler;
@@ -109,14 +110,15 @@ static int __test__rdpmc(void)
perf_event_open_cloexec_flag());
if (fd < 0) {
pr_err("Error: sys_perf_event_open() syscall returned "
- "with %d (%s)\n", fd, strerror(errno));
+ "with %d (%s)\n", fd,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return -1;
}
addr = mmap(NULL, page_size, PROT_READ, MAP_SHARED, fd, 0);
if (addr == (void *)(-1)) {
pr_err("Error: mmap() syscall returned with (%s)\n",
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_close;
}
diff --git a/tools/perf/tests/sw-clock.c b/tools/perf/tests/sw-clock.c
index 983d6b8562a8..1aa21c90731b 100644
--- a/tools/perf/tests/sw-clock.c
+++ b/tools/perf/tests/sw-clock.c
@@ -22,6 +22,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
volatile int tmp = 0;
u64 total_periods = 0;
int nr_samples = 0;
+ char sbuf[STRERR_BUFSIZE];
union perf_event *event;
struct perf_evsel *evsel;
struct perf_evlist *evlist;
@@ -62,14 +63,15 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
err = -errno;
pr_debug("Couldn't open evlist: %s\nHint: check %s, using %" PRIu64 " in this test.\n",
- strerror(errno), knob, (u64)attr.sample_freq);
+ strerror_r(errno, sbuf, sizeof(sbuf)),
+ knob, (u64)attr.sample_freq);
goto out_delete_evlist;
}
err = perf_evlist__mmap(evlist, 128, true);
if (err < 0) {
pr_debug("failed to mmap event: %d (%s)\n", errno,
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c
index 5ff3db318f12..87522f01c7ad 100644
--- a/tools/perf/tests/task-exit.c
+++ b/tools/perf/tests/task-exit.c
@@ -42,6 +42,7 @@ int test__task_exit(void)
.uses_mmap = true,
};
const char *argv[] = { "true", NULL };
+ char sbuf[STRERR_BUFSIZE];
signal(SIGCHLD, sig_handler);
@@ -82,13 +83,14 @@ int test__task_exit(void)
err = perf_evlist__open(evlist);
if (err < 0) {
- pr_debug("Couldn't open the evlist: %s\n", strerror(-err));
+ pr_debug("Couldn't open the evlist: %s\n",
+ strerror_r(-err, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
if (perf_evlist__mmap(evlist, 128, true) < 0) {
pr_debug("failed to mmap events: %d (%s)\n", errno,
- strerror(errno));
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out_delete_evlist;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 14/18] perf sched: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (12 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 13/18] perf test: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:49 ` Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 15/18] perf buildid-cache: " Arnaldo Carvalho de Melo
` (4 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:49 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error message for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022247.3545.4564.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-sched.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index f5874a27b346..9c9287fbf8e9 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -428,6 +428,7 @@ static u64 get_cpu_usage_nsec_parent(void)
static int self_open_counters(void)
{
struct perf_event_attr attr;
+ char sbuf[STRERR_BUFSIZE];
int fd;
memset(&attr, 0, sizeof(attr));
@@ -440,7 +441,8 @@ static int self_open_counters(void)
if (fd < 0)
pr_err("Error: sys_perf_event_open() syscall returned "
- "with %d (%s)\n", fd, strerror(errno));
+ "with %d (%s)\n", fd,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
return fd;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 15/18] perf buildid-cache: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (13 preceding siblings ...)
2014-08-15 16:49 ` [PATCH 14/18] perf sched: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:50 ` Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 16/18] perf kvm: " Arnaldo Carvalho de Melo
` (3 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error messages for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022249.3545.53211.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-buildid-cache.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
index ac5838e0b1bd..70385756da63 100644
--- a/tools/perf/builtin-buildid-cache.c
+++ b/tools/perf/builtin-buildid-cache.c
@@ -291,6 +291,7 @@ int cmd_buildid_cache(int argc, const char **argv,
*missing_filename = NULL,
*update_name_list_str = NULL,
*kcore_filename;
+ char sbuf[STRERR_BUFSIZE];
struct perf_data_file file = {
.mode = PERF_DATA_MODE_READ,
@@ -347,7 +348,7 @@ int cmd_buildid_cache(int argc, const char **argv,
continue;
}
pr_warning("Couldn't add %s: %s\n",
- pos->s, strerror(errno));
+ pos->s, strerror_r(errno, sbuf, sizeof(sbuf)));
}
strlist__delete(list);
@@ -365,7 +366,7 @@ int cmd_buildid_cache(int argc, const char **argv,
continue;
}
pr_warning("Couldn't remove %s: %s\n",
- pos->s, strerror(errno));
+ pos->s, strerror_r(errno, sbuf, sizeof(sbuf)));
}
strlist__delete(list);
@@ -386,7 +387,7 @@ int cmd_buildid_cache(int argc, const char **argv,
continue;
}
pr_warning("Couldn't update %s: %s\n",
- pos->s, strerror(errno));
+ pos->s, strerror_r(errno, sbuf, sizeof(sbuf)));
}
strlist__delete(list);
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 16/18] perf kvm: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (14 preceding siblings ...)
2014-08-15 16:50 ` [PATCH 15/18] perf buildid-cache: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:50 ` Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 17/18] perf help: " Arnaldo Carvalho de Melo
` (2 subsequent siblings)
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error messages for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022251.3545.83718.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-kvm.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 14d03edc81c2..1a4ef9cd9d5f 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -990,6 +990,7 @@ static int kvm_live_open_events(struct perf_kvm_stat *kvm)
int err, rc = -1;
struct perf_evsel *pos;
struct perf_evlist *evlist = kvm->evlist;
+ char sbuf[STRERR_BUFSIZE];
perf_evlist__config(evlist, &kvm->opts);
@@ -1026,12 +1027,14 @@ static int kvm_live_open_events(struct perf_kvm_stat *kvm)
err = perf_evlist__open(evlist);
if (err < 0) {
- printf("Couldn't create the events: %s\n", strerror(errno));
+ printf("Couldn't create the events: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
goto out;
}
if (perf_evlist__mmap(evlist, kvm->opts.mmap_pages, false) < 0) {
- ui__error("Failed to mmap the events: %s\n", strerror(errno));
+ ui__error("Failed to mmap the events: %s\n",
+ strerror_r(errno, sbuf, sizeof(sbuf)));
perf_evlist__close(evlist);
goto out;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 17/18] perf help: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (15 preceding siblings ...)
2014-08-15 16:50 ` [PATCH 16/18] perf kvm: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:50 ` Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 18/18] perf stat: " Arnaldo Carvalho de Melo
2014-08-18 8:18 ` [GIT PULL 00/18] perf/core improvements and fixes Ingo Molnar
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error messages for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022253.3545.82136.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-help.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c
index 0384d930480b..25d20628212e 100644
--- a/tools/perf/builtin-help.c
+++ b/tools/perf/builtin-help.c
@@ -103,6 +103,8 @@ static int check_emacsclient_version(void)
static void exec_woman_emacs(const char *path, const char *page)
{
+ char sbuf[STRERR_BUFSIZE];
+
if (!check_emacsclient_version()) {
/* This works only with emacsclient version >= 22. */
struct strbuf man_page = STRBUF_INIT;
@@ -111,16 +113,19 @@ static void exec_woman_emacs(const char *path, const char *page)
path = "emacsclient";
strbuf_addf(&man_page, "(woman \"%s\")", page);
execlp(path, "emacsclient", "-e", man_page.buf, NULL);
- warning("failed to exec '%s': %s", path, strerror(errno));
+ warning("failed to exec '%s': %s", path,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
}
}
static void exec_man_konqueror(const char *path, const char *page)
{
const char *display = getenv("DISPLAY");
+
if (display && *display) {
struct strbuf man_page = STRBUF_INIT;
const char *filename = "kfmclient";
+ char sbuf[STRERR_BUFSIZE];
/* It's simpler to launch konqueror using kfmclient. */
if (path) {
@@ -139,24 +144,31 @@ static void exec_man_konqueror(const char *path, const char *page)
path = "kfmclient";
strbuf_addf(&man_page, "man:%s(1)", page);
execlp(path, filename, "newTab", man_page.buf, NULL);
- warning("failed to exec '%s': %s", path, strerror(errno));
+ warning("failed to exec '%s': %s", path,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
}
}
static void exec_man_man(const char *path, const char *page)
{
+ char sbuf[STRERR_BUFSIZE];
+
if (!path)
path = "man";
execlp(path, "man", page, NULL);
- warning("failed to exec '%s': %s", path, strerror(errno));
+ warning("failed to exec '%s': %s", path,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
}
static void exec_man_cmd(const char *cmd, const char *page)
{
struct strbuf shell_cmd = STRBUF_INIT;
+ char sbuf[STRERR_BUFSIZE];
+
strbuf_addf(&shell_cmd, "%s %s", cmd, page);
execl("/bin/sh", "sh", "-c", shell_cmd.buf, NULL);
- warning("failed to exec '%s': %s", cmd, strerror(errno));
+ warning("failed to exec '%s': %s", cmd,
+ strerror_r(errno, sbuf, sizeof(sbuf)));
}
static void add_man_viewer(const char *name)
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* [PATCH 18/18] perf stat: Use strerror_r instead of strerror
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (16 preceding siblings ...)
2014-08-15 16:50 ` [PATCH 17/18] perf help: " Arnaldo Carvalho de Melo
@ 2014-08-15 16:50 ` Arnaldo Carvalho de Melo
2014-08-18 8:18 ` [GIT PULL 00/18] perf/core improvements and fixes Ingo Molnar
18 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Masami Hiramatsu, Ingo Molnar, Namhyung Kim,
Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Arnaldo Carvalho de Melo
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Use strerror_r instead of strerror in error message for thread-safety.
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20140814022255.3545.81549.stgit@kbuild-fedora.novalocal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 3e80aa10cfd8..5fe0edb1de5d 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -593,7 +593,7 @@ static int __run_perf_stat(int argc, const char **argv)
if (perf_evlist__apply_filters(evsel_list)) {
error("failed to set filter with %d (%s)\n", errno,
- strerror(errno));
+ strerror_r(errno, msg, sizeof(msg)));
return -1;
}
--
1.9.3
^ permalink raw reply related [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (17 preceding siblings ...)
2014-08-15 16:50 ` [PATCH 18/18] perf stat: " Arnaldo Carvalho de Melo
@ 2014-08-18 8:18 ` Ingo Molnar
18 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2014-08-18 8:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alex Converse, Andi Kleen,
Anshuman Khandual, Arun Sharma, Brendan Gregg, Cody P Schafer,
David Ahern, Elliott Hughes, Frederic Weisbecker, Haren Myneni,
Jiri Olsa, linuxppc-dev, Masami Hiramatsu, Michael Ellerman,
Namhyung Kim, Naohiro Aota, Paul Mackerras, Peter Zijlstra,
Rodrigo Campos, Stephane Eranian, Sukadev Bhattiprolu,
yrl.pp-manager.tt, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit f373da34282560c60f0c197690eecb1b2dc49fc0:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-08-14 10:38:40 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 759e612bf96627b64fcafe4174b3f6f2dedf2c0d:
>
> perf stat: Use strerror_r instead of strerror (2014-08-15 13:08:40 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> . Warn user to rebuild target with debuginfo in 'perf probe' (Masami Hiramatsu)
>
> . Don't truncate Intel style addresses in 'annotate'. (Alex Converse)
>
> Developer stuff:
>
> . Annotate PMU related list_head members with type info. (Cody P Schafer)
>
> . Add the triplet used for arm64 by Android (Elliott Hughes)
>
> . Replace thread unsafe strerror() with strerror_r() accross the
> whole tools/perf/ tree (Masami Hiramatsu)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Alex Converse (1):
> perf annotate: Don't truncate Intel style addresses
>
> Cody P Schafer (1):
> perf tools: Annotate PMU related list_head members with type info
>
> Elliott Hughes (1):
> perf tools: Add arm64 triplets
>
> Masami Hiramatsu (14):
> perf probe: Warn user to rebuild target with debuginfo
> perf probe: Don't use strerror if strlist__add failed
> perf: Use strerror_r instead of strerror
> perf probe: Make error messages thread-safe
> perf util: Replace strerror with strerror_r for thread-safety
> perf top: Use strerror_r instead of strerror
> perf trace: Use strerror_r instead of strerror
> perf record: Use strerror_r instead of strerror
> perf test: Use strerror_r instead of strerror
> perf sched: Use strerror_r instead of strerror
> perf buildid-cache: Use strerror_r instead of strerror
> perf kvm: Use strerror_r instead of strerror
> perf help: Use strerror_r instead of strerror
> perf stat: Use strerror_r instead of strerror
>
> Namhyung Kim (1):
> perf report: Relax -g option parsing not to limit the option order
>
> tools/perf/arch/common.c | 9 +++
> tools/perf/builtin-buildid-cache.c | 7 ++-
> tools/perf/builtin-help.c | 20 +++++--
> tools/perf/builtin-kvm.c | 7 ++-
> tools/perf/builtin-probe.c | 5 +-
> tools/perf/builtin-record.c | 7 ++-
> tools/perf/builtin-sched.c | 4 +-
> tools/perf/builtin-stat.c | 2 +-
> tools/perf/builtin-top.c | 2 +-
> tools/perf/builtin-trace.c | 6 +-
> tools/perf/perf.c | 10 +++-
> tools/perf/tests/builtin-test.c | 4 +-
> tools/perf/tests/mmap-basic.c | 7 ++-
> tools/perf/tests/open-syscall-all-cpus.c | 5 +-
> tools/perf/tests/open-syscall-tp-fields.c | 7 ++-
> tools/perf/tests/open-syscall.c | 3 +-
> tools/perf/tests/perf-record.c | 13 +++--
> tools/perf/tests/rdpmc.c | 6 +-
> tools/perf/tests/sw-clock.c | 6 +-
> tools/perf/tests/task-exit.c | 6 +-
> tools/perf/util/annotate.c | 12 +++-
> tools/perf/util/callchain.c | 95 +++++++++++++------------------
> tools/perf/util/cloexec.c | 6 +-
> tools/perf/util/data.c | 8 ++-
> tools/perf/util/debug.h | 3 +
> tools/perf/util/dso.c | 8 ++-
> tools/perf/util/evlist.c | 2 +-
> tools/perf/util/evsel.c | 7 ++-
> tools/perf/util/parse-events.c | 5 +-
> tools/perf/util/pmu.c | 4 +-
> tools/perf/util/pmu.h | 6 +-
> tools/perf/util/probe-event.c | 75 +++++++++++++-----------
> tools/perf/util/probe-finder.c | 7 ++-
> tools/perf/util/run-command.c | 9 ++-
> tools/perf/util/util.c | 5 +-
> 35 files changed, 234 insertions(+), 154 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2018-05-19 10:54 Arnaldo Carvalho de Melo
@ 2018-05-19 11:33 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2018-05-19 11:33 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Clark Williams, linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Andy Lutomirski, Dave Hansen,
David Ahern, H . Peter Anvin, Jin Yao, Jiri Olsa, Joerg Roedel,
Kan Liang, Namhyung Kim, Naveen N . Rao, Peter Zijlstra,
Ravi Bangoria, Sandipan Das, Taeung Song, Thomas Gleixner,
Wang Nan, x86, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 5aafae8d097e2161ee5c6a12ad532100f8885d2b:
>
> Merge tag 'perf-core-for-mingo-4.18-20180516' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2018-05-16 17:56:43 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.18-20180519
>
> for you to fetch changes up to 19422a9f2a3be7f3a046285ffae4cbb571aa853a:
>
> perf tools: Fix kernel_start for PTI on x86 (2018-05-19 06:42:51 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Record min/max LBR cycles (>= skylake) and add 'perf annotate' TUI
> hotkey to show it (c) (Jin Yao)
>
> - Fix machine->kernel_start for PTI on x86 (Adrian Hunter)
>
> - Make machine->env->arch always available, e.g. in 'perf top', not
> just when reading that info from perf.data files (Adrian Hunter)
>
> - Reduce the number of files read at 'perf' start, leaving information such as
> cacheline size, tracefs mount point determination, max_stack, etc, to be
> lazily read as tools needs then (Arnaldo Carvalho de Melo)
>
> - Fixup BPF include and examples install messages (Arnaldo Carvalho de Melo)
>
> - Fixup callchain addresses and symbol offsets in 'perf script', to help
> correlating with objdump output (Sandipan Das)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (2):
> perf machine: Add machine__is() to identify machine arch
> perf tools: Fix kernel_start for PTI on x86
>
> Arnaldo Carvalho de Melo (12):
> perf config: Call perf_config__init() lazily
> tools lib api: The tracing_mnt variable doesn't need to be global
> tools lib api: Unexport 'tracing_path' variable
> tools lib api fs tracing_path: Introduce get/put_events_file() helpers
> perf tools: Reuse the path to the tracepoint /events/ directory
> perf parse-events: Use get/put_events_file()
> tools lib api fs tracing_path: Introduce opendir() method
> tools lib api fs tracing_path: Make tracing_events_path private
> tools include compiler-gcc: Add __pure attribute helper
> perf tools: Read the cache line size lazily
> perf tools: No need to unconditionally read the max_stack sysctls
> perf bpf: Fixup include and examples install messages
>
> Jin Yao (2):
> perf annotate: Record the min/max cycles
> perf annotate: Create hotkey 'c' to show min/max cycles
>
> Sandipan Das (2):
> perf script: Show virtual addresses instead of offsets
> perf script: Show symbol offsets by default
>
> tools/include/linux/compiler-gcc.h | 3 +
> tools/lib/api/fs/tracing_path.c | 40 +++++++++---
> tools/lib/api/fs/tracing_path.h | 9 ++-
> tools/perf/Makefile.perf | 2 +
> tools/perf/builtin-script.c | 26 ++++----
> tools/perf/builtin-top.c | 2 +-
> tools/perf/builtin-trace.c | 2 +-
> tools/perf/perf.c | 24 +------
> tools/perf/tests/parse-events.c | 9 +--
> .../tests/shell/record+probe_libc_inet_pton.sh | 12 ++--
> tools/perf/ui/browsers/annotate.c | 8 +++
> tools/perf/util/annotate.c | 51 ++++++++++++---
> tools/perf/util/annotate.h | 11 +++-
> tools/perf/util/config.c | 16 ++---
> tools/perf/util/config.h | 1 -
> tools/perf/util/env.c | 18 ++++++
> tools/perf/util/env.h | 2 +
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/machine.c | 18 +++++-
> tools/perf/util/machine.h | 2 +
> tools/perf/util/parse-events.c | 73 +++++++++++++---------
> tools/perf/util/probe-file.c | 3 +-
> tools/perf/util/sort.c | 4 +-
> tools/perf/util/sort.h | 4 +-
> tools/perf/util/trace-event-info.c | 11 ++--
> tools/perf/util/trace-event.c | 8 ++-
> tools/perf/util/util.c | 34 +++++++++-
> tools/perf/util/util.h | 4 +-
> 28 files changed, 279 insertions(+), 120 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2018-05-19 10:54 Arnaldo Carvalho de Melo
2018-05-19 11:33 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-05-19 10:54 UTC (permalink / raw)
To: Ingo Molnar
Cc: Clark Williams, linux-kernel, linux-perf-users,
Arnaldo Carvalho de Melo, Adrian Hunter, Alexander Shishkin,
Andi Kleen, Andy Lutomirski, Dave Hansen, David Ahern,
H . Peter Anvin, Jin Yao, Jiri Olsa, Joerg Roedel, Kan Liang,
Namhyung Kim, Naveen N . Rao, Peter Zijlstra, Ravi Bangoria,
Sandipan Das, Taeung Song, Thomas Gleixner, Wang Nan, x86,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 5aafae8d097e2161ee5c6a12ad532100f8885d2b:
Merge tag 'perf-core-for-mingo-4.18-20180516' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2018-05-16 17:56:43 +0200)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.18-20180519
for you to fetch changes up to 19422a9f2a3be7f3a046285ffae4cbb571aa853a:
perf tools: Fix kernel_start for PTI on x86 (2018-05-19 06:42:51 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Record min/max LBR cycles (>= skylake) and add 'perf annotate' TUI
hotkey to show it (c) (Jin Yao)
- Fix machine->kernel_start for PTI on x86 (Adrian Hunter)
- Make machine->env->arch always available, e.g. in 'perf top', not
just when reading that info from perf.data files (Adrian Hunter)
- Reduce the number of files read at 'perf' start, leaving information such as
cacheline size, tracefs mount point determination, max_stack, etc, to be
lazily read as tools needs then (Arnaldo Carvalho de Melo)
- Fixup BPF include and examples install messages (Arnaldo Carvalho de Melo)
- Fixup callchain addresses and symbol offsets in 'perf script', to help
correlating with objdump output (Sandipan Das)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (2):
perf machine: Add machine__is() to identify machine arch
perf tools: Fix kernel_start for PTI on x86
Arnaldo Carvalho de Melo (12):
perf config: Call perf_config__init() lazily
tools lib api: The tracing_mnt variable doesn't need to be global
tools lib api: Unexport 'tracing_path' variable
tools lib api fs tracing_path: Introduce get/put_events_file() helpers
perf tools: Reuse the path to the tracepoint /events/ directory
perf parse-events: Use get/put_events_file()
tools lib api fs tracing_path: Introduce opendir() method
tools lib api fs tracing_path: Make tracing_events_path private
tools include compiler-gcc: Add __pure attribute helper
perf tools: Read the cache line size lazily
perf tools: No need to unconditionally read the max_stack sysctls
perf bpf: Fixup include and examples install messages
Jin Yao (2):
perf annotate: Record the min/max cycles
perf annotate: Create hotkey 'c' to show min/max cycles
Sandipan Das (2):
perf script: Show virtual addresses instead of offsets
perf script: Show symbol offsets by default
tools/include/linux/compiler-gcc.h | 3 +
tools/lib/api/fs/tracing_path.c | 40 +++++++++---
tools/lib/api/fs/tracing_path.h | 9 ++-
tools/perf/Makefile.perf | 2 +
tools/perf/builtin-script.c | 26 ++++----
tools/perf/builtin-top.c | 2 +-
tools/perf/builtin-trace.c | 2 +-
tools/perf/perf.c | 24 +------
tools/perf/tests/parse-events.c | 9 +--
.../tests/shell/record+probe_libc_inet_pton.sh | 12 ++--
tools/perf/ui/browsers/annotate.c | 8 +++
tools/perf/util/annotate.c | 51 ++++++++++++---
tools/perf/util/annotate.h | 11 +++-
tools/perf/util/config.c | 16 ++---
tools/perf/util/config.h | 1 -
tools/perf/util/env.c | 18 ++++++
tools/perf/util/env.h | 2 +
tools/perf/util/evsel.c | 2 +-
tools/perf/util/machine.c | 18 +++++-
tools/perf/util/machine.h | 2 +
tools/perf/util/parse-events.c | 73 +++++++++++++---------
tools/perf/util/probe-file.c | 3 +-
tools/perf/util/sort.c | 4 +-
tools/perf/util/sort.h | 4 +-
tools/perf/util/trace-event-info.c | 11 ++--
tools/perf/util/trace-event.c | 8 ++-
tools/perf/util/util.c | 34 +++++++++-
tools/perf/util/util.h | 4 +-
28 files changed, 279 insertions(+), 120 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with
and without libelf support. Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.
The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.
Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0
2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822
3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0
4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0
5 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0
6 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
7 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
8 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
9 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
10 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
11 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18)
12 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)
13 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2
14 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2
15 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
16 debian:experimental : Ok gcc (Debian 7.3.0-19) 7.3.0
17 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 7.3.0-19) 7.3.0
18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 7.3.0-19) 7.3.0
19 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 7.3.0-18) 7.3.0
20 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 7.3.0-19) 7.3.0
21 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
22 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
23 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
24 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
25 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
26 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
27 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
28 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
29 fedora:27 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
30 fedora:28 : Ok gcc (GCC) 8.1.1 20180502 (Red Hat 8.1.1-1)
31 fedora:rawhide : Ok gcc (GCC) 8.0.1 20180324 (Red Hat 8.0.1-0.20)
32 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 6.4.0-r1 p1.3) 6.4.0
33 mageia:5 : Ok gcc (GCC) 4.9.2
34 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0
35 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5
36 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5
37 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5
38 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
39 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18.0.7)
40 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
41 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
42 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
43 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
44 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
45 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
46 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
47 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
48 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
49 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
50 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
51 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
52 ubuntu:17.04 : Ok gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406
53 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
54 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
#
# uname -a
Linux seventh 4.17.0-rc5-00069-g3acf4e395260 #2 SMP Fri May 18 12:13:59 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
# perf --version
perf version 4.17.rc5.g19422a9
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Breakpoint accounting : Ok
22: Number of exit events of a simple workload : Ok
23: Software clock events period values : Ok
24: Object code reading : Ok
25: Sample parsing : Ok
26: Use a dummy software event to keep tracking : Ok
27: Parse with no sample_id_all bit set : Ok
28: Filter hist entries : Ok
29: Lookup mmap thread : Ok
30: Share thread mg : Ok
31: Sort output of hist entries : Ok
32: Cumulate child hist entries : Ok
33: Track with sched_switch : Ok
34: Filter fds with revents mask in a fdarray : Ok
35: Add fd to a fdarray, making it autogrow : Ok
36: kmod_path__parse : Ok
37: Thread map : Ok
38: LLVM search and compile :
38.1: Basic BPF llvm compile : Ok
38.2: kbuild searching : Ok
38.3: Compile source for BPF prologue generation : Ok
38.4: Compile source for BPF relocation : Ok
39: Session topology : Ok
40: BPF filter :
40.1: Basic BPF filtering : Ok
40.2: BPF pinning : Ok
40.3: BPF prologue generation : Ok
40.4: BPF relocation checker : Ok
41: Synthesize thread map : Ok
42: Remove thread map : Ok
43: Synthesize cpu map : Ok
44: Synthesize stat config : Ok
45: Synthesize stat : Ok
46: Synthesize stat round : Ok
47: Synthesize attr update : Ok
48: Event times : Ok
49: Read backward ring buffer : Ok
50: Print cpu map : Ok
51: Probe SDT events : Ok
52: is_printable_array : Ok
53: Print bitmap : Ok
54: perf hooks : Ok
55: builtin clang support : Skip (not compiled in)
56: unit_number__scnprintf : Ok
57: mem2node : Ok
58: x86 rdpmc : Ok
59: Convert perf time to TSC : Ok
60: DWARF unwind : Ok
61: x86 instruction decoder - new instructions : Ok
62: Use vfs_getname probe to get syscall args filenames : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: probe libc's inet_pton & backtrace it with ping : Ok
65: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/perf/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_debug_O: make DEBUG=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_static_O: make LDFLAGS=-static
make_no_libperl_O: make NO_LIBPERL=1
make_util_map_o_O: make util/map.o
make_no_libelf_O: make NO_LIBELF=1
make_no_slang_O: make NO_SLANG=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_help_O: make help
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_newt_O: make NO_NEWT=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_perf_o_O: make perf.o
make_install_O: make install
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_tags_O: make tags
make_install_prefix_O: make install prefix=/tmp/krava
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_clean_all_O: make clean all
make_no_gtk2_O: make NO_GTK2=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libbpf_O: make NO_LIBBPF=1
make_install_bin_O: make install-bin
make_doc_O: make doc
make_pure_O: make
OK
make: Leaving directory '/home/acme/git/perf/tools/perf'
$
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2017-08-29 19:42 Arnaldo Carvalho de Melo
@ 2017-08-29 21:15 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2017-08-29 21:15 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, linux-perf-users, Adrian Hunter,
Alexander Shishkin, Alexis Berlemont, Andi Kleen,
Andy Lutomirski, Arnd Bergmann, Borislav Petkov, Dave Hansen,
David Ahern, David Carrillo-Cisneros, David Tolnay, Hanjun Guo,
Hemant Kumar, Jack Henschel, Janakarajan Natarajan, Jiri Olsa,
Joe Mario, Li Bin, Mark Rutland, Masami Hiramatsu, Milian Wolff,
Namhyung Kim, Paul Turner, Peter Zijlstra, Stephane Eranian,
Wang Nan, zhangmengting, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit b00233b5306512a09e339d69ef5e390a77f2d302:
>
> perf/x86: Export some PMU attributes in caps/ directory (2017-08-25 11:04:20 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170829
>
> for you to fetch changes up to b2f7605076d6cdd68162c42c34caadafbbe4c69f:
>
> perf symbols: Fix plt entry calculation for ARM and AARCH64 (2017-08-29 11:41:27 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> - Fix remote HITM detection for Skylake in 'perf c2c' (Jiri Olsa)
>
> - Fixes for the handling of PERF_RECORD_READ records (Jiri Olsa)
>
> - Fix kprobes blackist symbol lookup in 'perf probe' (Li Bin)
>
> - The PLT header and entry sizes are not the same in !x86, fix it for ARM and
> AARCH64 (Li Bin)
>
> - Beautify pkey_{alloc,free,mprotect} arguments in 'perf trace' (Arnaldo Carvalho de Melo)
>
> - Fix CC, AR, LD external definition, allow flex and bison to be
> externally defined and other related Makefile fixes (David Carrillo-Cisneros)
>
> - Sync cpu features kernel ABI headers with tooling headers (Arnaldo Carvalho de Melo)
>
> - Fix path to PMU formats in 'perf stat' documentation (Jack Henschel)
>
> - Fix static build with newer toolchains (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> tools headers: Sync cpu features kernel ABI headers with tooling headers
> perf trace beauty: Beautify pkey_{alloc,free,mprotect} arguments
>
> David Carrillo-Cisneros (5):
> tools build tests: Don't hardcode gcc name
> perf tools: Allow external definition of flex and bison binary names
> tools lib: Allow external definition of CC, AR and LD
> perf tools: Robustify detection of clang binary
> perf tools: Pass full path of FEATURES_DUMP
>
> Jack Henschel (1):
> perf stat: Fix path to PMU formats in documentation
>
> Jiri Olsa (8):
> perf tools: Fix static build with newer toolchains
> perf c2c: Fix remote HITM detection for Skylake
> perf record: Set read_format for inherit_stat
> perf report: Add dump_read function
> perf values: Fix thread index bug
> perf values: Fix allocation check
> perf values: Zero value buffers
> perf report: Group stat values on global event id
>
> Li Bin (2):
> perf probe: Fix kprobe blacklist checking condition
> perf symbols: Fix plt entry calculation for ARM and AARCH64
>
> tools/arch/x86/include/asm/cpufeatures.h | 5 +--
> tools/arch/x86/include/asm/disabled-features.h | 4 +-
> tools/build/tests/ex/Makefile | 2 +-
> tools/lib/api/Makefile | 8 ++--
> tools/lib/subcmd/Makefile | 2 +-
> tools/perf/Documentation/perf-stat.txt | 4 +-
> tools/perf/Makefile.config | 4 +-
> tools/perf/Makefile.perf | 26 ++++++++---
> tools/perf/builtin-report.c | 6 +--
> tools/perf/builtin-trace.c | 8 ++++
> tools/perf/trace/beauty/Build | 1 +
> tools/perf/trace/beauty/beauty.h | 3 ++
> tools/perf/trace/beauty/pkey_alloc.c | 50 ++++++++++++++++++++++
> .../perf/trace/beauty/pkey_alloc_access_rights.sh | 10 +++++
> tools/perf/util/evsel.c | 7 ++-
> tools/perf/util/intel-pt-decoder/Build | 2 +-
> tools/perf/util/mem-events.c | 11 ++++-
> tools/perf/util/probe-event.c | 2 +-
> tools/perf/util/session.c | 25 +++++++++++
> tools/perf/util/symbol-elf.c | 27 +++++++++---
> tools/perf/util/values.c | 17 +++++---
> tools/scripts/Makefile.include | 4 +-
> 22 files changed, 185 insertions(+), 43 deletions(-)
> create mode 100644 tools/perf/trace/beauty/pkey_alloc.c
> create mode 100755 tools/perf/trace/beauty/pkey_alloc_access_rights.sh
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2017-08-29 19:42 Arnaldo Carvalho de Melo
2017-08-29 21:15 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-08-29 19:42 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linux-perf-users, Arnaldo Carvalho de Melo,
Adrian Hunter, Alexander Shishkin, Alexis Berlemont, Andi Kleen,
Andy Lutomirski, Arnd Bergmann, Borislav Petkov, Dave Hansen,
David Ahern, David Carrillo-Cisneros, David Tolnay, Hanjun Guo,
Hemant Kumar, Jack Henschel, Janakarajan Natarajan, Jiri Olsa,
Joe Mario, Li Bin, Mark Rutland, Masami Hiramatsu, Milian Wolff,
Namhyung Kim, Paul Turner, Peter Zijlstra, Stephane Eranian,
Wang Nan, zhangmengting, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit b00233b5306512a09e339d69ef5e390a77f2d302:
perf/x86: Export some PMU attributes in caps/ directory (2017-08-25 11:04:20 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.14-20170829
for you to fetch changes up to b2f7605076d6cdd68162c42c34caadafbbe4c69f:
perf symbols: Fix plt entry calculation for ARM and AARCH64 (2017-08-29 11:41:27 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
- Fix remote HITM detection for Skylake in 'perf c2c' (Jiri Olsa)
- Fixes for the handling of PERF_RECORD_READ records (Jiri Olsa)
- Fix kprobes blackist symbol lookup in 'perf probe' (Li Bin)
- The PLT header and entry sizes are not the same in !x86, fix it for ARM and
AARCH64 (Li Bin)
- Beautify pkey_{alloc,free,mprotect} arguments in 'perf trace' (Arnaldo Carvalho de Melo)
- Fix CC, AR, LD external definition, allow flex and bison to be
externally defined and other related Makefile fixes (David Carrillo-Cisneros)
- Sync cpu features kernel ABI headers with tooling headers (Arnaldo Carvalho de Melo)
- Fix path to PMU formats in 'perf stat' documentation (Jack Henschel)
- Fix static build with newer toolchains (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
tools headers: Sync cpu features kernel ABI headers with tooling headers
perf trace beauty: Beautify pkey_{alloc,free,mprotect} arguments
David Carrillo-Cisneros (5):
tools build tests: Don't hardcode gcc name
perf tools: Allow external definition of flex and bison binary names
tools lib: Allow external definition of CC, AR and LD
perf tools: Robustify detection of clang binary
perf tools: Pass full path of FEATURES_DUMP
Jack Henschel (1):
perf stat: Fix path to PMU formats in documentation
Jiri Olsa (8):
perf tools: Fix static build with newer toolchains
perf c2c: Fix remote HITM detection for Skylake
perf record: Set read_format for inherit_stat
perf report: Add dump_read function
perf values: Fix thread index bug
perf values: Fix allocation check
perf values: Zero value buffers
perf report: Group stat values on global event id
Li Bin (2):
perf probe: Fix kprobe blacklist checking condition
perf symbols: Fix plt entry calculation for ARM and AARCH64
tools/arch/x86/include/asm/cpufeatures.h | 5 +--
tools/arch/x86/include/asm/disabled-features.h | 4 +-
tools/build/tests/ex/Makefile | 2 +-
tools/lib/api/Makefile | 8 ++--
tools/lib/subcmd/Makefile | 2 +-
tools/perf/Documentation/perf-stat.txt | 4 +-
tools/perf/Makefile.config | 4 +-
tools/perf/Makefile.perf | 26 ++++++++---
tools/perf/builtin-report.c | 6 +--
tools/perf/builtin-trace.c | 8 ++++
tools/perf/trace/beauty/Build | 1 +
tools/perf/trace/beauty/beauty.h | 3 ++
tools/perf/trace/beauty/pkey_alloc.c | 50 ++++++++++++++++++++++
.../perf/trace/beauty/pkey_alloc_access_rights.sh | 10 +++++
tools/perf/util/evsel.c | 7 ++-
tools/perf/util/intel-pt-decoder/Build | 2 +-
tools/perf/util/mem-events.c | 11 ++++-
tools/perf/util/probe-event.c | 2 +-
tools/perf/util/session.c | 25 +++++++++++
tools/perf/util/symbol-elf.c | 27 +++++++++---
tools/perf/util/values.c | 17 +++++---
tools/scripts/Makefile.include | 4 +-
22 files changed, 185 insertions(+), 43 deletions(-)
create mode 100644 tools/perf/trace/beauty/pkey_alloc.c
create mode 100755 tools/perf/trace/beauty/pkey_alloc_access_rights.sh
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf
commands with a variety of command line event specifications to then
intercept the sys_perf_event syscall to check that the perf_event_attr
fields are set up as expected, among a variety of other unit tests.
The 'perf test' also runs shell scripts exercising the tools, checking
if they affect the system in certain ways, like setting up kprobes and
uprobes, request callchains for well known programs and check that they
are the expected ones, see if 'perf trace' beautifies system call
arguments correctly, etc.
Additionally, a new set of tests, script based, runs the tools in a live system,
setting probes in place that then gets used by 'perf trace', with its output
compared against expected results.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:3.6: Ok
4 alpine:edge: Ok
5 android-ndk:r12b-arm: Ok
6 archlinux:latest: Ok
7 centos:5: Ok
8 centos:6: Ok
9 centos:7: Ok
10 debian:7: Ok
11 debian:8: Ok
12 debian:9: Ok
13 debian:experimental: Ok
14 debian:experimental-x-arm64: Ok
15 debian:experimental-x-mips: Ok
16 debian:experimental-x-mips64: Ok
17 debian:experimental-x-mipsel: Ok
18 fedora:20: Ok
19 fedora:21: Ok
20 fedora:22: Ok
21 fedora:23: Ok
22 fedora:24: Ok
23 fedora:24-x-ARC-uClibc: Ok
24 fedora:25: Ok
25 fedora:26: Ok
26 fedora:rawhide: Ok
27 mageia:5: Ok
28 opensuse:13.2: Ok
29 opensuse:42.1: Ok
30 opensuse:42.2: Ok
31 opensuse:42.3: Ok
32 opensuse:tumbleweed: Ok
33 oraclelinux:6: Ok
34 oraclelinux:7: Ok
35 ubuntu:12.04.5: Ok
36 ubuntu:14.04.4: Ok
37 ubuntu:14.04.4-x-linaro-arm64: Ok
38 ubuntu:15.10: Ok
39 ubuntu:16.04: Ok
40 ubuntu:16.04-x-arm: Ok
41 ubuntu:16.04-x-arm64: Ok
42 ubuntu:16.04-x-powerpc: Ok
43 ubuntu:16.04-x-powerpc64: Ok
44 ubuntu:16.04-x-powerpc64el: Ok
45 ubuntu:16.04-x-s390: Ok
46 ubuntu:16.10: Ok
47 ubuntu:17.04: Ok
48 ubuntu:17.10: Ok
#
# uname -a
Linux jouet 4.13.0-rc4+ #2 SMP Fri Aug 11 12:39:09 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Test data source output : Ok
6: Parse event definition strings : Ok
7: Simple expression parser : Ok
8: PERF_RECORD_* events & perf_sample fields : Ok
9: Parse perf pmu format : Ok
10: DSO data read : Ok
11: DSO data cache : Ok
12: DSO data reopen : Ok
13: Roundtrip evsel->name : Ok
14: Parse sched tracepoints fields : Ok
15: syscalls:sys_enter_openat event fields : Ok
16: Setup struct perf_event_attr : Ok
17: Match and link multiple hists : Ok
18: 'import perf' in python : Ok
19: Breakpoint overflow signal handler : Ok
20: Breakpoint overflow sampling : Ok
21: Number of exit events of a simple workload : Ok
22: Software clock events period values : Ok
23: Object code reading : Ok
24: Sample parsing : Ok
25: Use a dummy software event to keep tracking : Ok
26: Parse with no sample_id_all bit set : Ok
27: Filter hist entries : Ok
28: Lookup mmap thread : Ok
29: Share thread mg : Ok
30: Sort output of hist entries : Ok
31: Cumulate child hist entries : Ok
32: Track with sched_switch : Ok
33: Filter fds with revents mask in a fdarray : Ok
34: Add fd to a fdarray, making it autogrow : Ok
35: kmod_path__parse : Ok
36: Thread map : Ok
37: LLVM search and compile :
37.1: Basic BPF llvm compile : Ok
37.2: kbuild searching : Ok
37.3: Compile source for BPF prologue generation : Ok
37.4: Compile source for BPF relocation : Ok
38: Session topology : Ok
39: BPF filter :
39.1: Basic BPF filtering : Ok
39.2: BPF pinning : Ok
39.3: BPF prologue generation : Ok
39.4: BPF relocation checker : Ok
40: Synthesize thread map : Ok
41: Remove thread map : Ok
42: Synthesize cpu map : Ok
43: Synthesize stat config : Ok
44: Synthesize stat : Ok
45: Synthesize stat round : Ok
46: Synthesize attr update : Ok
47: Event times : Ok
48: Read backward ring buffer : Ok
49: Print cpu map : Ok
50: Probe SDT events : Ok
51: is_printable_array : Ok
52: Print bitmap : Ok
53: perf hooks : Ok
54: builtin clang support : Skip (not compiled in)
55: unit_number__scnprintf : Ok
56: x86 rdpmc : Ok
57: Convert perf time to TSC : Ok
58: DWARF unwind : Ok
59: x86 instruction decoder - new instructions : Ok
60: Intel cqm nmi context read : Skip
61: Use vfs_getname probe to get syscall args filenames : Ok
62: probe libc's inet_pton & backtrace it with ping : Ok
63: Check open filename arg using perf trace + vfs_getname: Ok
64: Add vfs_getname probe to get syscall args filenames : Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_backtrace_O: make NO_BACKTRACE=1
make_debug_O: make DEBUG=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_demangle_O: make NO_DEMANGLE=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_tags_O: make tags
make_install_prefix_O: make install prefix=/tmp/krava
make_no_gtk2_O: make NO_GTK2=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_static_O: make LDFLAGS=-static
make_util_map_o_O: make util/map.o
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_install_O: make install
make_no_libelf_O: make NO_LIBELF=1
make_pure_O: make
make_no_libperl_O: make NO_LIBPERL=1
make_perf_o_O: make perf.o
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_install_bin_O: make install-bin
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_newt_O: make NO_NEWT=1
make_doc_O: make doc
make_no_libbpf_O: make NO_LIBBPF=1
make_clean_all_O: make clean all
make_help_O: make help
make_no_libbionic_O: make NO_LIBBIONIC=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_slang_O: make NO_SLANG=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2017-04-12 7:13 ` Christian Borntraeger
@ 2017-04-12 7:24 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2017-04-12 7:24 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Arnaldo Carvalho de Melo, linux-kernel, Alexander Shishkin,
Andi Kleen, Andreas Krebbel, Andrew Vagin, David Ahern,
David Carrillo-Cisneros, Don Zickus, He Kuang, Hendrik Brueckner,
Jiri Olsa, Kan Liang, Martin Schwidefsky, Masami Hiramatsu,
Namhyung Kim, Paul Turner, Peter Zijlstra, Simon Que, stable, #,
v4.10+,
Stephane Eranian, Taeung Song, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
* Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> The merge looks wrong:
>
> dbdebdc53 (Ravi Bangoria 2016-11-23 21:33:46 +0530 133) },
> 3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 134) {
> 3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 135) .name = "s390",
> d9f8dfa9b (Christian Borntraeger 2017-04-06 09:51:52 +0200 136) .init = s390__annotate_init,
> e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 137) .objdump = {
> e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 138) .comment_char = '#',
> e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 139) },
> e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 140) },
> 43d5b075c (Ingo Molnar 2017-04-12 07:29:13 +0200 141) {
> 43d5b075c (Ingo Molnar 2017-04-12 07:29:13 +0200 142) .name = "s390",
> 3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 143) .objdump = {
> 3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 144) .comment_char = '#',
> 3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 145) },
> 3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 146) },
> 786c1b518 (Arnaldo Carvalho de Melo 2016-11-16 15:39:50 -0300 147) };
>
> You can delete line 141-146
Ok, I've deleted those lines and amended the merge commit - thanks!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2017-04-12 5:30 ` Ingo Molnar
@ 2017-04-12 7:13 ` Christian Borntraeger
2017-04-12 7:24 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Christian Borntraeger @ 2017-04-12 7:13 UTC (permalink / raw)
To: Ingo Molnar, Arnaldo Carvalho de Melo
Cc: linux-kernel, Alexander Shishkin, Andi Kleen, Andreas Krebbel,
Andrew Vagin, David Ahern, David Carrillo-Cisneros, Don Zickus,
He Kuang, Hendrik Brueckner, Jiri Olsa, Kan Liang,
Martin Schwidefsky, Masami Hiramatsu, Namhyung Kim, Paul Turner,
Peter Zijlstra, Simon Que, stable, #, v4.10+,
Stephane Eranian, Taeung Song, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
On 04/12/2017 07:30 AM, Ingo Molnar wrote:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
>> Hi Ingo,
>>
>> Please consider pulling,
>>
>> - Arnaldo
>>
>> Test results at the end of this message, as usual.
>>
>> The following changes since commit 9df9078ef2086652647248ee6e82ca8f661cb3f5:
>>
>> perf/amd/uncore: Fix pr_fmt() prefix (2017-04-11 08:44:59 +0200)
>>
>> are available in the git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170411
>>
>> for you to fetch changes up to 986a5bc028a84d487c354a529730b48682d1fb41:
>>
>> perf annotate: Use stripped line instead of raw disassemble line (2017-04-11 16:22:23 -0300)
>>
>> ----------------------------------------------------------------
>> perf/core improvements and fixes:
>>
>> User visible:
>>
>> - Support s390 jump instructions in perf annotate (Christian Borntraeger)
>>
>> - When failing to setup multiple events (e.g. '-e irq_vectors:*'), state
>> which one caused the failure (Yao Jin)
>>
>> - Various fixes for pipe mode, where the output of 'perf record' is
>> written to stdout instead of to a perf.data file, fixing workloads
>> such as: (David Carrillo-Cisneros)
>>
>> $ perf record -o - noploop | perf inject -b > perf.data
>>
>> $ perf record -o - noploop | perf annotate
>>
>> Infrastructure:
>>
>> - Simplify ltrim() implementation (Arnaldo Carvalho de Melo)
>>
>> - Use ltrim() and rtrim() in places where ad-hoc equivalents were being
>> used (Taeung Song)
>>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>>
>> ----------------------------------------------------------------
>> Arnaldo Carvalho de Melo (3):
>> perf callchains: Switch from strtok() to strtok_r() when parsing options
>> perf script: Use strtok_r() when parsing output field list
>> perf string: Simplify ltrim() implementation
>>
>> Christian Borntraeger (2):
>> perf annotate s390: Fix perf annotate error -95 (4.10 regression)
>> perf annotate s390: Implement jump types for perf annotate
>>
>> David Carrillo-Cisneros (6):
>> perf inject: Don't proceed if perf_session__process_event() fails
>> perf inject: Copy events when reordering events in pipe mode
>> perf tools: Describe pipe mode in perf.data-file-fomat.txt
>> perf annotate: Process attr and build_id records
>> perf session: Don't rely on evlist in pipe mode
>> perf tools: Do not print missing features in pipe-mode
>>
>> Jin Yao (1):
>> perf evsel: Return exact sub event which failed with EPERM for wildcards
>>
>> Taeung Song (6):
>> perf stat: Refactor the code to strip csv output with ltrim()
>> perf ui browser: Refactor the code to parse color configs with ltrim()
>> perf pmu: Refactor wordwrap() with ltrim()
>> perf tools: Refactor the code to strip command name with {l,r}trim()
>> perf annotate: Refactor the code to parse disassemble lines with {l,r}trim()
>> perf annotate: Use stripped line instead of raw disassemble line
>>
>> tools/perf/Documentation/perf.data-file-format.txt | 19 +++++++-
>> tools/perf/arch/s390/annotate/instructions.c | 30 ++++++++++++
>> tools/perf/builtin-annotate.c | 2 +
>> tools/perf/builtin-inject.c | 2 +
>> tools/perf/builtin-script.c | 4 +-
>> tools/perf/builtin-stat.c | 10 +---
>> tools/perf/ui/browser.c | 2 +-
>> tools/perf/util/annotate.c | 54 +++++++---------------
>> tools/perf/util/callchain.c | 4 +-
>> tools/perf/util/event.c | 11 +----
>> tools/perf/util/evsel.c | 8 +++-
>> tools/perf/util/header.c | 3 ++
>> tools/perf/util/ordered-events.c | 3 +-
>> tools/perf/util/pmu.c | 3 +-
>> tools/perf/util/session.c | 17 +++++--
>> tools/perf/util/string.c | 6 +--
>> 16 files changed, 105 insertions(+), 73 deletions(-)
>> create mode 100644 tools/perf/arch/s390/annotate/instructions.c
>
> Pulled, thanks a lot Arnaldo!
>
> Note, there was a conflict in tools/perf/util/annotate.c due to the s390 fix in
> perf/urgent. I've fixed it up, but please double check the conflict resolution I
> made in 43d5b075c400.
>
> Thanks,
>
> Ingo
>
The merge looks wrong:
dbdebdc53 (Ravi Bangoria 2016-11-23 21:33:46 +0530 133) },
3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 134) {
3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 135) .name = "s390",
d9f8dfa9b (Christian Borntraeger 2017-04-06 09:51:52 +0200 136) .init = s390__annotate_init,
e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 137) .objdump = {
e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 138) .comment_char = '#',
e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 139) },
e77852b32 (Christian Borntraeger 2017-04-06 09:51:51 +0200 140) },
43d5b075c (Ingo Molnar 2017-04-12 07:29:13 +0200 141) {
43d5b075c (Ingo Molnar 2017-04-12 07:29:13 +0200 142) .name = "s390",
3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 143) .objdump = {
3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 144) .comment_char = '#',
3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 145) },
3c1a42795 (Christian Borntraeger 2017-04-06 09:51:51 +0200 146) },
786c1b518 (Arnaldo Carvalho de Melo 2016-11-16 15:39:50 -0300 147) };
You can delete line 141-146
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2017-04-12 0:51 Arnaldo Carvalho de Melo
@ 2017-04-12 5:30 ` Ingo Molnar
2017-04-12 7:13 ` Christian Borntraeger
0 siblings, 1 reply; 50+ messages in thread
From: Ingo Molnar @ 2017-04-12 5:30 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Alexander Shishkin, Andi Kleen, Andreas Krebbel,
Andrew Vagin, Christian Borntraeger, David Ahern,
David Carrillo-Cisneros, Don Zickus, He Kuang, Hendrik Brueckner,
Jiri Olsa, Kan Liang, Martin Schwidefsky, Masami Hiramatsu,
Namhyung Kim, Paul Turner, Peter Zijlstra, Simon Que, stable, #,
v4.10+,
Stephane Eranian, Taeung Song, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 9df9078ef2086652647248ee6e82ca8f661cb3f5:
>
> perf/amd/uncore: Fix pr_fmt() prefix (2017-04-11 08:44:59 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170411
>
> for you to fetch changes up to 986a5bc028a84d487c354a529730b48682d1fb41:
>
> perf annotate: Use stripped line instead of raw disassemble line (2017-04-11 16:22:23 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Support s390 jump instructions in perf annotate (Christian Borntraeger)
>
> - When failing to setup multiple events (e.g. '-e irq_vectors:*'), state
> which one caused the failure (Yao Jin)
>
> - Various fixes for pipe mode, where the output of 'perf record' is
> written to stdout instead of to a perf.data file, fixing workloads
> such as: (David Carrillo-Cisneros)
>
> $ perf record -o - noploop | perf inject -b > perf.data
>
> $ perf record -o - noploop | perf annotate
>
> Infrastructure:
>
> - Simplify ltrim() implementation (Arnaldo Carvalho de Melo)
>
> - Use ltrim() and rtrim() in places where ad-hoc equivalents were being
> used (Taeung Song)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf callchains: Switch from strtok() to strtok_r() when parsing options
> perf script: Use strtok_r() when parsing output field list
> perf string: Simplify ltrim() implementation
>
> Christian Borntraeger (2):
> perf annotate s390: Fix perf annotate error -95 (4.10 regression)
> perf annotate s390: Implement jump types for perf annotate
>
> David Carrillo-Cisneros (6):
> perf inject: Don't proceed if perf_session__process_event() fails
> perf inject: Copy events when reordering events in pipe mode
> perf tools: Describe pipe mode in perf.data-file-fomat.txt
> perf annotate: Process attr and build_id records
> perf session: Don't rely on evlist in pipe mode
> perf tools: Do not print missing features in pipe-mode
>
> Jin Yao (1):
> perf evsel: Return exact sub event which failed with EPERM for wildcards
>
> Taeung Song (6):
> perf stat: Refactor the code to strip csv output with ltrim()
> perf ui browser: Refactor the code to parse color configs with ltrim()
> perf pmu: Refactor wordwrap() with ltrim()
> perf tools: Refactor the code to strip command name with {l,r}trim()
> perf annotate: Refactor the code to parse disassemble lines with {l,r}trim()
> perf annotate: Use stripped line instead of raw disassemble line
>
> tools/perf/Documentation/perf.data-file-format.txt | 19 +++++++-
> tools/perf/arch/s390/annotate/instructions.c | 30 ++++++++++++
> tools/perf/builtin-annotate.c | 2 +
> tools/perf/builtin-inject.c | 2 +
> tools/perf/builtin-script.c | 4 +-
> tools/perf/builtin-stat.c | 10 +---
> tools/perf/ui/browser.c | 2 +-
> tools/perf/util/annotate.c | 54 +++++++---------------
> tools/perf/util/callchain.c | 4 +-
> tools/perf/util/event.c | 11 +----
> tools/perf/util/evsel.c | 8 +++-
> tools/perf/util/header.c | 3 ++
> tools/perf/util/ordered-events.c | 3 +-
> tools/perf/util/pmu.c | 3 +-
> tools/perf/util/session.c | 17 +++++--
> tools/perf/util/string.c | 6 +--
> 16 files changed, 105 insertions(+), 73 deletions(-)
> create mode 100644 tools/perf/arch/s390/annotate/instructions.c
Pulled, thanks a lot Arnaldo!
Note, there was a conflict in tools/perf/util/annotate.c due to the s390 fix in
perf/urgent. I've fixed it up, but please double check the conflict resolution I
made in 43d5b075c400.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2017-04-12 0:51 Arnaldo Carvalho de Melo
2017-04-12 5:30 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-04-12 0:51 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Alexander Shishkin,
Andi Kleen, Andreas Krebbel, Andrew Vagin, Christian Borntraeger,
David Ahern, David Carrillo-Cisneros, Don Zickus, He Kuang,
Hendrik Brueckner, Jiri Olsa, Kan Liang, Martin Schwidefsky,
Masami Hiramatsu, Namhyung Kim, Paul Turner, Peter Zijlstra,
Simon Que, stable, #, v4.10+,
Stephane Eranian, Taeung Song, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 9df9078ef2086652647248ee6e82ca8f661cb3f5:
perf/amd/uncore: Fix pr_fmt() prefix (2017-04-11 08:44:59 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170411
for you to fetch changes up to 986a5bc028a84d487c354a529730b48682d1fb41:
perf annotate: Use stripped line instead of raw disassemble line (2017-04-11 16:22:23 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Support s390 jump instructions in perf annotate (Christian Borntraeger)
- When failing to setup multiple events (e.g. '-e irq_vectors:*'), state
which one caused the failure (Yao Jin)
- Various fixes for pipe mode, where the output of 'perf record' is
written to stdout instead of to a perf.data file, fixing workloads
such as: (David Carrillo-Cisneros)
$ perf record -o - noploop | perf inject -b > perf.data
$ perf record -o - noploop | perf annotate
Infrastructure:
- Simplify ltrim() implementation (Arnaldo Carvalho de Melo)
- Use ltrim() and rtrim() in places where ad-hoc equivalents were being
used (Taeung Song)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf callchains: Switch from strtok() to strtok_r() when parsing options
perf script: Use strtok_r() when parsing output field list
perf string: Simplify ltrim() implementation
Christian Borntraeger (2):
perf annotate s390: Fix perf annotate error -95 (4.10 regression)
perf annotate s390: Implement jump types for perf annotate
David Carrillo-Cisneros (6):
perf inject: Don't proceed if perf_session__process_event() fails
perf inject: Copy events when reordering events in pipe mode
perf tools: Describe pipe mode in perf.data-file-fomat.txt
perf annotate: Process attr and build_id records
perf session: Don't rely on evlist in pipe mode
perf tools: Do not print missing features in pipe-mode
Jin Yao (1):
perf evsel: Return exact sub event which failed with EPERM for wildcards
Taeung Song (6):
perf stat: Refactor the code to strip csv output with ltrim()
perf ui browser: Refactor the code to parse color configs with ltrim()
perf pmu: Refactor wordwrap() with ltrim()
perf tools: Refactor the code to strip command name with {l,r}trim()
perf annotate: Refactor the code to parse disassemble lines with {l,r}trim()
perf annotate: Use stripped line instead of raw disassemble line
tools/perf/Documentation/perf.data-file-format.txt | 19 +++++++-
tools/perf/arch/s390/annotate/instructions.c | 30 ++++++++++++
tools/perf/builtin-annotate.c | 2 +
tools/perf/builtin-inject.c | 2 +
tools/perf/builtin-script.c | 4 +-
tools/perf/builtin-stat.c | 10 +---
tools/perf/ui/browser.c | 2 +-
tools/perf/util/annotate.c | 54 +++++++---------------
tools/perf/util/callchain.c | 4 +-
tools/perf/util/event.c | 11 +----
tools/perf/util/evsel.c | 8 +++-
tools/perf/util/header.c | 3 ++
tools/perf/util/ordered-events.c | 3 +-
tools/perf/util/pmu.c | 3 +-
tools/perf/util/session.c | 17 +++++--
tools/perf/util/string.c | 6 +--
16 files changed, 105 insertions(+), 73 deletions(-)
create mode 100644 tools/perf/arch/s390/annotate/instructions.c
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
For this specific pull request the samples/bpf/ was disabled, as 'make headers_install'
is failing with the following error, in this case in fedora:rawhide:
INSTALL usr/include/uapi/ (0 file)
/git/linux/scripts/Makefile.headersinst:62: *** Missing generated UAPI file ./arch/x86/include/generated/uapi/asm/unistd_32.h. Stop.
make[1]: *** [/git/linux/Makefile:1151: headers_install] Error 2
make[1]: Leaving directory '/tmp/build/linux'
make: *** [Makefile:152: sub-make] Error 2
make: Leaving directory '/git/linux'
I'll investigate later, perf and objtool builds just fine, with clang and gcc.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:edge: Ok
4 android-ndk:r12b-arm: Ok
5 archlinux:latest: Ok
6 centos:5: Ok
7 centos:6: Ok
8 centos:7: Ok
9 debian:7: Ok
10 debian:8: Ok
11 debian:9: Ok
12 debian:experimental: Ok
13 debian:experimental-x-arm64: Ok
14 debian:experimental-x-mips: Ok
15 debian:experimental-x-mips64: Ok
16 debian:experimental-x-mipsel: Ok
17 fedora:20: Ok
18 fedora:21: Ok
19 fedora:22: Ok
20 fedora:23: Ok
21 fedora:24: Ok
22 fedora:24-x-ARC-uClibc: Ok
23 fedora:25: Ok
24 fedora:rawhide: Ok
25 mageia:5: Ok
26 opensuse:13.2: Ok
27 opensuse:42.1: Ok
28 opensuse:tumbleweed: Ok
29 ubuntu:12.04.5: Ok
30 ubuntu:14.04.4: Ok
31 ubuntu:14.04.4-x-linaro-arm64: Ok
32 ubuntu:15.10: Ok
33 ubuntu:16.04: Ok
34 ubuntu:16.04-x-arm: Ok
35 ubuntu:16.04-x-arm64: Ok
36 ubuntu:16.04-x-powerpc: Ok
37 ubuntu:16.04-x-powerpc64: Ok
38 ubuntu:16.04-x-s390: Ok
39 ubuntu:16.10: Ok
40 ubuntu:17.04: Ok
#
# uname -a
Linux jouet 4.11.0-rc6+ #7 SMP Tue Apr 11 11:53:14 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking: Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation: Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Ok
38.2: BPF pinning : Ok
38.3: BPF prologue generation : Ok
38.4: BPF relocation checker : Ok
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : Ok
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_auxtrace_O: make NO_AUXTRACE=1
make_install_bin_O: make install-bin
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_no_libperl_O: make NO_LIBPERL=1
make_no_libelf_O: make NO_LIBELF=1
make_no_gtk2_O: make NO_GTK2=1
make_no_newt_O: make NO_NEWT=1
make_debug_O: make DEBUG=1
make_no_libbpf_O: make NO_LIBBPF=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_help_O: make help
make_clean_all_O: make clean all
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_perf_o_O: make perf.o
make_tags_O: make tags
make_util_map_o_O: make util/map.o
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_slang_O: make NO_SLANG=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_pure_O: make
make_install_O: make install
make_no_libbionic_O: make NO_LIBBIONIC=1
make_static_O: make LDFLAGS=-static
make_doc_O: make doc
make_no_demangle_O: make NO_DEMANGLE=1
make_install_prefix_O: make install prefix=/tmp/krava
make_no_libaudit_O: make NO_LIBAUDIT=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2017-02-20 19:08 Arnaldo Carvalho de Melo
@ 2017-02-21 8:08 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2017-02-21 8:08 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Borislav Petkov, David Ahern,
Jan Stancek, Jiri Olsa, kernel-team, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, Steven Rostedt, Wang Nan
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 0c8967c9df230d2c4dde6649f410b62e01806c22:
>
> Merge tag 'perf-core-for-mingo-4.11-20170215' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-02-16 20:53:13 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.11-20170220
>
> for you to fetch changes up to 68ba32352d51474d163d58e084b62a12bb610b21:
>
> perf record: Honor --quiet option properly (2017-02-20 11:50:36 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Make -a/--all-cpus be the default target in 'perf record' and 'perf stat',
> just like it is with 'perf trace' (Jiri Olsa)
>
> - Introduce -q/--quiet to the 'annotate', 'diff' and 'report', fix up
> its behaviour in 'record'. This makes the output more compact by
> elliminating headers, leaving just the histogram lines (Namhyung Kim)
>
> Fixes:
>
> - Handle offline/absent CPUs (Jan Stancek)
>
> Infrastructure:
>
> - Filter out -specs=/a/b/c from CC options when building the python
> support, allowing that feature to be built with clang (Arnaldo Carvalho de Melo)
>
> - Fix DEBUG=1 build with clang (Arnaldo Carvalho de Melo)
>
> Trivial:
>
> - Fix spelling of 'preempt' in a libtraceevent function name (Steven Rostedt)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> tools perf scripting python: clang doesn't have -spec, remove it
> perf python: Filter out -specs=/a/b/c from the python binding cc options
> perf session: Fix DEBUG=1 build with clang
>
> Jan Stancek (3):
> perf cpumap: Add cpu__max_present_cpu()
> perf header: Make build_cpu_topology skip offline/absent CPUs
> perf tools: Replace _SC_NPROCESSORS_CONF with max_present_cpu in cpu_topology_map
>
> Jiri Olsa (5):
> perf build: Add special fixdep cleaning rule
> perf tools: Move new_term arguments into struct parse_events_term template
> perf tools: Fail on using multiple bits long terms without value
> perf stat: Add -a as default target
> perf record: Add -a as default target
>
> Namhyung Kim (6):
> perf utils: Add perf_quiet_option()
> perf utils: Check verbose flag properly
> perf report: Add -q/--quiet option
> perf diff: Add -q/--quiet option
> perf annotate: Add -q/--quiet option
> perf record: Honor --quiet option properly
>
> Steven Rostedt (VMware) (1):
> tools lib traceevent: It's preempt not prempt
>
> tools/build/Makefile | 4 +-
> tools/build/Makefile.include | 3 +
> tools/lib/traceevent/event-parse.c | 4 +-
> tools/lib/traceevent/event-parse.h | 2 +-
> tools/perf/Documentation/perf-annotate.txt | 4 ++
> tools/perf/Documentation/perf-diff.txt | 4 ++
> tools/perf/Documentation/perf-record.txt | 2 +-
> tools/perf/Documentation/perf-report.txt | 4 ++
> tools/perf/Documentation/perf-stat.txt | 2 +-
> tools/perf/Makefile.config | 7 +++
> tools/perf/Makefile.perf | 4 +-
> tools/perf/builtin-annotate.c | 4 ++
> tools/perf/builtin-diff.c | 14 +++--
> tools/perf/builtin-mem.c | 4 +-
> tools/perf/builtin-record.c | 8 ++-
> tools/perf/builtin-report.c | 21 +++++--
> tools/perf/builtin-sched.c | 12 ++--
> tools/perf/builtin-stat.c | 11 ++--
> tools/perf/builtin-top.c | 2 +-
> tools/perf/builtin-trace.c | 6 +-
> tools/perf/pmu-events/json.c | 2 +-
> tools/perf/tests/attr.c | 2 +-
> tools/perf/tests/builtin-test.c | 2 +-
> tools/perf/tests/code-reading.c | 2 +-
> tools/perf/tests/fdarray.c | 2 +-
> tools/perf/tests/llvm.c | 2 +-
> tools/perf/tests/parse-events.c | 2 +-
> tools/perf/tests/perf-record.c | 4 +-
> tools/perf/tests/python-use.c | 2 +-
> tools/perf/tests/thread-map.c | 6 +-
> tools/perf/tests/topology.c | 4 +-
> tools/perf/tests/vmlinux-kallsyms.c | 2 +-
> tools/perf/ui/browsers/map.c | 6 +-
> tools/perf/ui/hist.c | 2 +-
> tools/perf/util/annotate.c | 2 +-
> tools/perf/util/cpumap.c | 22 +++++++
> tools/perf/util/cpumap.h | 1 +
> tools/perf/util/debug.c | 17 ++++++
> tools/perf/util/debug.h | 1 +
> tools/perf/util/dso.c | 2 +-
> tools/perf/util/env.c | 2 +-
> tools/perf/util/header.c | 33 ++++++----
> tools/perf/util/hist.c | 6 +-
> tools/perf/util/parse-events.c | 71 +++++++++++++---------
> tools/perf/util/parse-events.h | 2 +
> tools/perf/util/parse-events.y | 14 ++---
> tools/perf/util/pmu.c | 21 +++++--
> tools/perf/util/probe-event.c | 2 +-
> .../util/scripting-engines/trace-event-python.c | 4 +-
> tools/perf/util/session.c | 2 +-
> tools/perf/util/setup.py | 9 ++-
> tools/perf/util/sort.c | 8 +--
> tools/perf/util/stat.c | 2 +-
> tools/perf/util/symbol-elf.c | 2 +-
> 54 files changed, 256 insertions(+), 129 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2017-02-20 19:08 Arnaldo Carvalho de Melo
2017-02-21 8:08 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-02-20 19:08 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Borislav Petkov, David Ahern,
Jan Stancek, Jiri Olsa, kernel-team, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, Steven Rostedt, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 0c8967c9df230d2c4dde6649f410b62e01806c22:
Merge tag 'perf-core-for-mingo-4.11-20170215' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-02-16 20:53:13 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.11-20170220
for you to fetch changes up to 68ba32352d51474d163d58e084b62a12bb610b21:
perf record: Honor --quiet option properly (2017-02-20 11:50:36 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Make -a/--all-cpus be the default target in 'perf record' and 'perf stat',
just like it is with 'perf trace' (Jiri Olsa)
- Introduce -q/--quiet to the 'annotate', 'diff' and 'report', fix up
its behaviour in 'record'. This makes the output more compact by
elliminating headers, leaving just the histogram lines (Namhyung Kim)
Fixes:
- Handle offline/absent CPUs (Jan Stancek)
Infrastructure:
- Filter out -specs=/a/b/c from CC options when building the python
support, allowing that feature to be built with clang (Arnaldo Carvalho de Melo)
- Fix DEBUG=1 build with clang (Arnaldo Carvalho de Melo)
Trivial:
- Fix spelling of 'preempt' in a libtraceevent function name (Steven Rostedt)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
tools perf scripting python: clang doesn't have -spec, remove it
perf python: Filter out -specs=/a/b/c from the python binding cc options
perf session: Fix DEBUG=1 build with clang
Jan Stancek (3):
perf cpumap: Add cpu__max_present_cpu()
perf header: Make build_cpu_topology skip offline/absent CPUs
perf tools: Replace _SC_NPROCESSORS_CONF with max_present_cpu in cpu_topology_map
Jiri Olsa (5):
perf build: Add special fixdep cleaning rule
perf tools: Move new_term arguments into struct parse_events_term template
perf tools: Fail on using multiple bits long terms without value
perf stat: Add -a as default target
perf record: Add -a as default target
Namhyung Kim (6):
perf utils: Add perf_quiet_option()
perf utils: Check verbose flag properly
perf report: Add -q/--quiet option
perf diff: Add -q/--quiet option
perf annotate: Add -q/--quiet option
perf record: Honor --quiet option properly
Steven Rostedt (VMware) (1):
tools lib traceevent: It's preempt not prempt
tools/build/Makefile | 4 +-
tools/build/Makefile.include | 3 +
tools/lib/traceevent/event-parse.c | 4 +-
tools/lib/traceevent/event-parse.h | 2 +-
tools/perf/Documentation/perf-annotate.txt | 4 ++
tools/perf/Documentation/perf-diff.txt | 4 ++
tools/perf/Documentation/perf-record.txt | 2 +-
tools/perf/Documentation/perf-report.txt | 4 ++
tools/perf/Documentation/perf-stat.txt | 2 +-
tools/perf/Makefile.config | 7 +++
tools/perf/Makefile.perf | 4 +-
tools/perf/builtin-annotate.c | 4 ++
tools/perf/builtin-diff.c | 14 +++--
tools/perf/builtin-mem.c | 4 +-
tools/perf/builtin-record.c | 8 ++-
tools/perf/builtin-report.c | 21 +++++--
tools/perf/builtin-sched.c | 12 ++--
tools/perf/builtin-stat.c | 11 ++--
tools/perf/builtin-top.c | 2 +-
tools/perf/builtin-trace.c | 6 +-
tools/perf/pmu-events/json.c | 2 +-
tools/perf/tests/attr.c | 2 +-
tools/perf/tests/builtin-test.c | 2 +-
tools/perf/tests/code-reading.c | 2 +-
tools/perf/tests/fdarray.c | 2 +-
tools/perf/tests/llvm.c | 2 +-
tools/perf/tests/parse-events.c | 2 +-
tools/perf/tests/perf-record.c | 4 +-
tools/perf/tests/python-use.c | 2 +-
tools/perf/tests/thread-map.c | 6 +-
tools/perf/tests/topology.c | 4 +-
tools/perf/tests/vmlinux-kallsyms.c | 2 +-
tools/perf/ui/browsers/map.c | 6 +-
tools/perf/ui/hist.c | 2 +-
tools/perf/util/annotate.c | 2 +-
tools/perf/util/cpumap.c | 22 +++++++
tools/perf/util/cpumap.h | 1 +
tools/perf/util/debug.c | 17 ++++++
tools/perf/util/debug.h | 1 +
tools/perf/util/dso.c | 2 +-
tools/perf/util/env.c | 2 +-
tools/perf/util/header.c | 33 ++++++----
tools/perf/util/hist.c | 6 +-
tools/perf/util/parse-events.c | 71 +++++++++++++---------
tools/perf/util/parse-events.h | 2 +
tools/perf/util/parse-events.y | 14 ++---
tools/perf/util/pmu.c | 21 +++++--
tools/perf/util/probe-event.c | 2 +-
.../util/scripting-engines/trace-event-python.c | 4 +-
tools/perf/util/session.c | 2 +-
tools/perf/util/setup.py | 9 ++-
tools/perf/util/sort.c | 8 +--
tools/perf/util/stat.c | 2 +-
tools/perf/util/symbol-elf.c | 2 +-
54 files changed, 256 insertions(+), 129 deletions(-)
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 debian:experimental-x-arm64: Ok
11 debian:experimental-x-mips: Ok
12 debian:experimental-x-mips64: Ok
13 debian:experimental-x-mipsel: Ok
14 fedora:20: Ok
15 fedora:21: Ok
16 fedora:22: Ok
17 fedora:23: Ok
18 fedora:24: Ok
19 fedora:24-x-ARC-uClibc: Ok
20 fedora:25: Ok
21 fedora:rawhide: Ok
22 mageia:5: Ok
23 opensuse:13.2: Ok
24 opensuse:42.1: Ok
25 opensuse:tumbleweed: Ok
26 ubuntu:12.04.5: Ok
27 ubuntu:14.04.4-x-linaro-arm64: Ok
28 ubuntu:15.10: Ok
29 ubuntu:16.04: Ok
30 ubuntu:16.04-x-arm: Ok
31 ubuntu:16.04-x-arm64: Ok
32 ubuntu:16.04-x-powerpc: Ok
33 ubuntu:16.04-x-powerpc64: Ok
34 ubuntu:16.04-x-powerpc64el: Ok
35 ubuntu:16.04-x-s390: Ok
36 ubuntu:16.10: Ok
#
# uname -a
Linux jouet 4.10.0-rc8 #2 SMP Wed Feb 15 15:26:36 BRT 2017 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: PERF_RECORD_* events & perf_sample fields : Ok
7: Parse perf pmu format : Ok
8: DSO data read : Ok
9: DSO data cache : Ok
10: DSO data reopen : Ok
11: Roundtrip evsel->name : Ok
12: Parse sched tracepoints fields : Ok
13: syscalls:sys_enter_openat event fields : Ok
14: Setup struct perf_event_attr : Ok
15: Match and link multiple hists : Ok
16: 'import perf' in python : Ok
17: Breakpoint overflow signal handler : Ok
18: Breakpoint overflow sampling : Ok
19: Number of exit events of a simple workload : Ok
20: Software clock events period values : Ok
21: Object code reading : Ok
22: Sample parsing : Ok
23: Use a dummy software event to keep tracking: Ok
24: Parse with no sample_id_all bit set : Ok
25: Filter hist entries : Ok
26: Lookup mmap thread : Ok
27: Share thread mg : Ok
28: Sort output of hist entries : Ok
29: Cumulate child hist entries : Ok
30: Track with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: kmod_path__parse : Ok
34: Thread map : Ok
35: LLVM search and compile :
35.1: Basic BPF llvm compile : Ok
35.2: kbuild searching : Ok
35.3: Compile source for BPF prologue generation: Ok
35.4: Compile source for BPF relocation : Ok
36: Session topology : Ok
37: BPF filter :
37.1: Basic BPF filtering : Ok
37.2: BPF pinning : Ok
37.3: BPF prologue generation : Ok
37.4: BPF relocation checker : Ok
38: Synthesize thread map : Ok
39: Remove thread map : Ok
40: Synthesize cpu map : Ok
41: Synthesize stat config : Ok
42: Synthesize stat : Ok
43: Synthesize stat round : Ok
44: Synthesize attr update : Ok
45: Event times : Ok
46: Read backward ring buffer : Ok
47: Print cpu map : Ok
48: Probe SDT events : Ok
49: is_printable_array : Ok
50: Print bitmap : Ok
51: perf hooks : Ok
52: builtin clang support : Skip (not compiled in)
53: unit_number__scnprintf : Ok
54: x86 rdpmc : Ok
55: Convert perf time to TSC : Ok
56: DWARF unwind : Ok
57: x86 instruction decoder - new instructions : Ok
58: Intel cqm nmi context read : Skip
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_tags_O: make tags
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_clean_all_O: make clean all
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libpython_O: make NO_LIBPYTHON=1
make_install_bin_O: make install-bin
make_no_newt_O: make NO_NEWT=1
make_no_slang_O: make NO_SLANG=1
make_doc_O: make doc
make_no_libbpf_O: make NO_LIBBPF=1
make_perf_o_O: make perf.o
make_install_prefix_O: make install prefix=/tmp/krava
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_help_O: make help
make_pure_O: make
make_no_libelf_O: make NO_LIBELF=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_debug_O: make DEBUG=1
make_install_O: make install
make_no_libbionic_O: make NO_LIBBIONIC=1
make_static_O: make LDFLAGS=-static
make_util_map_o_O: make util/map.o
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_gtk2_O: make NO_GTK2=1
make_no_demangle_O: make NO_DEMANGLE=1
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2016-11-23 16:40 Arnaldo Carvalho de Melo
@ 2016-11-24 4:10 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2016-11-24 4:10 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Andrew Morton, Chris Riyder,
David Ahern, Don Zickus, Jiri Olsa, Joe Mario, Kim Phillips,
Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim,
Naveen N . Rao, Pawel Moll, Peter Zijlstra, Ravi Bangoria,
Russell King, Stephane Eranian, Steven Rostedt, Taeung Song,
Wang Nan
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end.
>
> The following changes since commit 6a6b12e2125591e24891e6860410795ea53aed11:
>
> Merge tag 'perf-core-for-mingo-20161114' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-15 09:45:04 +0100)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161123
>
> for you to fetch changes up to a407b0678bc1c39d70af5fdbe6421c164b69a8c0:
>
> perf sched timehist: Add -V/--cpu-visual option (2016-11-23 10:44:09 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New tool:
>
> - 'perf sched timehist' provides an analysis of scheduling events.
>
> Example usage:
> perf sched record -- sleep 1
> perf sched timehist
>
> By default it shows the individual schedule events, including the wait
> time (time between sched-out and next sched-in events for the task), the
> task scheduling delay (time between wakeup and actually running) and run
> time for the task:
>
> time cpu task name wait time sch delay run time
> [tid/pid] (msec) (msec) (msec)
> -------- ------ ---------------- --------- --------- --------
> 1.874569 [0011] gcc[31949] 0.014 0.000 1.148
> 1.874591 [0010] gcc[31951] 0.000 0.000 0.024
> 1.874603 [0010] migration/10[59] 3.350 0.004 0.011
> 1.874604 [0011] <idle> 1.148 0.000 0.035
> 1.874723 [0005] <idle> 0.016 0.000 1.383
> 1.874746 [0005] gcc[31949] 0.153 0.078 0.022
> ...
>
> Times are in msec.usec. (David Ahern, Namhyung Kim)
>
> Improvements:
>
> - Make 'perf c2c report' support -f/--force, to allow skipping the
> ownership check for root users, for instance, just like the other
> tools (Jiri Olsa)
>
> - Allow sorting cachelines by total number of HITMs, in addition to
> local and remote numbers (Jiri Olsa)
>
> Fixes:
>
> - Make sure errors aren't suppressed by the TUI reset at the end of
> a 'perf c2c report' session (Jiri Olsa)
>
> Infrastructure:
>
> - Initial work on having the annotate code better support multiple
> architectures, including the ability to cross-annotate, i.e. to
> annotate perf.data files collected on an ARM system on a x86_64
> workstation (Arnaldo Carvalho de Melo, Ravi Bangoria, Kim Phillips)
>
> - Use USECS_PER_SEC instead of hard coded number in libtraceevent (Steven Rostedt)
>
> - Add retrieval of preempt count and latency flags in libtraceevent (Steven Rostedt)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (3):
> perf annotate: Start supporting cross arch annotation
> perf annotate: Allow arches to specify functions to skip
> perf annotate: Add per arch instructions annotate handlers
>
> David Ahern (5):
> perf sched timehist: Introduce timehist command
> perf sched timehist: Add summary options
> perf sched timehist: Add -w/--wakeups option
> perf sched timehist: Add call graph options
> perf sched timehist: Add -V/--cpu-visual option
>
> Jiri Olsa (6):
> perf tools: Show event fd in debug output
> perf c2c report: Setup browser after opening perf.data
> perf c2c report: Add -f/--force option
> perf c2c report: Add struct c2c_stats::tot_hitm field
> perf c2c report: Display total HITMs on default
> perf c2c: Support cascading options
>
> Namhyung Kim (2):
> perf symbols: Print symbol offsets conditionally
> perf evsel: Support printing callchains with arrows
>
> Steven Rostedt (2):
> tools lib traceevent: Use USECS_PER_SEC instead of hardcoded number
> tools lib traceevent: Add retrieval of preempt count and latency flags
>
> tools/lib/traceevent/event-parse.c | 41 +-
> tools/lib/traceevent/event-parse.h | 5 +-
> tools/perf/Documentation/perf-c2c.txt | 8 +
> tools/perf/Documentation/perf-sched.txt | 66 +-
> tools/perf/arch/arm/annotate/instructions.c | 90 +++
> tools/perf/arch/x86/annotate/instructions.c | 78 +++
> tools/perf/builtin-c2c.c | 80 ++-
> tools/perf/builtin-sched.c | 914 +++++++++++++++++++++++++++-
> tools/perf/builtin-top.c | 2 +-
> tools/perf/ui/browsers/annotate.c | 2 +-
> tools/perf/ui/gtk/annotate.c | 2 +-
> tools/perf/util/annotate.c | 251 ++++----
> tools/perf/util/annotate.h | 6 +-
> tools/perf/util/evsel.c | 6 +-
> tools/perf/util/evsel.h | 1 +
> tools/perf/util/evsel_fprintf.c | 12 +-
> tools/perf/util/mem-events.c | 12 +-
> tools/perf/util/mem-events.h | 1 +
> tools/perf/util/symbol.h | 3 +-
> tools/perf/util/symbol_fprintf.c | 11 +-
> 20 files changed, 1406 insertions(+), 185 deletions(-)
> create mode 100644 tools/perf/arch/arm/annotate/instructions.c
> create mode 100644 tools/perf/arch/x86/annotate/instructions.c
>
> # uname -a
> Linux jouet 4.8.6-201.fc24.x86_64 #1 SMP Thu Nov 3 14:38:57 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
> # perf test
> 1: vmlinux symtab matches kallsyms : Ok
> 2: detect openat syscall event : Ok
> 3: detect openat syscall event on all cpus : Ok
> 4: read samples using the mmap interface : Ok
> 5: parse events tests : Ok
> 6: Validate PERF_RECORD_* events & perf_sample fields : Ok
> 7: Test perf pmu format parsing : Ok
> 8: Test dso data read : Ok
> 9: Test dso data cache : Ok
> 10: Test dso data reopen : Ok
> 11: roundtrip evsel->name check : Ok
> 12: Check parsing of sched tracepoints fields : Ok
> 13: Generate and check syscalls:sys_enter_openat event fields: Ok
> 14: struct perf_event_attr setup : Ok
> 15: Test matching and linking multiple hists : Ok
> 16: Try 'import perf' in python, checking link problems : Ok
> 17: Test breakpoint overflow signal handler : Ok
> 18: Test breakpoint overflow sampling : Ok
> 19: Test number of exit event of a simple workload : Ok
> 20: Test software clock events have valid period values : Ok
> 21: Test object code reading : Ok
> 22: Test sample parsing : Ok
> 23: Test using a dummy software event to keep tracking : Ok
> 24: Test parsing with no sample_id_all bit set : Ok
> 25: Test filtering hist entries : Ok
> 26: Test mmap thread lookup : Ok
> 27: Test thread mg sharing : Ok
> 28: Test output sorting of hist entries : Ok
> 29: Test cumulation of child hist entries : Ok
> 30: Test tracking with sched_switch : Ok
> 31: Filter fds with revents mask in a fdarray : Ok
> 32: Add fd to a fdarray, making it autogrow : Ok
> 33: Test kmod_path__parse function : Ok
> 34: Test thread map : Ok
> 35: Test LLVM searching and compiling :
> 35.1: Basic BPF llvm compiling test : Ok
> 35.2: Test kbuild searching : Ok
> 35.3: Compile source for BPF prologue generation test : Ok
> 35.4: Compile source for BPF relocation test : Ok
> 36: Test topology in session : Ok
> 37: Test BPF filter :
> 37.1: Test basic BPF filtering : Ok
> 37.2: Test BPF prologue generation : Ok
> 37.3: Test BPF relocation checker : Ok
> 38: Test thread map synthesize : Ok
> 39: Test cpu map synthesize : Ok
> 40: Test stat config synthesize : Ok
> 41: Test stat synthesize : Ok
> 42: Test stat round synthesize : Ok
> 43: Test attr update synthesize : Ok
> 44: Test events times : Ok
> 45: Test backward reading from ring buffer : Ok
> 46: Test cpu map print : Ok
> 47: Test SDT event probing : Ok
> 48: Test is_printable_array function : Ok
> 49: Test bitmap print : Ok
> 50: x86 rdpmc test : Ok
> 51: Test converting perf time to TSC : Ok
> 52: Test dwarf unwind : Ok
> 53: Test x86 instruction decoder - new instructions : Ok
> 54: Test intel cqm nmi context read : Skip
> #
>
> # dm
> 1 alpine:3.4: Ok
> 2 android-ndk:r12b-arm: Ok
> 3 archlinux:latest: Ok
> 4 centos:5: Ok
> 5 centos:6: Ok
> 6 centos:7: Ok
> 7 debian:7: Ok
> 8 debian:8: Ok
> 9 debian:experimental: Ok
> 10 fedora:20: Ok
> 11 fedora:21: Ok
> 12 fedora:22: Ok
> 13 fedora:23: Ok
> 14 fedora:24: Ok
> 15 fedora:24-x-ARC-uClibc: Ok
> 16 fedora:rawhide: Ok
> 17 mageia:5: Ok
> 18 opensuse:13.2: Ok
> 19 opensuse:42.1: Ok
> 20 opensuse:tumbleweed: Ok
> 21 ubuntu:12.04.5: Ok
> 22 ubuntu:14.04: Ok
> 23 ubuntu:14.04.4: Ok
> 24 ubuntu:15.10: Ok
> 25 ubuntu:16.04: Ok
> 26 ubuntu:16.04-x-arm: Ok
> 27 ubuntu:16.04-x-arm64: Ok
> 28 ubuntu:16.04-x-powerpc: Ok
> 29 ubuntu:16.04-x-powerpc64: Ok
> 30 ubuntu:16.04-x-powerpc64el: Ok
> 31 ubuntu:16.04-x-s390: Ok
> 32 ubuntu:16.10: Ok
> #
>
> $ make -C tools/perf build-test
> make: Entering directory '/home/acme/git/linux/tools/perf'
> - tarpkg: ./tests/perf-targz-src-pkg .
> make_no_libperl_O: make NO_LIBPERL=1
> make_no_demangle_O: make NO_DEMANGLE=1
> make_no_libnuma_O: make NO_LIBNUMA=1
> make_install_bin_O: make install-bin
> make_install_prefix_O: make install prefix=/tmp/krava
> make_util_map_o_O: make util/map.o
> make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
> make_no_libbpf_O: make NO_LIBBPF=1
> make_doc_O: make doc
> make_util_pmu_bison_o_O: make util/pmu-bison.o
> make_with_babeltrace_O: make LIBBABELTRACE=1
> make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
> make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
> make_debug_O: make DEBUG=1
> make_perf_o_O: make perf.o
> make_no_slang_O: make NO_SLANG=1
> make_no_newt_O: make NO_NEWT=1
> make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
> make_install_O: make install
> make_no_auxtrace_O: make NO_AUXTRACE=1
> make_no_backtrace_O: make NO_BACKTRACE=1
> make_install_prefix_slash_O: make install prefix=/tmp/krava/
> make_clean_all_O: make clean all
> make_no_libpython_O: make NO_LIBPYTHON=1
> make_no_libaudit_O: make NO_LIBAUDIT=1
> make_no_libbionic_O: make NO_LIBBIONIC=1
> make_help_O: make help
> make_no_libelf_O: make NO_LIBELF=1
> make_tags_O: make tags
> make_no_libunwind_O: make NO_LIBUNWIND=1
> make_no_gtk2_O: make NO_GTK2=1
> make_pure_O: make
> make_static_O: make LDFLAGS=-static
> OK
> make: Leaving directory '/home/acme/git/linux/tools/perf'
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2016-11-23 16:40 Arnaldo Carvalho de Melo
2016-11-24 4:10 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-11-23 16:40 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Andi Kleen, Andrew Morton, Chris Riyder,
David Ahern, Don Zickus, Jiri Olsa, Joe Mario, Kim Phillips,
Markus Trippelsdorf, Masami Hiramatsu, Namhyung Kim,
Naveen N . Rao, Pawel Moll, Peter Zijlstra, Ravi Bangoria,
Russell King, Stephane Eranian, Steven Rostedt, Taeung Song,
Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end.
The following changes since commit 6a6b12e2125591e24891e6860410795ea53aed11:
Merge tag 'perf-core-for-mingo-20161114' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-15 09:45:04 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161123
for you to fetch changes up to a407b0678bc1c39d70af5fdbe6421c164b69a8c0:
perf sched timehist: Add -V/--cpu-visual option (2016-11-23 10:44:09 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New tool:
- 'perf sched timehist' provides an analysis of scheduling events.
Example usage:
perf sched record -- sleep 1
perf sched timehist
By default it shows the individual schedule events, including the wait
time (time between sched-out and next sched-in events for the task), the
task scheduling delay (time between wakeup and actually running) and run
time for the task:
time cpu task name wait time sch delay run time
[tid/pid] (msec) (msec) (msec)
-------- ------ ---------------- --------- --------- --------
1.874569 [0011] gcc[31949] 0.014 0.000 1.148
1.874591 [0010] gcc[31951] 0.000 0.000 0.024
1.874603 [0010] migration/10[59] 3.350 0.004 0.011
1.874604 [0011] <idle> 1.148 0.000 0.035
1.874723 [0005] <idle> 0.016 0.000 1.383
1.874746 [0005] gcc[31949] 0.153 0.078 0.022
...
Times are in msec.usec. (David Ahern, Namhyung Kim)
Improvements:
- Make 'perf c2c report' support -f/--force, to allow skipping the
ownership check for root users, for instance, just like the other
tools (Jiri Olsa)
- Allow sorting cachelines by total number of HITMs, in addition to
local and remote numbers (Jiri Olsa)
Fixes:
- Make sure errors aren't suppressed by the TUI reset at the end of
a 'perf c2c report' session (Jiri Olsa)
Infrastructure:
- Initial work on having the annotate code better support multiple
architectures, including the ability to cross-annotate, i.e. to
annotate perf.data files collected on an ARM system on a x86_64
workstation (Arnaldo Carvalho de Melo, Ravi Bangoria, Kim Phillips)
- Use USECS_PER_SEC instead of hard coded number in libtraceevent (Steven Rostedt)
- Add retrieval of preempt count and latency flags in libtraceevent (Steven Rostedt)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (3):
perf annotate: Start supporting cross arch annotation
perf annotate: Allow arches to specify functions to skip
perf annotate: Add per arch instructions annotate handlers
David Ahern (5):
perf sched timehist: Introduce timehist command
perf sched timehist: Add summary options
perf sched timehist: Add -w/--wakeups option
perf sched timehist: Add call graph options
perf sched timehist: Add -V/--cpu-visual option
Jiri Olsa (6):
perf tools: Show event fd in debug output
perf c2c report: Setup browser after opening perf.data
perf c2c report: Add -f/--force option
perf c2c report: Add struct c2c_stats::tot_hitm field
perf c2c report: Display total HITMs on default
perf c2c: Support cascading options
Namhyung Kim (2):
perf symbols: Print symbol offsets conditionally
perf evsel: Support printing callchains with arrows
Steven Rostedt (2):
tools lib traceevent: Use USECS_PER_SEC instead of hardcoded number
tools lib traceevent: Add retrieval of preempt count and latency flags
tools/lib/traceevent/event-parse.c | 41 +-
tools/lib/traceevent/event-parse.h | 5 +-
tools/perf/Documentation/perf-c2c.txt | 8 +
tools/perf/Documentation/perf-sched.txt | 66 +-
tools/perf/arch/arm/annotate/instructions.c | 90 +++
tools/perf/arch/x86/annotate/instructions.c | 78 +++
tools/perf/builtin-c2c.c | 80 ++-
tools/perf/builtin-sched.c | 914 +++++++++++++++++++++++++++-
tools/perf/builtin-top.c | 2 +-
tools/perf/ui/browsers/annotate.c | 2 +-
tools/perf/ui/gtk/annotate.c | 2 +-
tools/perf/util/annotate.c | 251 ++++----
tools/perf/util/annotate.h | 6 +-
tools/perf/util/evsel.c | 6 +-
tools/perf/util/evsel.h | 1 +
tools/perf/util/evsel_fprintf.c | 12 +-
tools/perf/util/mem-events.c | 12 +-
tools/perf/util/mem-events.h | 1 +
tools/perf/util/symbol.h | 3 +-
tools/perf/util/symbol_fprintf.c | 11 +-
20 files changed, 1406 insertions(+), 185 deletions(-)
create mode 100644 tools/perf/arch/arm/annotate/instructions.c
create mode 100644 tools/perf/arch/x86/annotate/instructions.c
# uname -a
Linux jouet 4.8.6-201.fc24.x86_64 #1 SMP Thu Nov 3 14:38:57 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: detect openat syscall event : Ok
3: detect openat syscall event on all cpus : Ok
4: read samples using the mmap interface : Ok
5: parse events tests : Ok
6: Validate PERF_RECORD_* events & perf_sample fields : Ok
7: Test perf pmu format parsing : Ok
8: Test dso data read : Ok
9: Test dso data cache : Ok
10: Test dso data reopen : Ok
11: roundtrip evsel->name check : Ok
12: Check parsing of sched tracepoints fields : Ok
13: Generate and check syscalls:sys_enter_openat event fields: Ok
14: struct perf_event_attr setup : Ok
15: Test matching and linking multiple hists : Ok
16: Try 'import perf' in python, checking link problems : Ok
17: Test breakpoint overflow signal handler : Ok
18: Test breakpoint overflow sampling : Ok
19: Test number of exit event of a simple workload : Ok
20: Test software clock events have valid period values : Ok
21: Test object code reading : Ok
22: Test sample parsing : Ok
23: Test using a dummy software event to keep tracking : Ok
24: Test parsing with no sample_id_all bit set : Ok
25: Test filtering hist entries : Ok
26: Test mmap thread lookup : Ok
27: Test thread mg sharing : Ok
28: Test output sorting of hist entries : Ok
29: Test cumulation of child hist entries : Ok
30: Test tracking with sched_switch : Ok
31: Filter fds with revents mask in a fdarray : Ok
32: Add fd to a fdarray, making it autogrow : Ok
33: Test kmod_path__parse function : Ok
34: Test thread map : Ok
35: Test LLVM searching and compiling :
35.1: Basic BPF llvm compiling test : Ok
35.2: Test kbuild searching : Ok
35.3: Compile source for BPF prologue generation test : Ok
35.4: Compile source for BPF relocation test : Ok
36: Test topology in session : Ok
37: Test BPF filter :
37.1: Test basic BPF filtering : Ok
37.2: Test BPF prologue generation : Ok
37.3: Test BPF relocation checker : Ok
38: Test thread map synthesize : Ok
39: Test cpu map synthesize : Ok
40: Test stat config synthesize : Ok
41: Test stat synthesize : Ok
42: Test stat round synthesize : Ok
43: Test attr update synthesize : Ok
44: Test events times : Ok
45: Test backward reading from ring buffer : Ok
46: Test cpu map print : Ok
47: Test SDT event probing : Ok
48: Test is_printable_array function : Ok
49: Test bitmap print : Ok
50: x86 rdpmc test : Ok
51: Test converting perf time to TSC : Ok
52: Test dwarf unwind : Ok
53: Test x86 instruction decoder - new instructions : Ok
54: Test intel cqm nmi context read : Skip
#
# dm
1 alpine:3.4: Ok
2 android-ndk:r12b-arm: Ok
3 archlinux:latest: Ok
4 centos:5: Ok
5 centos:6: Ok
6 centos:7: Ok
7 debian:7: Ok
8 debian:8: Ok
9 debian:experimental: Ok
10 fedora:20: Ok
11 fedora:21: Ok
12 fedora:22: Ok
13 fedora:23: Ok
14 fedora:24: Ok
15 fedora:24-x-ARC-uClibc: Ok
16 fedora:rawhide: Ok
17 mageia:5: Ok
18 opensuse:13.2: Ok
19 opensuse:42.1: Ok
20 opensuse:tumbleweed: Ok
21 ubuntu:12.04.5: Ok
22 ubuntu:14.04: Ok
23 ubuntu:14.04.4: Ok
24 ubuntu:15.10: Ok
25 ubuntu:16.04: Ok
26 ubuntu:16.04-x-arm: Ok
27 ubuntu:16.04-x-arm64: Ok
28 ubuntu:16.04-x-powerpc: Ok
29 ubuntu:16.04-x-powerpc64: Ok
30 ubuntu:16.04-x-powerpc64el: Ok
31 ubuntu:16.04-x-s390: Ok
32 ubuntu:16.10: Ok
#
$ make -C tools/perf build-test
make: Entering directory '/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make_no_libperl_O: make NO_LIBPERL=1
make_no_demangle_O: make NO_DEMANGLE=1
make_no_libnuma_O: make NO_LIBNUMA=1
make_install_bin_O: make install-bin
make_install_prefix_O: make install prefix=/tmp/krava
make_util_map_o_O: make util/map.o
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_no_libbpf_O: make NO_LIBBPF=1
make_doc_O: make doc
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_with_babeltrace_O: make LIBBABELTRACE=1
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_debug_O: make DEBUG=1
make_perf_o_O: make perf.o
make_no_slang_O: make NO_SLANG=1
make_no_newt_O: make NO_NEWT=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_install_O: make install
make_no_auxtrace_O: make NO_AUXTRACE=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_install_prefix_slash_O: make install prefix=/tmp/krava/
make_clean_all_O: make clean all
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_libaudit_O: make NO_LIBAUDIT=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_help_O: make help
make_no_libelf_O: make NO_LIBELF=1
make_tags_O: make tags
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_gtk2_O: make NO_GTK2=1
make_pure_O: make
make_static_O: make LDFLAGS=-static
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2016-06-28 14:01 ` Arnaldo Carvalho de Melo
2016-06-28 14:12 ` Arnaldo Carvalho de Melo
@ 2016-06-29 9:36 ` Ingo Molnar
1 sibling, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2016-06-29 9:36 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Ananth N Mavinakayanahalli,
Andi Kleen, Anton Blanchard, Daniel Axtens, David Ahern,
He Kuang, Jiri Olsa, Marc Kleine-Budde, Masami Hiramatsu,
Michael Ellerman, Namhyung Kim, Naveen N . Rao, Neeraj Badlani,
Nilay Vaish, Peter Zijlstra, pi3orama, Ravi Bangoria,
Taeung Song, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Jun 28, 2016 at 09:02:57AM +0200, Ingo Molnar escreveu:
> >
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > > Hi Ingo,
> > >
> > > Please consider pulling,
> > >
> > > - Arnaldo
> > >
> > > The following changes since commit d4cf1949f9689314aef962eea95df84a8288d097:
> > >
> > > perf/x86/intel: Add {rd,wr}lbr_{to,from} wrappers (2016-06-27 11:34:21 +0200)
> > >
> > > are available in the git repository at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160627
> > >
> > > for you to fetch changes up to 6d9c675078e697309c1c06a1051f01de8151c476:
> > >
> > > perf data ctf: Generate fork and exit events to CTF output (2016-06-27 15:50:23 -0300)
> > >
> > > ----------------------------------------------------------------
> > > perf/core improvements and fixes:
> > >
> > > New features:
> > >
> > > - Generate comm, fork and exit events when converting perf.data files to CTF (Wang Nan)
> > >
> > > Documentation:
> > >
> > > - Document perf.data on disk format (Andi Kleen)
> > >
> > > Infrastructure:
> > >
> > > - Add libbabeltrace to build-test (Wang Nan)
> > >
> > > - 'perf record' prep work to support multiple evlists (Wang Nan)
> > >
> > > - Remove unused hist_entry__annotate function (Ravi Bangoria)
> > >
> > > - Add more toolchain triplets (Ravi Bangoria)
> > >
> > > - Update message for slang devel packages on Ubuntu (Neeraj Badlani)
> > >
> > > - Generalize handling of 'ret' instructions in the annotate TUI (Naveen N. Rao)
> > >
> > > - Use proper dso name for is_regular_file, fixing device file handling (Jiri Olsa)
> > >
> > > Build Fixes:
> > >
> > > - Add missing config.h include, fixing the build with libabeltrace (Jiri Olsa)
> > >
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > > Andi Kleen (1):
> > > perf tools: Add documentation for perf.data on disk format
> >
> > The doc build fails with:
> >
> > asciidoc: FAILED: manpage document title is mandatory
> > Makefile:276: recipe for target 'perf-file-format.xml' failed
> > make[2]: *** [perf-file-format.xml] Error 1
> > make[2]: *** Waiting for unfinished jobs....
>
> Ok, I've created a perf-core-for-mingo-20160628 with that patch removed
> while we investigate this, please consider pulling that one instead.
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2016-06-28 14:01 ` Arnaldo Carvalho de Melo
@ 2016-06-28 14:12 ` Arnaldo Carvalho de Melo
2016-06-29 9:36 ` Ingo Molnar
1 sibling, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-06-28 14:12 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Ingo Molnar, linux-kernel, Adrian Hunter,
Ananth N Mavinakayanahalli, Andi Kleen, Anton Blanchard,
Daniel Axtens, David Ahern, He Kuang, Jiri Olsa,
Marc Kleine-Budde, Masami Hiramatsu, Michael Ellerman,
Namhyung Kim, Naveen N . Rao, Neeraj Badlani, Nilay Vaish,
Peter Zijlstra, pi3orama, Ravi Bangoria, Taeung Song, Wang Nan,
Zefan Li, Arnaldo Carvalho de Melo
Em Tue, Jun 28, 2016 at 11:01:55AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Jun 28, 2016 at 09:02:57AM +0200, Ingo Molnar escreveu:
> > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > Andi Kleen (1):
> > > perf tools: Add documentation for perf.data on disk format
> > The doc build fails with:
> > asciidoc: FAILED: manpage document title is mandatory
> > Makefile:276: recipe for target 'perf-file-format.xml' failed
> > make[2]: *** [perf-file-format.xml] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> Ok, I've created a perf-core-for-mingo-20160628 with that patch removed
> while we investigate this, please consider pulling that one instead.
> build-test should've caught this... Reproduced, trying to fix...
So, when doing the docs install it expects files starting with perf-*
will be fed to asciidoc to generate man pages, etc, so the quick fix
here is to rename perf-file-format.txt to perf.data-file-format.txt,
which I did, so this will go in the next pull request.
Volunteers accepted to turn this into asciidoc format so that we can do
a man perf-data-file-format or somesuch.
- Arnaldo
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2016-06-28 7:02 ` Ingo Molnar
2016-06-28 8:27 ` Jiri Olsa
@ 2016-06-28 14:01 ` Arnaldo Carvalho de Melo
2016-06-28 14:12 ` Arnaldo Carvalho de Melo
2016-06-29 9:36 ` Ingo Molnar
1 sibling, 2 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-06-28 14:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Ananth N Mavinakayanahalli,
Andi Kleen, Anton Blanchard, Daniel Axtens, David Ahern,
He Kuang, Jiri Olsa, Marc Kleine-Budde, Masami Hiramatsu,
Michael Ellerman, Namhyung Kim, Naveen N . Rao, Neeraj Badlani,
Nilay Vaish, Peter Zijlstra, pi3orama, Ravi Bangoria,
Taeung Song, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Em Tue, Jun 28, 2016 at 09:02:57AM +0200, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > - Arnaldo
> >
> > The following changes since commit d4cf1949f9689314aef962eea95df84a8288d097:
> >
> > perf/x86/intel: Add {rd,wr}lbr_{to,from} wrappers (2016-06-27 11:34:21 +0200)
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160627
> >
> > for you to fetch changes up to 6d9c675078e697309c1c06a1051f01de8151c476:
> >
> > perf data ctf: Generate fork and exit events to CTF output (2016-06-27 15:50:23 -0300)
> >
> > ----------------------------------------------------------------
> > perf/core improvements and fixes:
> >
> > New features:
> >
> > - Generate comm, fork and exit events when converting perf.data files to CTF (Wang Nan)
> >
> > Documentation:
> >
> > - Document perf.data on disk format (Andi Kleen)
> >
> > Infrastructure:
> >
> > - Add libbabeltrace to build-test (Wang Nan)
> >
> > - 'perf record' prep work to support multiple evlists (Wang Nan)
> >
> > - Remove unused hist_entry__annotate function (Ravi Bangoria)
> >
> > - Add more toolchain triplets (Ravi Bangoria)
> >
> > - Update message for slang devel packages on Ubuntu (Neeraj Badlani)
> >
> > - Generalize handling of 'ret' instructions in the annotate TUI (Naveen N. Rao)
> >
> > - Use proper dso name for is_regular_file, fixing device file handling (Jiri Olsa)
> >
> > Build Fixes:
> >
> > - Add missing config.h include, fixing the build with libabeltrace (Jiri Olsa)
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > ----------------------------------------------------------------
> > Andi Kleen (1):
> > perf tools: Add documentation for perf.data on disk format
>
> The doc build fails with:
>
> asciidoc: FAILED: manpage document title is mandatory
> Makefile:276: recipe for target 'perf-file-format.xml' failed
> make[2]: *** [perf-file-format.xml] Error 1
> make[2]: *** Waiting for unfinished jobs....
Ok, I've created a perf-core-for-mingo-20160628 with that patch removed
while we investigate this, please consider pulling that one instead.
build-test should've caught this... Reproduced, trying to fix...
- Arnaldo
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2016-06-28 7:02 ` Ingo Molnar
@ 2016-06-28 8:27 ` Jiri Olsa
2016-06-28 14:01 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 50+ messages in thread
From: Jiri Olsa @ 2016-06-28 8:27 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Adrian Hunter,
Ananth N Mavinakayanahalli, Andi Kleen, Anton Blanchard,
Daniel Axtens, David Ahern, He Kuang, Marc Kleine-Budde,
Masami Hiramatsu, Michael Ellerman, Namhyung Kim, Naveen N . Rao,
Neeraj Badlani, Nilay Vaish, Peter Zijlstra, pi3orama,
Ravi Bangoria, Taeung Song, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
On Tue, Jun 28, 2016 at 09:02:57AM +0200, Ingo Molnar wrote:
SNIP
> > - Add missing config.h include, fixing the build with libabeltrace (Jiri Olsa)
> >
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > ----------------------------------------------------------------
> > Andi Kleen (1):
> > perf tools: Add documentation for perf.data on disk format
>
> The doc build fails with:
>
> asciidoc: FAILED: manpage document title is mandatory
> Makefile:276: recipe for target 'perf-file-format.xml' failed
> make[2]: *** [perf-file-format.xml] Error 1
> make[2]: *** Waiting for unfinished jobs....
>
hum, my asciidoc does not complain
jirka
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2016-06-27 21:01 Arnaldo Carvalho de Melo
@ 2016-06-28 7:02 ` Ingo Molnar
2016-06-28 8:27 ` Jiri Olsa
2016-06-28 14:01 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 50+ messages in thread
From: Ingo Molnar @ 2016-06-28 7:02 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Ananth N Mavinakayanahalli,
Andi Kleen, Anton Blanchard, Daniel Axtens, David Ahern,
He Kuang, Jiri Olsa, Marc Kleine-Budde, Masami Hiramatsu,
Michael Ellerman, Namhyung Kim, Naveen N . Rao, Neeraj Badlani,
Nilay Vaish, Peter Zijlstra, pi3orama, Ravi Bangoria,
Taeung Song, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit d4cf1949f9689314aef962eea95df84a8288d097:
>
> perf/x86/intel: Add {rd,wr}lbr_{to,from} wrappers (2016-06-27 11:34:21 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160627
>
> for you to fetch changes up to 6d9c675078e697309c1c06a1051f01de8151c476:
>
> perf data ctf: Generate fork and exit events to CTF output (2016-06-27 15:50:23 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Generate comm, fork and exit events when converting perf.data files to CTF (Wang Nan)
>
> Documentation:
>
> - Document perf.data on disk format (Andi Kleen)
>
> Infrastructure:
>
> - Add libbabeltrace to build-test (Wang Nan)
>
> - 'perf record' prep work to support multiple evlists (Wang Nan)
>
> - Remove unused hist_entry__annotate function (Ravi Bangoria)
>
> - Add more toolchain triplets (Ravi Bangoria)
>
> - Update message for slang devel packages on Ubuntu (Neeraj Badlani)
>
> - Generalize handling of 'ret' instructions in the annotate TUI (Naveen N. Rao)
>
> - Use proper dso name for is_regular_file, fixing device file handling (Jiri Olsa)
>
> Build Fixes:
>
> - Add missing config.h include, fixing the build with libabeltrace (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf tools: Add documentation for perf.data on disk format
The doc build fails with:
asciidoc: FAILED: manpage document title is mandatory
Makefile:276: recipe for target 'perf-file-format.xml' failed
make[2]: *** [perf-file-format.xml] Error 1
make[2]: *** Waiting for unfinished jobs....
Thanks,
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2016-06-27 21:01 Arnaldo Carvalho de Melo
2016-06-28 7:02 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-06-27 21:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Ananth N Mavinakayanahalli, Andi Kleen, Anton Blanchard,
Daniel Axtens, David Ahern, He Kuang, Jiri Olsa,
Marc Kleine-Budde, Masami Hiramatsu, Michael Ellerman,
Namhyung Kim, Naveen N . Rao, Neeraj Badlani, Nilay Vaish,
Peter Zijlstra, pi3orama, Ravi Bangoria, Taeung Song, Wang Nan,
Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit d4cf1949f9689314aef962eea95df84a8288d097:
perf/x86/intel: Add {rd,wr}lbr_{to,from} wrappers (2016-06-27 11:34:21 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160627
for you to fetch changes up to 6d9c675078e697309c1c06a1051f01de8151c476:
perf data ctf: Generate fork and exit events to CTF output (2016-06-27 15:50:23 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Generate comm, fork and exit events when converting perf.data files to CTF (Wang Nan)
Documentation:
- Document perf.data on disk format (Andi Kleen)
Infrastructure:
- Add libbabeltrace to build-test (Wang Nan)
- 'perf record' prep work to support multiple evlists (Wang Nan)
- Remove unused hist_entry__annotate function (Ravi Bangoria)
- Add more toolchain triplets (Ravi Bangoria)
- Update message for slang devel packages on Ubuntu (Neeraj Badlani)
- Generalize handling of 'ret' instructions in the annotate TUI (Naveen N. Rao)
- Use proper dso name for is_regular_file, fixing device file handling (Jiri Olsa)
Build Fixes:
- Add missing config.h include, fixing the build with libabeltrace (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf tools: Add documentation for perf.data on disk format
Jiri Olsa (2):
perf data convert: Include config.h header
perf symbols: Use proper dso name for is_regular_file
Naveen N. Rao (1):
perf annotate: Generalize handling of 'ret' instructions
Neeraj Badlani (1):
perf tools: Update makefile message for installing slang devel package
Ravi Bangoria (2):
perf annotate: Remove unused hist_entry__annotate function
perf tools: Add more toolchain triplets
Wang Nan (11):
perf build: Add libbabeltrace to build-test
perf record: Move mmap setup block to separate function
perf record: Prepare reading from multiple evlists in record__mmap_read_all()
perf record: Prepare picking perf_event_mmap_page from multiple evlists
perf data ctf: Add value_set_string() helper
perf data ctf: Pass convert options through opts structure
perf data ctf: Add 'all' option
perf data ctf: Prepare collect non-sample events
perf data ctf: Generate comm event to CTF output
perf data ctf: Add '--all' option for 'perf data convert'
perf data ctf: Generate fork and exit events to CTF output
tools/perf/Documentation/perf-data.txt | 4 +
tools/perf/Documentation/perf-file-format.txt | 442 ++++++++++++++++++++++++++
tools/perf/arch/common.c | 17 +
tools/perf/builtin-data.c | 11 +-
tools/perf/builtin-record.c | 105 ++++--
tools/perf/config/Makefile | 2 +-
tools/perf/tests/make | 2 +
tools/perf/ui/browsers/annotate.c | 20 +-
tools/perf/util/annotate.c | 15 +-
tools/perf/util/annotate.h | 3 +-
tools/perf/util/data-convert-bt.c | 196 +++++++++++-
tools/perf/util/data-convert-bt.h | 4 +-
tools/perf/util/data-convert.h | 9 +
tools/perf/util/symbol.c | 2 +-
14 files changed, 773 insertions(+), 59 deletions(-)
create mode 100644 tools/perf/Documentation/perf-file-format.txt
create mode 100644 tools/perf/util/data-convert.h
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2015-07-24 1:58 Arnaldo Carvalho de Melo
@ 2015-07-27 15:58 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2015-07-27 15:58 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Borislav Petkov,
David Ahern, Frederic Weisbecker, Jiri Olsa, Mathieu Poirier,
Namhyung Kim, Pawel Moll, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, Thomas Gleixner, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit a11c51acc52822754d66a11c15f6f6edd4d23c55:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-07-21 07:58:06 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 7c14898ba9386ee5c939bb418643ac6baff52840:
>
> perf script: Add option --show-switch-events (2015-07-23 22:51:14 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Introduce PERF_RECORD_SWITCH(_CPU_WIDE) and use it in 'record' to
> ask for context switches, allowing non priviledged tasks to know
> when they are switched in and out, which wasn't possible with
> the other context switch tracepoint and software events, see the
> patch description for a comprehensive justification (Adrian Hunter)
>
> - Stop collecting /proc/kallsyms in perf.data files, saving about
> 4.5MB on a typical x86-64 system, use the symbol resolution
> routines used in all the other tools (report, top, etc) now that
> we can ask libtraceevent to use perf's symbol resolution code.
> (Arnaldo Carvalho de Melo)
>
> User visible fixes:
>
> - Expose perf's symbol resolver to libtraceecent, so that its plugins can
> resolve tracepoint fields to kernel functions, like the 'function' field
> in the "timer:hrtimer_start tracepoint" (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Map propagation of thread and cpu maps improvements, prep work for
> 'perf stat' new features (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (5):
> perf: Add PERF_RECORD_SWITCH to indicate context switches
> perf tools: Add new PERF_RECORD_SWITCH event
> perf record: Add option --switch-events to select PERF_RECORD_SWITCH events
> perf script: Don't assume evsel position of tracking events
> perf script: Add option --show-switch-events
>
> Arnaldo Carvalho de Melo (8):
> perf symbols: Add front end cache for DSO symbol lookup
> perf symbols: Introduce map__is_(kernel,kmodule)()
> tools lib traceevent: Allow setting an alternative symbol resolver
> perf symbols: Provide libtraceevent callback to resolve kernel symbols
> perf trace: Provide libtracevent with a kernel symbol resolver
> perf script: Switch from perf.data's kallsyms to perf's symbol resolver
> perf tools: Stop reading the kallsyms data from perf.data
> perf tools: Stop copying kallsyms into the perf.data file header
>
> Jiri Olsa (5):
> perf test: Check for refcnt in thread_map test
> perf evlist: Force perf_evlist__set_maps to propagate maps through events
> perf evlist: Use bool instead of target argument in propagate_maps()
> perf evlist: Tolerate NULL maps in propagate_maps
> perf header: Use argv style storage for cmdline feature data
>
> include/uapi/linux/perf_event.h | 31 +++++++++-
> kernel/events/core.c | 103 +++++++++++++++++++++++++++++++
> tools/lib/traceevent/event-parse.c | 68 +++++++++++++++++++-
> tools/lib/traceevent/event-parse.h | 8 +++
> tools/perf/Documentation/perf-record.txt | 4 ++
> tools/perf/Documentation/perf-script.txt | 4 ++
> tools/perf/builtin-inject.c | 1 +
> tools/perf/builtin-record.c | 7 +++
> tools/perf/builtin-script.c | 48 ++++++++++++--
> tools/perf/builtin-trace.c | 3 +
> tools/perf/perf.h | 1 +
> tools/perf/tests/thread-map.c | 4 ++
> tools/perf/util/dso.h | 4 ++
> tools/perf/util/event.c | 28 +++++++++
> tools/perf/util/event.h | 12 ++++
> tools/perf/util/evlist.c | 28 +++++++--
> tools/perf/util/evlist.h | 12 ++--
> tools/perf/util/evsel.c | 4 ++
> tools/perf/util/header.c | 35 ++++++-----
> tools/perf/util/header.h | 1 +
> tools/perf/util/machine.c | 25 ++++++++
> tools/perf/util/machine.h | 6 ++
> tools/perf/util/map.c | 14 +++++
> tools/perf/util/map.h | 7 +++
> tools/perf/util/record.c | 10 +++
> tools/perf/util/session.c | 21 +++++++
> tools/perf/util/symbol.c | 7 ++-
> tools/perf/util/tool.h | 1 +
> tools/perf/util/trace-event-info.c | 22 +++----
> tools/perf/util/trace-event-parse.c | 30 ---------
> tools/perf/util/trace-event-read.c | 28 ++++-----
> tools/perf/util/trace-event.c | 45 +++++++++-----
> tools/perf/util/trace-event.h | 1 +
> 33 files changed, 513 insertions(+), 110 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2015-07-24 1:58 Arnaldo Carvalho de Melo
2015-07-27 15:58 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-07-24 1:58 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, David Ahern, Frederic Weisbecker,
Jiri Olsa, Mathieu Poirier, Namhyung Kim, Pawel Moll,
Peter Zijlstra, Stephane Eranian, Steven Rostedt,
Thomas Gleixner, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit a11c51acc52822754d66a11c15f6f6edd4d23c55:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-07-21 07:58:06 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 7c14898ba9386ee5c939bb418643ac6baff52840:
perf script: Add option --show-switch-events (2015-07-23 22:51:14 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Introduce PERF_RECORD_SWITCH(_CPU_WIDE) and use it in 'record' to
ask for context switches, allowing non priviledged tasks to know
when they are switched in and out, which wasn't possible with
the other context switch tracepoint and software events, see the
patch description for a comprehensive justification (Adrian Hunter)
- Stop collecting /proc/kallsyms in perf.data files, saving about
4.5MB on a typical x86-64 system, use the symbol resolution
routines used in all the other tools (report, top, etc) now that
we can ask libtraceevent to use perf's symbol resolution code.
(Arnaldo Carvalho de Melo)
User visible fixes:
- Expose perf's symbol resolver to libtraceecent, so that its plugins can
resolve tracepoint fields to kernel functions, like the 'function' field
in the "timer:hrtimer_start tracepoint" (Arnaldo Carvalho de Melo)
Infrastructure:
- Map propagation of thread and cpu maps improvements, prep work for
'perf stat' new features (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (5):
perf: Add PERF_RECORD_SWITCH to indicate context switches
perf tools: Add new PERF_RECORD_SWITCH event
perf record: Add option --switch-events to select PERF_RECORD_SWITCH events
perf script: Don't assume evsel position of tracking events
perf script: Add option --show-switch-events
Arnaldo Carvalho de Melo (8):
perf symbols: Add front end cache for DSO symbol lookup
perf symbols: Introduce map__is_(kernel,kmodule)()
tools lib traceevent: Allow setting an alternative symbol resolver
perf symbols: Provide libtraceevent callback to resolve kernel symbols
perf trace: Provide libtracevent with a kernel symbol resolver
perf script: Switch from perf.data's kallsyms to perf's symbol resolver
perf tools: Stop reading the kallsyms data from perf.data
perf tools: Stop copying kallsyms into the perf.data file header
Jiri Olsa (5):
perf test: Check for refcnt in thread_map test
perf evlist: Force perf_evlist__set_maps to propagate maps through events
perf evlist: Use bool instead of target argument in propagate_maps()
perf evlist: Tolerate NULL maps in propagate_maps
perf header: Use argv style storage for cmdline feature data
include/uapi/linux/perf_event.h | 31 +++++++++-
kernel/events/core.c | 103 +++++++++++++++++++++++++++++++
tools/lib/traceevent/event-parse.c | 68 +++++++++++++++++++-
tools/lib/traceevent/event-parse.h | 8 +++
tools/perf/Documentation/perf-record.txt | 4 ++
tools/perf/Documentation/perf-script.txt | 4 ++
tools/perf/builtin-inject.c | 1 +
tools/perf/builtin-record.c | 7 +++
tools/perf/builtin-script.c | 48 ++++++++++++--
tools/perf/builtin-trace.c | 3 +
tools/perf/perf.h | 1 +
tools/perf/tests/thread-map.c | 4 ++
tools/perf/util/dso.h | 4 ++
tools/perf/util/event.c | 28 +++++++++
tools/perf/util/event.h | 12 ++++
tools/perf/util/evlist.c | 28 +++++++--
tools/perf/util/evlist.h | 12 ++--
tools/perf/util/evsel.c | 4 ++
tools/perf/util/header.c | 35 ++++++-----
tools/perf/util/header.h | 1 +
tools/perf/util/machine.c | 25 ++++++++
tools/perf/util/machine.h | 6 ++
tools/perf/util/map.c | 14 +++++
tools/perf/util/map.h | 7 +++
tools/perf/util/record.c | 10 +++
tools/perf/util/session.c | 21 +++++++
tools/perf/util/symbol.c | 7 ++-
tools/perf/util/tool.h | 1 +
tools/perf/util/trace-event-info.c | 22 +++----
tools/perf/util/trace-event-parse.c | 30 ---------
tools/perf/util/trace-event-read.c | 28 ++++-----
tools/perf/util/trace-event.c | 45 +++++++++-----
tools/perf/util/trace-event.h | 1 +
33 files changed, 513 insertions(+), 110 deletions(-)
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2015-05-18 15:50 Arnaldo Carvalho de Melo
@ 2015-05-20 11:25 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2015-05-20 11:25 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Andi Kleen,
Borislav Petkov, Brendan Gregg, Daniel Borkmann, David Ahern,
Don Zickus, Frederic Weisbecker, He Kuang, Ingo Molnar,
Jan Stancek, Jiri Olsa, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, pi3orama,
Stephane Eranian, Steven Rostedt, Vinson Lee, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider applying,
>
> - Arnaldo
>
> The following changes since commit aa891009ee8863944a96ba4a348102f3d5f5f931:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-05-15 08:36:33 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 2d8e405acd787f4b975f73e0f8d9804b272c00f0:
>
> perf bench numa: Share sched_getcpu() __weak def with cloexec.c (2015-05-18 12:36:46 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix "Command" sort_entry's cmp and collapse function (Jiri Olsa)
>
> - Load map's symtab before 'perf probe' glob matching (Wang Nan)
>
> - Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit, to fix
> the use case where this code is called multiple times, which wasn't
> that common when it was introduced but seems to be now (Wang Nan).
>
> Infrastructure:
>
> - Protect dso symtab and cache operations with a mutex (Namhyung Kim)
>
> - Make all refcnt operations use atomic.h (Arnaldo Carvalho de Melo)
>
> - Install libtraceevent.a into libdir (Wang Nan)
>
> Build fixes:
>
> - Fix one build failure on RHEL5 by making 'perf bench numa' use the
> __weak sched_getcpu() provided by cloexec.h (Arnaldo Carvalho de Melo)
>
> - Fix dwarf-aux.c compilation on i386 (Jiri Olsa)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (6):
> perf tools: Use atomic.h for the map_groups refcount
> perf machine: Stop accessing atomic_t::counter directly
> perf evlist: Use atomic.h for the perf_mmap refcount
> perf cgroup: Use atomic.h for refcounting
> perf tools: Elliminate alignment holes
> perf bench numa: Share sched_getcpu() __weak def with cloexec.c
>
> Jiri Olsa (2):
> perf tools: Fix dwarf-aux.c compilation on i386
> perf tools: Fix "Command" sort_entry's cmp and collapse function
>
> Namhyung Kim (5):
> perf tools: Add rm_rf() utility function
> perf tools: Introduce copyfile_offset() function
> perf symbols: Protect dso symbol loading using a mutex
> perf symbols: Protect dso cache tree using dso->lock
> perf tools: Protect dso cache fd with a mutex
>
> Wang Nan (5):
> perf probe: Load map before glob matching
> tools include: add __aligned_u64 to types.h.
> perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit
> tools lib traceevent: Install libtraceevent.a into libdir
> tools build: Change FEATURE_TESTS and FEATURE_DISPLAY to weak binding
>
> tools/build/Makefile.feature | 4 +-
> tools/include/linux/types.h | 4 ++
> tools/lib/traceevent/Makefile | 20 ++++--
> tools/perf/bench/numa.c | 1 +
> tools/perf/builtin-timechart.c | 4 +-
> tools/perf/tests/thread-mg-share.c | 12 ++--
> tools/perf/util/cgroup.c | 10 +--
> tools/perf/util/cgroup.h | 4 +-
> tools/perf/util/dso.c | 134 ++++++++++++++++++++++++++++---------
> tools/perf/util/dso.h | 1 +
> tools/perf/util/dwarf-aux.c | 8 +--
> tools/perf/util/evlist.c | 12 ++--
> tools/perf/util/evlist.h | 5 +-
> tools/perf/util/evsel.h | 4 +-
> tools/perf/util/machine.c | 2 +-
> tools/perf/util/map.c | 4 +-
> tools/perf/util/map.h | 6 +-
> tools/perf/util/probe-event.c | 3 +
> tools/perf/util/sort.c | 4 +-
> tools/perf/util/symbol.c | 35 +++++++---
> tools/perf/util/thread.h | 2 +-
> tools/perf/util/util.c | 81 +++++++++++++++++++---
> tools/perf/util/util.h | 2 +
> 23 files changed, 263 insertions(+), 99 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2015-05-18 15:50 Arnaldo Carvalho de Melo
2015-05-20 11:25 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-05-18 15:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Andi Kleen, Borislav Petkov, Brendan Gregg,
Daniel Borkmann, David Ahern, Don Zickus, Frederic Weisbecker,
He Kuang, Ingo Molnar, Jan Stancek, Jiri Olsa, Jiri Olsa,
Masami Hiramatsu, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
pi3orama, Stephane Eranian, Steven Rostedt, Vinson Lee, Wang Nan,
Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider applying,
- Arnaldo
The following changes since commit aa891009ee8863944a96ba4a348102f3d5f5f931:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-05-15 08:36:33 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 2d8e405acd787f4b975f73e0f8d9804b272c00f0:
perf bench numa: Share sched_getcpu() __weak def with cloexec.c (2015-05-18 12:36:46 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix "Command" sort_entry's cmp and collapse function (Jiri Olsa)
- Load map's symtab before 'perf probe' glob matching (Wang Nan)
- Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit, to fix
the use case where this code is called multiple times, which wasn't
that common when it was introduced but seems to be now (Wang Nan).
Infrastructure:
- Protect dso symtab and cache operations with a mutex (Namhyung Kim)
- Make all refcnt operations use atomic.h (Arnaldo Carvalho de Melo)
- Install libtraceevent.a into libdir (Wang Nan)
Build fixes:
- Fix one build failure on RHEL5 by making 'perf bench numa' use the
__weak sched_getcpu() provided by cloexec.h (Arnaldo Carvalho de Melo)
- Fix dwarf-aux.c compilation on i386 (Jiri Olsa)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (6):
perf tools: Use atomic.h for the map_groups refcount
perf machine: Stop accessing atomic_t::counter directly
perf evlist: Use atomic.h for the perf_mmap refcount
perf cgroup: Use atomic.h for refcounting
perf tools: Elliminate alignment holes
perf bench numa: Share sched_getcpu() __weak def with cloexec.c
Jiri Olsa (2):
perf tools: Fix dwarf-aux.c compilation on i386
perf tools: Fix "Command" sort_entry's cmp and collapse function
Namhyung Kim (5):
perf tools: Add rm_rf() utility function
perf tools: Introduce copyfile_offset() function
perf symbols: Protect dso symbol loading using a mutex
perf symbols: Protect dso cache tree using dso->lock
perf tools: Protect dso cache fd with a mutex
Wang Nan (5):
perf probe: Load map before glob matching
tools include: add __aligned_u64 to types.h.
perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit
tools lib traceevent: Install libtraceevent.a into libdir
tools build: Change FEATURE_TESTS and FEATURE_DISPLAY to weak binding
tools/build/Makefile.feature | 4 +-
tools/include/linux/types.h | 4 ++
tools/lib/traceevent/Makefile | 20 ++++--
tools/perf/bench/numa.c | 1 +
tools/perf/builtin-timechart.c | 4 +-
tools/perf/tests/thread-mg-share.c | 12 ++--
tools/perf/util/cgroup.c | 10 +--
tools/perf/util/cgroup.h | 4 +-
tools/perf/util/dso.c | 134 ++++++++++++++++++++++++++++---------
tools/perf/util/dso.h | 1 +
tools/perf/util/dwarf-aux.c | 8 +--
tools/perf/util/evlist.c | 12 ++--
tools/perf/util/evlist.h | 5 +-
tools/perf/util/evsel.h | 4 +-
tools/perf/util/machine.c | 2 +-
tools/perf/util/map.c | 4 +-
tools/perf/util/map.h | 6 +-
tools/perf/util/probe-event.c | 3 +
tools/perf/util/sort.c | 4 +-
tools/perf/util/symbol.c | 35 +++++++---
tools/perf/util/thread.h | 2 +-
tools/perf/util/util.c | 81 +++++++++++++++++++---
tools/perf/util/util.h | 2 +
23 files changed, 263 insertions(+), 99 deletions(-)
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2014-12-17 14:50 ` Arnaldo Carvalho de Melo
@ 2014-12-18 6:24 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2014-12-18 6:24 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, David Ahern,
Don Zickus, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Mitchell Krome, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Stephane Eranian
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Dec 16, 2014 at 01:57:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Hi Ingo,
> >
> > Please consider pulling,
> >
> > - Arnaldo
> >
> > The following changes since commit 41e950c033b7df997d4b38653efe6554be9b96a7:
> >
> > Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-12-12 09:09:52 +0100)
> >
> > are available in the git repository at:
> >
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> Ingo,
>
> Please consider pulling the perf-core-for-mingo-2 signed tag
> instead, it is exactly the same content modulo removal of some
> whitespaces at the end of a few lines in tools/perf/Makefile.perf that
> Jiri found while reading those patches,
Pulled, thanks a lot!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2014-12-16 16:57 Arnaldo Carvalho de Melo
@ 2014-12-17 14:50 ` Arnaldo Carvalho de Melo
2014-12-18 6:24 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-12-17 14:50 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Borislav Petkov, David Ahern,
Don Zickus, Frederic Weisbecker, Jiri Olsa, Mike Galbraith,
Mitchell Krome, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Stephane Eranian
Em Tue, Dec 16, 2014 at 01:57:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 41e950c033b7df997d4b38653efe6554be9b96a7:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-12-12 09:09:52 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
Ingo,
Please consider pulling the perf-core-for-mingo-2 signed tag
instead, it is exactly the same content modulo removal of some
whitespaces at the end of a few lines in tools/perf/Makefile.perf that
Jiri found while reading those patches,
Thanks,
- Arnaldo
> for you to fetch changes up to 67195c75a87232f055ff415fc4624ef01f24fc3d:
>
> perf symbols: Fix use after free in filename__read_build_id (2014-12-16 13:38:28 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - The mmap address range for the ring buffer now is calculated using the
> contents of /proc/sys/kernel/perf_event_mlock_kb.
>
> This fixes an -EPERM case where 'trace' was trying to use more than what
> configured on perf_event_mlock_kb. (Arnaldo Carvalho de Melo)
>
> Infrastructure:
>
> - Move bitops definitions so that they match the header file hierarchy
> in the kernel sources where that code came from. (Arnaldo Carvalho de Melo)
>
> - Adopt round{down,up}_pow_of_two from the kernel and use it instead of
> equivalent code, so that we reuse more kernel code and make tools/ look
> more like kernel source code, to encourage further contributions from
> kernel hackers (Arnaldo Carvalho de Melo)
>
> - Fix use after free in filename__read_build_id (Mitchell Krome)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (17):
> perf evlist: Fixup brown paper bag on "hint" for --mmap-pages cmdline arg
> perf evlist: Clarify sterror_mmap variable names
> perf evlist: Improve the strerror_mmap method
> perf trace: Let the perf_evlist__mmap autosize the number of pages to use
> perf evlist: Do not use hard coded value for a mmap_pages default
> tools: Move __ffs implementation to tools/include/asm-generic/bitops/__ffs.h
> tools: Move code originally from linux/log2.h to tools/include/linux/
> tools: Move code originally from asm-generic/atomic.h into tools/include/asm-generic/
> tools: Whitespace prep patches for moving bitops.h
> tools lib: Move asm-generic/bitops/find.h code to tools/include and tools/lib
> tools: Introduce asm-generic/bitops.h
> tools: Move bitops.h from tools/perf/util to tools/
> tools: Adopt fls_long and deps
> tools: Adopt rounddown_pow_of_two and deps
> perf tools: Make the mmap length autotuning more robust
> tools: Adopt roundup_pow_of_two
> perf evlist: Use roundup_pow_of_two
>
> Mitchell Krome (1):
> perf symbols: Fix use after free in filename__read_build_id
>
> tools/include/asm-generic/bitops.h | 27 +++++
> tools/include/asm-generic/bitops/__ffs.h | 43 +++++++
> tools/include/asm-generic/bitops/__fls.h | 1 +
> tools/include/asm-generic/bitops/atomic.h | 22 ++++
> tools/include/asm-generic/bitops/find.h | 33 ++++++
> tools/include/asm-generic/bitops/fls.h | 1 +
> tools/include/asm-generic/bitops/fls64.h | 1 +
> tools/include/linux/bitops.h | 53 +++++++++
> tools/include/linux/log2.h | 185 ++++++++++++++++++++++++++++++
> tools/lib/util/find_next_bit.c | 89 ++++++++++++++
> tools/perf/MANIFEST | 13 ++-
> tools/perf/Makefile.perf | 14 ++-
> tools/perf/builtin-trace.c | 2 +-
> tools/perf/util/evlist.c | 46 ++++++--
> tools/perf/util/include/linux/bitops.h | 162 --------------------------
> tools/perf/util/symbol-minimal.c | 8 +-
> tools/perf/util/util.h | 29 -----
> 17 files changed, 522 insertions(+), 207 deletions(-)
> create mode 100644 tools/include/asm-generic/bitops.h
> create mode 100644 tools/include/asm-generic/bitops/__ffs.h
> create mode 100644 tools/include/asm-generic/bitops/__fls.h
> create mode 100644 tools/include/asm-generic/bitops/atomic.h
> create mode 100644 tools/include/asm-generic/bitops/find.h
> create mode 100644 tools/include/asm-generic/bitops/fls.h
> create mode 100644 tools/include/asm-generic/bitops/fls64.h
> create mode 100644 tools/include/linux/bitops.h
> create mode 100644 tools/include/linux/log2.h
> create mode 100644 tools/lib/util/find_next_bit.c
> delete mode 100644 tools/perf/util/include/linux/bitops.h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2014-12-16 16:57 Arnaldo Carvalho de Melo
2014-12-17 14:50 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-12-16 16:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Borislav Petkov, David Ahern, Don Zickus, Frederic Weisbecker,
Jiri Olsa, Mike Galbraith, Mitchell Krome, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 41e950c033b7df997d4b38653efe6554be9b96a7:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2014-12-12 09:09:52 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 67195c75a87232f055ff415fc4624ef01f24fc3d:
perf symbols: Fix use after free in filename__read_build_id (2014-12-16 13:38:28 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- The mmap address range for the ring buffer now is calculated using the
contents of /proc/sys/kernel/perf_event_mlock_kb.
This fixes an -EPERM case where 'trace' was trying to use more than what
configured on perf_event_mlock_kb. (Arnaldo Carvalho de Melo)
Infrastructure:
- Move bitops definitions so that they match the header file hierarchy
in the kernel sources where that code came from. (Arnaldo Carvalho de Melo)
- Adopt round{down,up}_pow_of_two from the kernel and use it instead of
equivalent code, so that we reuse more kernel code and make tools/ look
more like kernel source code, to encourage further contributions from
kernel hackers (Arnaldo Carvalho de Melo)
- Fix use after free in filename__read_build_id (Mitchell Krome)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (17):
perf evlist: Fixup brown paper bag on "hint" for --mmap-pages cmdline arg
perf evlist: Clarify sterror_mmap variable names
perf evlist: Improve the strerror_mmap method
perf trace: Let the perf_evlist__mmap autosize the number of pages to use
perf evlist: Do not use hard coded value for a mmap_pages default
tools: Move __ffs implementation to tools/include/asm-generic/bitops/__ffs.h
tools: Move code originally from linux/log2.h to tools/include/linux/
tools: Move code originally from asm-generic/atomic.h into tools/include/asm-generic/
tools: Whitespace prep patches for moving bitops.h
tools lib: Move asm-generic/bitops/find.h code to tools/include and tools/lib
tools: Introduce asm-generic/bitops.h
tools: Move bitops.h from tools/perf/util to tools/
tools: Adopt fls_long and deps
tools: Adopt rounddown_pow_of_two and deps
perf tools: Make the mmap length autotuning more robust
tools: Adopt roundup_pow_of_two
perf evlist: Use roundup_pow_of_two
Mitchell Krome (1):
perf symbols: Fix use after free in filename__read_build_id
tools/include/asm-generic/bitops.h | 27 +++++
tools/include/asm-generic/bitops/__ffs.h | 43 +++++++
tools/include/asm-generic/bitops/__fls.h | 1 +
tools/include/asm-generic/bitops/atomic.h | 22 ++++
tools/include/asm-generic/bitops/find.h | 33 ++++++
tools/include/asm-generic/bitops/fls.h | 1 +
tools/include/asm-generic/bitops/fls64.h | 1 +
tools/include/linux/bitops.h | 53 +++++++++
tools/include/linux/log2.h | 185 ++++++++++++++++++++++++++++++
tools/lib/util/find_next_bit.c | 89 ++++++++++++++
tools/perf/MANIFEST | 13 ++-
tools/perf/Makefile.perf | 14 ++-
tools/perf/builtin-trace.c | 2 +-
tools/perf/util/evlist.c | 46 ++++++--
tools/perf/util/include/linux/bitops.h | 162 --------------------------
tools/perf/util/symbol-minimal.c | 8 +-
tools/perf/util/util.h | 29 -----
17 files changed, 522 insertions(+), 207 deletions(-)
create mode 100644 tools/include/asm-generic/bitops.h
create mode 100644 tools/include/asm-generic/bitops/__ffs.h
create mode 100644 tools/include/asm-generic/bitops/__fls.h
create mode 100644 tools/include/asm-generic/bitops/atomic.h
create mode 100644 tools/include/asm-generic/bitops/find.h
create mode 100644 tools/include/asm-generic/bitops/fls.h
create mode 100644 tools/include/asm-generic/bitops/fls64.h
create mode 100644 tools/include/linux/bitops.h
create mode 100644 tools/include/linux/log2.h
create mode 100644 tools/lib/util/find_next_bit.c
delete mode 100644 tools/perf/util/include/linux/bitops.h
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2014-12-11 21:25 Arnaldo Carvalho de Melo
@ 2014-12-12 8:10 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2014-12-12 8:10 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Yarygin, Andi Kleen,
Arjun Sreedharan, Borislav Petkov, Christian Borntraeger,
Corey Ashford, David Ahern, Don Zickus, Frederic Weisbecker,
Jiri Olsa, Kan Liang, Kim Phillips, Matt Mullins, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Rabin Vincent,
Stephane Eranian, Steven Rostedt, Tom Huynh, Yann E. MORIN,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit cfa0bd52d0ba9b852f76c7b3f1055edd5e5c7846:
>
> Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-12-08 07:45:45 +0100)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to e09b18d4907992d3d615b215c1abf585721b2810:
>
> perf trace: Provide a better explanation when mmap fails (2014-12-11 18:04:10 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Mark events as (x86 only) in help output for 'perf kvm stat live" (Alexander Yarygin)
>
> - Provide a better explanation when mmap fails in 'trace' (Arnaldo Carvalho de Melo)
>
> - Add --buildid-dir option to set cache directory, i.e. use:
>
> $ perf --buildid-dir /path/to/dir tool --tool-options
>
> (Jiri Olsa)
>
> - Fix memcpy/memset 'perf bench' output (Rabin Vicent)
>
> - Fix 'perf test' attr tests size values to cope with machine state on
> interrupt ABI changes (Jiri Olsa)
>
> - Fixup callchain type parameter handling error message (Kan Liang)
>
> Infrastructure/cleanups:
>
> - calloc/xcalloc: Fix argument order (Arjun Sreedharan)
>
> - Move filename__read_int from tools/perf/ to tools/lib, add sysctl__read_int
> there and use it in place of ad-hoc copies (Arnaldo Carvalho de Melo)
>
> - Use single strcmp call instead of two (Jiri Olsa)
>
> - Remove extra debugdir variables in 'perf buildid-cache' (Jiri Olsa)
>
> - Fix -a segfault related to kcore handling in 'perf buildid-cache' (Jiri Olsa)
>
> - Move cpumode resolve code to add_callchain_ip (Kan Liang)
>
> - Merge memset into memcpy 'perf bench' (Rabin Vincent)
>
> - Change print format from %lu to %PRIu64 in the hists browser (Tom Huynh)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Alexander Yarygin (1):
> perf kvm stat live: Mark events as (x86 only) in help output
>
> Arjun Sreedharan (1):
> calloc/xcalloc: Fix argument order
>
> Arnaldo Carvalho de Melo (5):
> tools lib fs: Adopt filename__read_int from tools/perf/
> tools lib fs: Add sysctl__read_int helper
> perf tools: Use sysctl__read_int instead of ad-hoc copies
> perf evlist: Introduce strerror_mmap method
> perf trace: Provide a better explanation when mmap fails
>
> Jiri Olsa (5):
> perf tools: Use single strcmp call instead of two
> perf buildid-cache: Remove extra debugdir variables
> perf buildid cache: Fix -a segfault related to kcore handling
> perf tools: Add --buildid-dir option to set cache directory
> perf tests: Fix attr tests size values to cope with machine state on interrupt ABI changes
>
> Kan Liang (2):
> perf callchain: Fixup parameter handling error message
> perf callchain: Move cpumode resolve code to add_callchain_ip
>
> Rabin Vincent (3):
> perf bench: Prepare memcpy for merge
> perf bench: Merge memset into memcpy
> perf bench: Fix memcpy/memset output
>
> Tom Huynh (1):
> perf hists browser: Change print format from %lu to %PRIu64
>
> scripts/kconfig/mconf.c | 4 +-
> tools/lib/api/fs/fs.c | 34 +++++
> tools/lib/api/fs/fs.h | 3 +
> tools/perf/Documentation/perf.txt | 4 +
> tools/perf/Makefile.perf | 1 -
> tools/perf/bench/mem-memcpy.c | 286 ++++++++++++++++++++++++----------
> tools/perf/bench/mem-memset.c | 304 -------------------------------------
> tools/perf/builtin-buildid-cache.c | 13 +-
> tools/perf/builtin-kvm.c | 3 +-
> tools/perf/builtin-trace.c | 12 +-
> tools/perf/perf.c | 14 +-
> tools/perf/tests/attr/base-record | 2 +-
> tools/perf/tests/attr/base-stat | 2 +-
> tools/perf/ui/browsers/hists.c | 2 +-
> tools/perf/ui/hist.c | 4 +-
> tools/perf/util/build-id.c | 9 +-
> tools/perf/util/callchain.c | 2 +-
> tools/perf/util/config.c | 10 +-
> tools/perf/util/evlist.c | 23 +++
> tools/perf/util/evlist.h | 1 +
> tools/perf/util/machine.c | 72 +++++----
> tools/perf/util/record.c | 11 +-
> tools/perf/util/util.c | 26 +---
> tools/perf/util/util.h | 3 +-
> tools/thermal/tmon/sysfs.c | 6 +-
> 25 files changed, 350 insertions(+), 501 deletions(-)
> delete mode 100644 tools/perf/bench/mem-memset.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2014-12-11 21:25 Arnaldo Carvalho de Melo
2014-12-12 8:10 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-12-11 21:25 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Yarygin, Andi Kleen, Arjun Sreedharan, Borislav Petkov,
Christian Borntraeger, Corey Ashford, David Ahern, Don Zickus,
Frederic Weisbecker, Jiri Olsa, Kan Liang, Kim Phillips,
Matt Mullins, Mike Galbraith, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Rabin Vincent, Stephane Eranian, Steven Rostedt,
Tom Huynh, Yann E. MORIN, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit cfa0bd52d0ba9b852f76c7b3f1055edd5e5c7846:
Merge tag 'perf-core-for-mingo-2' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-12-08 07:45:45 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to e09b18d4907992d3d615b215c1abf585721b2810:
perf trace: Provide a better explanation when mmap fails (2014-12-11 18:04:10 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Mark events as (x86 only) in help output for 'perf kvm stat live" (Alexander Yarygin)
- Provide a better explanation when mmap fails in 'trace' (Arnaldo Carvalho de Melo)
- Add --buildid-dir option to set cache directory, i.e. use:
$ perf --buildid-dir /path/to/dir tool --tool-options
(Jiri Olsa)
- Fix memcpy/memset 'perf bench' output (Rabin Vicent)
- Fix 'perf test' attr tests size values to cope with machine state on
interrupt ABI changes (Jiri Olsa)
- Fixup callchain type parameter handling error message (Kan Liang)
Infrastructure/cleanups:
- calloc/xcalloc: Fix argument order (Arjun Sreedharan)
- Move filename__read_int from tools/perf/ to tools/lib, add sysctl__read_int
there and use it in place of ad-hoc copies (Arnaldo Carvalho de Melo)
- Use single strcmp call instead of two (Jiri Olsa)
- Remove extra debugdir variables in 'perf buildid-cache' (Jiri Olsa)
- Fix -a segfault related to kcore handling in 'perf buildid-cache' (Jiri Olsa)
- Move cpumode resolve code to add_callchain_ip (Kan Liang)
- Merge memset into memcpy 'perf bench' (Rabin Vincent)
- Change print format from %lu to %PRIu64 in the hists browser (Tom Huynh)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Alexander Yarygin (1):
perf kvm stat live: Mark events as (x86 only) in help output
Arjun Sreedharan (1):
calloc/xcalloc: Fix argument order
Arnaldo Carvalho de Melo (5):
tools lib fs: Adopt filename__read_int from tools/perf/
tools lib fs: Add sysctl__read_int helper
perf tools: Use sysctl__read_int instead of ad-hoc copies
perf evlist: Introduce strerror_mmap method
perf trace: Provide a better explanation when mmap fails
Jiri Olsa (5):
perf tools: Use single strcmp call instead of two
perf buildid-cache: Remove extra debugdir variables
perf buildid cache: Fix -a segfault related to kcore handling
perf tools: Add --buildid-dir option to set cache directory
perf tests: Fix attr tests size values to cope with machine state on interrupt ABI changes
Kan Liang (2):
perf callchain: Fixup parameter handling error message
perf callchain: Move cpumode resolve code to add_callchain_ip
Rabin Vincent (3):
perf bench: Prepare memcpy for merge
perf bench: Merge memset into memcpy
perf bench: Fix memcpy/memset output
Tom Huynh (1):
perf hists browser: Change print format from %lu to %PRIu64
scripts/kconfig/mconf.c | 4 +-
tools/lib/api/fs/fs.c | 34 +++++
tools/lib/api/fs/fs.h | 3 +
tools/perf/Documentation/perf.txt | 4 +
tools/perf/Makefile.perf | 1 -
tools/perf/bench/mem-memcpy.c | 286 ++++++++++++++++++++++++----------
tools/perf/bench/mem-memset.c | 304 -------------------------------------
tools/perf/builtin-buildid-cache.c | 13 +-
tools/perf/builtin-kvm.c | 3 +-
tools/perf/builtin-trace.c | 12 +-
tools/perf/perf.c | 14 +-
tools/perf/tests/attr/base-record | 2 +-
tools/perf/tests/attr/base-stat | 2 +-
tools/perf/ui/browsers/hists.c | 2 +-
tools/perf/ui/hist.c | 4 +-
tools/perf/util/build-id.c | 9 +-
tools/perf/util/callchain.c | 2 +-
tools/perf/util/config.c | 10 +-
tools/perf/util/evlist.c | 23 +++
tools/perf/util/evlist.h | 1 +
tools/perf/util/machine.c | 72 +++++----
tools/perf/util/record.c | 11 +-
tools/perf/util/util.c | 26 +---
tools/perf/util/util.h | 3 +-
tools/thermal/tmon/sysfs.c | 6 +-
25 files changed, 350 insertions(+), 501 deletions(-)
delete mode 100644 tools/perf/bench/mem-memset.c
^ permalink raw reply [flat|nested] 50+ messages in thread
* Re: [GIT PULL 00/18] perf/core improvements and fixes
2014-11-06 21:04 Arnaldo Carvalho de Melo
@ 2014-11-07 5:24 ` Ingo Molnar
0 siblings, 0 replies; 50+ messages in thread
From: Ingo Molnar @ 2014-11-07 5:24 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Corey Ashford, David Ahern,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit daa01794a4a36a1da1b09a529adec0c8c0b94ab2:
>
> perf evsel: Do not call pevent_free_format when deleting tracepoint (2014-11-06 17:47:14 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to daa01794a4a36a1da1b09a529adec0c8c0b94ab2:
>
> perf evsel: Do not call pevent_free_format when deleting tracepoint (2014-11-06 17:47:14 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> Infrastructure:
>
> o Add gzip decompression support for kernel modules (Namhyung Kim)
>
> o More prep patches for Intel PT, including a a thread stack and
> more stuff made available via the database export mechanism (Adrian Hunter)
>
> o Optimize checking that tracepoint events are defined in perf script perl/python (Jiri Olsa)
>
> o Do not free pevent when deleting tracepoint evsel (Jiri Olsa)
>
> o Fix build-id matching for vmlinux (Namhyung Kim)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2014-11-06 21:04 Arnaldo Carvalho de Melo
2014-11-07 5:24 ` Ingo Molnar
0 siblings, 1 reply; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-11-06 21:04 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Corey Ashford, David Ahern, Frederic Weisbecker, Jiri Olsa,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit daa01794a4a36a1da1b09a529adec0c8c0b94ab2:
perf evsel: Do not call pevent_free_format when deleting tracepoint (2014-11-06 17:47:14 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to daa01794a4a36a1da1b09a529adec0c8c0b94ab2:
perf evsel: Do not call pevent_free_format when deleting tracepoint (2014-11-06 17:47:14 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
Infrastructure:
o Add gzip decompression support for kernel modules (Namhyung Kim)
o More prep patches for Intel PT, including a a thread stack and
more stuff made available via the database export mechanism (Adrian Hunter)
o Optimize checking that tracepoint events are defined in perf script perl/python (Jiri Olsa)
o Do not free pevent when deleting tracepoint evsel (Jiri Olsa)
o Fix build-id matching for vmlinux (Namhyung Kim)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
^ permalink raw reply [flat|nested] 50+ messages in thread
* [GIT PULL 00/18] perf/core improvements and fixes
@ 2014-08-15 16:48 Arnaldo Carvalho de Melo
0 siblings, 0 replies; 50+ messages in thread
From: Arnaldo Carvalho de Melo @ 2014-08-15 16:48 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alex Converse, Andi Kleen, Anshuman Khandual, Arun Sharma,
Brendan Gregg, Cody P Schafer, David Ahern, Elliott Hughes,
Frederic Weisbecker, Haren Myneni, Jiri Olsa, linuxppc-dev,
Masami Hiramatsu, Michael Ellerman, Namhyung Kim, Naohiro Aota,
Paul Mackerras, Peter Zijlstra, Rodrigo Campos, Stephane Eranian,
Sukadev Bhattiprolu, yrl.pp-manager.tt, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit f373da34282560c60f0c197690eecb1b2dc49fc0:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-08-14 10:38:40 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 759e612bf96627b64fcafe4174b3f6f2dedf2c0d:
perf stat: Use strerror_r instead of strerror (2014-08-15 13:08:40 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
. Warn user to rebuild target with debuginfo in 'perf probe' (Masami Hiramatsu)
. Don't truncate Intel style addresses in 'annotate'. (Alex Converse)
Developer stuff:
. Annotate PMU related list_head members with type info. (Cody P Schafer)
. Add the triplet used for arm64 by Android (Elliott Hughes)
. Replace thread unsafe strerror() with strerror_r() accross the
whole tools/perf/ tree (Masami Hiramatsu)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Alex Converse (1):
perf annotate: Don't truncate Intel style addresses
Cody P Schafer (1):
perf tools: Annotate PMU related list_head members with type info
Elliott Hughes (1):
perf tools: Add arm64 triplets
Masami Hiramatsu (14):
perf probe: Warn user to rebuild target with debuginfo
perf probe: Don't use strerror if strlist__add failed
perf: Use strerror_r instead of strerror
perf probe: Make error messages thread-safe
perf util: Replace strerror with strerror_r for thread-safety
perf top: Use strerror_r instead of strerror
perf trace: Use strerror_r instead of strerror
perf record: Use strerror_r instead of strerror
perf test: Use strerror_r instead of strerror
perf sched: Use strerror_r instead of strerror
perf buildid-cache: Use strerror_r instead of strerror
perf kvm: Use strerror_r instead of strerror
perf help: Use strerror_r instead of strerror
perf stat: Use strerror_r instead of strerror
Namhyung Kim (1):
perf report: Relax -g option parsing not to limit the option order
tools/perf/arch/common.c | 9 +++
tools/perf/builtin-buildid-cache.c | 7 ++-
tools/perf/builtin-help.c | 20 +++++--
tools/perf/builtin-kvm.c | 7 ++-
tools/perf/builtin-probe.c | 5 +-
tools/perf/builtin-record.c | 7 ++-
tools/perf/builtin-sched.c | 4 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-top.c | 2 +-
tools/perf/builtin-trace.c | 6 +-
tools/perf/perf.c | 10 +++-
tools/perf/tests/builtin-test.c | 4 +-
tools/perf/tests/mmap-basic.c | 7 ++-
tools/perf/tests/open-syscall-all-cpus.c | 5 +-
tools/perf/tests/open-syscall-tp-fields.c | 7 ++-
tools/perf/tests/open-syscall.c | 3 +-
tools/perf/tests/perf-record.c | 13 +++--
tools/perf/tests/rdpmc.c | 6 +-
tools/perf/tests/sw-clock.c | 6 +-
tools/perf/tests/task-exit.c | 6 +-
tools/perf/util/annotate.c | 12 +++-
tools/perf/util/callchain.c | 95 +++++++++++++------------------
tools/perf/util/cloexec.c | 6 +-
tools/perf/util/data.c | 8 ++-
tools/perf/util/debug.h | 3 +
tools/perf/util/dso.c | 8 ++-
tools/perf/util/evlist.c | 2 +-
tools/perf/util/evsel.c | 7 ++-
tools/perf/util/parse-events.c | 5 +-
tools/perf/util/pmu.c | 4 +-
tools/perf/util/pmu.h | 6 +-
tools/perf/util/probe-event.c | 75 +++++++++++++-----------
tools/perf/util/probe-finder.c | 7 ++-
tools/perf/util/run-command.c | 9 ++-
tools/perf/util/util.c | 5 +-
35 files changed, 234 insertions(+), 154 deletions(-)
^ permalink raw reply [flat|nested] 50+ messages in thread
end of thread, other threads:[~2018-05-19 11:34 UTC | newest]
Thread overview: 50+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-15 16:49 [GIT PULL 00/18] perf/core improvements and fixes Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 01/18] perf probe: Warn user to rebuild target with debuginfo Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 02/18] perf annotate: Don't truncate Intel style addresses Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 03/18] perf tools: Add arm64 triplets Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 04/18] perf tools: Annotate PMU related list_head members with type info Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 05/18] perf report: Relax -g option parsing not to limit the option order Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 06/18] perf probe: Don't use strerror if strlist__add failed Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 07/18] perf: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 08/18] perf probe: Make error messages thread-safe Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 09/18] perf util: Replace strerror with strerror_r for thread-safety Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 10/18] perf top: Use strerror_r instead of strerror Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 11/18] perf trace: " Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 12/18] perf record: " Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 13/18] perf test: " Arnaldo Carvalho de Melo
2014-08-15 16:49 ` [PATCH 14/18] perf sched: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 15/18] perf buildid-cache: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 16/18] perf kvm: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 17/18] perf help: " Arnaldo Carvalho de Melo
2014-08-15 16:50 ` [PATCH 18/18] perf stat: " Arnaldo Carvalho de Melo
2014-08-18 8:18 ` [GIT PULL 00/18] perf/core improvements and fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2018-05-19 10:54 Arnaldo Carvalho de Melo
2018-05-19 11:33 ` Ingo Molnar
2017-08-29 19:42 Arnaldo Carvalho de Melo
2017-08-29 21:15 ` Ingo Molnar
2017-04-12 0:51 Arnaldo Carvalho de Melo
2017-04-12 5:30 ` Ingo Molnar
2017-04-12 7:13 ` Christian Borntraeger
2017-04-12 7:24 ` Ingo Molnar
2017-02-20 19:08 Arnaldo Carvalho de Melo
2017-02-21 8:08 ` Ingo Molnar
2016-11-23 16:40 Arnaldo Carvalho de Melo
2016-11-24 4:10 ` Ingo Molnar
2016-06-27 21:01 Arnaldo Carvalho de Melo
2016-06-28 7:02 ` Ingo Molnar
2016-06-28 8:27 ` Jiri Olsa
2016-06-28 14:01 ` Arnaldo Carvalho de Melo
2016-06-28 14:12 ` Arnaldo Carvalho de Melo
2016-06-29 9:36 ` Ingo Molnar
2015-07-24 1:58 Arnaldo Carvalho de Melo
2015-07-27 15:58 ` Ingo Molnar
2015-05-18 15:50 Arnaldo Carvalho de Melo
2015-05-20 11:25 ` Ingo Molnar
2014-12-16 16:57 Arnaldo Carvalho de Melo
2014-12-17 14:50 ` Arnaldo Carvalho de Melo
2014-12-18 6:24 ` Ingo Molnar
2014-12-11 21:25 Arnaldo Carvalho de Melo
2014-12-12 8:10 ` Ingo Molnar
2014-11-06 21:04 Arnaldo Carvalho de Melo
2014-11-07 5:24 ` Ingo Molnar
2014-08-15 16:48 Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).