* [PATCH] [TRIVIAL] gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP'
@ 2014-04-04 7:59 Paul Bolle
2014-09-04 23:18 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2014-04-04 7:59 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested.
These two typos were introduced in commit 1425052097b5 ("gpio: add IRQ
chip helpers in gpiolib"), which has just been merged.
include/linux/gpio/driver.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 1827b43..8652ab7 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -102,7 +102,7 @@ struct gpio_chip {
#ifdef CONFIG_GPIOLIB_IRQCHIP
/*
- * With CONFIG_GPIO_IRQCHIP we get an irqchip inside the gpiolib
+ * With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib
* to handle IRQs for most practical cases.
*/
struct irq_chip *irqchip;
@@ -218,7 +218,7 @@ int gpiochip_irqchip_add(struct gpio_chip *gpiochip,
irq_flow_handler_t handler,
unsigned int type);
-#endif /* CONFIG_GPIO_IRQCHIP */
+#endif /* CONFIG_GPIOLIB_IRQCHIP */
#else /* CONFIG_GPIOLIB */
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [TRIVIAL] gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP'
2014-04-04 7:59 [PATCH] [TRIVIAL] gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP' Paul Bolle
@ 2014-09-04 23:18 ` Paul Bolle
2014-09-05 11:09 ` [PATCH] [RESEND] " Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2014-09-04 23:18 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel
Hi Jiri,
On Fri, 2014-04-04 at 09:59 +0200, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Untested.
>
> These two typos were introduced in commit 1425052097b5 ("gpio: add IRQ
> chip helpers in gpiolib"), which has just been merged.
>
> include/linux/gpio/driver.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 1827b43..8652ab7 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -102,7 +102,7 @@ struct gpio_chip {
>
> #ifdef CONFIG_GPIOLIB_IRQCHIP
> /*
> - * With CONFIG_GPIO_IRQCHIP we get an irqchip inside the gpiolib
> + * With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib
> * to handle IRQs for most practical cases.
> */
> struct irq_chip *irqchip;
> @@ -218,7 +218,7 @@ int gpiochip_irqchip_add(struct gpio_chip *gpiochip,
> irq_flow_handler_t handler,
> unsigned int type);
>
> -#endif /* CONFIG_GPIO_IRQCHIP */
> +#endif /* CONFIG_GPIOLIB_IRQCHIP */
>
> #else /* CONFIG_GPIOLIB */
Did you ever had a chance to look at this patch? It still applies to
next-20140904.
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] [RESEND] [TRIVIAL] gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP'
2014-09-04 23:18 ` Paul Bolle
@ 2014-09-05 11:09 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2014-09-05 11:09 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-kernel
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Resending at Jiri's request.
Build tested, actually (but only by building drivers/gpio/gpiolib.o).
These two typos were introduced in commit 1425052097b5 ("gpio: add IRQ
chip helpers in gpiolib").
include/linux/gpio/driver.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index a2de58fffd19..f8f6fae0b7c3 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -105,7 +105,7 @@ struct gpio_chip {
#ifdef CONFIG_GPIOLIB_IRQCHIP
/*
- * With CONFIG_GPIO_IRQCHIP we get an irqchip inside the gpiolib
+ * With CONFIG_GPIOLIB_IRQCHIP we get an irqchip inside the gpiolib
* to handle IRQs for most practical cases.
*/
struct irq_chip *irqchip;
@@ -164,7 +164,7 @@ int gpiochip_irqchip_add(struct gpio_chip *gpiochip,
irq_flow_handler_t handler,
unsigned int type);
-#endif /* CONFIG_GPIO_IRQCHIP */
+#endif /* CONFIG_GPIOLIB_IRQCHIP */
struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *chip, u16 hwnum,
const char *label);
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-05 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-04 7:59 [PATCH] [TRIVIAL] gpio: fix comment typos 'CONFIG_GPIO_IRQCHIP' Paul Bolle
2014-09-04 23:18 ` Paul Bolle
2014-09-05 11:09 ` [PATCH] [RESEND] " Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).