* Re: [PATCH] extcon: checkpatch warning removal
@ 2012-08-31 8:13 MyungJoo Ham
0 siblings, 0 replies; 2+ messages in thread
From: MyungJoo Ham @ 2012-08-31 8:13 UTC (permalink / raw)
To: anish kumar, 최찬우; +Cc: linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1337 bytes --]
> From: anish kumar <anish198519851985@gmail.com>
>
> without this patch we get below warning:
> WARNING: externs should be avoided in .c files
> 132: FILE: extcon/extcon-class.c:
> int extcon_set_state(struct extcon_dev *edev, u32 state);
>
> So just removed the declaration.
>
> Signed-off-by: anish kumar <anish198519851985@gmail.com>
Ah.. yes.. I thought removing it could emit compiler errors.
But, we have it declared in the header file. Good.
Thanks.
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/extcon/extcon-class.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
> index 06df95a..6f3391b 100644
> --- a/drivers/extcon/extcon-class.c
> +++ b/drivers/extcon/extcon-class.c
> @@ -129,7 +129,6 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
> return count;
> }
>
> -int extcon_set_state(struct extcon_dev *edev, u32 state);
> static ssize_t state_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t count)
> {
> --
> 1.7.1
>
>
>
>
>
>
>
>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] extcon: checkpatch warning removal
@ 2012-08-30 16:31 anish kumar
0 siblings, 0 replies; 2+ messages in thread
From: anish kumar @ 2012-08-30 16:31 UTC (permalink / raw)
To: cw00.choi, myungjoo.ham; +Cc: linux-kernel, anish kumar
From: anish kumar <anish198519851985@gmail.com>
without this patch we get below warning:
WARNING: externs should be avoided in .c files
132: FILE: extcon/extcon-class.c:
int extcon_set_state(struct extcon_dev *edev, u32 state);
So just removed the declaration.
Signed-off-by: anish kumar <anish198519851985@gmail.com>
---
drivers/extcon/extcon-class.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
index 06df95a..6f3391b 100644
--- a/drivers/extcon/extcon-class.c
+++ b/drivers/extcon/extcon-class.c
@@ -129,7 +129,6 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
return count;
}
-int extcon_set_state(struct extcon_dev *edev, u32 state);
static ssize_t state_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-31 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-31 8:13 [PATCH] extcon: checkpatch warning removal MyungJoo Ham
-- strict thread matches above, loose matches on Subject: below --
2012-08-30 16:31 anish kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).