linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Revert "percpu: free percpu allocation info for uniprocessor system"
@ 2014-09-21 22:04 Guenter Roeck
  2014-09-22  4:02 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2014-09-21 22:04 UTC (permalink / raw)
  To: linux-mm
  Cc: Christoph Lameter, linux-kernel, Guenter Roeck, Tejun Heo, Honggang Li

This reverts commit 3189eddbcafc ("percpu: free percpu allocation info for
uniprocessor system").

The commit causes a hang with a crisv32 image. This may be an architecture
problem, but at least for now the revert is necessary to be able to boot a
crisv32 image.

Fixes: 3189eddbcafc ("percpu: free percpu allocation info for uniprocessor system")
Cc: Tejun Heo <tj@kernel.org>
Cc: Honggang Li <enjoymindful@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
Resent as non-RFC patch per Tejun's request.

 mm/percpu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/percpu.c b/mm/percpu.c
index da997f9..2139e30 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -1932,8 +1932,6 @@ void __init setup_per_cpu_areas(void)
 
 	if (pcpu_setup_first_chunk(ai, fc) < 0)
 		panic("Failed to initialize percpu areas.");
-
-	pcpu_free_alloc_info(ai);
 }
 
 #endif	/* CONFIG_SMP */
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Revert "percpu: free percpu allocation info for uniprocessor system"
  2014-09-21 22:04 [PATCH] Revert "percpu: free percpu allocation info for uniprocessor system" Guenter Roeck
@ 2014-09-22  4:02 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-09-22  4:02 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-mm, Christoph Lameter, linux-kernel, Honggang Li

On Sun, Sep 21, 2014 at 03:04:53PM -0700, Guenter Roeck wrote:
> This reverts commit 3189eddbcafc ("percpu: free percpu allocation info for
> uniprocessor system").
> 
> The commit causes a hang with a crisv32 image. This may be an architecture
> problem, but at least for now the revert is necessary to be able to boot a
> crisv32 image.
> 
> Fixes: 3189eddbcafc ("percpu: free percpu allocation info for uniprocessor system")
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Honggang Li <enjoymindful@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Applied to percpu/for-3.18.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-22  4:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-21 22:04 [PATCH] Revert "percpu: free percpu allocation info for uniprocessor system" Guenter Roeck
2014-09-22  4:02 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).