* [PATCH] vfio/pci: Add missing linux/irq.h include
@ 2014-10-01 12:00 Thierry Reding
2014-10-01 17:14 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2014-10-01 12:00 UTC (permalink / raw)
To: Alex Williamson; +Cc: kvm, linux-kernel
From: Thierry Reding <treding@nvidia.com>
This code uses the irq_get_msi_desc() function whose prototype is in
linux/irq.h. Include this header to fix a build failure.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/vfio/pci/vfio_pci_intrs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index a068bb0d69e5..d6f097b0e0e3 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -15,6 +15,7 @@
#include <linux/device.h>
#include <linux/interrupt.h>
+#include <linux/irq.h>
#include <linux/eventfd.h>
#include <linux/msi.h>
#include <linux/pci.h>
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vfio/pci: Add missing linux/irq.h include
2014-10-01 12:00 [PATCH] vfio/pci: Add missing linux/irq.h include Thierry Reding
@ 2014-10-01 17:14 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2014-10-01 17:14 UTC (permalink / raw)
To: Thierry Reding; +Cc: kvm, linux-kernel
On Wed, 2014-10-01 at 14:00 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This code uses the irq_get_msi_desc() function whose prototype is in
> linux/irq.h. Include this header to fix a build failure.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/vfio/pci/vfio_pci_intrs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index a068bb0d69e5..d6f097b0e0e3 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -15,6 +15,7 @@
>
> #include <linux/device.h>
> #include <linux/interrupt.h>
> +#include <linux/irq.h>
> #include <linux/eventfd.h>
> #include <linux/msi.h>
> #include <linux/pci.h>
Hi Thierry, thanks for the patch. The call to irq_get_msi_desc()
actually came in as part of a conflict resolution in the next tree.
I've requested that the next spin of linux-next include this header if
the conflict still exists, but I'm also working to make the conflict go
away along with the function call that requires this additional header.
Thanks,
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-01 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-01 12:00 [PATCH] vfio/pci: Add missing linux/irq.h include Thierry Reding
2014-10-01 17:14 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).