linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] HSI: remove deprecated IRQF_DISABLED
  2014-10-01 20:28 [PATCH] HSI: remove deprecated IRQF_DISABLED Michael Opdenacker
@ 2014-09-12 14:40 ` Pavel Machek
  2014-10-02 20:19   ` Michael Opdenacker
  2014-10-03  2:23 ` Sebastian Reichel
  1 sibling, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2014-09-12 14:40 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: sre, linux-kernel

On Wed 2014-10-01 22:28:55, Michael Opdenacker wrote:
> Remove the use of the IRQF_DISABLED flag
> from drivers/hsi/clients/nokia-modem.c
> 
> It's a NOOP since 2.6.35 and it will be removed soon.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>

Acked-by: Pavel Machek <pavel@ucw.cz>



> --- a/drivers/hsi/clients/nokia-modem.c
> +++ b/drivers/hsi/clients/nokia-modem.c
> @@ -174,7 +174,7 @@ static int nokia_modem_probe(struct device *dev)
>  	tasklet_init(&modem->nokia_modem_rst_ind_tasklet,
>  			do_nokia_modem_rst_ind_tasklet, (unsigned long)modem);
>  	err = devm_request_irq(dev, irq, nokia_modem_rst_ind_isr,
> -				IRQF_DISABLED | pflags, "modem_rst_ind", modem);
> +				pflags, "modem_rst_ind", modem);
>  	if (err < 0) {
>  		dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n",
>  								irq, pflags);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] HSI: remove deprecated IRQF_DISABLED
@ 2014-10-01 20:28 Michael Opdenacker
  2014-09-12 14:40 ` Pavel Machek
  2014-10-03  2:23 ` Sebastian Reichel
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Opdenacker @ 2014-10-01 20:28 UTC (permalink / raw)
  To: sre; +Cc: pavel, linux-kernel, Michael Opdenacker

Remove the use of the IRQF_DISABLED flag
from drivers/hsi/clients/nokia-modem.c

It's a NOOP since 2.6.35 and it will be removed soon.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 drivers/hsi/clients/nokia-modem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index 363b780dacea..e43c3c9acec1 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -174,7 +174,7 @@ static int nokia_modem_probe(struct device *dev)
 	tasklet_init(&modem->nokia_modem_rst_ind_tasklet,
 			do_nokia_modem_rst_ind_tasklet, (unsigned long)modem);
 	err = devm_request_irq(dev, irq, nokia_modem_rst_ind_isr,
-				IRQF_DISABLED | pflags, "modem_rst_ind", modem);
+				pflags, "modem_rst_ind", modem);
 	if (err < 0) {
 		dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n",
 								irq, pflags);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] HSI: remove deprecated IRQF_DISABLED
  2014-09-12 14:40 ` Pavel Machek
@ 2014-10-02 20:19   ` Michael Opdenacker
  2014-10-02 21:13     ` Pavel Machek
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Opdenacker @ 2014-10-02 20:19 UTC (permalink / raw)
  To: Pavel Machek; +Cc: sre, linux-kernel

On 09/12/2014 04:40 PM, Pavel Machek wrote:
> On Wed 2014-10-01 22:28:55, Michael Opdenacker wrote:
>> Remove the use of the IRQF_DISABLED flag
>> from drivers/hsi/clients/nokia-modem.c
>>
>> It's a NOOP since 2.6.35 and it will be removed soon.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>

Thanks! Wow, you have a nice system date, writing from the past (Sep. 12).

Mike.


-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] HSI: remove deprecated IRQF_DISABLED
  2014-10-02 20:19   ` Michael Opdenacker
@ 2014-10-02 21:13     ` Pavel Machek
  0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2014-10-02 21:13 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: sre, linux-kernel

On Thu 2014-10-02 22:19:28, Michael Opdenacker wrote:
> On 09/12/2014 04:40 PM, Pavel Machek wrote:
> > On Wed 2014-10-01 22:28:55, Michael Opdenacker wrote:
> >> Remove the use of the IRQF_DISABLED flag
> >> from drivers/hsi/clients/nokia-modem.c
> >>
> >> It's a NOOP since 2.6.35 and it will be removed soon.
> >>
> >> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> Thanks! Wow, you have a nice system date, writing from the past (Sep. 12).

My TARDIS is better and better. Normally, I write from 1970 :-).

Why do all the great machines lack working RTC? Spitz, n900,
OLPC-1.75...

								Pavel

#!/bin/bash
F=/etc/zaurus.time
if [ $(date +%s) -lt $(< $F) ];
    then
    date -s @$(< $F)
    fi
date +%s > $F

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] HSI: remove deprecated IRQF_DISABLED
  2014-10-01 20:28 [PATCH] HSI: remove deprecated IRQF_DISABLED Michael Opdenacker
  2014-09-12 14:40 ` Pavel Machek
@ 2014-10-03  2:23 ` Sebastian Reichel
  1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2014-10-03  2:23 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: pavel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi,

On Wed, Oct 01, 2014 at 10:28:55PM +0200, Michael Opdenacker wrote:
> Remove the use of the IRQF_DISABLED flag
> from drivers/hsi/clients/nokia-modem.c
> 
> It's a NOOP since 2.6.35 and it will be removed soon.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=a26a42508157bc9fda89e3b1d64e47b9e4b55c30

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-03  2:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-01 20:28 [PATCH] HSI: remove deprecated IRQF_DISABLED Michael Opdenacker
2014-09-12 14:40 ` Pavel Machek
2014-10-02 20:19   ` Michael Opdenacker
2014-10-02 21:13     ` Pavel Machek
2014-10-03  2:23 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).