[PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Sylwester Nawrocki]

The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
("ARM: SAMSUNG: Remove remaining legacy code"). There are still
some references left, fix that by replacing them with ARCH_S5PV210.

Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
Reported-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Cc: <stable@vger.kernel.org>	[3.17+]
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v2:
 - updated the commit description.

 drivers/usb/host/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 82800a7..6f1d48e 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -220,7 +220,7 @@ config USB_EHCI_SH

 config USB_EHCI_EXYNOS
        tristate "EHCI support for Samsung S5P/EXYNOS SoC Series"
-       depends on PLAT_S5P || ARCH_EXYNOS
+       depends on ARCH_S5PV210 || ARCH_EXYNOS
        help
 	Enable support for the Samsung Exynos SOC's on-chip EHCI controller.

@@ -527,7 +527,7 @@ config USB_OHCI_SH

 config USB_OHCI_EXYNOS
 	tristate "OHCI support for Samsung S5P/EXYNOS SoC Series"
-	depends on PLAT_S5P || ARCH_EXYNOS
+	depends on ARCH_S5PV210 || ARCH_EXYNOS
 	help
 	 Enable support for the Samsung Exynos SOC's on-chip OHCI controller.

--
1.7.9.5

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Greg KH]

On Tue, Oct 07, 2014 at 11:12:07AM +0200, Sylwester Nawrocki wrote:
> The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
> ("ARM: SAMSUNG: Remove remaining legacy code"). There are still
> some references left, fix that by replacing them with ARCH_S5PV210.
> 
> Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> Cc: <stable@vger.kernel.org>	[3.17+]

This isn't a stable issue...

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Sylwester Nawrocki]

On 04/11/14 00:24, Greg KH wrote:
> On Tue, Oct 07, 2014 at 11:12:07AM +0200, Sylwester Nawrocki wrote:
>> > The PLAT_S5P Kconfig symbol was removed in commit d78c16ccde96
>> > ("ARM: SAMSUNG: Remove remaining legacy code"). There are still
>> > some references left, fix that by replacing them with ARCH_S5PV210.
>> > 
>> > Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
>> > Reported-by: Paul Bolle <pebolle@tiscali.nl>
>> > Acked-by: Jingoo Han <jg1.han@samsung.com>
>> > Cc: <stable@vger.kernel.org>	[3.17+]
>
> This isn't a stable issue...

Sorry for disturbing then, let me go and read the documentation again.

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Paul Bolle]

On Tue, 2014-11-04 at 19:33 +0100, Sylwester Nawrocki wrote:
> On 04/11/14 00:24, Greg KH wrote:
> > This isn't a stable issue...
> 
> Sorry for disturbing then, let me go and read the documentation again.

If I remember correctly, I asked Sylwester to mark this for stable. So
it's me that should be educated here.

Why is a patch that allows the users of ARCH_S5PV210 to set
USB_EHCI_EXYNOS or USB_OHCI_EXYNOS - which they apparently need - for a
v3.17.y kernel, not a stable issue?


Paul Bolle

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Greg KH]

On Tue, Nov 04, 2014 at 08:21:04PM +0100, Paul Bolle wrote:
> On Tue, 2014-11-04 at 19:33 +0100, Sylwester Nawrocki wrote:
> > On 04/11/14 00:24, Greg KH wrote:
> > > This isn't a stable issue...
> > 
> > Sorry for disturbing then, let me go and read the documentation again.
> 
> If I remember correctly, I asked Sylwester to mark this for stable. So
> it's me that should be educated here.
> 
> Why is a patch that allows the users of ARCH_S5PV210 to set
> USB_EHCI_EXYNOS or USB_OHCI_EXYNOS - which they apparently need - for a
> v3.17.y kernel, not a stable issue?

As it's something that no one seemed to ever need before (i.e. it's not
a regression fix), but it would be a "new feature", I don't think it's
really a stable fix.

But feel free to convince me otherwise :)

thanks,

greg k-h

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Paul Bolle]

On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote:
> As it's something that no one seemed to ever need before (i.e. it's not
> a regression fix), but it would be a "new feature", I don't think it's
> really a stable fix.
> 
> But feel free to convince me otherwise :)

Sylwester, was I right in thinking that users of PLAT_S5P, who could set
USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to
ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17?


Paul Bolle

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Sylwester Nawrocki]

On 04/11/14 20:52, Paul Bolle wrote:
> On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote:
>> > As it's something that no one seemed to ever need before (i.e. it's not
>> > a regression fix), but it would be a "new feature", I don't think it's
>> > really a stable fix.
>> > 
>> > But feel free to convince me otherwise :)
>
> Sylwester, was I right in thinking that users of PLAT_S5P, who could set
> USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to
> ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17?

Yes, after commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
we lost the ability to enable USB OHCI and EHCI on S5PV210 SoC.
Thus for those who use the mainline kernel (might be rare) with S5PV210 SoC
there is obviously a regression in USB subsystem in v3.17.


-- 
Regards,
Sylwester

Re: [PATCH v3] usb: Remove references to non-existent PLAT_S5P symbol

[Greg KH]

On Wed, Nov 05, 2014 at 11:23:36AM +0100, Sylwester Nawrocki wrote:
> On 04/11/14 20:52, Paul Bolle wrote:
> > On Tue, 2014-11-04 at 11:42 -0800, Greg KH wrote:
> >> > As it's something that no one seemed to ever need before (i.e. it's not
> >> > a regression fix), but it would be a "new feature", I don't think it's
> >> > really a stable fix.
> >> > 
> >> > But feel free to convince me otherwise :)
> >
> > Sylwester, was I right in thinking that users of PLAT_S5P, who could set
> > USB_EHCI_EXYNOS or USB_OHCI_EXYNOS pre v3.17, got, well, transferred to
> > ARCH_S5PV210 and lost the ability to set one of those symbols in v3.17?
> 
> Yes, after commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> we lost the ability to enable USB OHCI and EHCI on S5PV210 SoC.
> Thus for those who use the mainline kernel (might be rare) with S5PV210 SoC
> there is obviously a regression in USB subsystem in v3.17.

Ok, I'll add this to 3.17-stable when it hits Linus's tree, thanks.

greg k-h