* [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*()
@ 2014-10-23 8:16 Alexandre Courbot
2014-10-23 8:16 ` [PATCH] drm/panel: simple: " Alexandre Courbot
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Alexandre Courbot @ 2014-10-23 8:16 UTC (permalink / raw)
To: Thierry Reding; +Cc: dri-devel, linux-kernel, gnurou, Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and
remove any direction setting code afterwards.
Currently both forms (with or without the flags argument)
are valid thanks to transitional macros in
<linux/gpio/consumer.h>. These macros will be removed once
all consumers are updated and the flags argument will become
compulsary.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c
index b5217fe37f02..6427aa187735 100644
--- a/drivers/gpu/drm/panel/panel-s6e8aa0.c
+++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c
@@ -1019,17 +1019,12 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi)
return ret;
}
- ctx->reset_gpio = devm_gpiod_get(dev, "reset");
+ ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
if (IS_ERR(ctx->reset_gpio)) {
dev_err(dev, "cannot get reset-gpios %ld\n",
PTR_ERR(ctx->reset_gpio));
return PTR_ERR(ctx->reset_gpio);
}
- ret = gpiod_direction_output(ctx->reset_gpio, 1);
- if (ret < 0) {
- dev_err(dev, "cannot configure reset-gpios %d\n", ret);
- return ret;
- }
ctx->brightness = GAMMA_LEVEL_NUM - 1;
--
2.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drm/panel: simple: Update calls to gpiod_get*()
2014-10-23 8:16 [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*() Alexandre Courbot
@ 2014-10-23 8:16 ` Alexandre Courbot
2014-11-06 3:34 ` Alexandre Courbot
2014-11-06 8:52 ` Thierry Reding
2014-10-23 9:46 ` [PATCH] drm/panel: s6e8aa0: " Andrzej Hajda
2014-11-06 8:51 ` Thierry Reding
2 siblings, 2 replies; 7+ messages in thread
From: Alexandre Courbot @ 2014-10-23 8:16 UTC (permalink / raw)
To: Thierry Reding; +Cc: dri-devel, linux-kernel, gnurou, Alexandre Courbot
Add the new flags argument to calls of (devm_)gpiod_get*() and
remove any direction setting code afterwards.
Currently both forms (with or without the flags argument)
are valid thanks to transitional macros in
<linux/gpio/consumer.h>. These macros will be removed once
all consumers are updated and the flags argument will become
compulsary.
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
drivers/gpu/drm/panel/panel-simple.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 23de22f8c820..83d93062930d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -247,21 +247,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
if (IS_ERR(panel->supply))
return PTR_ERR(panel->supply);
- panel->enable_gpio = devm_gpiod_get_optional(dev, "enable");
+ panel->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+ GPIOD_OUT_LOW);
if (IS_ERR(panel->enable_gpio)) {
err = PTR_ERR(panel->enable_gpio);
dev_err(dev, "failed to request GPIO: %d\n", err);
return err;
}
- if (panel->enable_gpio) {
- err = gpiod_direction_output(panel->enable_gpio, 0);
- if (err < 0) {
- dev_err(dev, "failed to setup GPIO: %d\n", err);
- return err;
- }
- }
-
backlight = of_parse_phandle(dev->of_node, "backlight", 0);
if (backlight) {
panel->backlight = of_find_backlight_by_node(backlight);
--
2.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*()
2014-10-23 8:16 [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*() Alexandre Courbot
2014-10-23 8:16 ` [PATCH] drm/panel: simple: " Alexandre Courbot
@ 2014-10-23 9:46 ` Andrzej Hajda
2014-11-06 3:34 ` Alexandre Courbot
2014-11-06 8:51 ` Thierry Reding
2 siblings, 1 reply; 7+ messages in thread
From: Andrzej Hajda @ 2014-10-23 9:46 UTC (permalink / raw)
To: Alexandre Courbot, Thierry Reding; +Cc: gnurou, linux-kernel, dri-devel
On 10/23/2014 10:16 AM, Alexandre Courbot wrote:
> Add the new flags argument to calls of (devm_)gpiod_get*() and
> remove any direction setting code afterwards.
>
> Currently both forms (with or without the flags argument)
> are valid thanks to transitional macros in
> <linux/gpio/consumer.h>. These macros will be removed once
> all consumers are updated and the flags argument will become
> compulsary.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
It needs patch "gpio: Fix gpio direction flags not getting set" to work
correctly. It is not yet present in drm-next. Beside this:
Acked-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
> drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c b/drivers/gpu/drm/panel/panel-s6e8aa0.c
> index b5217fe37f02..6427aa187735 100644
> --- a/drivers/gpu/drm/panel/panel-s6e8aa0.c
> +++ b/drivers/gpu/drm/panel/panel-s6e8aa0.c
> @@ -1019,17 +1019,12 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi)
> return ret;
> }
>
> - ctx->reset_gpio = devm_gpiod_get(dev, "reset");
> + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> if (IS_ERR(ctx->reset_gpio)) {
> dev_err(dev, "cannot get reset-gpios %ld\n",
> PTR_ERR(ctx->reset_gpio));
> return PTR_ERR(ctx->reset_gpio);
> }
> - ret = gpiod_direction_output(ctx->reset_gpio, 1);
> - if (ret < 0) {
> - dev_err(dev, "cannot configure reset-gpios %d\n", ret);
> - return ret;
> - }
>
> ctx->brightness = GAMMA_LEVEL_NUM - 1;
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*()
2014-10-23 9:46 ` [PATCH] drm/panel: s6e8aa0: " Andrzej Hajda
@ 2014-11-06 3:34 ` Alexandre Courbot
0 siblings, 0 replies; 7+ messages in thread
From: Alexandre Courbot @ 2014-11-06 3:34 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Alexandre Courbot, Thierry Reding, Linux Kernel Mailing List, dri-devel
On Thu, Oct 23, 2014 at 6:46 PM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> On 10/23/2014 10:16 AM, Alexandre Courbot wrote:
>> Add the new flags argument to calls of (devm_)gpiod_get*() and
>> remove any direction setting code afterwards.
>>
>> Currently both forms (with or without the flags argument)
>> are valid thanks to transitional macros in
>> <linux/gpio/consumer.h>. These macros will be removed once
>> all consumers are updated and the flags argument will become
>> compulsary.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>
> It needs patch "gpio: Fix gpio direction flags not getting set" to work
> correctly. It is not yet present in drm-next. Beside this:
>
> Acked-by: Andrzej Hajda <a.hajda@samsung.com>
The required patch is now merged, can we go on with this patch?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/panel: simple: Update calls to gpiod_get*()
2014-10-23 8:16 ` [PATCH] drm/panel: simple: " Alexandre Courbot
@ 2014-11-06 3:34 ` Alexandre Courbot
2014-11-06 8:52 ` Thierry Reding
1 sibling, 0 replies; 7+ messages in thread
From: Alexandre Courbot @ 2014-11-06 3:34 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: Thierry Reding, dri-devel, Linux Kernel Mailing List
On Thu, Oct 23, 2014 at 5:16 PM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> Add the new flags argument to calls of (devm_)gpiod_get*() and
> remove any direction setting code afterwards.
>
> Currently both forms (with or without the flags argument)
> are valid thanks to transitional macros in
> <linux/gpio/consumer.h>. These macros will be removed once
> all consumers are updated and the flags argument will become
> compulsary.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Thierry, are you ok with this patch?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*()
2014-10-23 8:16 [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*() Alexandre Courbot
2014-10-23 8:16 ` [PATCH] drm/panel: simple: " Alexandre Courbot
2014-10-23 9:46 ` [PATCH] drm/panel: s6e8aa0: " Andrzej Hajda
@ 2014-11-06 8:51 ` Thierry Reding
2 siblings, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2014-11-06 8:51 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: dri-devel, linux-kernel, gnurou
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On Thu, Oct 23, 2014 at 05:16:57PM +0900, Alexandre Courbot wrote:
> Add the new flags argument to calls of (devm_)gpiod_get*() and
> remove any direction setting code afterwards.
>
> Currently both forms (with or without the flags argument)
> are valid thanks to transitional macros in
> <linux/gpio/consumer.h>. These macros will be removed once
> all consumers are updated and the flags argument will become
> compulsary.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> drivers/gpu/drm/panel/panel-s6e8aa0.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/panel: simple: Update calls to gpiod_get*()
2014-10-23 8:16 ` [PATCH] drm/panel: simple: " Alexandre Courbot
2014-11-06 3:34 ` Alexandre Courbot
@ 2014-11-06 8:52 ` Thierry Reding
1 sibling, 0 replies; 7+ messages in thread
From: Thierry Reding @ 2014-11-06 8:52 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: dri-devel, linux-kernel, gnurou
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Thu, Oct 23, 2014 at 05:16:58PM +0900, Alexandre Courbot wrote:
> Add the new flags argument to calls of (devm_)gpiod_get*() and
> remove any direction setting code afterwards.
>
> Currently both forms (with or without the flags argument)
> are valid thanks to transitional macros in
> <linux/gpio/consumer.h>. These macros will be removed once
> all consumers are updated and the flags argument will become
> compulsary.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-11-06 8:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-23 8:16 [PATCH] drm/panel: s6e8aa0: Update calls to gpiod_get*() Alexandre Courbot
2014-10-23 8:16 ` [PATCH] drm/panel: simple: " Alexandre Courbot
2014-11-06 3:34 ` Alexandre Courbot
2014-11-06 8:52 ` Thierry Reding
2014-10-23 9:46 ` [PATCH] drm/panel: s6e8aa0: " Andrzej Hajda
2014-11-06 3:34 ` Alexandre Courbot
2014-11-06 8:51 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).