* [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow
@ 2014-11-05 16:44 Andreas Färber
2014-11-05 17:09 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2014-11-05 16:44 UTC (permalink / raw)
To: Sangbeom Kim, alsa-devel
Cc: Liam Girdwood, Mark Brown, linux-samsung-soc, linux-arm-kernel,
Andreas Färber, Ben Dooks, Kukjin Kim, Jaroslav Kysela,
Takashi Iwai, open list
This enables the snd_soc_snow module to be auto-loaded.
Fixes: da5993df2374 ("ASoC: samsung: Add sound card driver for Snow board")
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
Tested using patches for Spring, but should apply to Snow/Peach-pi equally.
Rebased onto sound.git for-next branch.
sound/soc/samsung/snow.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c
index 0acf5d0eed53..72118a77dd5b 100644
--- a/sound/soc/samsung/snow.c
+++ b/sound/soc/samsung/snow.c
@@ -110,6 +110,7 @@ static const struct of_device_id snow_of_match[] = {
{ .compatible = "google,snow-audio-max98095", },
{},
};
+MODULE_DEVICE_TABLE(of, snow_of_match);
static struct platform_driver snow_driver = {
.driver = {
--
2.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow
2014-11-05 16:44 [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow Andreas Färber
@ 2014-11-05 17:09 ` Mark Brown
2014-11-05 18:11 ` Andreas Färber
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2014-11-05 17:09 UTC (permalink / raw)
To: Andreas Färber
Cc: Sangbeom Kim, alsa-devel, Liam Girdwood, linux-samsung-soc,
linux-arm-kernel, Ben Dooks, Kukjin Kim, Jaroslav Kysela,
Takashi Iwai, open list
[-- Attachment #1: Type: text/plain, Size: 144 bytes --]
On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
> This enables the snd_soc_snow module to be auto-loaded.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow
2014-11-05 17:09 ` Mark Brown
@ 2014-11-05 18:11 ` Andreas Färber
2014-11-05 18:44 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2014-11-05 18:11 UTC (permalink / raw)
To: Mark Brown
Cc: Sangbeom Kim, alsa-devel, Liam Girdwood, linux-samsung-soc,
linux-arm-kernel, Ben Dooks, Kukjin Kim, Jaroslav Kysela,
Takashi Iwai, LKML
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
Am 05.11.2014 um 18:09 schrieb Mark Brown:
> On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
>> This enables the snd_soc_snow module to be auto-loaded.
>
> Applied, thanks.
Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks
for. When do I need it and when should I leave it out? I thought it
tells GregKH more precisely which stable branches are affected for
backports than just a CC.
Regards,
Andreas
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow
2014-11-05 18:11 ` Andreas Färber
@ 2014-11-05 18:44 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-11-05 18:44 UTC (permalink / raw)
To: Andreas Färber
Cc: Sangbeom Kim, alsa-devel, Liam Girdwood, linux-samsung-soc,
linux-arm-kernel, Ben Dooks, Kukjin Kim, Jaroslav Kysela,
Takashi Iwai, LKML
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, Nov 05, 2014 at 07:11:06PM +0100, Andreas Färber wrote:
> Am 05.11.2014 um 18:09 schrieb Mark Brown:
> > On Wed, Nov 05, 2014 at 05:44:52PM +0100, Andreas Färber wrote:
> >> This enables the snd_soc_snow module to be auto-loaded.
> > Applied, thanks.
> Thanks. I notice you dropped my Fixes: line that SubmittingPatches asks
> for. When do I need it and when should I leave it out? I thought it
> tells GregKH more precisely which stable branches are affected for
> backports than just a CC.
It's not really adding anything if it's just identifying the patch that
created the file in the first place and what actually happened here is
that I applied it without the tag then later went back and decided to
add a stable Cc since it was probably worth that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-05 18:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-05 16:44 [PATCH] ASoC: samsung: Add MODULE_DEVICE_TABLE for Snow Andreas Färber
2014-11-05 17:09 ` Mark Brown
2014-11-05 18:11 ` Andreas Färber
2014-11-05 18:44 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).