linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] usb: gadget: at91_udc: remove unused release function
@ 2014-11-19  9:19 Bo Shen
  2014-11-19  9:19 ` [PATCH 2/2] usb: gadget: atmel_usba_udc: remove " Bo Shen
  0 siblings, 1 reply; 2+ messages in thread
From: Bo Shen @ 2014-11-19  9:19 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: nicolas.ferre, Greg Kroah-Hartman, linux-arm-kernel, linux-usb,
	linux-kernel, Bo Shen

As the driver call usb_add_gadget_udc --> usb_add_gadget_udc_release
with NULL as release parameter, so it will use usb_udc_no_release.
So, the release in driver won't used, remove it.

And at the same time, in the usb_add_gadget_udc_release will set the
gadget name, so remove it also in driver.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
 drivers/usb/gadget/udc/at91_udc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
index 9968f53..b179ab1 100644
--- a/drivers/usb/gadget/udc/at91_udc.c
+++ b/drivers/usb/gadget/udc/at91_udc.c
@@ -1512,20 +1512,11 @@ static irqreturn_t at91_udc_irq (int irq, void *_udc)
 
 /*-------------------------------------------------------------------------*/
 
-static void nop_release(struct device *dev)
-{
-	/* nothing to free */
-}
-
 static struct at91_udc controller = {
 	.gadget = {
 		.ops	= &at91_udc_ops,
 		.ep0	= &controller.ep[0].ep,
 		.name	= driver_name,
-		.dev	= {
-			.init_name = "gadget",
-			.release = nop_release,
-		}
 	},
 	.ep[0] = {
 		.ep = {
-- 
2.1.0.24.g4109c28


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 2/2] usb: gadget: atmel_usba_udc: remove release function
  2014-11-19  9:19 [PATCH 1/2] usb: gadget: at91_udc: remove unused release function Bo Shen
@ 2014-11-19  9:19 ` Bo Shen
  0 siblings, 0 replies; 2+ messages in thread
From: Bo Shen @ 2014-11-19  9:19 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: nicolas.ferre, Greg Kroah-Hartman, linux-arm-kernel, linux-usb,
	linux-kernel, Bo Shen

As the driver call usb_add_gadget_udc --> usb_add_gadget_udc_release
with NULL as release parameter, so it will use usb_udc_no_release.
So, the release in driver won't used, remove it.

And at the same time, in the usb_add_gadget_udc_release will set the
gadget name, so remove it also in driver.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 1529926..8c29d09 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -1007,19 +1007,10 @@ static struct usb_endpoint_descriptor usba_ep0_desc = {
 	.bInterval = 1,
 };
 
-static void nop_release(struct device *dev)
-{
-
-}
-
 static struct usb_gadget usba_gadget_template = {
 	.ops		= &usba_udc_ops,
 	.max_speed	= USB_SPEED_HIGH,
 	.name		= "atmel_usba_udc",
-	.dev	= {
-		.init_name	= "gadget",
-		.release	= nop_release,
-	},
 };
 
 /*
-- 
2.1.0.24.g4109c28


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-19  9:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-19  9:19 [PATCH 1/2] usb: gadget: at91_udc: remove unused release function Bo Shen
2014-11-19  9:19 ` [PATCH 2/2] usb: gadget: atmel_usba_udc: remove " Bo Shen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).