* [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)
@ 2014-11-30 10:58 Anjana Sasindran
2014-12-01 8:17 ` Hans Verkuil
2014-12-01 8:50 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Anjana Sasindran @ 2014-11-30 10:58 UTC (permalink / raw)
To: gregkh, joe, m.chehab, hans.verkuil; +Cc: linux-kernel, devel, Anjana Sasindran
This patch fix a checkpatch.pl error:
ERROR: space prohibited before ')' parenthesis closing
Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
---
drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h
index 0286c95..9490595 100644
--- a/drivers/staging/media/omap24xx/v4l2-int-device.h
+++ b/drivers/staging/media/omap24xx/v4l2-int-device.h
@@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *);
V4L2_INT_WRAPPER_0(dev_init);
V4L2_INT_WRAPPER_0(dev_exit);
-V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, );
+V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *);
V4L2_INT_WRAPPER_1(g_priv, void, *);
V4L2_INT_WRAPPER_1(g_ifparm, struct v4l2_ifparm, *);
V4L2_INT_WRAPPER_1(g_needs_reset, void, *);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)
2014-11-30 10:58 [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing) Anjana Sasindran
@ 2014-12-01 8:17 ` Hans Verkuil
2014-12-01 8:50 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2014-12-01 8:17 UTC (permalink / raw)
To: Anjana Sasindran, gregkh, joe, m.chehab, hans.verkuil; +Cc: linux-kernel, devel
On 11/30/2014 11:58 AM, Anjana Sasindran wrote:
> This patch fix a checkpatch.pl error:
>
> ERROR: space prohibited before ')' parenthesis closing
>
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
Thanks for the patch, but this driver is removed in kernel 3.19.
So there is no point in patching it.
Regards,
Hans
> ---
> drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h
> index 0286c95..9490595 100644
> --- a/drivers/staging/media/omap24xx/v4l2-int-device.h
> +++ b/drivers/staging/media/omap24xx/v4l2-int-device.h
> @@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *);
>
> V4L2_INT_WRAPPER_0(dev_init);
> V4L2_INT_WRAPPER_0(dev_exit);
> -V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, );
> +V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *);
> V4L2_INT_WRAPPER_1(g_priv, void, *);
> V4L2_INT_WRAPPER_1(g_ifparm, struct v4l2_ifparm, *);
> V4L2_INT_WRAPPER_1(g_needs_reset, void, *);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)
2014-11-30 10:58 [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing) Anjana Sasindran
2014-12-01 8:17 ` Hans Verkuil
@ 2014-12-01 8:50 ` Dan Carpenter
[not found] ` <CABU2W3oMGH9v0+mjw+s+nRpbOj7pxdVvdMWhnmNgEwKPJ2VSmg@mail.gmail.com>
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-12-01 8:50 UTC (permalink / raw)
To: Anjana Sasindran; +Cc: gregkh, joe, m.chehab, hans.verkuil, devel, linux-kernel
On Sun, Nov 30, 2014 at 04:28:02PM +0530, Anjana Sasindran wrote:
> This patch fix a checkpatch.pl error:
>
> ERROR: space prohibited before ')' parenthesis closing
>
> Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com>
> ---
> drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h
> index 0286c95..9490595 100644
> --- a/drivers/staging/media/omap24xx/v4l2-int-device.h
> +++ b/drivers/staging/media/omap24xx/v4l2-int-device.h
> @@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *);
>
> V4L2_INT_WRAPPER_0(dev_init);
> V4L2_INT_WRAPPER_0(dev_exit);
> -V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, );
> +V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *);
Wait, what? The changelog for this is not clear. This looks like
either a bug fix or a bug introducer.
This driver has been deleted in linux-next anyway so I guess it doesn't
matter. Please work against linux-next.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)
[not found] ` <CABU2W3oMGH9v0+mjw+s+nRpbOj7pxdVvdMWhnmNgEwKPJ2VSmg@mail.gmail.com>
@ 2014-12-01 13:06 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2014-12-01 13:06 UTC (permalink / raw)
To: anjana s, Dan Carpenter
Cc: Greg KH, joe, m.chehab, hans.verkuil, devel, linux-kernel
On 12/01/2014 02:01 PM, anjana s wrote:
> Should I do anything on this further?
No. The driver will disappear in 3.19, so there is no point to this patch.
BTW, always check the Kconfig to see if a staging driver is marked deprecated.
If so, then patches are pointless.
Regards,
Hans
> Looking forward to hear from you.
>
> On Mon, Dec 1, 2014 at 2:20 PM, Dan Carpenter <dan.carpenter@oracle.com <mailto:dan.carpenter@oracle.com>> wrote:
>
> On Sun, Nov 30, 2014 at 04:28:02PM +0530, Anjana Sasindran wrote:
> > This patch fix a checkpatch.pl <http://checkpatch.pl> error:
> >
> > ERROR: space prohibited before ')' parenthesis closing
> >
> > Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com <mailto:anjanasasindran123@gmail.com>>
> > ---
> > drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h
> > index 0286c95..9490595 100644
> > --- a/drivers/staging/media/omap24xx/v4l2-int-device.h
> > +++ b/drivers/staging/media/omap24xx/v4l2-int-device.h
> > @@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *);
> >
> > V4L2_INT_WRAPPER_0(dev_init);
> > V4L2_INT_WRAPPER_0(dev_exit);
> > -V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, );
> > +V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *);
>
> Wait, what? The changelog for this is not clear. This looks like
> either a bug fix or a bug introducer.
>
> This driver has been deleted in linux-next anyway so I guess it doesn't
> matter. Please work against linux-next.
>
> regards,
> dan carpenter
>
>
>
>
> --
> Anjana S
> Amrita School of Engineering
> anjanasasindran123@gmail.com <mailto:anjanasasindran123@gmail.com>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-01 13:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-30 10:58 [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing) Anjana Sasindran
2014-12-01 8:17 ` Hans Verkuil
2014-12-01 8:50 ` Dan Carpenter
[not found] ` <CABU2W3oMGH9v0+mjw+s+nRpbOj7pxdVvdMWhnmNgEwKPJ2VSmg@mail.gmail.com>
2014-12-01 13:06 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).