* [PATCH] sched/fair: tiny clearup of -1
@ 2014-12-05 6:02 jun.zhang
2014-12-05 21:32 ` Greg Kroah-Hartman
2014-12-15 16:59 ` Peter Zijlstra
0 siblings, 2 replies; 3+ messages in thread
From: jun.zhang @ 2014-12-05 6:02 UTC (permalink / raw)
To: mingo, peterz
Cc: linux-kernel, zhang jun, Chuansheng Liu, Changcheng Liu,
Greg Kroah-Hartman, Hillf Danton, Vincent Guittot
From: zhang jun <jun.zhang@intel.com>
find_idlest_cpu don't return -1, so clearup it.
Signed-off-by: zhang jun <jun.zhang@intel.com>
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ef2b104..bbf965f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4596,7 +4596,7 @@ select_task_rq_fair(struct task_struct *p, int prev_cpu, int sd_flag, int wake_f
}
new_cpu = find_idlest_cpu(group, p, cpu);
- if (new_cpu == -1 || new_cpu == cpu) {
+ if (new_cpu == cpu) {
/* Now try balancing at a lower domain level of cpu */
sd = sd->child;
continue;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/fair: tiny clearup of -1
2014-12-05 6:02 [PATCH] sched/fair: tiny clearup of -1 jun.zhang
@ 2014-12-05 21:32 ` Greg Kroah-Hartman
2014-12-15 16:59 ` Peter Zijlstra
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-12-05 21:32 UTC (permalink / raw)
To: jun.zhang
Cc: mingo, peterz, linux-kernel, Chuansheng Liu, Changcheng Liu,
Hillf Danton, Vincent Guittot
On Fri, Dec 05, 2014 at 02:02:45PM +0800, jun.zhang@intel.com wrote:
> From: zhang jun <jun.zhang@intel.com>
>
> find_idlest_cpu don't return -1, so clearup it.
>
> Signed-off-by: zhang jun <jun.zhang@intel.com>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Why me? I don't care about this file...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/fair: tiny clearup of -1
2014-12-05 6:02 [PATCH] sched/fair: tiny clearup of -1 jun.zhang
2014-12-05 21:32 ` Greg Kroah-Hartman
@ 2014-12-15 16:59 ` Peter Zijlstra
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2014-12-15 16:59 UTC (permalink / raw)
To: jun.zhang
Cc: mingo, linux-kernel, Chuansheng Liu, Changcheng Liu,
Greg Kroah-Hartman, Hillf Danton, Vincent Guittot
On Fri, Dec 05, 2014 at 02:02:45PM +0800, jun.zhang@intel.com wrote:
> From: zhang jun <jun.zhang@intel.com>
>
> find_idlest_cpu don't return -1, so clearup it.
'clean it up' perhaps?
> Signed-off-by: zhang jun <jun.zhang@intel.com>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
Invalid SoB chain.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-15 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-05 6:02 [PATCH] sched/fair: tiny clearup of -1 jun.zhang
2014-12-05 21:32 ` Greg Kroah-Hartman
2014-12-15 16:59 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).