* [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
@ 2014-12-20 8:55 Gangadhar
2014-12-20 9:10 ` Jeremiah Mahler
2014-12-20 9:14 ` Jeremiah Mahler
0 siblings, 2 replies; 7+ messages in thread
From: Gangadhar @ 2014-12-20 8:55 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, gangadharv
From: gangadharv <gangs.freelancer@gmail.com>
Fixed a Coding style issue.
Signed-off-by: Gangadhar V <gangs.freelancer@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index d61842e..da19145 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
tx_ra_bitmap |= ((raid<<28)&0xf0000000);
DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
- __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
+ __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
/* bitmap[0:27] = tx_rate_bitmap */
/* bitmap[28:31]= Rate Adaptive id */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
2014-12-20 8:55 [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue Gangadhar
@ 2014-12-20 9:10 ` Jeremiah Mahler
2014-12-20 9:14 ` Jeremiah Mahler
1 sibling, 0 replies; 7+ messages in thread
From: Jeremiah Mahler @ 2014-12-20 9:10 UTC (permalink / raw)
To: Gangadhar; +Cc: gregkh, linux-kernel
Gangadhar,
On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> From: gangadharv <gangs.freelancer@gmail.com>
>
> Fixed a Coding style issue.
>
> Signed-off-by: Gangadhar V <gangs.freelancer@gmail.com>
Your Signed-off-by doesn't much your From line.
Also, is this the full name you would use to sign off with on
legal documents?
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index d61842e..da19145 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
> tx_ra_bitmap |= ((raid<<28)&0xf0000000);
>
> DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
> - __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
> + __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
>
> /* bitmap[0:27] = tx_rate_bitmap */
> /* bitmap[28:31]= Rate Adaptive id */
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
2014-12-20 8:55 [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue Gangadhar
2014-12-20 9:10 ` Jeremiah Mahler
@ 2014-12-20 9:14 ` Jeremiah Mahler
2014-12-20 9:43 ` Gangadhar V
1 sibling, 1 reply; 7+ messages in thread
From: Jeremiah Mahler @ 2014-12-20 9:14 UTC (permalink / raw)
To: Gangadhar; +Cc: gregkh, linux-kernel
Gangadhar,
On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> From: gangadharv <gangs.freelancer@gmail.com>
>
> Fixed a Coding style issue.
The description needs to be more specific? What type of issue did you
fix? How did you find this issue?
[...]
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
2014-12-20 9:14 ` Jeremiah Mahler
@ 2014-12-20 9:43 ` Gangadhar V
2014-12-20 9:50 ` Jeremiah Mahler
0 siblings, 1 reply; 7+ messages in thread
From: Gangadhar V @ 2014-12-20 9:43 UTC (permalink / raw)
To: Jeremiah Mahler, Gangadhar, gregkh, linux-kernel
Hi,
It is Space coding Style issue which i found when running
checkpatch.pl script on rtw_ap.c.
--Gangadhar V
On Sat, Dec 20, 2014 at 2:44 PM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> Gangadhar,
>
> On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
>> From: gangadharv <gangs.freelancer@gmail.com>
>>
>> Fixed a Coding style issue.
>
> The description needs to be more specific? What type of issue did you
> fix? How did you find this issue?
>
> [...]
>
> --
> - Jeremiah Mahler
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
2014-12-20 9:43 ` Gangadhar V
@ 2014-12-20 9:50 ` Jeremiah Mahler
0 siblings, 0 replies; 7+ messages in thread
From: Jeremiah Mahler @ 2014-12-20 9:50 UTC (permalink / raw)
To: Gangadhar V; +Cc: gregkh, linux-kernel
Gangadhar,
On Sat, Dec 20, 2014 at 03:13:10PM +0530, Gangadhar V wrote:
> Hi,
> It is Space coding Style issue which i found when running
> checkpatch.pl script on rtw_ap.c.
>
> --Gangadhar V
> On Sat, Dec 20, 2014 at 2:44 PM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> > Gangadhar,
> >
> > On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> >> From: gangadharv <gangs.freelancer@gmail.com>
> >>
> >> Fixed a Coding style issue.
> >
> > The description needs to be more specific? What type of issue did you
> > fix? How did you find this issue?
> >
Good, now describe this in the log message and submit a second
version of the patch.
> > [...]
> >
> > --
> > - Jeremiah Mahler
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
@ 2014-12-20 10:05 Gangadhar V
2014-12-20 10:30 ` Jeremiah Mahler
0 siblings, 1 reply; 7+ messages in thread
From: Gangadhar V @ 2014-12-20 10:05 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Gangadhar V
Fixed a Space Coding style issue which was found when running checkpatch.pl script
on rtw_ap.c.
Signed-off-by: Gangadhar V <gangs.freelancer@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index d61842e..da19145 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
tx_ra_bitmap |= ((raid<<28)&0xf0000000);
DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
- __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
+ __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
/* bitmap[0:27] = tx_rate_bitmap */
/* bitmap[28:31]= Rate Adaptive id */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
2014-12-20 10:05 Gangadhar V
@ 2014-12-20 10:30 ` Jeremiah Mahler
0 siblings, 0 replies; 7+ messages in thread
From: Jeremiah Mahler @ 2014-12-20 10:30 UTC (permalink / raw)
To: Gangadhar V; +Cc: gregkh, linux-kernel
Gangadhar,
It is looking better but it still needs some work :)
Be sure to add a version number to your subject line when you release
a new version of your patch so reviewers know it is not an entirely
new patch.
[PATCH v2]
'git format-patch' will do this automatically with the '-v' option if you
are using that.
Also in the subject line, tags shouldn't include spaces.
e.g. 'rtl8188eu:' not 'rtl8188eu :'.
You don't need to include the file name ('rtw_ap.c') in the subject
line.
On Sat, Dec 20, 2014 at 03:35:34PM +0530, Gangadhar V wrote:
> Fixed a Space Coding style issue which was found when running checkpatch.pl script
> on rtw_ap.c.
Log messages should be less than 80 characters wide. I like to use 72
so that it doesn't wrap even after several replies.
>
> Signed-off-by: Gangadhar V <gangs.freelancer@gmail.com>
Is this your full legal name? Is your last name 'V'?
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index d61842e..da19145 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
> tx_ra_bitmap |= ((raid<<28)&0xf0000000);
>
> DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
> - __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
> + __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
This looks reasonable. There are only two checkpatch errors and you
fixed them both.
>
> /* bitmap[0:27] = tx_rate_bitmap */
> /* bitmap[28:31]= Rate Adaptive id */
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Time for version 3! :)
--
- Jeremiah Mahler
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-12-20 10:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-20 8:55 [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue Gangadhar
2014-12-20 9:10 ` Jeremiah Mahler
2014-12-20 9:14 ` Jeremiah Mahler
2014-12-20 9:43 ` Gangadhar V
2014-12-20 9:50 ` Jeremiah Mahler
2014-12-20 10:05 Gangadhar V
2014-12-20 10:30 ` Jeremiah Mahler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).