* [PATCH] infiniband: hw: ipath: ipath_wc_ppc64.c: Remove unused function
@ 2014-12-20 16:19 Rickard Strandqvist
2015-01-16 14:42 ` Marciniszyn, Mike
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-12-20 16:19 UTC (permalink / raw)
To: Mike Marciniszyn, Roland Dreier
Cc: Rickard Strandqvist, Sean Hefty, Hal Rosenstock, linux-rdma,
linux-kernel
Remove the function ipath_unordered_wc() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/infiniband/hw/ipath/ipath_kernel.h | 3 ---
drivers/infiniband/hw/ipath/ipath_wc_ppc64.c | 13 -------------
drivers/infiniband/hw/ipath/ipath_wc_x86_64.c | 15 ---------------
3 files changed, 31 deletions(-)
diff --git a/drivers/infiniband/hw/ipath/ipath_kernel.h b/drivers/infiniband/hw/ipath/ipath_kernel.h
index 6559af6..e08db70 100644
--- a/drivers/infiniband/hw/ipath/ipath_kernel.h
+++ b/drivers/infiniband/hw/ipath/ipath_kernel.h
@@ -908,9 +908,6 @@ void ipath_chip_cleanup(struct ipath_devdata *);
/* clean up any chip type-specific stuff */
void ipath_chip_done(void);
-/* check to see if we have to force ordering for write combining */
-int ipath_unordered_wc(void);
-
void ipath_disarm_piobufs(struct ipath_devdata *, unsigned first,
unsigned cnt);
void ipath_cancel_sends(struct ipath_devdata *, int);
diff --git a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c b/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c
index 1d7bd82..1a7e20a 100644
--- a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c
+++ b/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c
@@ -47,16 +47,3 @@ int ipath_enable_wc(struct ipath_devdata *dd)
{
return 0;
}
-
-/**
- * ipath_unordered_wc - indicate whether write combining is unordered
- *
- * Because our performance depends on our ability to do write
- * combining mmio writes in the most efficient way, we need to
- * know if we are on a processor that may reorder stores when
- * write combining.
- */
-int ipath_unordered_wc(void)
-{
- return 1;
-}
diff --git a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c b/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c
index 3428acb..4ad0b93 100644
--- a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c
+++ b/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c
@@ -167,18 +167,3 @@ void ipath_disable_wc(struct ipath_devdata *dd)
dd->ipath_wc_cookie = 0; /* even on failure */
}
}
-
-/**
- * ipath_unordered_wc - indicate whether write combining is ordered
- *
- * Because our performance depends on our ability to do write combining mmio
- * writes in the most efficient way, we need to know if we are on an Intel
- * or AMD x86_64 processor. AMD x86_64 processors flush WC buffers out in
- * the order completed, and so no special flushing is required to get
- * correct ordering. Intel processors, however, will flush write buffers
- * out in "random" orders, and so explicit ordering is needed at times.
- */
-int ipath_unordered_wc(void)
-{
- return boot_cpu_data.x86_vendor != X86_VENDOR_AMD;
-}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] infiniband: hw: ipath: ipath_wc_ppc64.c: Remove unused function
2014-12-20 16:19 [PATCH] infiniband: hw: ipath: ipath_wc_ppc64.c: Remove unused function Rickard Strandqvist
@ 2015-01-16 14:42 ` Marciniszyn, Mike
0 siblings, 0 replies; 2+ messages in thread
From: Marciniszyn, Mike @ 2015-01-16 14:42 UTC (permalink / raw)
To: Rickard Strandqvist, infinipath, Roland Dreier
Cc: Hefty, Sean, Hal Rosenstock, linux-rdma, linux-kernel
> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-
> owner@vger.kernel.org] On Behalf Of Rickard Strandqvist
> Sent: Saturday, December 20, 2014 11:19 AM
> To: infinipath; Roland Dreier
> Cc: Rickard Strandqvist; Hefty, Sean; Hal Rosenstock; linux-
> rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] infiniband: hw: ipath: ipath_wc_ppc64.c: Remove unused
> function
>
Roland,
Can you change in summary from https://patchwork.kernel.org/patch/5522791:
IB/ipath: Remove unused function in ipath_wc_ppc64
Thanks for the patch!
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-16 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-20 16:19 [PATCH] infiniband: hw: ipath: ipath_wc_ppc64.c: Remove unused function Rickard Strandqvist
2015-01-16 14:42 ` Marciniszyn, Mike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).