* [PATCH] usb: gadget: udc: s3c2410_udc.c: Remove some unused functions
@ 2014-12-20 22:30 Rickard Strandqvist
2014-12-22 9:02 ` Vasily Khoruzhick
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-12-20 22:30 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: Rickard Strandqvist, Robert Baldyga, Sachin Kamat, Michal Sojka,
Vasily Khoruzhick, Arnd Bergmann, linux-usb, linux-kernel
Removes some functions that are not used anywhere:
s3c2410_udc_clear_ep_state() s3c2410_udc_set_ep0_sse_out()
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/usb/gadget/udc/s3c2410_udc.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
index ff423d1..41b60cd 100644
--- a/drivers/usb/gadget/udc/s3c2410_udc.c
+++ b/drivers/usb/gadget/udc/s3c2410_udc.c
@@ -238,14 +238,6 @@ static inline void s3c2410_udc_set_ep0_de_out(void __iomem *base)
S3C2410_UDC_EP0_CSR_REG);
}
-static inline void s3c2410_udc_set_ep0_sse_out(void __iomem *base)
-{
- udc_writeb(base, S3C2410_UDC_INDEX_EP0, S3C2410_UDC_INDEX_REG);
- udc_writeb(base, (S3C2410_UDC_EP0_CSR_SOPKTRDY
- | S3C2410_UDC_EP0_CSR_SSE),
- S3C2410_UDC_EP0_CSR_REG);
-}
-
static inline void s3c2410_udc_set_ep0_de_in(void __iomem *base)
{
udc_writeb(base, S3C2410_UDC_INDEX_EP0, S3C2410_UDC_INDEX_REG);
@@ -291,18 +283,6 @@ static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
}
}
-static inline void s3c2410_udc_clear_ep_state(struct s3c2410_udc *dev)
-{
- unsigned i;
-
- /* hardware SET_{CONFIGURATION,INTERFACE} automagic resets endpoint
- * fifos, and pending transactions mustn't be continued in any case.
- */
-
- for (i = 1; i < S3C2410_ENDPOINTS; i++)
- s3c2410_udc_nuke(dev, &dev->ep[i], -ECONNABORTED);
-}
-
static inline int s3c2410_udc_fifo_count_out(void)
{
int tmp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: udc: s3c2410_udc.c: Remove some unused functions
2014-12-20 22:30 [PATCH] usb: gadget: udc: s3c2410_udc.c: Remove some unused functions Rickard Strandqvist
@ 2014-12-22 9:02 ` Vasily Khoruzhick
0 siblings, 0 replies; 2+ messages in thread
From: Vasily Khoruzhick @ 2014-12-22 9:02 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Felipe Balbi, Greg Kroah-Hartman, Robert Baldyga, Sachin Kamat,
Michal Sojka, Arnd Bergmann, linux-usb, linux-kernel
On Sun, Dec 21, 2014 at 1:30 AM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Removes some functions that are not used anywhere:
> s3c2410_udc_clear_ep_state() s3c2410_udc_set_ep0_sse_out()
>
> This was partially found by using a static code analysis program called cppcheck.
Looks OK to me.
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/usb/gadget/udc/s3c2410_udc.c | 20 --------------------
> 1 file changed, 20 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
> index ff423d1..41b60cd 100644
> --- a/drivers/usb/gadget/udc/s3c2410_udc.c
> +++ b/drivers/usb/gadget/udc/s3c2410_udc.c
> @@ -238,14 +238,6 @@ static inline void s3c2410_udc_set_ep0_de_out(void __iomem *base)
> S3C2410_UDC_EP0_CSR_REG);
> }
>
> -static inline void s3c2410_udc_set_ep0_sse_out(void __iomem *base)
> -{
> - udc_writeb(base, S3C2410_UDC_INDEX_EP0, S3C2410_UDC_INDEX_REG);
> - udc_writeb(base, (S3C2410_UDC_EP0_CSR_SOPKTRDY
> - | S3C2410_UDC_EP0_CSR_SSE),
> - S3C2410_UDC_EP0_CSR_REG);
> -}
> -
> static inline void s3c2410_udc_set_ep0_de_in(void __iomem *base)
> {
> udc_writeb(base, S3C2410_UDC_INDEX_EP0, S3C2410_UDC_INDEX_REG);
> @@ -291,18 +283,6 @@ static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
> }
> }
>
> -static inline void s3c2410_udc_clear_ep_state(struct s3c2410_udc *dev)
> -{
> - unsigned i;
> -
> - /* hardware SET_{CONFIGURATION,INTERFACE} automagic resets endpoint
> - * fifos, and pending transactions mustn't be continued in any case.
> - */
> -
> - for (i = 1; i < S3C2410_ENDPOINTS; i++)
> - s3c2410_udc_nuke(dev, &dev->ep[i], -ECONNABORTED);
> -}
> -
> static inline int s3c2410_udc_fifo_count_out(void)
> {
> int tmp;
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-22 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-20 22:30 [PATCH] usb: gadget: udc: s3c2410_udc.c: Remove some unused functions Rickard Strandqvist
2014-12-22 9:02 ` Vasily Khoruzhick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).