* [PATCH] staging: rtl8192e: Fix duplicated conditional branch
@ 2015-01-04 6:59 Alexander Kuleshov
2015-01-04 7:10 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kuleshov @ 2015-01-04 6:59 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Alexander Kuleshov
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index 885315c..9010d0f 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
dm_digtable.rssi_low_thresh = dm_value;
} else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
dm_digtable.rssi_high_power_highthresh = dm_value;
- } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
+ } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
dm_digtable.rssi_high_power_highthresh = dm_value;
} else if (dm_type == DIG_TYPE_ENABLE) {
dm_digtable.dig_state = DM_STA_DIG_MAX;
--
2.2.1.202.g44ae4ee.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix duplicated conditional branch
2015-01-04 6:59 [PATCH] staging: rtl8192e: Fix duplicated conditional branch Alexander Kuleshov
@ 2015-01-04 7:10 ` Joe Perches
2015-01-05 1:40 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-01-04 7:10 UTC (permalink / raw)
To: Alexander Kuleshov, Larry Finger; +Cc: Greg Kroah-Hartman, linux-kernel
On Sun, 2015-01-04 at 12:59 +0600, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
[]
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
[]
> @@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
> dm_digtable.rssi_low_thresh = dm_value;
> } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
> dm_digtable.rssi_high_power_highthresh = dm_value;
> - } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
> + } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
> dm_digtable.rssi_high_power_highthresh = dm_value;
> } else if (dm_type == DIG_TYPE_ENABLE) {
> dm_digtable.dig_state = DM_STA_DIG_MAX;
Presumably, this is a copy/paste error and should have
both lines changed to HIGHPWR_LOW/high_power_lowthresh
else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW)
dm_digtable.rssi_high_power_lowthresh = dm_value;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix duplicated conditional branch
2015-01-04 7:10 ` Joe Perches
@ 2015-01-05 1:40 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2015-01-05 1:40 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: Joe Perches, Greg Kroah-Hartman, linux-kernel
On 01/04/2015 01:10 AM, Joe Perches wrote:
> On Sun, 2015-01-04 at 12:59 +0600, Alexander Kuleshov wrote:
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> []
>> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> []
>> @@ -1661,7 +1661,7 @@ void dm_change_dynamic_initgain_thresh(struct net_device *dev,
>> dm_digtable.rssi_low_thresh = dm_value;
>> } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> dm_digtable.rssi_high_power_highthresh = dm_value;
>> - } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_HIGH) {
>> + } else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW) {
>> dm_digtable.rssi_high_power_highthresh = dm_value;
>> } else if (dm_type == DIG_TYPE_ENABLE) {
>> dm_digtable.dig_state = DM_STA_DIG_MAX;
>
> Presumably, this is a copy/paste error and should have
> both lines changed to HIGHPWR_LOW/high_power_lowthresh
>
> else if (dm_type == DIG_TYPE_THRESH_HIGHPWR_LOW)
> dm_digtable.rssi_high_power_lowthresh = dm_value;
>
I have no idea what this should be, but this patch does not appear to be any
improvement. Joe is probably correct.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-05 1:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-04 6:59 [PATCH] staging: rtl8192e: Fix duplicated conditional branch Alexander Kuleshov
2015-01-04 7:10 ` Joe Perches
2015-01-05 1:40 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).