* [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block
@ 2019-12-19 4:10 Anshuman Khandual
2019-12-19 5:19 ` Dan Williams
2019-12-19 9:26 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Anshuman Khandual @ 2019-12-19 4:10 UTC (permalink / raw)
To: linux-mm
Cc: Anshuman Khandual, Andrew Morton, David Hildenbrand,
Michal Hocko, Pavel Tatashin, Dan Williams, linux-kernel
memory_block structure elements 'hw' and 'phys_callback' are not getting
used. This was originally added with commit 3947be1969a9 ("[PATCH] memory
hotplug: sysfs and add/remove functions") but never seem to have been used.
Just drop them now.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
include/linux/memory.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/memory.h b/include/linux/memory.h
index 0ebb105eb261..4e95a9eb8061 100644
--- a/include/linux/memory.h
+++ b/include/linux/memory.h
@@ -29,8 +29,6 @@ struct memory_block {
int section_count; /* serialized by mem_sysfs_mutex */
int online_type; /* for passing data to online routine */
int phys_device; /* to which fru does this belong? */
- void *hw; /* optional pointer to fw/hw data */
- int (*phys_callback)(struct memory_block *);
struct device dev;
int nid; /* NID for this memory block */
};
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block
2019-12-19 4:10 [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block Anshuman Khandual
@ 2019-12-19 5:19 ` Dan Williams
2019-12-19 9:26 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Dan Williams @ 2019-12-19 5:19 UTC (permalink / raw)
To: Anshuman Khandual
Cc: Linux MM, Andrew Morton, David Hildenbrand, Michal Hocko,
Pavel Tatashin, Linux Kernel Mailing List
On Wed, Dec 18, 2019 at 8:10 PM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> memory_block structure elements 'hw' and 'phys_callback' are not getting
> used. This was originally added with commit 3947be1969a9 ("[PATCH] memory
> hotplug: sysfs and add/remove functions") but never seem to have been used.
> Just drop them now.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> include/linux/memory.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 0ebb105eb261..4e95a9eb8061 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -29,8 +29,6 @@ struct memory_block {
> int section_count; /* serialized by mem_sysfs_mutex */
> int online_type; /* for passing data to online routine */
> int phys_device; /* to which fru does this belong? */
> - void *hw; /* optional pointer to fw/hw data */
> - int (*phys_callback)(struct memory_block *);
> struct device dev;
> int nid; /* NID for this memory block */
> };
> --
> 2.20.1
Looks good.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block
2019-12-19 4:10 [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block Anshuman Khandual
2019-12-19 5:19 ` Dan Williams
@ 2019-12-19 9:26 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2019-12-19 9:26 UTC (permalink / raw)
To: Anshuman Khandual, linux-mm
Cc: Andrew Morton, Michal Hocko, Pavel Tatashin, Dan Williams, linux-kernel
On 19.12.19 05:10, Anshuman Khandual wrote:
> memory_block structure elements 'hw' and 'phys_callback' are not getting
> used. This was originally added with commit 3947be1969a9 ("[PATCH] memory
> hotplug: sysfs and add/remove functions") but never seem to have been used.
> Just drop them now.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> include/linux/memory.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index 0ebb105eb261..4e95a9eb8061 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -29,8 +29,6 @@ struct memory_block {
> int section_count; /* serialized by mem_sysfs_mutex */
> int online_type; /* for passing data to online routine */
> int phys_device; /* to which fru does this belong? */
> - void *hw; /* optional pointer to fw/hw data */
> - int (*phys_callback)(struct memory_block *);
> struct device dev;
> int nid; /* NID for this memory block */
> };
>
Legacy cruft :)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-19 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 4:10 [PATCH] mm: Drop elements 'hw' and 'phys_callback' from struct memory_block Anshuman Khandual
2019-12-19 5:19 ` Dan Williams
2019-12-19 9:26 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).