* [PATCH] lockd: xdr: Remove unused function
@ 2015-01-10 17:02 Rickard Strandqvist
2015-01-12 21:24 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-10 17:02 UTC (permalink / raw)
To: J. Bruce Fields, Trond Myklebust
Cc: Rickard Strandqvist, linux-nfs, linux-kernel
Remove the function nlm_encode_fh() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
fs/lockd/xdr.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/fs/lockd/xdr.c b/fs/lockd/xdr.c
index 9340e7e..5b651da 100644
--- a/fs/lockd/xdr.c
+++ b/fs/lockd/xdr.c
@@ -95,14 +95,6 @@ nlm_decode_fh(__be32 *p, struct nfs_fh *f)
return p + XDR_QUADLEN(NFS2_FHSIZE);
}
-static inline __be32 *
-nlm_encode_fh(__be32 *p, struct nfs_fh *f)
-{
- *p++ = htonl(NFS2_FHSIZE);
- memcpy(p, f->data, NFS2_FHSIZE);
- return p + XDR_QUADLEN(NFS2_FHSIZE);
-}
-
/*
* Encode and decode owner handle
*/
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] lockd: xdr: Remove unused function
2015-01-10 17:02 [PATCH] lockd: xdr: Remove unused function Rickard Strandqvist
@ 2015-01-12 21:24 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2015-01-12 21:24 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: Trond Myklebust, linux-nfs, linux-kernel
On Sat, Jan 10, 2015 at 06:02:42PM +0100, Rickard Strandqvist wrote:
> Remove the function nlm_encode_fh() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
Huh. OK, thanks--applying.
--b.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> fs/lockd/xdr.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/fs/lockd/xdr.c b/fs/lockd/xdr.c
> index 9340e7e..5b651da 100644
> --- a/fs/lockd/xdr.c
> +++ b/fs/lockd/xdr.c
> @@ -95,14 +95,6 @@ nlm_decode_fh(__be32 *p, struct nfs_fh *f)
> return p + XDR_QUADLEN(NFS2_FHSIZE);
> }
>
> -static inline __be32 *
> -nlm_encode_fh(__be32 *p, struct nfs_fh *f)
> -{
> - *p++ = htonl(NFS2_FHSIZE);
> - memcpy(p, f->data, NFS2_FHSIZE);
> - return p + XDR_QUADLEN(NFS2_FHSIZE);
> -}
> -
> /*
> * Encode and decode owner handle
> */
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-12 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-10 17:02 [PATCH] lockd: xdr: Remove unused function Rickard Strandqvist
2015-01-12 21:24 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).