From: Julijonas Kikutis <julijonas.kikutis@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: corentin.chary@gmail.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] samsung-laptop: enable better lid handling
Date: Tue, 27 Jan 2015 13:35:30 +0000 [thread overview]
Message-ID: <1422365730.1634.3.camel@gmail.com> (raw)
In-Reply-To: <20150127025255.GA118747@vmdeb7>
> > However, a user with another laptop in the bug report says that
"power
> > button has to be pressed twice to wake the machine" in this mode.
>
> This is with this patch applied?
No, the commenter in bugzilla reports that it happened after manually
outputting the command to debugfs. Of course, the same command is used
by this patch only if the sysfs attribute is enabled.
> > This mode is also needed in UEFI, but there samsung-laptop is
> > unfortunately disabled.
>
> I don't follow. What are you saying here?
samsung_init returns -ENODEV if the computer boots in UEFI. Some
functionality (e.g. the battery saving mode, SABI access for this lid
handling issue, some LED functionality for other laptops) have no
alternative ways to be accessed without this module. But this issue is
only tangentially related to my patch.
> This can be one line.
I have sent the revised patch as a reply to the first patch.
Thank you.
Julijonas
next prev parent reply other threads:[~2015-01-27 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 21:18 [PATCH] samsung-laptop: enable better lid handling Julijonas Kikutis
2015-01-27 2:52 ` Darren Hart
2015-01-27 9:54 ` Corentin Chary
2015-01-27 13:35 ` Julijonas Kikutis [this message]
2015-01-27 13:26 ` [PATCH v2] " Julijonas Kikutis
2015-01-29 5:20 ` Darren Hart
2015-01-29 13:12 ` Julijonas Kikutis
2015-01-29 13:04 ` [PATCH v3] " Julijonas Kikutis
2015-02-07 2:38 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422365730.1634.3.camel@gmail.com \
--to=julijonas.kikutis@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).