From: Darren Hart <dvhart@infradead.org>
To: Julijonas Kikutis <julijonas.kikutis@gmail.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
"open list:ABI/API" <linux-api@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:SAMSUNG LAPTOP DR..."
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v3] samsung-laptop: enable better lid handling
Date: Fri, 6 Feb 2015 18:38:09 -0800 [thread overview]
Message-ID: <20150207023809.GA36295@fury.dvhart.com> (raw)
In-Reply-To: <1422536696-1718-1-git-send-email-julijonas.kikutis@gmail.com>
On Thu, Jan 29, 2015 at 01:04:37PM +0000, Julijonas Kikutis wrote:
> Some Samsung laptops with SABI3 delay the sleep for 10 seconds after
> the lid is closed and do not wake up from sleep after the lid is opened.
> A SABI command is needed to enable the better behavior.
>
> Command = 0x6e, d0 = 0x81 enables this behavior. Returns d0 = 0x01.
> Command = 0x6e, d0 = 0x80 disables this behavior. Returns d0 = 0x00.
>
> Command = 0x6d and any d0 queries the state. This returns:
> d0 = 0x00000*01, d1 = 0x00, d2 = 0x00, d3 = 0x0* when it is enabled.
> d0 = 0x00000*00, d1 = 0x00, d2 = 0x00, d3 = 0x0* when it is disabled.
> Where * is 0 - laptop has never slept or hibernated after switch on,
> 1 - laptop has hibernated just before,
> 2 - laptop has slept just before.
>
> Patch addresses bug https://bugzilla.kernel.org/show_bug.cgi?id=75901 .
> It adds a sysfs attribute lid_handling with a description and also an
> addition to the quirks structure to enable the mode by default.
>
> A user with another laptop in the bug report says that "power button has
> to be pressed twice to wake the machine" when he or she enabled the mode
> manually using the SABI command. Therefore, it is enabled by default
> only for the single laptop that I have tested.
>
> Signed-off-by: Julijonas Kikutis <julijonas.kikutis@gmail.com>
Queued up, thanks Jujijonas.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-02-07 2:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 21:18 [PATCH] samsung-laptop: enable better lid handling Julijonas Kikutis
2015-01-27 2:52 ` Darren Hart
2015-01-27 9:54 ` Corentin Chary
2015-01-27 13:35 ` Julijonas Kikutis
2015-01-27 13:26 ` [PATCH v2] " Julijonas Kikutis
2015-01-29 5:20 ` Darren Hart
2015-01-29 13:12 ` Julijonas Kikutis
2015-01-29 13:04 ` [PATCH v3] " Julijonas Kikutis
2015-02-07 2:38 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150207023809.GA36295@fury.dvhart.com \
--to=dvhart@infradead.org \
--cc=corentin.chary@gmail.com \
--cc=julijonas.kikutis@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).