* [PATCH] regulator: qcom-rpm: Make it possible to specify supply
@ 2015-01-30 0:22 Bjorn Andersson
2015-01-30 8:57 ` Srinivas Kandagatla
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2015-01-30 0:22 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, srinivas.kandagatla
Make it possible to specify the supply of a regulator, through the
vin-supply property in dt.
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
drivers/regulator/qcom_rpm-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
index e3120bf..00c5cc3 100644
--- a/drivers/regulator/qcom_rpm-regulator.c
+++ b/drivers/regulator/qcom_rpm-regulator.c
@@ -679,6 +679,7 @@ static int rpm_reg_probe(struct platform_device *pdev)
vreg->desc.owner = THIS_MODULE;
vreg->desc.type = REGULATOR_VOLTAGE;
vreg->desc.name = pdev->dev.of_node->name;
+ vreg->desc.supply_name = "vin";
vreg->rpm = dev_get_drvdata(pdev->dev.parent);
if (!vreg->rpm) {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: qcom-rpm: Make it possible to specify supply
2015-01-30 0:22 [PATCH] regulator: qcom-rpm: Make it possible to specify supply Bjorn Andersson
@ 2015-01-30 8:57 ` Srinivas Kandagatla
2015-01-30 12:39 ` Mark Brown
2015-01-30 15:46 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2015-01-30 8:57 UTC (permalink / raw)
To: Bjorn Andersson, Liam Girdwood, Mark Brown
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel
Hi Bjorn,
Thanks for sending this patch.. I almost forgot about this.
Shouldn’t we update the DT Bindings with this info?
Other than that:
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
--srini
On 30/01/15 00:22, Bjorn Andersson wrote:
> Make it possible to specify the supply of a regulator, through the
> vin-supply property in dt.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> drivers/regulator/qcom_rpm-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
> index e3120bf..00c5cc3 100644
> --- a/drivers/regulator/qcom_rpm-regulator.c
> +++ b/drivers/regulator/qcom_rpm-regulator.c
> @@ -679,6 +679,7 @@ static int rpm_reg_probe(struct platform_device *pdev)
> vreg->desc.owner = THIS_MODULE;
> vreg->desc.type = REGULATOR_VOLTAGE;
> vreg->desc.name = pdev->dev.of_node->name;
> + vreg->desc.supply_name = "vin";
>
> vreg->rpm = dev_get_drvdata(pdev->dev.parent);
> if (!vreg->rpm) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: qcom-rpm: Make it possible to specify supply
2015-01-30 8:57 ` Srinivas Kandagatla
@ 2015-01-30 12:39 ` Mark Brown
2015-01-30 15:46 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-01-30 12:39 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Bjorn Andersson, Liam Girdwood, linux-kernel, linux-arm-msm,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
On Fri, Jan 30, 2015 at 08:57:29AM +0000, Srinivas Kandagatla wrote:
> Hi Bjorn,
> Thanks for sending this patch.. I almost forgot about this.
>
> Shouldn’t we update the DT Bindings with this info?
>
> Other than that:
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Please don't top post.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: qcom-rpm: Make it possible to specify supply
2015-01-30 8:57 ` Srinivas Kandagatla
2015-01-30 12:39 ` Mark Brown
@ 2015-01-30 15:46 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2015-01-30 15:46 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Liam Girdwood, Mark Brown, linux-kernel, linux-arm-msm, linux-arm-kernel
On Fri 30 Jan 00:57 PST 2015, Srinivas Kandagatla wrote:
> Hi Bjorn,
> Thanks for sending this patch.. I almost forgot about this.
>
> Shouldn’t we update the DT Bindings with this info?
>
At this time we don't have any bindings for the subnodes merged. So I also sent
out [1] yesterday, including this property. Seems I forgot linux-arm-msm
though.
> Other than that:
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
Thanks
[1] https://lkml.org/lkml/2015/1/29/1077
Regards,
Bjorn
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-02-07 8:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-30 0:22 [PATCH] regulator: qcom-rpm: Make it possible to specify supply Bjorn Andersson
2015-01-30 8:57 ` Srinivas Kandagatla
2015-01-30 12:39 ` Mark Brown
2015-01-30 15:46 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).